moderate_parameters 0.2.6 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa022d8afad78e0d873a348c3c6b904126bb4667a1a121ff3f649f2ac1279f25
-  data.tar.gz: 4d2f9811d68673a8edfbb96eda872950c34f199d0f6fb0c856ab5dbaecc2f357
+  metadata.gz: 33118bf4c165859d1135b0628d3c1177560003900ea7637a4d97bb149f00fbef
+  data.tar.gz: cef73308c79623677793428b8704e667eca870e2f4463ffc41efb878d030429d
 SHA512:
-  metadata.gz: 27f5bd24d222651ce688faf335d6c387f216fd6bf8a6a225654cf4085e5f03deebe9249cb61f68748854b61434b899031b73a5f203e427bcd28d8338b3d1f995
-  data.tar.gz: e0a9b7507d86dfba2c61721c8fca95544b0dd571bf2163c28d251ebab73cbc7af890c8bea04717f0c54289eaffc9939fb473e6d29a67b39b3c108f3f058e62ee
+  metadata.gz: 12d73a15669d2af4b6b579b1fe0905efb191bc3474bb174fb011b2065d1efbce9c91efcf9f379984139a506c85cdf1b34ca8966df6dbf996d57c8e291487ff31
+  data.tar.gz: 68c48b72df1c5a99a7287330c4cfa2275c6cfdc8ccfc5c6af28db5b24e5b4bff232709e24c949a58d645fbb0ef1ea9fe0e751f7ad6e01c8c9348ab578eb3ff58

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    moderate_parameters (0.2.2)
+    moderate_parameters (0.3.0)
       actionpack (>= 4.2, < 6.1)
       activemodel (>= 4.2, < 6.1)
       activesupport (>= 4.2, < 6.1)
@@ -10,51 +10,51 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (6.0.0)
-      actionview (= 6.0.0)
-      activesupport (= 6.0.0)
-      rack (~> 2.0)
+    actionpack (6.0.2.1)
+      actionview (= 6.0.2.1)
+      activesupport (= 6.0.2.1)
+      rack (~> 2.0, >= 2.0.8)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (6.0.0)
-      activesupport (= 6.0.0)
+    actionview (6.0.2.1)
+      activesupport (= 6.0.2.1)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activemodel (6.0.0)
-      activesupport (= 6.0.0)
-    activesupport (6.0.0)
+    activemodel (6.0.2.1)
+      activesupport (= 6.0.2.1)
+    activesupport (6.0.2.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-      zeitwerk (~> 2.1, >= 2.1.8)
+      zeitwerk (~> 2.2)
     appraisal (2.2.0)
       bundler
       rake
       thor (>= 0.14.0)
-    builder (3.2.3)
+    builder (3.2.4)
     coderay (1.1.2)
     concurrent-ruby (1.1.5)
-    crass (1.0.5)
+    crass (1.0.6)
     diff-lcs (1.3)
     erubi (1.9.0)
-    i18n (1.7.0)
+    i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    loofah (2.3.1)
+    loofah (2.4.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     method_source (0.9.2)
     mini_portile2 (2.4.0)
-    minitest (5.12.2)
-    nokogiri (1.10.4)
+    minitest (5.14.0)
+    nokogiri (1.10.7)
       mini_portile2 (~> 2.4.0)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rack (2.0.7)
+    rack (2.1.1)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails-dom-testing (2.0.3)
@@ -62,40 +62,40 @@ GEM
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.3.0)
       loofah (~> 2.3)
-    railties (6.0.0)
-      actionpack (= 6.0.0)
-      activesupport (= 6.0.0)
+    railties (6.0.2.1)
+      actionpack (= 6.0.2.1)
+      activesupport (= 6.0.2.1)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.20.3, < 2.0)
     rake (10.5.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
+    rspec-expectations (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.1)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.2)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    thor (0.20.3)
+    thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.5)
+    tzinfo (1.2.6)
       thread_safe (~> 0.1)
-    zeitwerk (2.2.0)
+    zeitwerk (2.2.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   appraisal (= 2.2.0)
-  bundler (~> 2.0.1)
+  bundler (~> 2.0)
   moderate_parameters!
   pry (~> 0.12.2)
   rake (~> 10.0)
@@ -103,4 +103,4 @@ DEPENDENCIES
   rspec_junit_formatter (= 0.4.1)
 
 BUNDLED WITH
-   2.0.1
+   2.1.4

data/lib/generators/templates/moderate_parameters.rb

@@ -4,4 +4,6 @@ ModerateParameters.configure do |config|
   # Enables/Disables logging occurrences of
   # reading/writing from ActionController::Parameters.
   config.breadcrumbs_enabled = false
+  # Sets where to log the ModerateParameters output
+  config.logger = ActiveSupport::Logger.new('log/moderate_parameters.log')
 end

data/lib/moderate_parameters/parameters.rb

@@ -8,7 +8,11 @@ module ModerateParameters
       filters.each do |filter|
         case filter
         when Symbol, String
-          permitted_scalar_filter(params, filter)
+          if non_scalar?(self[filter])
+            non_scalar_value_filter(params, filter, controller_name, action)
+          else
+            permitted_scalar_filter(params, filter)
+          end
         when Hash
           cust_hash_filter(params, filter, controller_name, action)
         end
@@ -20,13 +24,26 @@ module ModerateParameters
 
     private
 
+    def write_to_log(options)
+      ActiveSupport::Notifications.instrument('moderate_parameters') do |payload|
+        payload.merge!(options)
+      end
+    end
+
     def incoming_params_logging(params, controller_name, action)
       unpermitted_keys(params).each do |k|
-        ActiveSupport::Notifications.instrument('moderate_parameters') do |payload|
-          payload[:controller] = controller_name
-          payload[:action] = action
-          payload[:message] = "#{@context || 'Top Level'} is missing: #{k}"
-        end
+        write_to_log(message: "#{@context || 'Top Level'} is missing: #{k}",
+                     action: action,
+                     controller: controller_name)
+      end
+    end
+
+    def non_scalar_value_filter(params, key, controller_name, action)
+      if has_key?(key) && !permitted_scalar?(self[key])
+        params[key] = self[key].class.new
+        write_to_log(message: "#{@context || 'Top Level'} is missing: #{params[key]} value for #{key}",
+                     action: action,
+                     controller: controller_name)
       end
     end
 
@@ -34,6 +51,38 @@ module ModerateParameters
       value.is_a?(Array) || value.is_a?(Parameters)
     end
 
+    def permit_any_in_array(array)
+      [].tap do |sanitized|
+        array.each do |element|
+          case element
+          when ->(e) { permitted_scalar?(e) }
+            sanitized << element
+          when Parameters
+            sanitized << permit_any_in_parameters(element)
+          else
+            # Log it
+          end
+        end
+      end
+    end
+
+    def permit_any_in_parameters(params)
+      self.class.new.tap do |sanitized|
+        params.each do |key, value|
+          case value
+          when ->(v) { permitted_scalar?(v) }
+            sanitized[key] = value
+          when Array
+            sanitized[key] = permit_any_in_array(value)
+          when Parameters
+            sanitized[key] = permit_any_in_parameters(value)
+          else
+            # Log It
+          end
+        end
+      end
+    end
+
     EMPTY_HASH ||= {}
     EMPTY_ARRAY ||= []
     def cust_hash_filter(params, filter, controller_name, action)

data/lib/moderate_parameters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ModerateParameters
-  VERSION = '0.2.6'
+  VERSION = '0.3.0'
 end

data/moderate_parameters.gemspec

@@ -41,7 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'activesupport', '>= 4.2', '< 6.1'
   spec.add_dependency 'railties', '>= 4.2', '< 6.1'
 
-  spec.add_development_dependency 'bundler', '~> 2.0.1'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'pry', '~> 0.12.2'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moderate_parameters
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.3.0
 platform: ruby
 authors:
 - Kyle Boe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-19 00:00:00.000000000 Z
+date: 2020-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -96,14 +96,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement