model_error_messages 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3346cf1d3cc91ec5fa3a8befc871931b1087b33a
-  data.tar.gz: cf709e9fad5263088ae0e3ffba6bac1a8fde6439
+  metadata.gz: 007df75f1595da7a658b842cd21ee696b1fd528f
+  data.tar.gz: dcb48d29502d70d33764934b945d64c5ada1b061
 SHA512:
-  metadata.gz: 0d33d97a77439dd700d9afdf0e4ab471dd9f7f4c1ee20bf3c00cc9ae880a488d648c68bb37dd3fd0fc308126ae83415e7c40e9d953c3c3eb30320fb3aecbbbf5
-  data.tar.gz: 1ad227a9061979297a003d05ec3a8de746b5e000a41a887c7cf062b732117a4431811558a05ba1e1532715f7eb2ce39cfbc51d8223e9716c11f50b9f714742d2
+  metadata.gz: 075734aaecb95dbc036310aeeef7dce016568075b6b7d5af236ae314502fce8e70ad576e02671469d8b5c774b83d54c1ebc78f6f2197c3d83f471852212dbb59
+  data.tar.gz: 757313149b18469716c470b4fc7090994625aab782a48746d8560f88ccce6624dbe09af67ae8a479e4c7d108d7ab73e5de0957d8dd721c9c30cc14defa360ee2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    model_error_messages (1.0.2)
+    model_error_messages (1.1.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/model_error_messages/helpers.rb

@@ -37,11 +37,11 @@ module ModelErrorMessages
       messages = model.errors.full_messages
 
       if messages.count == 1 && config.single_error_in_paragraph
-        return tag(:p, messages.first)
+        return tag(:p, CGI.escapeHTML(messages.first))
       end
 
       ul_string = messages.map do |message|
-        tag(:li, message)
+        tag(:li, CGI.escapeHTML(message))
       end.join.html_safe
 
       tag(:ul, ul_string)
@@ -61,8 +61,9 @@ module ModelErrorMessages
           attrs << %( #{pair.first}="#{CGI.escapeHTML(pair.last.to_s)}")
         end
         attrs
-      end
-      "<#{name}#{string_attributes}>#{value}</#{name}>"
+      end.html_safe
+
+      "<#{name}#{string_attributes}>#{value}</#{name}>".html_safe
     end
   end
 end

data/lib/model_error_messages/version.rb

@@ -1,8 +1,8 @@
 module ModelErrorMessages
   module VERSION
     MAJOR = 1
-    MINOR = 0
-    TINY  = 2
+    MINOR = 1
+    TINY  = 0
 
     STRING = [MAJOR, MINOR, TINY].compact.join('.')
   end

data/spec/model_error_messages/helpers_spec.rb

@@ -10,7 +10,7 @@ end
 def mock_model_full_messages(errors_count)
   case errors_count
   when 0 then []
-  when 1 then ['Title is missing']
+  when 1 then ['Title is -> missing']
   when 2 then ['Please select an author', 'Content is missing']
   else
     raise 'Please enter a valid `errors` count.'
@@ -27,7 +27,6 @@ end
 describe 'Helpers' do
   describe '#model_error_messages' do
     include ModelErrorMessages::Helpers
-    attr_accessor :output_buffer
 
     subject { model_error_messages(mock_model) }
 
@@ -46,7 +45,7 @@ describe 'Helpers' do
         result = model_error_messages(mock_model(errors: 1))
         expect(result).to eql(
           '<div class="alert alert-danger model-error-messages">' \
-          '<p>Title is missing</p>' \
+          '<p>Title is -&gt; missing</p>' \
           '</div>'
         )
       end
@@ -60,6 +59,11 @@ describe 'Helpers' do
           '</div>'
         )
       end
+
+      it 'returns a safe string' do
+        result = model_error_messages(mock_model(errors: 1))
+        expect(result.html_safe?).to eql(true)
+      end
     end
 
     context 'with a custom configuration' do
@@ -78,7 +82,7 @@ describe 'Helpers' do
         expect(result).to eql(
           '<div class="model-foo bar">' \
           '<h1>An error occurred</h1>' \
-          '<ul><li>Title is missing</li></ul>' \
+          '<ul><li>Title is -&gt; missing</li></ul>' \
           '<p>Please try again.</p>' \
           '</div>'
         )

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: model_error_messages
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Christophe Maximin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-30 00:00:00.000000000 Z
+date: 2016-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake