mocktail 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a9c74cd3ff5167b99c38892ee6411a1ac3f1379158c062076bfbe6d8479c7b7
-  data.tar.gz: 81dd2b80a78c162a9c4030fa8bc9be42741c3a8c053fa33c319dc13c404234a8
+  metadata.gz: 3f1b0c2f99097d0f23cb67928b5455ce5acf9fad24baee1dff64c748b60a8da9
+  data.tar.gz: 9595e5e672d13711a45447b8242977189700e6d0a044f9553e75d642e455f898
 SHA512:
-  metadata.gz: bd1fbc482135e89dea00de9249d63b5e851d64ecb2f4afc898b4bb77abf5afc96303cfed6b59665d0e51ab4b2c8dd4c438dc2a7ab93d1c69e1d12d723797cf9a
-  data.tar.gz: 3af137dd6d1488b1ef41ac0b47178a224e160f11dce0ed0cbeb24418ae4a33c86a6e4fa8e3cabb20c8421c8ac1ac8c166045051d996d4aa1dc709e4fcc97ec3a
+  metadata.gz: 5469cfd8d09da0ba752c60529cfc016acecea8b69107d07a467e576812e1d1abf74d05f3431228c4789bf3397059e249a3307dd788a7c4bce410a85f8d86d0ee
+  data.tar.gz: c7dea9981f4ed8f76b4f5595c0dd88d747f30371d6c5c6245f8bd498864850700e5ca9f1c1af06b67879b24bcdf90e14d5cfd7b2111838580f3fbd4554b3cbec

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 1.1.1
+
+* Improve output for undefined singleton methods
+  ([#11](https://github.com/testdouble/mocktail/pull/11) by
+  [@calebhearth](https://github.com/calebhearth))
+
 # 1.1.0
 
 * Feature: add support for passing methods to `Mocktail.explain()`

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mocktail (1.1.0)
+    mocktail (1.1.1)
 
 GEM
   remote: https://rubygems.org/
@@ -11,28 +11,28 @@ GEM
     docile (1.4.0)
     method_source (1.0.0)
     minitest (5.15.0)
-    parallel (1.21.0)
-    parser (3.1.0.0)
+    parallel (1.22.1)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.2.0)
+    regexp_parser (2.3.0)
     rexml (3.2.5)
-    rubocop (1.25.0)
+    rubocop (1.27.0)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.15.1, < 2.0)
+      rubocop-ast (>= 1.16.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.15.1)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.13.2)
+    rubocop-ast (1.17.0)
+      parser (>= 3.1.1.0)
+    rubocop-performance (1.13.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     ruby-progressbar (1.11.0)
@@ -41,10 +41,10 @@ GEM
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
-    simplecov_json_formatter (0.1.3)
-    standard (1.7.0)
-      rubocop (= 1.25.0)
-      rubocop-performance (= 1.13.2)
+    simplecov_json_formatter (0.1.4)
+    standard (1.10.0)
+      rubocop (= 1.27.0)
+      rubocop-performance (= 1.13.3)
     unicode-display_width (2.1.0)
 
 PLATFORMS

data/README.md

@@ -813,6 +813,31 @@ Calling reset in a `teardown` or `after(:each)` hook will also improve the
 usefulness of messages returned by `Mocktail.explain` and
 `Mocktail.explain_nils`.
 
+## References
+
+Mocktail is designed following a somewhat academic understanding of what mocking
+is and how it should be used. Below are several references on this topic.
+
+Blog Posts and Papers:
+
+- [Endo-Testing: Unit Testing with Mock
+  Objects](<https://www2.ccs.neu.edu/research/demeter/related-work/extreme-programming/MockObjectsFinal.PDF>
+  by Tim Mackinnon, Steve Freeman, and Philip Craig, the paper that introduced
+  mocking presented by the creators of mocking.
+- Michael Feathers' [The Flawed Theory Behind Unit
+  Testing](<https://michaelfeathers.typepad.com/michael_feathers_blog/2008/06/the-flawed-theo.html>)
+
+Books:
+
+- [_Growing Object-Oriented Software, Guided by
+  Tests_](<https://bookshop.org/books/growing-object-oriented-software-guided-by-tests/9780321503626>)
+  by Steve Freeman and Nat Price
+
+Talks:
+
+- [Please don’t mock me](https://www.youtube.com/watch?v=Af4M8GMoxi4) by Justin
+  Searls
+
 ## Acknowledgements
 
 Mocktail is created & maintained by the software agency [Test
@@ -839,4 +864,3 @@ including (but not limited to) one-on-one communications, public posts/comments,
 code reviews, pull requests, and GitHub issues. If violations occur, Test Double
 will take any action they deem appropriate for the infraction, up to and
 including blocking a user from the organization's repositories.
-

data/lib/mocktail/matchers/any.rb

@@ -4,7 +4,9 @@ module Mocktail::Matchers
       :any
     end
 
-    def initialize
+    # Change this comment to a descriptive one once this is merged:
+    # https://github.com/rubocop/rubocop/pull/10551
+    def initialize # standard:disable Style/RedundantInitialize
     end
 
     def match?(actual)

data/lib/mocktail/matchers/numeric.rb

@@ -4,7 +4,9 @@ module Mocktail::Matchers
       :numeric
     end
 
-    def initialize
+    # Change this comment to a descriptive one once this is merged:
+    # https://github.com/rubocop/rubocop/pull/10551
+    def initialize # standard:disable Style/RedundantInitialize
     end
 
     def match?(actual)

data/lib/mocktail/raises_neato_no_method_error.rb

@@ -18,7 +18,7 @@ module Mocktail
 
         Need to define the method? Here's a sample definition:
 
-          def #{call.method}#{params(call)}
+          def #{"self." if call.singleton}#{call.method}#{params(call)}
           end
         #{corrections(call)}
       MSG

data/lib/mocktail/replaces_type/redefines_singleton_methods.rb

@@ -12,6 +12,7 @@ module Mocktail
         type.method(name)
       } - [type_replacement.replacement_new]
 
+      declare_singleton_method_missing_errors!(type)
       handles_dry_call = @handles_dry_call
       type_replacement.replacement_methods = type_replacement.original_methods.map { |original_method|
         type.singleton_class.send(:undef_method, original_method.name)
@@ -35,5 +36,27 @@ module Mocktail
         type.singleton_method(original_method.name)
       }
     end
+
+    def declare_singleton_method_missing_errors!(type)
+      return if type.singleton_methods.include?(:method_missing)
+
+      raises_neato_no_method_error = RaisesNeatoNoMethodError.new
+      type.define_singleton_method :method_missing,
+        ->(name, *args, **kwargs, &block) {
+          raises_neato_no_method_error.call(
+            Call.new(
+              singleton: true,
+              double: self,
+              original_type: type,
+              dry_type: self.class,
+              method: name,
+              original_method: nil,
+              args: args,
+              kwargs: kwargs,
+              block: block
+            )
+          )
+        }
+    end
   end
 end

data/lib/mocktail/version.rb

@@ -1,3 +1,3 @@
 module Mocktail
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mocktail
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-27 00:00:00.000000000 Z
+date: 2022-05-14 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -117,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.6
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Take your objects, and make them a double