mocha 1.15.1 → 1.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f69e06715dfda038470d522472d10e99e4de02d57f1efe4d4f81caaff7856e4
-  data.tar.gz: a1fae0b515f7f76108c58fc151995eaab5a03a3d034820e3853799c2f571bcda
+  metadata.gz: dd831959184fe3eecebdf969b343f35890f555b638aade8a24100ec68fcc1dbf
+  data.tar.gz: 4bbb00fdfb329c95cee458c9a0ba9d79519183794ba843646b30368300d48b85
 SHA512:
-  metadata.gz: 997c75e49d45c59eab07d55c940bf56bf94161a4b1940de46f70ab5d3c8749657de799d61ac519b85e89de9154618df5cd5d4eedcb7ab85499cf404eb5ad54f4
-  data.tar.gz: 90122aa4932173fc3dfc2b7295f97af05f23abb0967fc46da3a7c977ec4b16371595f21b9eeae58c50024a57e20dd3861e91ab67a405a0b29d20267a46b8800e
+  metadata.gz: 7193325ccc907fddeb7c779ba632877e363a633a642096c26ea866595449d0d0f0e8674cd2af06020ca5486e4553a97e573bb73acf89e35b0a8144af320c6b79
+  data.tar.gz: 7e761bb099334893252ea4652348868ab4125d73fa225a0b50da6bfbc92a83b75471aeb1e4e80a2949f39ecbf672a019077229ff7e8ae65f224c74b92451a144

data/RELEASE.md

@@ -1,10 +1,15 @@
 # Release Notes
 
-## 1.15.1
+## 1.16.0
 
 ### External changes
 
-* Fix regression in `Mock#responds_like` behaviour - thanks to @adrianna-chang-shopify for reporting (#580,#583,c586a08c)
+* Default `Configuration#reinstate_undocumented_behaviour_from_v1_9=` to `false` (6fcaf947)
+* Deprecate `Configuration#reinstate_undocumented_behaviour_from_v1_9=` (a797c5fd)
+
+### Internal changes
+
+* Remove redundant deprecation disabling in MockTest (dc8ca969)
 
 ## 1.15.0
 

data/lib/mocha/configuration.rb

@@ -43,7 +43,7 @@ module Mocha
       :stubbing_non_public_method => :allow,
       :stubbing_method_on_nil => :prevent,
       :display_matching_invocations_on_failure => false,
-      :reinstate_undocumented_behaviour_from_v1_9 => true
+      :reinstate_undocumented_behaviour_from_v1_9 => false
     }.freeze
 
     attr_reader :options
@@ -258,7 +258,8 @@ module Mocha
     #
     # Enabling this configuration option reinstates the previous behaviour, but displays a deprecation warning.
     #
-    # @param [Boolean] value +true+ to reinstate undocumented behaviour; enabled by default.
+    # @param [Boolean] value +true+ to reinstate undocumented behaviour; disabled by default.
+    # @deprecated Fix deprecation warnings caused by reliance on v1.9 behaviour and remove calls to this method.
     #
     # @example Reinstate undocumented behaviour for {API#mock}
     #   Mocha.configure do |c|
@@ -295,6 +296,16 @@ module Mocha
     #   foo.my_method # => does *not* raise LocalJumpError when no block is supplied
     #
     def reinstate_undocumented_behaviour_from_v1_9=(value)
+      if value
+        sentence1 = 'Configuration#reinstate_undocumented_behaviour_from_v1_9= will be removed in the future.'
+        sentence2 = 'Fix deprecation warnings caused by reliance on v1.9 behaviour.'
+        sentence3 = 'See docs for API#mock, API#stub, API#stub_everything, Expectation#yields and Expectation#multiple_yields.'
+        Deprecation.warning([sentence1, sentence2, sentence3].join(' '))
+      else
+        sentence1 = 'Configuration#reinstate_undocumented_behaviour_from_v1_9= is unnecessarily being set to false, because this is now the default value.'
+        sentence2 = 'Configuration#reinstate_undocumented_behaviour_from_v1_9= will be removed in the future, so you should avoid calling it.'
+        Deprecation.warning([sentence1, sentence2].join(' '))
+      end
       @options[:reinstate_undocumented_behaviour_from_v1_9] = value
     end
 

data/lib/mocha/mock.rb

@@ -182,11 +182,11 @@ module Mocha
       end
     end
 
-    # Constrains the {Mock} instance so that it can only expect or stub methods to which +responder+ responds publicly. The constraint is only applied at method invocation time.
+    # Constrains the {Mock} instance so that it can only expect or stub methods to which +responder+ responds. The constraint is only applied at method invocation time.
     #
-    # A +NoMethodError+ will be raised if the +responder+ does not publicly +#respond_to?+ the invoked method (even if the method has been expected or stubbed).
+    # A +NoMethodError+ will be raised if the +responder+ does not +#respond_to?+ a method invocation (even if the method has been expected or stubbed).
     #
-    # The {Mock} instance will delegate its +#respond_to?+ method to the +responder+. However, the +include_all+ parameter is not passed through, so only public methods on the +responder+ will be considered.
+    # The {Mock} instance will delegate its +#respond_to?+ method to the +responder+.
     #
     # Note that the methods on +responder+ are never actually invoked.
     #
@@ -236,11 +236,11 @@ module Mocha
       self
     end
 
-    # Constrains the {Mock} instance so that it can only expect or stub methods to which an instance of the +responder_class+ responds publicly. The constraint is only applied at method invocation time. Note that the responder instance is instantiated using +Class#allocate+.
+    # Constrains the {Mock} instance so that it can only expect or stub methods to which an instance of the +responder_class+ responds. The constraint is only applied at method invocation time. Note that the responder instance is instantiated using +Class#allocate+.
     #
-    # A +NoMethodError+ will be raised if the responder instance does not publicly +#respond_to?+ the invoked method (even if the method has been expected or stubbed).
+    # A +NoMethodError+ will be raised if the responder instance does not +#respond_to?+ a method invocation (even if the method has been expected or stubbed).
     #
-    # The {Mock} instance will delegate its +#respond_to?+ method to the responder instance. However, the +include_all+ parameter is not passed through, so only public methods on the +responder+  will be considered.
+    # The {Mock} instance will delegate its +#respond_to?+ method to the responder instance.
     #
     # Note that the methods on the responder instance are never actually invoked.
     #
@@ -325,9 +325,9 @@ module Mocha
     end
 
     # @private
-    def respond_to_missing?(symbol, _include_all)
+    def respond_to_missing?(symbol, include_all)
       if @responder
-        @responder.respond_to?(symbol)
+        @responder.respond_to?(symbol, include_all)
       else
         @everything_stubbed || all_expectations.matches_method?(symbol)
       end

data/lib/mocha/version.rb

@@ -1,3 +1,3 @@
 module Mocha
-  VERSION = '1.15.1'.freeze
+  VERSION = '1.16.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mocha
 version: !ruby/object:Gem::Version
-  version: 1.15.1
+  version: 1.16.0
 platform: ruby
 authors:
 - James Mead
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-07 00:00:00.000000000 Z
+date: 2022-10-18 00:00:00.000000000 Z
 dependencies: []
 description: Mocking and stubbing library with JMock/SchMock syntax, which allows
   mocking and stubbing of methods on real (non-mock) classes.