mobility 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b94201a6b91ad2fff4818aa37fa4fd99df97944d98f3888af6b76f732f71658
-  data.tar.gz: 8be29d872e1488575253302daa13b46d5f065c5dd9aa35c526c0fd561ae478c5
+  metadata.gz: d0dd974f8a077b31fc0ab41df158e4cac50c6aee4e7fd66348db1ed2ef5f78f9
+  data.tar.gz: ea72521a4bb8daedf08d3012353c591ec47f76e3fe6ec3c10b87e331a5404db9
 SHA512:
-  metadata.gz: a7afca6199b32df4105ad2bd55d33c6213677d424d6a4bb22e5d39e33b649de2e256a04b1f03e9c33d6374e5c4ec7858a7de9b2a0e190cc1a417da895981b7a0
-  data.tar.gz: 23ef1c7ca95c54872c5504a50af6c94116c94157586ba755a9ed57e6ca878647a1693460232840ed58c47f5807b6fd6c6db2283c397faf7a7e3402e93f675be3
+  metadata.gz: 15b9df45774c9b3d4ae343b2f083b2a85ddfd7585283998b0dc624aa62eee5c6e5fade0737ae78b3dd728dd273a03dcf10afecabcca6eb8f90400619de0a7fa4
+  data.tar.gz: 1f199821139bf35b4e176f52dac0249f482ffb5edc9d7957d437e9262a908812fab01ba5dea52e18a9b1f37f92744b345c34ca0c84d97da0641f9fab19577704

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 1.2
 
+### 1.2.4
+- Fix fallbacks performance regression
+  ([#548](https://github.com/shioyama/mobility/pull/548))
+
 ### 1.2.3
 - Fix passing wrong options to super in fallbacks plugin
   ([#539](https://github.com/shioyama/mobility/pull/539))

data/Gemfile.lock

@@ -1,6 +1,6 @@
 GIT
   remote: https://github.com/rails/rails.git
-  revision: 0a751a021bfc0c71bb2a10ff8af9654c785c94f1
+  revision: 5647a9c1ced68d20338552d47a3b755e10a271c4
   branch: main
   specs:
     activemodel (7.0.0.alpha2)

data/README.md

@@ -55,7 +55,7 @@ Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 1.2.3'
+gem 'mobility', '~> 1.2.4'
 ```
 
 ### ActiveRecord (Rails)

data/lib/mobility/plugins/fallbacks.rb

@@ -117,10 +117,21 @@ the current locale was +nil+.
       # Applies fallbacks plugin to attributes. Completely disables fallbacks
       # on model if option is +false+.
       included_hook do |_, backend_class|
-        backend_class.include(BackendInstanceMethods) unless options[:fallbacks] == false
-        # This is weird. We need to find a better way to allow customization of
-        # rarely-customized code like this.
-        backend_class.define_method(:generate_fallbacks, &method(:generate_fallbacks))
+        unless options[:fallbacks] == false
+          backend_class.include(BackendInstanceMethods)
+
+          fallbacks =
+            if options[:fallbacks].is_a?(Hash)
+              generate_fallbacks(options[:fallbacks])
+            elsif options[:fallbacks] == true
+              generate_fallbacks({})
+            else
+              ::Hash.new { [] }
+            end
+
+          backend_class.singleton_class.attr_reader :fallbacks
+          backend_class.instance_variable_set(:@fallbacks, fallbacks)
+        end
       end
 
       private
@@ -140,7 +151,7 @@ the current locale was +nil+.
         def read(locale, fallback: true, **kwargs)
           return super(locale, **kwargs) if !fallback || kwargs[:locale]
 
-          locales = fallback == true ? fallbacks[locale] : [locale, *fallback]
+          locales = fallback == true ? self.class.fallbacks[locale] : [locale, *fallback]
           locales.each do |fallback_locale|
             value = super(fallback_locale, **kwargs)
             return value if Util.present?(value)
@@ -148,18 +159,6 @@ the current locale was +nil+.
 
           super(locale, **kwargs)
         end
-
-        private
-
-        def fallbacks
-          if options[:fallbacks].is_a?(Hash)
-            generate_fallbacks(options[:fallbacks])
-          elsif options[:fallbacks] == true
-            generate_fallbacks({})
-          else
-            ::Hash.new { [] }
-          end
-        end
       end
     end
 

data/lib/mobility/version.rb

@@ -8,7 +8,7 @@ module Mobility
   module VERSION
     MAJOR = 1
     MINOR = 2
-    TINY = 3
+    TINY = 4
     PRE = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Chris Salzberg
@@ -34,7 +34,7 @@ cert_chain:
   eBMcZq0d1tbtv1M1UXND9mOfhLZ31YvoSTPkrJiRpljUNgD0+ugelnr1/5X/9k8y
   J9QOd3C5jpSShf/HMvpJnFuSYFm19cH9GrHjvw==
   -----END CERTIFICATE-----
-date: 2021-10-25 00:00:00.000000000 Z
+date: 2021-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store

metadata.gz.sig

@@ -1,3 +1,3 @@
-	|��Q��Xԁ�S%oj8ۿ���Y���-�D����'����V�C��(f9E�F��P	w̌xg;z�(@��B"����LCx��H���ht�v�����M��˚���Y�OT�
-,�4nOD>1��ȧ�h�������/Hf�حU�P'ؘ�0e=d�S>�l.���I��?��St|���k���?�ԥ�k�.��j�;=^�X7B��?�߻��_u���9��(+�����n@����>�bS�\y�N�n}�P�]7uʦq�
D�0:�.�[f�r�P*o���$L%����m���g�P["�^�
-b�'f��U�G�cO��r������׭*?�Kx0�Tʰ�l�q��(��%���ο
6ݑ�MAA���$
+�}�=�''g�s�0�J)�������^�(����h*G��=^ �~V2����;\v_6K�݆f�ߵP�P�E�h�G�۶�$���Χ�5k�uS
+2�6�C;�}SMw�k�bL�
+���Yԝ������{u�T��0L�wz��:qJ-8���<g�G�>#
+jg_ko���^^ɓO�͜B��ݯ��/��~xGV���Vc��Ww��ѥVu"�۟2�#�C��hڴW�J�^.U���+蕕&8�)~��[���6������S�&��6mX�5F�~B4.�6�t�&�4������#����Ң��l�$����4-�Uc7d��A*����J��g��;tD�$