mobility 1.0.0.beta1 → 1.0.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a27c475aac12e8c93750cd6b11b7b339912c95bb24ada1e579c8f87598359388
-  data.tar.gz: faf2187673842e059b204715e774b2ef22d0a98e6162d7014ef875236a0db192
+  metadata.gz: 2346e4ef46985b520c5feea3577a6644f213e1fe89e3dfd5960f3347c72a1134
+  data.tar.gz: df38726f94dca7139a3eb9cf838b27dfede5378c34290a5298e7dcde01bf3c90
 SHA512:
-  metadata.gz: 51dfb02fb8624897834dbc9260eb7edc67f6120f2971de120f7084e59df0865a027eca3ccae435ba77604fa8086760a1c682b9879a4c625be71368fa21d3b2c7
-  data.tar.gz: 5133980f0433ba31d157ebda7e1a8028dc84aa8d8dc7ab6b0df94861c347e60f34b09665eb890341998080be5256bea566f7e0dea62f96f6c85fcfd931319969
+  metadata.gz: 236ad0894645f98bf2a21c6848b4ba439da84b24862a56f6fca878889a6cd9a79108711923961d2f9ee75b6a6ee8482fcefff213b5433736fa507332db0cc253
+  data.tar.gz: a3e78f97d08d26e18ac8187b961097e686c3fc5650f45ae84fb4aa1aad1ccd0970410f2b9e887d8618ed6c1a09e559b1fe3fd0428df591de011961a0c2da1379

data/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 1.0 is a rewrite of many internals of the gem. Please see the [wiki page on v1.0](https://github.com/shioyama/mobility/wiki/Introduction-to-Mobility-v1.0) for more details on how to upgrade.
 
+## 1.0.0.beta2 (pre-release)
+
+- Refactor attributes & backend plugins and make `mobility_attributes` public
+  ([#462](https://github.com/shioyama/mobility/pull/462))
+- Make attribute_methods plugin depend on attributes
+  ([#461](https://github.com/shioyama/mobility/pull/461))
+
 ## 1.0.0.beta1 (pre-release)
 
 - Remove `Mobility::Backend#apply_plugin`

data/Gemfile.lock

@@ -1,14 +1,13 @@
 PATH
   remote: .
   specs:
-    mobility (1.0.0.alpha)
+    mobility (1.0.0.beta2)
       i18n (>= 0.6.10, < 2)
       request_store (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    allocation_stats (0.1.5)
     benchmark-ips (2.8.3)
     byebug (11.1.3)
     coderay (1.1.3)
@@ -76,7 +75,6 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  allocation_stats
   benchmark-ips
   database_cleaner (~> 1.5, >= 1.5.3)
   guard-rspec

data/README.md

@@ -58,7 +58,7 @@ To use the latest pre-version of Mobility 1.0, add this line to your
 application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 1.0.0.beta1'
+gem 'mobility', '~> 1.0.0.beta2'
 ```
 
 For the latest stable version of Mobility, see the readme on the

data/lib/mobility/plugins/attribute_methods.rb

@@ -15,6 +15,7 @@ attributes only.
       extend Plugin
 
       default true
+      requires :attributes
 
       initialize_hook do |*names|
         include InstanceMethods

data/lib/mobility/plugins/attributes.rb

@@ -32,8 +32,15 @@ for aggregating attributes.
       end
 
       included_hook do |klass|
-        klass.extend ClassMethods
-        @names.each { |name| klass.register_mobility_attribute(name) }
+        names = @names
+
+        klass.class_eval do
+          extend ClassMethods
+          names.each { |name| mobility_attributes << name.to_s }
+          mobility_attributes.uniq!
+        rescue FrozenError
+          raise FrozenAttributesError, "Attempting to translate these attributes on #{klass}, which has already been subclassed: #{names.join(', ')}."
+        end
       end
 
       module ClassMethods
@@ -44,25 +51,20 @@ for aggregating attributes.
           mobility_attributes.include?(name.to_s)
         end
 
-        # Register a new attribute name. Public, but treat as internal.
-        # @param [String, Symbol] Attribute name
-        def register_mobility_attribute(name)
-          (self.mobility_attributes << name.to_s).uniq!
-        end
-
-        def inherited(klass)
-          super
-          mobility_attributes.each { |name| klass.register_mobility_attribute(name) }
-        end
-
-        protected
-
         # Return translated attribute names on this model.
         # @return [Array<String>] Attribute names
         def mobility_attributes
           @mobility_attributes ||= []
         end
+
+        def inherited(klass)
+          super
+          attrs = mobility_attributes.freeze # ensure attributes are not modified after being inherited
+          klass.class_eval { @mobility_attributes = attrs.dup }
+        end
       end
+
+      class FrozenAttributesError < Error; end
     end
 
     register_plugin(:attributes, Attributes)

data/lib/mobility/plugins/backend.rb

@@ -56,8 +56,11 @@ Defines:
 
           backend_class.setup_model(klass, names)
 
-          @names.each do |name|
-            klass.register_mobility_backend_class(name, @backend_class)
+          names = @names
+          backend_class = @backend_class
+
+          klass.class_eval do
+            names.each { |name| mobility_backend_classes[name.to_sym] = backend_class }
           end
 
           backend_class
@@ -137,12 +140,9 @@ Defines:
           raise KeyError, "No backend for: #{name}"
         end
 
-        def register_mobility_backend_class(name, backend_class)
-          mobility_backend_classes[name.to_sym] = backend_class
-        end
-
         def inherited(klass)
-          klass.mobility_backend_classes.merge!(@mobility_backend_classes)
+          parent_classes = mobility_backend_classes.freeze # ensure backend classes are not modified after being inherited
+          klass.class_eval { @mobility_backend_classes = parent_classes.dup }
           super
         end
 

data/lib/mobility/version.rb

@@ -9,7 +9,7 @@ module Mobility
     MAJOR = 1
     MINOR = 0
     TINY = 0
-    PRE = "beta1"
+    PRE = "beta2"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta1
+  version: 1.0.0.beta2
 platform: ruby
 authors:
 - Chris Salzberg
@@ -34,7 +34,7 @@ cert_chain:
   gSQml7TqcC6dZRsZRwYqzD9kUwdAJoCqno2CBUKs2l0yQAjFT36lRrVJznb7uWwa
   xpPFnsrtyaZW6Dty8TSG3qzmeGpmpIotA8x1VA==
   -----END CERTIFICATE-----
-date: 2020-11-03 00:00:00.000000000 Z
+date: 2020-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store