mobility 0.8.11 → 0.8.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af3d3290a6ff7b079c7762980e5b26127c22e2a047e24d1d732daae129c51d3e
-  data.tar.gz: 4318510dcbc21495323317f02fed44b8d44218bd572a1ff9a32ee401ea97ad43
+  metadata.gz: bd73c4e94757a4138786f7ebfeb2ac7bbdbcb219030af3319043232b696d70c2
+  data.tar.gz: c05a86a128d80fb859b531c25745474a561f92bf1c610a6d41250c4995f8b0a0
 SHA512:
-  metadata.gz: ac1ac24bec3eb971644aa9cf63a5515c102649cc534f8cce7455bc90dd2dbfbe3002fab8e8dfd79adb0b7784bf87269b7e074723caec1598b163595defa79da9
-  data.tar.gz: fb6cdeb01e91a6373486a5156742ef068184742d53419ea6b1595a878ddd03fbc82345333519917a242bbc61798fc4e71e5f21494c0939272576f2af912e5b15
+  metadata.gz: cfcddf59bc7a203fd00508bbcb32c8e59658eded31cbf637fb5fe9e9ccfd4cde3b59f762113b1f32c1427d5e2fecfa67e9c91d6c9d8b58c05928cf90356370be
+  data.tar.gz: 887fbb7bb02fa80fc421b45f8f434972c4d163e11e0d6d5dc2618f94e7f86307feb2fc4801c988fd86d19735edb863519b60addacaebebb49d2cb27490af0210

data/CHANGELOG.md

@@ -2,8 +2,22 @@
 
 ## 0.8
 
+### 0.8.13 (May 27, 2020)
+
+* Fix fallthrough accessor method_missing not passing all options to super
+  ([#364](https://github.com/shioyama/mobility/pull/364),
+  [#384](https://github.com/shioyama/mobility/pull/384),
+  [#377](https://github.com/shioyama/mobility/pull/377), thanks
+  [doits](https://github.com/doits)!)
+
+### 0.8.12 (May 15, 2020)
+
+(yanked)
+
 ### 0.8.11 (May 14, 2020)
-* Handle select with block ([#359](https://github.com/shioyama/mobility/pull/359))
+* Handle select with block
+  ([#359](https://github.com/shioyama/mobility/pull/359), thanks
+  [dlcmh](https://github.com/dlcmh)!)
 
 ### 0.8.10 (February 11, 2020)
 * Enforce case_sensitive comparison for Rails 6.1

data/Gemfile

@@ -3,41 +3,70 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in mobility.gemspec
 gemspec
 
+orm, orm_version = ENV['ORM'], ENV['ORM_VERSION']
+
 group :development, :test do
-  if ENV['ORM'] == 'active_record'
-    if ENV['RAILS_VERSION'] == '5.0'
-      gem 'activerecord', '>= 5.0', '< 5.1'
-    elsif ENV['RAILS_VERSION'] == '4.2'
+  case orm
+  when 'active_record'
+    orm_version ||= '6.0'
+    case orm_version
+    when '4.2'
       gem 'activerecord', '>= 4.2.6', '< 5.0'
-    elsif ENV['RAILS_VERSION'] == '5.1'
+    when '5.0'
+      gem 'activerecord', '>= 5.0', '< 5.1'
+    when '5.1'
       gem 'activerecord', '>= 5.1', '< 5.2'
-    elsif ENV['RAILS_VERSION'] == '5.2'
+    when '5.2'
       gem 'activerecord', '>= 5.2.0', '< 5.3'
       gem 'railties', '>= 5.2.0.rc2', '< 5.3'
-    else # Default is Rails 6.0
+    when '6.0'
       gem 'activerecord', '>= 6.0.0', '< 6.1'
+    when '6.1'
+      git 'https://github.com/rails/rails.git' do
+        gem 'activerecord'
+        gem 'activesupport'
+      end
+    else
+      raise ArgumentError, 'Invalid ActiveRecord version'
     end
+
     gem "generator_spec", '~> 0.9.4'
-  elsif ENV['ORM'] == 'sequel'
-    if ENV['SEQUEL_VERSION'] == '4'
+  when 'sequel'
+    orm_version ||= '5'
+    case orm_version
+    when '4'
       gem 'sequel', '>= 4.46.0', '< 5.0'
-    else
+    when '5'
       gem 'sequel', '>= 5.0.0', '< 6.0.0'
+    else
+      raise ArgumentError, 'Invalid Sequel version'
     end
+  when nil, ''
+  else
+    raise ArgumentError, "Invalid ORM: #{orm}"
   end
 
-  gem 'allocation_stats' if ENV['TEST_PERFORMANCE']
+  gem 'allocation_stats' if ENV['FEATURE'] == 'performance'
 
   platforms :ruby do
     gem 'guard-rspec'
     gem 'pry-byebug'
-    if ENV['ORM'] == 'active_record' && ENV['RAILS_VERSION'] < '5.2'
-      gem 'sqlite3', '~> 1.3.13'
-    else
-      gem 'sqlite3', '~> 1.4.1'
+    case ENV['DB']
+    when 'sqlite3'
+      if orm == 'active_record' && orm_version < '5.2'
+        gem 'sqlite3', '~> 1.3.13'
+      else
+        gem 'sqlite3', '~> 1.4.1'
+      end
+    when 'mysql'
+      gem 'mysql2'
+    when 'postgres'
+      if orm == 'active_record' && orm_version < '5.0'
+        gem 'pg', '< 1.0'
+      else
+        gem 'pg'
+      end
     end
-    gem 'mysql2', '~> 0.4.9'
-    gem 'pg', '< 1.0'
   end
 end
 

data/Gemfile.lock

@@ -1,51 +1,21 @@
 PATH
   remote: .
   specs:
-    mobility (0.8.10)
+    mobility (1.0.alpha.1)
       i18n (>= 0.6.10, < 2)
       request_store (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (6.0.3)
-      actionview (= 6.0.3)
-      activesupport (= 6.0.3)
-      rack (~> 2.0, >= 2.0.8)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (6.0.3)
-      activesupport (= 6.0.3)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activemodel (6.0.3)
-      activesupport (= 6.0.3)
-    activerecord (6.0.3)
-      activemodel (= 6.0.3)
-      activesupport (= 6.0.3)
-    activesupport (6.0.3)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
     benchmark-ips (2.8.2)
-    builder (3.2.4)
     byebug (11.1.3)
     coderay (1.1.2)
     concurrent-ruby (1.1.6)
-    crass (1.0.6)
     database_cleaner (1.8.5)
     diff-lcs (1.3)
-    erubi (1.9.0)
     ffi (1.12.2)
     formatador (0.2.5)
-    generator_spec (0.9.4)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
     guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -65,21 +35,12 @@ GEM
     listen (3.2.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    loofah (2.5.0)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
     lumberjack (1.2.4)
     method_source (1.0.0)
-    mini_portile2 (2.4.0)
-    minitest (5.14.0)
-    mysql2 (0.4.10)
     nenv (0.3.0)
-    nokogiri (1.10.9)
-      mini_portile2 (~> 2.4.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    pg (0.21.0)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -87,19 +48,6 @@ GEM
       byebug (~> 11.0)
       pry (~> 0.13.0)
     rack (2.2.2)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.3.0)
-      loofah (~> 2.3)
-    railties (6.0.3)
-      actionpack (= 6.0.3)
-      activesupport (= 6.0.3)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.20.3, < 2.0)
     rake (12.3.3)
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
@@ -120,31 +68,21 @@ GEM
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
     shellany (0.0.1)
-    sqlite3 (1.4.2)
     thor (1.0.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
     yard (0.9.25)
-    zeitwerk (2.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 6.0.0, < 6.1)
   benchmark-ips
   database_cleaner (~> 1.5, >= 1.5.3)
-  generator_spec (~> 0.9.4)
   guard-rspec
   mobility!
-  mysql2 (~> 0.4.9)
-  pg (< 1.0)
   pry-byebug
   rake (~> 12, >= 12.2.1)
   rspec (~> 3.0)
-  sqlite3 (~> 1.4.1)
   yard (~> 0.9.0)
 
 BUNDLED WITH
-   1.17.3
+   2.1.4

data/README.md

@@ -51,7 +51,7 @@ Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 0.8.11'
+gem 'mobility', '~> 0.8.13'
 ```
 
 Mobility is cryptographically signed. To be sure the gem you install hasn't

data/Rakefile

@@ -2,7 +2,9 @@ require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "yaml"
 
-RSpec::Core::RakeTask.new(:spec)
+RSpec::Core::RakeTask.new(:spec) do |task|
+  task.rspec_opts = '-f p'
+end
 
 task :default => :spec
 
@@ -18,7 +20,7 @@ namespace :db do
   desc "Create the database"
   task create: :setup do
     commands = {
-      "mysql"    => "mysql -u #{config['username']} -e 'create database #{config["database"]} default character set #{config["encoding"]} default collate #{config["collation"]};' >/dev/null",
+      "mysql"    => "mysql -h #{config['host']} -P #{config['port']} -u #{config['username']} --password=#{config['password']} -e 'create database #{config["database"]} default character set #{config["encoding"]} default collate #{config["collation"]};' >/dev/null",
       "postgres" => "psql -c 'create database #{config['database']};' -U #{config['username']} >/dev/null"
     }
     %x{#{commands[driver] || true}}
@@ -28,7 +30,7 @@ namespace :db do
   desc "Drop the database"
   task drop: :setup do
     commands = {
-      "mysql"    => "mysql -u #{config['username']} -e 'drop database #{config["database"]};' >/dev/null",
+      "mysql"    => "mysql -h #{config['host']} -P #{config['port']} -u #{config['username']} --password=#{config['password']} -e 'drop database #{config["database"]};' >/dev/null",
       "postgres" => "psql -c 'drop database #{config['database']};' -U #{config['username']} >/dev/null"
     }
     %x{#{commands[driver] || true}}
@@ -42,8 +44,8 @@ namespace :db do
 
     require orm
     require "database"
-    require "#{orm}/schema"
     DB = Mobility::Test::Database.connect(orm)
+    require "#{orm}/schema"
     Mobility::Test::Schema.up
   end
 

data/lib/mobility/plugins/fallthrough_accessors.rb

@@ -46,14 +46,18 @@ model class is generated.
       def initialize(*attributes)
         method_name_regex = /\A(#{attributes.join('|')})_([a-z]{2}(_[a-z]{2})?)(=?|\??)\z/.freeze
 
-        define_method :method_missing do |method_name, *arguments, **options, &block|
+        define_method :method_missing do |method_name, *args, &block|
           if method_name =~ method_name_regex
-            attribute = $1.to_sym
+            attribute_method = "#{$1}#{$4}"
             locale, suffix = $2.split('_')
             locale = "#{locale}-#{suffix.upcase}" if suffix
-            public_send("#{attribute}#{$4}", *arguments, **options, locale: locale.to_sym)
+            if $4 == '=' # writer
+              public_send(attribute_method, args[0], **(args[1] || {}), locale: locale.to_sym)
+            else         # reader
+              public_send(attribute_method, **(args[0] || {}), locale: locale.to_sym)
+            end
           else
-            super(method_name, *arguments, &block)
+            super(method_name, *args, &block)
           end
         end
 

data/lib/mobility/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mobility
-  VERSION = "0.8.11"
+  VERSION = "0.8.13"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 0.8.11
+  version: 0.8.13
 platform: ruby
 authors:
 - Chris Salzberg
@@ -34,7 +34,7 @@ cert_chain:
   gSQml7TqcC6dZRsZRwYqzD9kUwdAJoCqno2CBUKs2l0yQAjFT36lRrVJznb7uWwa
   xpPFnsrtyaZW6Dty8TSG3qzmeGpmpIotA8x1VA==
   -----END CERTIFICATE-----
-date: 2020-05-14 00:00:00.000000000 Z
+date: 2020-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store
@@ -273,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Pluggable Ruby translation framework