mobility 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c134f78117865e131baf9ceecb0c902cb63abb08
-  data.tar.gz: 2076ecc0e3164b962d1f5147e0af81d2ba9baac3
+  metadata.gz: 7758652b17c028026785aab433d317fa8508b3b1
+  data.tar.gz: 359c5dd578fe9f7d2f1cb3aef187aacbf3a12246
 SHA512:
-  metadata.gz: f6ec9f5003e16ace7ea7a77136266af20f5c86beb1ebea6ae4e83598d20bdf4d14971d6f029c2b1bd74763c599287e362b7b3204c51660606ab2b371a4620842
-  data.tar.gz: 8eae38b70cb15cb0eeec7dfb51f72e4076268312bdd73d63a9fda7611414d116e5bd95771a3042ca080ea4495c335e50a66f5c92a1beb6994e2d1d8d4c9d3bb9
+  metadata.gz: 42dc9e922f1da3baccad99b8acaff68b7ff7f69623b700ba71b698337c2d21dd78ec53b07d533d7c3cfb732d4f44b999506e31103ab2027e591146ddb65556be
+  data.tar.gz: ce8545687458395b0817ef6f478262664478afcc6a3b9d22441d1eae61268f8d705deacef2ba30f01e2573bafc688f4d51d813cf62bfe444bf5bce3cfb93c9c7

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## 0.3
 
+### 0.3.1 (December 1, 2017)
+* Disable AR::Dirty method overrides for AR >= 5.2 (and < 5.1 for `has_attribute`) ([#120](https://github.com/shioyama/mobility/pull/120))
+
 ### 0.3.0 (November 30, 2017)
 * `dup` support for table backend ([#84](https://github.com/shioyama/mobility/pull/84)). Thanks [@pwim](https://github.com/pwim)!
 * Disable fallbacks when using locale/fallthrough accessors
@@ -15,6 +18,7 @@
 * Update dependency versions ([#107](https://github.com/shioyama/mobility/pull/107))
 * Support new AR::Dirty methods ([#111](https://github.com/shioyama/mobility/pull/111))
 * Use `public_send` in LocaleAccessors plugin ([#117](https://github.com/shioyama/mobility/pull/117))
+* Deprecate setting value of `default_options` directly ([#113](https://github.com/shioyama/mobility/pull/113))
 
 ## 0.2
 

data/Gemfile.lock

@@ -1,38 +1,38 @@
 PATH
   remote: .
   specs:
-    mobility (0.3.0.pre.alpha)
+    mobility (0.3.0)
       i18n (>= 0.6.10, < 0.10)
       request_store (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (5.2.0.beta2)
-      actionview (= 5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
+    actionpack (5.1.4)
+      actionview (= 5.1.4)
+      activesupport (= 5.1.4)
       rack (~> 2.0)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
+    actionview (5.1.4)
+      activesupport (= 5.1.4)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
-    activerecord (5.2.0.beta2)
-      activemodel (= 5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
-      arel (>= 9.0)
-    activesupport (5.2.0.beta2)
+    activemodel (5.1.4)
+      activesupport (= 5.1.4)
+    activerecord (5.1.4)
+      activemodel (= 5.1.4)
+      activesupport (= 5.1.4)
+      arel (~> 8.0)
+    activesupport (5.1.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    arel (9.0.0)
+    arel (8.0.0)
     builder (3.2.3)
     byebug (9.1.0)
     coderay (1.1.2)
@@ -95,9 +95,9 @@ GEM
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.2.0.beta2)
-      actionpack (= 5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
+    railties (5.1.4)
+      actionpack (= 5.1.4)
+      activesupport (= 5.1.4)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
@@ -132,7 +132,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 5.2.0.beta1)
+  activerecord (>= 5.1, < 5.2)
   bundler (~> 1.12)
   database_cleaner (~> 1.5, >= 1.5.3)
   generator_spec (~> 0.9.4)
@@ -141,7 +141,6 @@ DEPENDENCIES
   mysql2 (~> 0.4.9)
   pg
   pry-byebug
-  railties (>= 5.2.0.beta1)
   rake (~> 12, >= 12.2.1)
   rspec (~> 3.0)
   sqlite3

data/README.md

@@ -52,7 +52,7 @@ Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 0.3.0'
+gem 'mobility', '~> 0.3.1'
 ```
 
 Mobility is cryptographically signed. To be sure the gem you install hasn't
@@ -96,6 +96,7 @@ with the lines:
 Mobility.configure do |config|
   config.default_backend = :key_value
   config.accessor_method = :translates
+  config.query_method    = :i18n
 end
 ```
 

data/lib/mobility/plugins/active_record/dirty.rb

@@ -30,32 +30,39 @@ AR::Dirty plugin adds support for the following persistence-specific methods
           def initialize(*attribute_names)
             super
             @attribute_names = attribute_names
-            define_method_overrides
+            define_method_overrides if ::ActiveRecord::VERSION::STRING < '5.2'
             define_attribute_methods if ::ActiveRecord::VERSION::STRING >= '5.1'
           end
 
-          # Overrides +ActiveRecord::AttributeMethods::ClassMethods#has_attribute+ and
-          # +ActiveModel::AttributeMethods#_read_attribute+ to treat
-          # fallthrough attribute methods just like "real" attribute methods.
+          # Overrides +ActiveRecord::AttributeMethods::ClassMethods#has_attribute+ (in AR 5.1) and
+          # +ActiveModel::AttributeMethods#_read_attribute+ (in AR >= 5.2) to
+          # ensure that fallthrough attribute methods are treated like "real"
+          # attribute methods.
           #
-          # @note Patching +has_attribute?+ is necessary as of AR 5.1 due to this commit[https://github.com/rails/rails/commit/4fed08fa787a316fa51f14baca9eae11913f5050].
-          #   (I have voiced my opposition to this change here[https://github.com/rails/rails/pull/27963#issuecomment-310092787]).
+          # @note Patching +has_attribute?+ is necessary in AR 5.1 due to this commit[https://github.com/rails/rails/commit/4fed08fa787a316fa51f14baca9eae11913f5050].
           # @param [Attributes] attributes
           def included(model_class)
             super
-            names = @attribute_names
-            method_name_regex = /\A(#{names.join('|'.freeze)})_([a-z]{2}(_[a-z]{2})?)(=?|\??)\z/.freeze
-            has_attribute = Module.new do
-              define_method :has_attribute? do |attr_name|
-                super(attr_name) || !!method_name_regex.match(attr_name)
+
+            if ::ActiveRecord::VERSION::MAJOR == 5 && ::ActiveRecord::VERSION::MINOR == 1
+              names = @attribute_names
+              method_name_regex = /\A(#{names.join('|'.freeze)})_([a-z]{2}(_[a-z]{2})?)(=?|\??)\z/.freeze
+              has_attribute = Module.new do
+                define_method :has_attribute? do |attr_name|
+                  super(attr_name) || !!method_name_regex.match(attr_name)
+                end
               end
+              model_class.extend has_attribute
+            elsif ::ActiveRecord::VERSION::STRING >= '5.2'
+              model_class.include ReadAttribute
             end
-            model_class.extend has_attribute
-            model_class.include ReadAttribute if ::ActiveRecord::VERSION::STRING >= '5.2'
           end
 
           private
 
+          # @note These method overrides are needed for AR versions < 5.2,
+          #   since AR::Dirty overrides AM::Dirty, disabling previous_changes
+          #   from being set. Here we "undo" that.
           def define_method_overrides
             changes_applied_method = ::ActiveRecord::VERSION::STRING < '5.1' ? :changes_applied : :changes_internally_applied
             define_method changes_applied_method do

data/lib/mobility/version.rb

@@ -1,3 +1,3 @@
 module Mobility
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Chris Salzberg
@@ -30,7 +30,7 @@ cert_chain:
   eGDROPZoL5RXwiOnRbexxa7dcAxMrDfGB/hpiunIPWPsi4n5P7K/6OO/sGVMl9xv
   SZBPXjzrHdyOFLBYXB+PG7s3F/4=
   -----END CERTIFICATE-----
-date: 2017-11-30 00:00:00.000000000 Z
+date: 2017-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store