mobility 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db71989aceb090cc6bc7fba2a4bfed78ae0ccc23
-  data.tar.gz: fa3c53b2540e63638c7e35b2fa43731b7c00ed90
+  metadata.gz: 1d5bbeab96e1792e6240d3f1854e302c5845689b
+  data.tar.gz: 0a821c40d9b1c3e6202a92e6194307fb0698c12c
 SHA512:
-  metadata.gz: 9cef93cb7bc0a451a3eaf7ea18b284258894a99c5214b5933f9ff54752bf525900736c35850c6a7e3a712e116e5b3c0a721b230eeefff3fbf7cab452ed6daa66
-  data.tar.gz: 0b682ce576e80ba2834f80fe91b19d0027277b06fea27f1fa8eca9e3aa91fc2bba627b0bfea8fe9b495bae5cd19b5ee2eb0b697a6dd592283ecc3e73453ea494
+  metadata.gz: 8cc59378dff919de4592e35b1a73e11ab808616ed1b6a9cdc84737e447a97a50d2503d348a41d3c8645f129a0f65554705a5696041c89950e5e7dd3b98b4f357
+  data.tar.gz: ed3e03d952e333bd04e4d366b0a9e6d523981e8270c1e5d7d36213e15806383ca3c6c0cd245e72b304420e725bcfbe400f4e3a28b32d64394a7ba29bf4f3004b

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## 0.1
 
+### 0.1.12
+* Extract presence filter into `Mobility::Backend::Presence` class
+  ([7d654](https://github.com/shioyama/mobility/commit/7d65479c832ca154a45a548b64d27016486d34df),
+  [e42ee6](https://github.com/shioyama/mobility/commit/e42ee6123197594f3a8d694bff68c2ef4044562e))
+* Get suffix methods from ActiveModel (for compatibility with Rails 4.2)
+  ([9685d1](https://github.com/shioyama/mobility/commit/9685d182f285bddd2f5739a655f7c9e18998a5a1))
+* Destroy all translations after model is destroyed (KeyValue backend)
+  ([#15](https://github.com/shioyama/mobility/pull/15))
+* Refactor to remove `mobility_get`, `mobility_set`. `mobility_present?` models
+  from model class ([#16](https://github.com/shioyama/mobility/pull/16))
+
 ### 0.1.11
 * Add backend-specific translations generator (`rails generate
   mobility:translations`)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mobility (0.1.10)
+    mobility (0.1.11)
       i18n (>= 0.6.10)
       request_store (~> 1.0)
 
@@ -29,9 +29,10 @@ GEM
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
     i18n (0.8.1)
-    listen (3.0.8)
+    listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
+      ruby_dep (~> 1.2)
     lumberjack (1.0.11)
     method_source (0.8.2)
     mysql2 (0.3.21)
@@ -39,7 +40,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    pg (0.19.0)
+    pg (0.20.0)
     pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -68,7 +69,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    sequel (4.42.1)
+    ruby_dep (1.5.0)
     shellany (0.0.1)
     slop (3.6.0)
     sqlite3 (1.3.13)
@@ -89,7 +90,6 @@ DEPENDENCIES
   rake (~> 10.0)
   rspec (~> 3.0)
   rspec-its (~> 1.2.0)
-  sequel (>= 4.0.0, < 5.0)
   sqlite3
   yard (~> 0.9.0)
 

data/README.md

@@ -37,7 +37,8 @@ platforms planned.
 For a detailed introduction to Mobility, see [Translating with
 Mobility](http://dejimata.com/2017/3/3/translating-with-mobility). See also the
 [Roadmap](https://github.com/shioyama/mobility/wiki/Roadmap) for what's in the
-works for future releases.
+works for future releases, and other pages of the [wiki][wiki] for more detail
+on usage.
 
 Installation
 ------------
@@ -45,7 +46,7 @@ Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 0.1.11'
+gem 'mobility', '~> 0.1.12'
 ```
 
 To translate attributes on a model, include (or extend) `Mobility`, then call
@@ -97,10 +98,10 @@ You can include `Mobility` just like in ActiveRecord, or you can use the
 `mobility` plugin, which does the same thing:
 
 ```ruby
-class Post < ::Sequel::Model
+class Word < ::Sequel::Model
   plugin :mobility
-  translates :title,   type: :string
-  translates :content, type: :text
+  translates :name,    type: :string
+  translates :meaning, type: :text
 end
 ```
 
@@ -108,7 +109,7 @@ Otherwise everything is (almost) identical to AR, with the exception that there
 is no equivalent to a Rails generator (so you will need to create the migration
 for any translation table(s) yourself, using Rails generators as a reference).
 
-The models in examples below all inherit from `ActiveRecord::Base`, but
+The models in examples below all inherit from `ApplicationRecord`, but
 everything works exactly the same if the parent class is `Sequel::Model`.
 
 Usage
@@ -117,10 +118,12 @@ Usage
 ### <a name="quickstart"></a>Getting Started
 
 Once the install generator has been run to generate translation tables, using
-Mobility is as easy as adding a few lines to any class you want to translate:
+Mobility is as easy as adding a few lines to any class you want to translate.
+Simply pass one or more attribute names to the `translates` method with a hash
+of options, like this:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   include Mobility
   translates :name,    type: :string
   translates :meaning, type: :text
@@ -221,7 +224,7 @@ accessors" in Mobility, and they can be defined by passing a `locale_accessors`
 option when defining translated attributes on the model class:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   include Mobility
   translates :name, type: :string, locale_accessors: [:en, :ja]
 end
@@ -261,7 +264,7 @@ precedence if defined for a given locale.)
 For example, if we define `Word` this way:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   include Mobility
   translates :name, type: :string, fallthrough_accessors: true
 end
@@ -366,7 +369,7 @@ pass a hash with fallbacks for each locale as an option when defining
 translated attributes on a class:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   include Mobility
   translates :name,    type: :string, fallbacks: { de: :ja, fr: :ja }
   translates :meaning, type: :text,   fallbacks: { de: :ja, fr: :ja }
@@ -451,7 +454,7 @@ First, enable dirty tracking (note that this is a persisted AR model, although
 dirty tracking is not specific to AR and works for non-persisted models as well):
 
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   include Mobility
   translates :title, type: :string, dirty: true
 end
@@ -525,7 +528,7 @@ generally only be disabled when debugging; this can be done by passing `cache:
 false` when defining an attribute, like this:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   include Mobility
   translates :name, type: :string, cache: false
 end
@@ -546,7 +549,7 @@ Mobility-specific query method overrides.
 So assuming a model:
 
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   include Mobility
   translates :title,   type: :string
   translates :content, type: :text
@@ -590,7 +593,7 @@ If you would prefer to avoid the `i18n` scope everywhere, define it as a
 default scope on your model:
 
 ```ruby
-class Post < ActiveRecord::Base
+class Post < ApplicationRecord
   include Mobility
   translates :title,   type: :string
   translates :content, type: :text
@@ -617,7 +620,7 @@ configuration, or you can set it explicitly when defining a translated
 attribute, like this:
 
 ```ruby
-class Word < ActiveRecord::Base
+class Word < ApplicationRecord
   translates :name, backend: :table
 end
 ```
@@ -626,7 +629,8 @@ This would set the `name` attribute to use the `Table` backend (see below).
 The `type` option (`type: :string` or `type: :text`) is missing here because
 this is an option specific to the KeyValue backend (specifying which shared
 table to store translations on). Backends have their own specific options; see
-the API documentation for which options are available for each.
+the [Wiki][wiki] and [API documentation][api] for which options are available
+for each.
 
 Everything else described above (fallbacks, dirty tracking, locale accessors,
 caching, querying, etc) is the same regardless of which backend you use.
@@ -648,12 +652,14 @@ rails generate mobility:translations post title:string content:text
 
 This will generate the `post_translations` table with columns `title` and
 `content`, and all other necessary columns and indices. For more details see
-the API documentation on the [`Mobility::Backend::Table`
+the [Table
+Backend](https://github.com/shioyama/mobility/wiki/Table-Backend) page of the
+wiki and API documentation on the [`Mobility::Backend::Table`
 class](http://www.rubydoc.info/gems/mobility/Mobility/Backend/Table).
 
 ### Column Backend (like Traco)
 
-The `Column` backend stores translationsi as columns with locale suffixes on
+The `Column` backend stores translations as columns with locale suffixes on
 the model table. For an attribute `title`, these would be of the form
 `title_en`, `title_fr`, etc.
 
@@ -664,7 +670,9 @@ Use the `mobility:translations` generator to add columns for locales in
 rails generate mobility:translations post title:string content:text
 ```
 
-For more details, see the API documentation on the [`Mobility::Backend::Column`
+For more details, see the [Column
+Backend](https://github.com/shioyama/mobility/wiki/Column-Backend) page of the
+wiki and API documentation on the [`Mobility::Backend::Column`
 class](http://www.rubydoc.info/gems/mobility/Mobility/Backend/Column).
 
 ### PostgreSQL-specific Backends
@@ -672,7 +680,9 @@ class](http://www.rubydoc.info/gems/mobility/Mobility/Backend/Column).
 Mobility also supports jsonb and Hstore storage options, if you are using
 PostgreSQL as your database. To use this option, create column(s) on the model
 table for each translated attribute, and set your backend to `:jsonb` or
-`:hstore`. Other details are covered in the API documentation
+`:hstore`. Other details are covered in the [Postgres
+Backend](https://github.com/shioyama/mobility/wiki/Postgres-Backends) page of
+the wiki and in the API documentation
 ([`Mobility::Backend::Jsonb`](http://www.rubydoc.info/gems/mobility/Mobility/Backend/Jsonb)
 and
 [`Mobility::Backend::Hstore`](http://www.rubydoc.info/gems/mobility/Mobility/Backend/Hstore)).
@@ -703,8 +713,9 @@ class MyClass
 end
 ```
 
-For details on how to define a backend class, see the [API documentation on the
-`Mobility::Backend`
+For details on how to define a backend class, see the [Introduction to Mobility
+Backends](https://github.com/shioyama/mobility/wiki/Introduction-to-Mobility-Backends)
+page of the wiki and the [API documentation on the `Mobility::Backend`
 module](http://www.rubydoc.info/gems/mobility/Mobility/Backend).
 
 ### Testing Backends

data/lib/mobility.rb

@@ -37,6 +37,7 @@ module Mobility
   autoload :BackendResetter,      "mobility/backend_resetter"
   autoload :Configuration,        "mobility/configuration"
   autoload :FallthroughAccessors, "mobility/fallthrough_accessors"
+  autoload :LocaleAccessors,      "mobility/locale_accessors"
   autoload :InstanceMethods,      "mobility/instance_methods"
   autoload :Translates,           "mobility/translates"
   autoload :Wrapper,              "mobility/wrapper"

data/lib/mobility/attributes.rb

@@ -115,16 +115,18 @@ with other backends.
     # @param [Array<String>] attributes_ Attributes to define backend for
     # @param [Hash] options_ Backend options hash
     # @option options_ [Class] model_class Class of model
-    # @option options_ [Boolean, Array<Symbol>] locale_accessors Enable locale
-    #   accessors or specify locales for which accessors should be defined on
-    #   this model backend. Will default to +true+ if +dirty+ option is +true+.
     # @option options_ [Boolean] cache (true) Enable cache for this model backend
-    # @option options_ [Boolean, Hash] fallbacks Enable fallbacks or specify
-    #   fallbacks for this model backend
     # @option options_ [Boolean] dirty Enable dirty tracking for this model
     #   backend
+    # @option options_ [Boolean, Hash] fallbacks Enable fallbacks or specify
+    #   fallbacks for this model backend
     # @option options_ [Boolean] fallthrough_accessors Enable fallthrough
     #   locale accessors for this model backend
+    # @option options_ [Boolean, Array<Symbol>] locale_accessors Enable locale
+    #   accessors or specify locales for which accessors should be defined on
+    #   this model backend. Will default to +true+ if +dirty+ option is +true+.
+    # @option options_ [Boolean] presence (true) Enable presence filter on
+    #   reads and writes
     # @raise [ArgumentError] if method is not reader, writer or accessor
     def initialize(method, *attributes_, **options_)
       raise ArgumentError, "method must be one of: reader, writer, accessor" unless %i[reader writer accessor].include?(method)
@@ -137,7 +139,7 @@ with other backends.
       if (options[:dirty] && options[:fallthrough_accessors] != false)
         options[:fallthrough_accessors] = true
       end
-      include FallthroughAccessors.new(attributes) if options[:fallthrough_accessors]
+      include FallthroughAccessors.new(*attributes) if options[:fallthrough_accessors]
 
       @backend_class.configure!(options) if @backend_class.respond_to?(:configure!)
 
@@ -145,25 +147,12 @@ with other backends.
 
       @accessor_locales = options[:locale_accessors]
       @accessor_locales = Mobility.config.default_accessor_locales if @accessor_locales == true
+      include LocaleAccessors.new(*attributes, locales: @accessor_locales) if @accessor_locales
 
       attributes.each do |attribute|
         define_backend(attribute)
-
-        if %i[accessor reader].include?(method)
-          define_method attribute do |**options|
-            mobility_get(attribute, options)
-          end
-
-          define_method "#{attribute}?" do |**options|
-            mobility_present?(attribute, options)
-          end
-        end
-
-        define_method "#{attribute}=" do |value, **options|
-          mobility_set(attribute, value, **options)
-        end if %i[accessor writer].include?(method)
-
-        define_locale_accessors(attribute, @accessor_locales) if @accessor_locales
+        define_reader(attribute) if %i[accessor reader].include?(method)
+        define_writer(attribute) if %i[accessor writer].include?(method)
       end
     end
 
@@ -188,6 +177,7 @@ with other backends.
       backend_class.include(Backend::Cache)                            unless options[:cache] == false
       backend_class.include(Backend::Dirty.for(options[:model_class])) if options[:dirty]
       backend_class.include(Backend::Fallbacks)                        unless options[:fallbacks] == false
+      backend_class.include(Backend::Presence)                         unless options[:presence] == false
     end
 
     def define_backend(attribute)
@@ -198,18 +188,22 @@ with other backends.
       end
     end
 
-    def define_locale_accessors(attribute, locales)
-      locales.each do |locale|
-        normalized_locale = Mobility.normalize_locale(locale)
-        define_method "#{attribute}_#{normalized_locale}" do |**options|
-          mobility_get(attribute, options.merge(locale: locale))
-        end
-        define_method "#{attribute}_#{normalized_locale}?" do |**options|
-          mobility_present?(attribute, options.merge(locale: locale))
-        end
-        define_method "#{attribute}_#{normalized_locale}=" do |value, **options|
-          mobility_set(attribute, value, locale: locale)
-        end
+    def define_reader(attribute)
+      define_method attribute do |locale: Mobility.locale, **options|
+        Mobility.enforce_available_locales!(locale)
+        mobility_backend_for(attribute).read(locale.to_sym, options)
+      end
+
+      define_method "#{attribute}?" do |locale: Mobility.locale, **options|
+        Mobility.enforce_available_locales!(locale)
+        mobility_backend_for(attribute).read(locale.to_sym, options).present?
+      end
+    end
+
+    def define_writer(attribute)
+      define_method "#{attribute}=" do |value, locale: Mobility.locale, **options|
+        Mobility.enforce_available_locales!(locale)
+        mobility_backend_for(attribute).write(locale.to_sym, value, options)
       end
     end
 

data/lib/mobility/backend.rb

@@ -60,6 +60,7 @@ On top of this, a backend will normally:
     autoload :KeyValue,     'mobility/backend/key_value'
     autoload :Null,         'mobility/backend/null'
     autoload :OrmDelegator, 'mobility/backend/orm_delegator'
+    autoload :Presence,     'mobility/backend/presence'
     autoload :Sequel,       'mobility/backend/sequel'
     autoload :Serialized,   'mobility/backend/serialized'
     autoload :Table,        'mobility/backend/table'

data/lib/mobility/backend/active_model/dirty.rb

@@ -47,11 +47,11 @@ value of the translated attribute if passed to it.
         def setup_model(model_class, attributes, **options)
           super
           model_class.class_eval do
-            %w[changed? change was will_change! previously_changed? previous_change].each do |suffix|
+            Mobility::Backend::ActiveModel::Dirty.method_suffixes.each do |suffix|
               attributes.each do |attribute|
                 class_eval <<-EOM, __FILE__, __LINE__ + 1
-                  def #{attribute}_#{suffix}
-                    attribute_#{suffix}(Mobility.normalize_locale_accessor("#{attribute}"))
+                  def #{attribute}#{suffix}
+                    attribute#{suffix}(Mobility.normalize_locale_accessor("#{attribute}"))
                   end
                 EOM
               end
@@ -80,6 +80,18 @@ value of the translated attribute if passed to it.
           model_class.include restore_methods
         end
       end
+
+      # Get method suffixes. Creating an object just to get the list of
+      # suffixes is not very efficient, but the most reliable way given that
+      # they change from Rails version to version.
+      def self.method_suffixes
+        @method_suffixes ||=
+          begin
+            Class.new do
+              include ::ActiveModel::Dirty
+            end.attribute_method_matchers.map { |m| m.suffix }
+          end.select { |m| m =~ /\A_/ }
+      end
     end
   end
 end

data/lib/mobility/backend/active_record/column.rb

@@ -43,7 +43,7 @@ or locales.)
       # @!group Backend Accessors
       # @!macro backend_writer
       def write(locale, value, **_)
-        model.write_attribute(column(locale), value)
+        model.send(:write_attribute, column(locale), value)
       end
 
       # @!group Backend Configuration

data/lib/mobility/backend/active_record/key_value.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Mobility
   module Backend
 =begin
@@ -54,7 +56,7 @@ Implements the {Mobility::Backend::KeyValue} backend for ActiveRecord models.
       def self.configure!(options)
         super
         type = options[:type]
-        options[:class_name] ||= Mobility::ActiveRecord.const_get("#{type.capitalize}Translation")
+        options[:class_name] ||= Mobility::ActiveRecord.const_get("#{type.capitalize}Translation".freeze)
         options[:class_name] = options[:class_name].constantize if options[:class_name].is_a?(String)
         options[:association_name] ||= options[:class_name].table_name.to_sym
         %i[type association_name].each { |key| options[key] = options[key].to_sym }
@@ -77,7 +79,6 @@ Implements the {Mobility::Backend::KeyValue} backend for ActiveRecord models.
         has_many association_name, ->{ where key: association_attributes },
           as: :translatable,
           class_name: translations_class,
-          dependent:  :destroy,
           inverse_of: :translatable,
           autosave:   true
         before_save do
@@ -85,6 +86,7 @@ Implements the {Mobility::Backend::KeyValue} backend for ActiveRecord models.
             send(association_name).destroy(translation)
           end
         end
+        after_destroy :mobility_destroy_key_value_translations
 
         mod = Module.new do
           define_method :i18n do
@@ -92,6 +94,16 @@ Implements the {Mobility::Backend::KeyValue} backend for ActiveRecord models.
           end
         end
         extend mod
+
+        private
+
+        # Clean up *all* leftover translations of this model, only once.
+        def mobility_destroy_key_value_translations
+          [:string, :text].freeze.each do |type|
+            Mobility::ActiveRecord.const_get("#{type.capitalize}Translation".freeze).
+              where(translatable: self).destroy_all
+          end
+        end unless private_instance_methods(false).include?(:mobility_destroy_key_value_translations)
       end
 
       # @!group Cache Methods

data/lib/mobility/backend/fallbacks.rb

@@ -95,11 +95,12 @@ locale was +nil+.
       # @param [Boolean,Symbol,Array] fallback
       #   +false+ to disable fallbacks on lookup, or a locale or array of
       #   locales to set fallback(s) for this lookup.
-      def read(locale, fallback: nil, **options)
+      def read(locale, **options)
         if !options[:fallbacks].nil?
           warn "You passed an option with key 'fallbacks', which will be
             ignored. Did you mean 'fallback'?"
         end
+        fallback = options.delete(:fallback)
         return super if fallback == false || (fallback.nil? && fallbacks.nil?)
         (fallback ? [locale, *fallback] : fallbacks[locale]).detect do |fallback_locale|
           value = super(fallback_locale, **options)

data/lib/mobility/backend/presence.rb

@@ -0,0 +1,30 @@
+module Mobility
+  module Backend
+=begin
+
+Applies presence filter to values fetched from backend and to values set on
+backend. Included by default, but can be disabled with presence: false option.
+
+=end
+    module Presence
+      # @group Backend Accessors
+      # @!macro backend_reader
+      # @param [Boolean] presence
+      #   *false* to disable presence filter.
+      def read(locale, **options)
+        return super if options.delete(:presence) == false
+        value = super
+        value == false ? value : value.presence
+      end
+
+      # @group Backend Accessors
+      # @!macro backend_writer
+      # @param [Boolean] presence
+      #   *false* to disable presence filter.
+      def write(locale, value, **options)
+        return super if options.delete(:presence) == false
+        super(locale, value == false ? value : value.presence, **options)
+      end
+    end
+  end
+end

data/lib/mobility/backend/sequel/key_value.rb

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 module Mobility
   module Backend
 =begin
@@ -52,7 +54,7 @@ Implements the {Mobility::Backend::KeyValue} backend for Sequel models.
         super
         raise CacheRequired, "Cache required for Sequel::KeyValue backend" if options[:cache] == false
         type = options[:type]
-options[:class_name] ||= Mobility::Sequel.const_get("#{type.capitalize}Translation")
+        options[:class_name] ||= Mobility::Sequel.const_get("#{type.capitalize}Translation".freeze)
         options[:class_name] = options[:class_name].constantize if options[:class_name].is_a?(String)
         options[:association_name] ||= options[:class_name].table_name.to_sym
         %i[type association_name].each { |key| options[key] = options[key].to_sym }
@@ -77,8 +79,6 @@ options[:class_name] ||= Mobility::Sequel.const_get("#{type.capitalize}Translati
           clearer:         proc { send(:"#{association_name}_dataset").update(translatable_id: nil, translatable_type: nil) },
           class:           translations_class
 
-        plugin :association_dependencies, association_name => :destroy
-
         callback_methods = Module.new do
           define_method :before_save do
             super()
@@ -99,6 +99,22 @@ options[:class_name] ||= Mobility::Sequel.const_get("#{type.capitalize}Translati
         extend extension
 
         include Mobility::Sequel::ColumnChanges.new(attributes)
+
+        private
+
+        # Clean up *all* leftover translations of this model, only once.
+        def self.mobility_key_value_callbacks_module
+          @mobility_key_value_destroy_callbacks_module ||= Module.new do
+            def after_destroy
+              super
+              [:string, :text].freeze.each do |type|
+                Mobility::Sequel.const_get("#{type.capitalize}Translation".freeze).
+                  where(translatable_id: id, translatable_type: self.class.name).destroy
+              end
+            end
+          end
+        end unless respond_to?(:mobility_key_value_callbacks_module, true)
+        include mobility_key_value_callbacks_module
       end
 
       # @!group Cache Methods

data/lib/mobility/fallthrough_accessors.rb

@@ -34,7 +34,7 @@ model class is generated.
 
 =end
   class FallthroughAccessors < Module
-    # @param [Array<String>] Array of attributes
+    # @param [String] One or more attributes
     def initialize(*attributes)
       method_name_regex = /\A(#{attributes.join('|'.freeze)})_([a-z]{2}(_[a-z]{2})?)(=?|\??)\z/.freeze
 

data/lib/mobility/instance_methods.rb

@@ -11,26 +11,5 @@ Instance methods attached to all model classes when model includes or extends
     def mobility_backend_for(attribute)
       send(Backend.method_name(attribute))
     end
-
-    private
-
-    def mobility_get(*args)
-      value = mobility_read(*args)
-      value == false ? value : value.presence
-    end
-
-    def mobility_present?(*args)
-      mobility_read(*args).present?
-    end
-
-    def mobility_set(attribute, value, locale: Mobility.locale, **options)
-      Mobility.enforce_available_locales!(locale)
-      mobility_backend_for(attribute).write(locale.to_sym, value == false ? value : value.presence, **options)
-    end
-
-    def mobility_read(attribute, locale: Mobility.locale, **options)
-      Mobility.enforce_available_locales!(locale)
-      mobility_backend_for(attribute).read(locale.to_sym, options)
-    end
   end
 end

data/lib/mobility/locale_accessors.rb

@@ -0,0 +1,55 @@
+# frozen-string-literal: true
+
+module Mobility
+=begin
+
+Defines methods for a set of locales to access translated attributes in those
+locales directly with a method call, using a suffix including the locale:
+
+  article.title_pt_br
+
+If no locales are passed as an option to the initializer,
++I18n.available_locales+ will be used by default.
+
+@example
+  class Post
+    def title
+      "title in #{Mobility.locale}"
+    end
+    include Mobility::LocaleAccessors.new("title", locales: [:en, :fr])
+  end
+
+  Mobility.locale = :en
+  post = Post.new
+  post.title
+  #=> "title in en"
+  post.title_fr
+  #=> "title in fr"
+
+=end
+  class LocaleAccessors < Module
+    # @param [String] One or more attributes
+    # @param [Array<Symbol>] Locales
+    def initialize(*attributes, locales: I18n.available_locales)
+      warning_message = "locale passed as option to locale accessor will be ignored".freeze
+
+      attributes.each do |attribute|
+        locales.each do |locale|
+          normalized_locale = Mobility.normalize_locale(locale)
+          define_method "#{attribute}_#{normalized_locale}" do |**options|
+            warn warning_message if options.delete(:locale)
+            Mobility.with_locale(locale) { send(attribute, options) }
+          end
+          define_method "#{attribute}_#{normalized_locale}?" do |**options|
+            warn warning_message if options.delete(:locale)
+            Mobility.with_locale(locale) { send("#{attribute}?", options) }
+          end
+          define_method "#{attribute}_#{normalized_locale}=" do |value, **options|
+            warn warning_message if options.delete(:locale)
+            Mobility.with_locale(locale) { send("#{attribute}=", value, options) }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/mobility/sequel/column_changes.rb

@@ -11,18 +11,18 @@ is called.
       def initialize(attributes)
         @attributes = attributes
 
-        define_method :mobility_set do |attribute, value, locale: Mobility.locale|
-          if attributes.include?(attribute)
-            column = attribute.to_sym
-            column_with_locale = :"#{attribute}_#{Mobility.normalize_locale(locale)}"
-            if mobility_get(attribute) != value
+        attributes.each do |attribute|
+          define_method "#{attribute}=" do |value, **options|
+            if send(attribute) != value
+              locale = options[:locale] || Mobility.locale
+              column = attribute.to_sym
+              column_with_locale = :"#{attribute}_#{Mobility.normalize_locale(locale)}"
               @changed_columns << column_with_locale if !changed_columns.include?(column_with_locale)
               @changed_columns << column             if !changed_columns.include?(column)
             end
+            super(value, **options)
           end
-          super(attribute, value, locale: locale)
         end
-        private :mobility_set
       end
     end
   end

data/lib/mobility/version.rb

@@ -1,3 +1,3 @@
 module Mobility
-  VERSION = "0.1.11"
+  VERSION = "0.1.12"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Chris Salzberg
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-26 00:00:00.000000000 Z
+date: 2017-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store
@@ -186,6 +186,7 @@ files:
 - lib/mobility/backend/key_value.rb
 - lib/mobility/backend/null.rb
 - lib/mobility/backend/orm_delegator.rb
+- lib/mobility/backend/presence.rb
 - lib/mobility/backend/sequel.rb
 - lib/mobility/backend/sequel/column.rb
 - lib/mobility/backend/sequel/column/query_methods.rb
@@ -210,6 +211,7 @@ files:
 - lib/mobility/core_ext/string.rb
 - lib/mobility/fallthrough_accessors.rb
 - lib/mobility/instance_methods.rb
+- lib/mobility/locale_accessors.rb
 - lib/mobility/orm.rb
 - lib/mobility/rails.rb
 - lib/mobility/sequel.rb