mobilify 1.0.1 → 1.1.1

data/README.md

@@ -1,14 +1,10 @@
 # Mobilify
 [![Gem Version](https://badge.fury.io/rb/mobilify.png)](http://badge.fury.io/rb/mobilify)
 
-We don't like to maintain a lot of test code. Which means, we don't want to rewrite the same tests for the same web application on different platforms. It's easy when those different platforms are browsers, because the site doesn't change much (at all?). 
+Mobilify allows you to create one page object and write one test for your web application, but execute different methods as part of that test given the context. Just change context when initializing your object.
 
-But, it's a challenge to reuse code when the different platforms are desktop and mobile browsers. The elements move, and their identifiers change. We could create separate page objects for desktop and mobile, with a mixin object for the shared stuff. Or we could create one page object with all the elements, and write two different tests. Seems like a waste both ways.
-
-Mobilify allows you to create one page object and write one test. You write tests for the desktop, and it will grab mobile elements when necessary. Just define the context during page initialization.
-
-#### Usage
-To Mobilify your page objects, ```include Mobilify``` in the page class. For each method requiring a mobile replacement, create an element definition with ```mobile_``` prepended to the original's name.
+## Usage
+To Mobilify your page objects, ```include Mobilify``` in the page class. For each method requiring a mobile replacement, create an element (or method) definition with your context prepended to the original's name (like `mobile_`).
 
 ```ruby
 # method
@@ -17,27 +13,23 @@ text_field(:password, :id => "user-pw")
 text_field(:mobile_password, :id => "mobile-pw")
 ```
 
-Mobilify will replace called methods with their ```mobile_``` counterparts if two conditions are met. First, a hash with a key-value pair of ```:agent => :mobile``` is passed to the page object constructor. And second, the page object responds to a ```mobile_``` version of the called method.
+Mobilify will replace called methods with their contextual counterparts if two conditions are met. First, a hash with a key-value pair of `:context => :{your_context}` is passed to the page object constructor. And second, the page object responds to `{your_context}_method`.
 
 ```ruby
 # constructor
-my_page = Page.new(@browser, :agent => :mobile)
+my_page = Page.new(@browser, :context => :mobile)
 ```
 
 To navigate to your page object during initialization, pass the key-value pair ```:visit => true``` to the constructor.
 ```ruby
 # visiting
 my_page = Page.new(@browser, :visit => true)
-my_page = Page.new(@browser, :visit => true, :agent => :mobile)
+my_page = Page.new(@browser, :visit => true, :context => :mobile)
 ```
 
 #### Example
 
-You're testing a responsive page with a link to your registration form. But you can only identify the link with XPath, and the XPath changes between your desktop-sized application and your mobile-sized application. You could: 
-
-* Call two different methods in two different specs, each pointing to its own XPath 
-* Call two different methods in one spec, using logic to determine the call correctly
-* Call the same method in one spec and Mobilify the page object for mobile testing
+You're testing a responsive page with a link to your registration form. But you can only identify the link with XPath, and the XPath changes between your desktop-sized application and your mobile-sized application.
 
 ```ruby
 # spec/page.rb
@@ -64,11 +56,11 @@ RSpec.configure do |config|
     case ENV['BROWSER']
     when 'desktop'
       @browser = Watir::Browser.new :firefox
-      @agent = :desktop
+      @my_context = :desktop
     when 'mobile'
       driver = Webdriver::UserAgent.driver(:browser => :firefox, :agent => :iphone)
       @browser = Watir::Browser.new driver
-      @agent = :mobile
+      @my_context = :mobile
     end
   end
 end
@@ -80,7 +72,7 @@ require 'spec_helper'
 require 'page'
 
 describe Page do
-  let(:page) { Page.new(@browser, :agent => @agent, :visit => true) }
+  let(:page) { Page.new(@browser, :context => @my_context, :visit => true) }
   
   describe "#to_registration" do
     it "takes me to the registration form" do

data/features/step_definitions/link_steps.rb

@@ -15,11 +15,11 @@ Then /^I should receive true$/ do
 end
 
 Then /^I should receive the desktop link element$/ do
-  @element.inspect.should include(':id=>"map-tab-link"')
+  @element.inspect.should include(':xpath=>"//div[@class=\'panel-body\']//a[contains(@href, \'/cmap/\')]"')
 end
 
 Then /^I should receive the mobile link element$/ do
-  @element.inspect.should include(':class=>"pvm prm"')
+  @element.inspect.should include(':xpath=>"//div[@class=\'col-xs-6\']/a[contains(@href, \'/cmap/\')]"')
 end
 
 Then /^I should land on the map page$/ do

data/features/step_definitions/navigation_step.rb

@@ -10,5 +10,5 @@ Given /^I am using a mobile device$/ do
 end
 
 Given /^I navigate to a Manta profile$/ do
-  @page = MantaPage.new(@browser, :agent => @agent, :visit => true)
+  @page = MantaPage.new(@browser, :context => @agent, :visit => true)
 end

data/features/support/manta_page.rb

@@ -5,6 +5,6 @@ class MantaPage
 
   page_url "http://www.manta.com/c/mm2fqg7"
 
-  link(:map, :id => "map-tab-link")
-  link(:mobile_map, :class => "pvm prm")
+  link(:map, :xpath => "//div[@class='panel-body']//a[contains(@href, '/cmap/')]")
+  link(:mobile_map, :xpath => "//div[@class='col-xs-6']/a[contains(@href, '/cmap/')]")
 end

data/lib/mobilify.rb

@@ -5,32 +5,32 @@ module Mobilify
 
   def initialize(browser, opts = {})
     super(browser, opts[:visit] || false)
-    @mobile = opts[:agent] == :mobile
-    mobilify! if mobile?
+    @context = opts[:context]
+    mobilify! if context?
   end
 
   def self.included(klass)
     klass.send :include, PageObject
   end
 
-  def mobile?
-    @mobile
+  def context?
+    @context
   end
 
   private
 
   def mobilify!
+    context = @context.to_s
+
     methods.
-      select { |m| m.to_s.start_with? 'mobile_' }.
-      select { |m| respond_to? m.to_s.gsub('mobile_', '') }.
+      select { |m| m.to_s.start_with? "#{context}_" }.
+      select { |m| respond_to? m.to_s.gsub("#{context}_", '') }.
       map { |m| self.method(m) }.each do |method|
         (class << self; self; end).class_eval do
-          define_method(method.name.to_s.gsub('mobile_', ''), method)
+          define_method(method.name.to_s.gsub("#{context}_", ''), method)
         end
       end
   end
-
 end
 
-
 require 'mobilify/version'

data/lib/mobilify/version.rb

@@ -1,3 +1,3 @@
 module Mobilify
-  VERSION = "1.0.1"
+  VERSION = "1.1.1"
 end

data/mobilify.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Mobilify::VERSION
   spec.authors       = ["Johnson Denen"]
   spec.email         = ["jdenen@manta.com"]
-  spec.description   = %q{switch seamlessly between page-object methods when testing your web app at different sizes}
-  spec.summary       = %q{switch seamlessly between page-object methods when testing your web app at different sizes}
+  spec.description   = %q{switch seamlessly between page-object methods when testing your web app in different contexts}
+  spec.summary       = %q{switch seamlessly between page-object methods when testing your web app in different contexts}
   spec.homepage      = "http://github.com/jdenen/mobilify"
   spec.license       = "MIT"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobilify
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-29 00:00:00.000000000 Z
+date: 2014-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: page-object
@@ -108,7 +108,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: switch seamlessly between page-object methods when testing your web app
-  at different sizes
+  in different contexts
 email:
 - jdenen@manta.com
 executables: []
@@ -154,8 +154,8 @@ rubyforge_project:
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: switch seamlessly between page-object methods when testing your web app at
-  different sizes
+summary: switch seamlessly between page-object methods when testing your web app in
+  different contexts
 test_files:
 - features/desktop_link.feature
 - features/mobile_link.feature