mobile_id 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23c0f87295e5303fe359317d68393e1c9cb50f8ba1d51030edb01f6d9aed12c9
-  data.tar.gz: 02efb290beb29fcc719fe2b9a291fbd5590426f681835949630ae977e2167055
+  metadata.gz: f6586590b52a7e282042dcc43d8de42c821d1d8b1ccfeb243ef4b9f75f2ac0ad
+  data.tar.gz: ae6c05b4242a3beadf025c109f0912b5be3f99da2f8ad78c55ea0a58f5a66b0b
 SHA512:
-  metadata.gz: f4223ca81fabe81ad3bacad29f1a7ea9026f797f619fb2bdd7f1ae4d1c15f931e61cb47e6dc6eb49f18b2b4293760b5fb324cddefb6c35b4b659ca2d05926e6f
-  data.tar.gz: f21c96ae471cfeff68341e19b3a83bed6ae4ba6b62262a8cb174e5f65f59bc4aeff114beb14638fad093a7ef59af0d983a42bdb29ac0bff061dae32fc95d85f2
+  metadata.gz: 67a128c840d171f2fc0199c86fea6d2c8cedca2d2efba844649595a156fc6cd29f9b50a442b8273bd1a719f8f26fbc57e66b5aa66c01e5e1204795b89b5d93ad
+  data.tar.gz: db6c5d6cfd37d16c8fa6c1e826614d0861d5827785183d9e93807ed5ebde7a9f63f1548d9ec1d5d427a0a6210082c53ffdcd85228462e645b0069386e58f7904

data/CHANGELOG.md

@@ -1,6 +1,11 @@
+Release 0.0.14
+* Added LT locale with locale init update (thanks Mijora)
+* Init rubocop (thanks Thales Ribeiro)
+
 Release 0.0.13
-* More test friendly init
-* More precise sert check
+* Gems updated to latest
+* More test friendly init (thanks Juri Linkov)
+* More precise sert check (thanks Andri Möll)
 
 Release 0.0.12
 * Supports session RUNNING state

data/README.md

@@ -114,10 +114,12 @@ After checking out the repo, run `bundle` to install dependencies. For testing c
 * Priit Tark
 * Andri Möll for pointing out user signature issue and cert date check
 * Juri Linkov for pointing out unpack method issue and test friendly init
+* Thales Ribeiro for rubocop initial
+* Mijora for LT locale
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/gitlabeu/mobile_id
+Bug reports and pull requests are welcome on GitHub at https://github.com/domify/mobile_id
 
 ## Roadmap
 
@@ -130,4 +132,4 @@ The gem is available as open source under the terms of the [MIT License](http://
 
 ## Sponsors
 
-Gem development and testing is sponsored by [GiTLAB](https://gitlab.eu).
+Gem development and testing is sponsored by [Domify](https://domify.io).

data/lib/mobile_id/auth.rb

@@ -2,12 +2,13 @@
 
 module MobileId
   class Auth
+
     # API documentation https://github.com/SK-EID/MID
-    LIVE_URL = "https://mid.sk.ee/mid-api"
-    TEST_URL = "https://tsp.demo.sk.ee/mid-api"
+    LIVE_URL = 'https://mid.sk.ee/mid-api'
+    TEST_URL = 'https://tsp.demo.sk.ee/mid-api'
 
-    TEST_UUID  = "00000000-0000-0000-0000-000000000000"
-    TEST_NAME  = "DEMO"
+    TEST_UUID  = '00000000-0000-0000-0000-000000000000'
+    TEST_NAME  = 'DEMO'
 
     attr_accessor :url, :uuid, :name, :doc, :hash, :user_cert, :live
 
@@ -24,25 +25,25 @@ module MobileId
       self.hash = Digest::SHA256.digest(doc)
     end
 
-    def authenticate!(phone_calling_code: nil, phone:, personal_code:, language: nil, display_text: nil)
+    def authenticate!(phone:, personal_code:, phone_calling_code: nil, language: nil, display_text: nil)
       phone_calling_code ||= '+372'
       full_phone = "#{phone_calling_code}#{phone}"
-      language ||= 
+      language ||=
         case I18n.locale
         when :et
-          display_text ||= 'Autentimine' 
+          display_text ||= 'Autentimine'
           'EST'
         when :ru
-          display_text ||= 'Аутентификация' 
+          display_text ||= 'Аутентификация'
           'RUS'
         else
-          display_text ||= 'Authentication' 
+          display_text ||= 'Authentication'
           'ENG'
         end
-      
+
       options = {
         headers: {
-          "Content-Type": "application/json"
+          'Content-Type': 'application/json'
         },
         query: {},
         body: {
@@ -52,20 +53,20 @@ module MobileId
           nationalIdentityNumber: personal_code.to_s.strip,
           hash: Base64.strict_encode64(hash),
           hashType: 'SHA256',
-          language: language,
+          language:,
           displayText: display_text,
           displayTextFormat: 'GSM-7' # or "UCS-2”
         }.to_json
       }
 
-      response = HTTParty.post(url + '/authentication', options)
+      response = HTTParty.post("#{url}/authentication", options)
       raise Error, "#{I18n.t('mobile_id.some_error')} #{response}" unless response.code == 200
 
       ActiveSupport::HashWithIndifferentAccess.new(
         session_id: response['sessionID'],
-        phone: phone,
-        phone_calling_code: phone_calling_code,
-        doc: doc
+        phone:,
+        phone_calling_code:,
+        doc:
       )
     end
 
@@ -73,9 +74,9 @@ module MobileId
       long_poll!(session_id: auth['session_id'], doc: auth['doc'])
 
       ActiveSupport::HashWithIndifferentAccess.new(
-        personal_code: personal_code,
-        first_name: first_name,
-        last_name: last_name,
+        personal_code:,
+        first_name:,
+        last_name:,
         phone: auth['phone'],
         phone_calling_code: auth['phone_calling_code'],
         auth_provider: 'mobileid' # User::MOBILEID
@@ -85,49 +86,51 @@ module MobileId
     def session_request(session_id)
       response = HTTParty.get(url + "/authentication/session/#{session_id}")
       raise Error, "#{I18n.t('mobile_id.some_error')} #{response.code} #{response}" if response.code != 200
+
       response
     end
 
     def long_poll!(session_id:, doc:)
       response = nil
 
-      # Retries until RUNNING state turns to COMPLETE 
-      30.times do |i|
+      # Retries until RUNNING state turns to COMPLETE
+      30.times do |_i|
         response = session_request(session_id)
         break if response['state'] == 'COMPLETE'
+
         sleep 1
       end
       raise Error, "#{I18n.t('mobile_id.some_error')} #{response.code} #{response}" if response['state'] != 'COMPLETE'
 
       if response['result'] != 'OK'
-        message = 
+        message =
           case response['result']
-          when "TIMEOUT"
+          when 'TIMEOUT'
             I18n.t('mobile_id.timeout')
-          when "NOT_MID_CLIENT"
+          when 'NOT_MID_CLIENT'
             I18n.t('mobile_id.user_is_not_mobile_id_client')
-          when "USER_CANCELLED"
+          when 'USER_CANCELLED'
             I18n.t('mobile_id.user_cancelled')
-          when "SIGNATURE_HASH_MISMATCH"
+          when 'SIGNATURE_HASH_MISMATCH'
             I18n.t('mobile_id.signature_hash_mismatch')
-          when "PHONE_ABSENT"
+          when 'PHONE_ABSENT'
             I18n.t('mobile_id.phone_absent')
-          when "DELIVERY_ERROR"
+          when 'DELIVERY_ERROR'
             I18n.t('mobile_id.delivery_error')
-          when "SIM_ERROR"
+          when 'SIM_ERROR'
             I18n.t('mobile_id.sim_error')
           end
-          raise Error, message
+        raise Error, message
       end
 
-      @user_cert = MobileId::Cert.new(response['cert'], live: live)
+      @user_cert = MobileId::Cert.new(response['cert'], live:)
       @user_cert.verify_signature!(response['signature']['value'], doc)
       self.user_cert = @user_cert
     end
 
     def verification_code
-      binary = hash.to_s.unpack('B*').first
-      "%04d" % (binary[0...6] + binary[-7..-1]).to_i(2)
+      binary = hash.to_s.unpack1('B*')
+      '%04d' % (binary[0...6] + binary[-7..]).to_i(2)
     end
 
     def given_name
@@ -139,7 +142,7 @@ module MobileId
       user_cert.surname
     end
     alias last_name surname
-    
+
     def country
       user_cert.country
     end
@@ -156,5 +159,6 @@ module MobileId
       user_cert.serial_number
     end
     alias personal_code serial_number
+
   end
 end

data/lib/mobile_id/cert.rb

@@ -2,49 +2,55 @@
 
 module MobileId
   class Cert
+
     class << self
+
       def root_path
         @root_path ||= File.expand_path('certs', __dir__)
       end
 
       def live_store
-        @live_store ||= 
+        @live_store ||=
           build_store([
-            File.join(root_path, 'EE_Certification_Centre_Root_CA.pem.crt'),
-            File.join(root_path, 'EE-GovCA2018.pem.crt'),
-            File.join(root_path, 'EID-SK_2011.pem.crt'),
-            File.join(root_path, 'EID-SK_2016.pem.crt'),
-            File.join(root_path, 'esteid2018.pem.crt'),
-            File.join(root_path, 'ESTEID-SK_2011.pem.crt'),
-            File.join(root_path, 'ESTEID-SK_2015.pem.crt'),
-            File.join(root_path, 'KLASS3-SK_2010_EECCRCA.pem.crt'),
-            File.join(root_path, 'KLASS3-SK_2010_EECCRCA_SHA384.pem.crt'),
-            File.join(root_path, 'KLASS3-SK_2016_EECCRCA_SHA384.pem.crt'),
-            File.join(root_path, 'KLASS3-SK.pem.crt'),
-            File.join(root_path, 'NQ-SK_2016.pem.crt')
-          ])
+                        File.join(root_path, 'EE_Certification_Centre_Root_CA.pem.crt'),
+                        File.join(root_path, 'EE-GovCA2018.pem.crt'),
+                        File.join(root_path, 'EID-SK_2011.pem.crt'),
+                        File.join(root_path, 'EID-SK_2016.pem.crt'),
+                        File.join(root_path, 'esteid2018.pem.crt'),
+                        File.join(root_path, 'ESTEID-SK_2011.pem.crt'),
+                        File.join(root_path, 'ESTEID-SK_2015.pem.crt'),
+                        File.join(root_path, 'KLASS3-SK_2010_EECCRCA.pem.crt'),
+                        File.join(root_path, 'KLASS3-SK_2010_EECCRCA_SHA384.pem.crt'),
+                        File.join(root_path, 'KLASS3-SK_2016_EECCRCA_SHA384.pem.crt'),
+                        File.join(root_path, 'KLASS3-SK.pem.crt'),
+                        File.join(root_path, 'NQ-SK_2016.pem.crt')
+                      ])
       end
 
       def test_store
-        @test_store ||= 
+        @test_store ||=
           build_store([
-            File.join(root_path, 'TEST_of_EE_Certification_Centre_Root_CA.pem.crt'),
-            File.join(root_path, 'TEST_of_ESTEID-SK_2015.pem.crt')
-          ])
+                        File.join(root_path, 'TEST_of_EE_Certification_Centre_Root_CA.pem.crt'),
+                        File.join(root_path, 'TEST_of_ESTEID-SK_2015.pem.crt')
+                      ])
       end
 
       def build_store(paths)
         store = OpenSSL::X509::Store.new
-        paths.each { |path| cert = OpenSSL::X509::Certificate.new(File.read(path)); store.add_cert(cert) }
+        paths.each do |path|
+          cert = OpenSSL::X509::Certificate.new(File.read(path))
+          store.add_cert(cert)
+        end
         store
       end
+
     end
 
     attr_accessor :cert, :subject
 
     def initialize(base64_cert, live:)
       self.cert = OpenSSL::X509::Certificate.new(Base64.decode64(base64_cert))
-      verify!(self.cert, live: live)
+      verify!(cert, live:)
       build_cert_subject
     end
 
@@ -52,11 +58,14 @@ module MobileId
       if live == true
         raise Error, 'User certificate is not valid' unless self.class.live_store.verify(cert)
       else
-        raise Error, 'User certificate is not valid' unless self.class.test_store.verify(cert) || self.class.live_store.verify(cert)
+        unless self.class.test_store.verify(cert) || self.class.live_store.verify(cert)
+          raise Error,
+                'User certificate is not valid'
+        end
       end
 
       raise Error, 'User certificate is not valid [check_key]' unless cert.public_key.check_key
-      raise Error, 'User certificate is expired' unless (cert.not_before...cert.not_after) === Time.now
+      raise Error, 'User certificate is expired' unless (cert.not_before...cert.not_after).include?(Time.now)
 
       true
     end
@@ -77,49 +86,51 @@ module MobileId
     end
 
     def cvc_to_der(cvc)
-      sign_hex = cvc.unpack('H*').first
+      sign_hex = cvc.unpack1('H*')
       half = sign_hex.size / 2
-      i = [OpenSSL::ASN1::Integer.new(sign_hex[0...half].to_i(16)), OpenSSL::ASN1::Integer.new(sign_hex[half..sign_hex.size].to_i(16))]
+      i = [OpenSSL::ASN1::Integer.new(sign_hex[0...half].to_i(16)),
+           OpenSSL::ASN1::Integer.new(sign_hex[half..sign_hex.size].to_i(16))]
       seq = OpenSSL::ASN1::Sequence.new(i)
       seq.to_der
     end
 
     def given_name
-      subject["GN"].tr(",", " ")
+      subject['GN'].tr(',', ' ')
     end
     alias first_name given_name
 
     def surname
-      subject["SN"].tr(",", " ")
+      subject['SN'].tr(',', ' ')
     end
     alias last_name surname
-    
+
     def country
-      subject["C"].tr(",", " ")
+      subject['C'].tr(',', ' ')
     end
 
     def common_name
-      subject["CN"]
+      subject['CN']
     end
 
     def organizational_unit
-      subject["OU"]
+      subject['OU']
     end
 
     def serial_number
-      subject["serialNumber"]
+      subject['serialNumber']
     end
     alias personal_code serial_number
 
     private
 
     def build_cert_subject
-      self.subject = cert.subject.to_utf8.split(/(?<!\\)\,+/).each_with_object({}) do |c, result|
-        next unless c.include?("=")
+      self.subject = cert.subject.to_utf8.split(/(?<!\\),+/).each_with_object({}) do |c, result|
+        next unless c.include?('=')
 
-        key, val = c.split("=")
+        key, val = c.split('=')
         result[key] = val
       end
     end
+
   end
 end

data/lib/mobile_id/locales/lt.yml

@@ -0,0 +1,10 @@
+lt:
+  mobile_id:
+    some_error: Įvyko klaida
+    timeout: "M-parašo sesija pasibaigė"
+    user_is_not_mobile_id_client: Vartotojas nėra m-parašo klientas.
+    user_cancelled: Vartotojas nutraukė m-parašo operaciją.
+    signature_hash_mismatch: "M-parašo turi problemą. Vartotojas turėtų kreiptis į savo operatorių."
+    phone_absent: m-parašo SIM nepasiekiama.
+    delivery_error: m-parašo SMS siuntimo klaida.
+    sim_error: Neteisingas atsakymas iš m-parašo SIM kortelės

data/lib/mobile_id/railtie.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'rails'
 
 module MobileId
-  class Railtie < ::Rails::Railtie #:nodoc:
-    initializer 'mobile_id' do |app|
-      DeviseI18n::Railtie.instance_eval do
-        (app.config.i18n.available_locales & MobileId::LOCALES).each do |loc|
-          I18n.load_path << File.expand_path("locales/#{loc}.yml", __dir__)
-        end
+  class Railtie < ::Rails::Railtie # :nodoc:
+
+    initializer 'mobile_id' do |_app|
+      MobileId::LOCALES.each do |loc|
+        I18n.load_path << File.expand_path("locales/#{loc}.yml", __dir__)
       end
     end
+
   end
 end

data/lib/mobile_id.rb

@@ -5,16 +5,17 @@ require 'digest'
 require 'httparty'
 require 'active_support/core_ext/hash/indifferent_access'
 require 'i18n'
+
 if defined?(Rails)
-  require 'mobile_id/railtie' 
+  require 'mobile_id/railtie'
 else
-  I18n.load_path << Dir[File.expand_path("lib/mobile_id/locales") + "/*.yml"]
+  I18n.load_path << Dir["#{File.expand_path('lib/mobile_id/locales')}/*.yml"]
 end
 
 module MobileId
   class Error < StandardError; end
 
-  LOCALES = [:en, :et, :ru]
+  LOCALES = %i[en et lt ru].freeze
 end
 
 require 'mobile_id/cert'

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: mobile_id
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Priit Tark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-15 00:00:00.000000000 Z
+date: 2023-05-16 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: openssl
   requirement: !ruby/object:Gem::Requirement
@@ -39,13 +67,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.2.0
 - !ruby/object:Gem::Dependency
-  name: i18n
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -53,13 +81,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -67,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -94,8 +122,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Estonia Mobile ID authentication
-email: priit@gitlab.eu
+description: Ruby client for Estonia and Lithuania Mobile ID authentication
+email: priit@domify.io
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -122,12 +150,15 @@ files:
 - lib/mobile_id/certs/esteid2018.pem.crt
 - lib/mobile_id/locales/en.yml
 - lib/mobile_id/locales/et.yml
+- lib/mobile_id/locales/lt.yml
 - lib/mobile_id/locales/ru.yml
 - lib/mobile_id/railtie.rb
-homepage: https://github.com/gitlabeu/mobile_id
+homepage: https://github.com/domify/mobile_id
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/domify/mobile_id/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -146,5 +177,5 @@ requirements: []
 rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
-summary: Estonia Mobile ID authentication
+summary: Estonia and Lithuania Mobile ID authentication
 test_files: []