moat 0.3 → 0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e7f85e51dd0ffe82fe3b6437e93e4ada13459be
-  data.tar.gz: dccbce2a4b6ceece7d32391d7e4fd6c4b8440ec3
+  metadata.gz: 8650ce60afaf8d84d2f26e215e9d9a7ff5bc393a
+  data.tar.gz: 14c91842fc823ce114c0eb19daac0070e5dae1b8
 SHA512:
-  metadata.gz: b48428d4a14e1917564a1e89ed089376a7b2cdfcaaa8167f498372f824078a58c286c08e5d396e4a48c9e38fa575a3c0dd7e3f11098de541446cc3244736f43e
-  data.tar.gz: 4951f823e10c5d9d9986d6c863296c6502a7fb1cc4cdd9d19287d4354e681da5ef30de49c495e5d23aec28c86d7124e26de0ce8042f04689ffd8857810f63ffa
+  metadata.gz: b31364a24bc83743555b7fb89f69591cf88ea2c544dad9e01a7e8e0cb02424b47a231da46dc2ba246fad0df987464f7cf472ced12fad0a6242ba3f1bd5098bdf
+  data.tar.gz: 5ce3ba9dfb382042104995713ecc6a528aaf1282189ff35931d0de9d4700bb23fca1b7d03b4c407f5bf27c0e0999666316a94091d7a0f2cdf4121248b0b957dc

data/.gitignore

@@ -0,0 +1,14 @@
+/.bundle/
+/.yardoc
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+/vendor/
+
+# rspec failure tracking
+.rspec_status
+

data/README.md

@@ -174,11 +174,15 @@ end
 - `policy_filter(scope, action = action_name, user: moat_user, policy: <optional>)`
   - Called from controller actions or `before_action`s
   - Returns a `scope` with limitations according to `policy`
-  - Automagically looks up policy if not given
+  - Automagically tries to determine `policy` and `action` if not given
 - `authorize(resource, action = action_name, user: moat_user, policy: <optional>)`
-  - Called from controller actions or `before_action`s
-  - Raises `Moat::NotAuthorizedError` if `user` is not permitted to take `action` according to `policy`
-  - Automagically looks up policy if not given
+  - Called in controller methods
+  - Raises `Moat::NotAuthorizedError` if `user` is not permitted to take `action` on the resource according to `policy`
+  - Automagically tries to determine `policy` and `action` if not given
+- `authorized?(resource, action = action_name, user: moat_user, policy: <optional>)`
+  - Called in controller methods
+  - Returns `true` if `user` is permitted to take `action` on the resource according to `policy`, otherwise it returns `false`
+  - Automagically tries to determine `policy` and `action` if not given
 - `moat_user`
   - Returns `current_user` unless overridden
 - `verify_policy_applied`
@@ -188,8 +192,8 @@ end
 - `skip_verify_policy_applied`
   - Called from controller actions
   - Prevents `verify_policy_applied` from raising
-  - This removes an important fail-safe.
-  - Never use this without making it super clear to future developers why it is safe to call this method.
+  - This removes an important fail-safe
+  - Never use this without making it super clear to future developers why it is safe to call this method
 
 ## Conventions
 - A Moat `policy` is a PORO that is initialized with a user and a scope

data/lib/moat.rb

@@ -39,8 +39,12 @@ module Moat
     apply_policy(scope, action, user: user, policy: policy::Filter)
   end
 
+  def authorized?(resource, action = "#{action_name}?", user: moat_user, policy: find_policy(resource))
+    !!apply_policy(resource, action, user: user, policy: policy::Authorization)
+  end
+
   def authorize(resource, action = "#{action_name}?", user: moat_user, policy: find_policy(resource))
-    if apply_policy(resource, action, user: user, policy: policy::Authorization)
+    if authorized?(resource, action, user: user, policy: policy)
       resource
     else
       fail NotAuthorizedError, action: action, resource: resource, policy: policy, user: user

data/lib/moat/version.rb

@@ -1,3 +1,3 @@
 module Moat
-  VERSION = "0.3".freeze
+  VERSION = "0.4".freeze
 end

data/spec/moat_spec.rb

@@ -135,6 +135,45 @@ describe Moat do
     end
   end
 
+  describe "#authorized?" do
+    it "fails if resource is nil" do
+      expect { moat_consumer.authorized?(nil) }.
+        to raise_error(Moat::PolicyNotFoundError)
+    end
+
+    it "fails if a corresponding policy can't be found" do
+      expect { moat_consumer.authorized?(Hash) }.
+        to raise_error(Moat::PolicyNotFoundError, "Hash")
+      expect { moat_consumer.authorized?({}) }.
+        to raise_error(Moat::PolicyNotFoundError, "Hash")
+    end
+
+    it "fails if a corresponding action can't be found" do
+      expect { moat_consumer.authorized?([1, 2, 3], :invalid_action?, policy: IntegerPolicy) }.
+        to raise_error(Moat::ActionNotFoundError, "IntegerPolicy::Authorization#invalid_action?")
+    end
+
+    it "returns false when the value of calling the policy method is falsey" do
+      expect(moat_consumer.authorized?(3)). to be false
+    end
+
+    it "returns true when the value of calling the policy method is truthy" do
+      expect(moat_consumer.authorized?(4)).to be true
+    end
+
+    it "uses specified action" do
+      expect(moat_consumer.authorized?(3, :show?)).to be true
+    end
+
+    it "uses specified policy" do
+      expect(moat_consumer.authorized?(3, policy: OtherIntegerPolicy)).to be true
+    end
+
+    it "uses specified user" do
+      expect(moat_consumer.authorized?(3, user: "specified user")).to be true
+    end
+  end
+
   describe "#authorize" do
     it "fails if resource is nil" do
       expect { moat_consumer.authorize(nil) }.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moat
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: '0.4'
 platform: ruby
 authors:
 - Poll Everywhere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-02 00:00:00.000000000 Z
+date: 2018-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -47,10 +47,10 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
+- ".gitignore"
 - ".rubocop.yml"
 - CONTRIBUTING.md
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile

data/Gemfile.lock

@@ -1,50 +0,0 @@
-PATH
-  remote: .
-  specs:
-    moat (0.3)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (2.4.0)
-    diff-lcs (1.3)
-    jaro_winkler (1.5.1)
-    parallel (1.12.1)
-    parser (2.5.1.0)
-      ast (~> 2.4.0)
-    powerpack (0.1.2)
-    rainbow (3.0.0)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.57.2)
-      jaro_winkler (~> 1.5.1)
-      parallel (~> 1.10)
-      parser (>= 2.5)
-      powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 4.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
-    unicode-display_width (1.4.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  moat!
-  rspec (~> 3.5)
-  rubocop (~> 0.57.2)
-
-BUNDLED WITH
-   1.16.1