mmangino-facebooker 1.0.22 → 1.0.23

data/Rakefile

@@ -9,20 +9,19 @@ rescue LoadError
   $stderr.puts "Install the multi_rails gem to run tests against multiple versions of Rails"
 end
 
- $: << File.dirname(__FILE__) + '/lib'
+$: << File.dirname(__FILE__) + '/lib'
 require './lib/facebooker.rb'
 
-Hoe.new('facebooker', Facebooker::VERSION::STRING) do |p|
+HOE = Hoe.new('facebooker', Facebooker::VERSION::STRING) do |p|
   p.rubyforge_name = 'facebooker'
   p.author = ['Chad Fowler', 'Patrick Ewing', 'Mike Mangino', 'Shane Vitarana', 'Corey Innis']
   p.email = 'mmangino@elevatedrails.com'
-  p.summary = 'Pure, idiomatic Ruby wrapper for the Facebook REST API.'
-  p.description = p.paragraphs_of('README.rdoc', 2..5).join("\n\n")
-  p.url = p.paragraphs_of('README.rdoc', 0).first.split(/\n/)[1..-1]
-  p.changes = p.paragraphs_of('History.rdoc', 0..1).join("\n\n")
+  p.readme_file   = 'README.rdoc'
+  p.history_file  = 'CHANGELOG.rdoc'
   p.remote_rdoc_dir = '' # Release to root
   p.test_globs = 'test/**/*_test.rb'
   p.extra_deps << ['json', '>= 1.0.0'] 
+  p.extra_rdoc_files  = FileList['*.rdoc']
 end
 
 require 'rcov/rcovtask'
@@ -42,16 +41,20 @@ namespace :test do
   end
 end
 
-gem_spec_file = 'facebooker.gemspec'
-
-gem_spec = eval(File.read(gem_spec_file)) rescue nil
-
-desc "Generate the gemspec file."
-task :gemspec do
-  require 'erb'
+namespace :gem do
+  task :spec do
+    File.open("#{HOE.name}.gemspec", 'w') do |f|
+      f.write(HOE.spec.to_ruby)
+    end
+  end
 
-  File.open(gem_spec_file, 'w') do |f|
-    f.write ERB.new(File.read("#{gem_spec_file}.erb")).result(binding)
+  namespace :spec do
+    task :dev do
+      File.open("#{HOE.name}.gemspec", 'w') do |f|
+        HOE.spec.version = "#{HOE.version}.#{Time.now.strftime("%Y%m%d%H%M%S")}"
+        f.write(HOE.spec.to_ruby)
+      end
+    end
   end
 end
 

data/lib/facebooker/service.rb

@@ -2,7 +2,6 @@ begin
   require 'curb'
   Facebooker.use_curl = true
 rescue LoadError
-  $stderr.puts "Curb not found. Using Net::HTTP."
   require 'net/http'
 end
 require 'facebooker/parser'
@@ -92,4 +91,4 @@ module Facebooker
       parray
     end
   end
-end
+end

data/lib/facebooker/version.rb

@@ -2,7 +2,7 @@ module Facebooker #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 1
     MINOR = 0
-    TINY  = 22
+    TINY  = 23
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/test/rack/facebook_test.rb

@@ -0,0 +1,62 @@
+require File.dirname(__FILE__) + '/../test_helper.rb'
+require 'rack/facebook'
+require 'rack/lint'
+require 'rack/mock'
+require 'ruby-debug'
+
+class Rack::FacebookTest < Test::Unit::TestCase
+  
+  def setup
+    @secret_key = 'secret'
+    @app = lambda do |env|
+      @env = env
+      Rack::Response.new().to_a
+    end
+    @facebook = Rack::Facebook.new(@app, @secret_key)
+  end
+  
+  def params(p)
+    p.map{|*args| args.join('=') }.join('&')
+  end
+  
+  def app
+    Rack::MockRequest.new(Rack::Lint.new(@facebook))
+  end
+  
+  def test_without_fb_params
+    response = app.post("/")
+    assert_equal 200, response.status
+  end
+  
+  def test_converts_request_method
+    response = app.post("/",
+      :input => params(:fb_sig_request_method => 'GET', :fb_sig => '4d2a700e90b0bcbe54b9e627d2cc1417'))
+    assert_equal 200, response.status
+    assert_equal 'GET', @env['REQUEST_METHOD']
+  end
+  
+  def test_only_sets_request_method_if_provided
+    response = app.post("/", :input => params(:fb_sig_user => '1', :fb_sig => '313dd5caed3d0902d83225ff3ae9a950'))
+    assert_equal 200, response.status
+    assert_equal 'POST', @env['REQUEST_METHOD']
+  end
+
+  def test_renders_400_with_invalid_signature
+    response = app.post("/",
+      :input => params(:fb_sig => 'wrong', :fb_sig_user => 1))
+    assert_equal 400, response.status
+  end
+  
+  def test_skips_with_false_condition
+    @facebook = Rack::Facebook.new(@app, @secret_key) { false }
+    response = app.post("/", :input => params(:fb_sig_user => 'ignored'))
+    assert_equal 200, response.status
+  end
+  
+  def test_verifies_with_true_condition
+    @facebook = Rack::Facebook.new(@app, @secret_key) { true }
+    response = app.post("/", :input => params(:fb_sig_user => 'ignored'))
+    assert_equal 400, response.status
+  end
+
+end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: mmangino-facebooker
 version: !ruby/object:Gem::Version 
-  version: 1.0.22
+  version: 1.0.23
 platform: ruby
 authors: 
 - Chad Fowler
 - Patrick Ewing
 - Mike Mangino
 - Shane Vitarana
+- Corey Innis
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -15,6 +16,16 @@ cert_chain: []
 date: 2009-03-30 00:00:00 -07:00
 default_executable: 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: json
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.0.0
+    version: 
 - !ruby/object:Gem::Dependency 
   name: hoe
   type: :development
@@ -23,26 +34,22 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.5.0
+        version: 1.11.0
     version: 
-description: "== DESCRIPTION:  Facebooker is a Ruby wrapper over the Facebook[http://facebook.com] {REST API}[http://developer.facebook.com].  Its goals are:  * Idiomatic Ruby * No dependencies outside of the Ruby standard library * Concrete classes and methods modeling the Facebook data, so it's easy for a Rubyist to understand what's available * Well tested  == FEATURES/PROBLEMS:"
+description: "Facebooker is a Ruby wrapper over the Facebook[http://facebook.com] {REST API}[http://wiki.developers.facebook.com/index.php/API].  Its goals are:  * Idiomatic Ruby * No dependencies outside of the Ruby standard library (This is true with Rails 2.1. Previous Rails versions require the JSON gem) * Concrete classes and methods modeling the Facebook data, so it's easy for a Rubyist to understand what's available * Well tested"
 email: mmangino@elevatedrails.com
 executables: []
 
 extensions: []
 
 extra_rdoc_files: 
-- History.rdoc
-- Manifest.txt
+- CHANGELOG.rdoc
+- COPYING.rdoc
 - README.rdoc
 - TODO.rdoc
-- test/fixtures/multipart_post_body_with_only_parameters.txt
-- test/fixtures/multipart_post_body_with_single_file.txt
-- test/fixtures/multipart_post_body_with_single_file_that_has_nil_key.txt
 files: 
-- CHANGELOG.rdoc
 - COPYING.rdoc
-- History.rdoc
+- CHANGELOG.rdoc
 - README.rdoc
 - Rakefile
 - TODO.rdoc
@@ -165,9 +172,9 @@ files:
 - test/rails_test_helper.rb
 - test/test_helper.rb
 - test/facebooker/mobile_test.rb
-- Manifest.txt
+- test/rack/facebook_test.rb
 has_rdoc: true
-homepage: 
+homepage: http://facebooker.rubyforge.org
 post_install_message: 
 rdoc_options: 
 - --main
@@ -192,6 +199,21 @@ rubyforge_project: facebooker
 rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
-summary: Pure, idiomatic Ruby wrapper for the Facebook REST API.
+summary: Facebooker is a Ruby wrapper over the Facebook[http://facebook.com] {REST API}[http://wiki.developers.facebook.com/index.php/API]
 test_files: 
-- test/test_helper.rb
+- test/facebooker_test.rb
+- test/facebooker/adapters_test.rb
+- test/facebooker/admin_test.rb
+- test/facebooker/batch_request_test.rb
+- test/facebooker/data_test.rb
+- test/facebooker/logging_test.rb
+- test/facebooker/mobile_test.rb
+- test/facebooker/model_test.rb
+- test/facebooker/rails_integration_test.rb
+- test/facebooker/server_cache_test.rb
+- test/facebooker/session_test.rb
+- test/facebooker/models/event_test.rb
+- test/facebooker/models/user_test.rb
+- test/facebooker/rails/publisher_test.rb
+- test/net/http_multipart_post_test.rb
+- test/rack/facebook_test.rb

data/Manifest.txt

@@ -1,124 +0,0 @@
-COPYING.rdoc
-History.rdoc
-README.rdoc
-Rakefile
-TODO.rdoc
-generators/publisher/publisher_generator.rb
-generators/facebook/facebook_generator.rb
-generators/facebook/templates/config/facebooker.yml
-generators/facebook/templates/public/javascripts/facebooker.js
-generators/facebook_controller/USAGE
-generators/facebook_controller/facebook_controller_generator.rb
-generators/facebook_controller/templates/controller.rb
-generators/facebook_controller/templates/functional_test.rb
-generators/facebook_controller/templates/helper.rb
-generators/facebook_controller/templates/view.fbml.erb
-generators/facebook_controller/templates/view.html.erb
-generators/facebook_publisher/facebook_publisher_generator.rb
-generators/facebook_publisher/templates/create_facebook_templates.rb
-generators/facebook_publisher/templates/publisher.rb
-generators/facebook_scaffold/USAGE
-generators/facebook_scaffold/facebook_scaffold_generator.rb
-generators/facebook_scaffold/templates/controller.rb
-generators/facebook_scaffold/templates/facebook_style.css
-generators/facebook_scaffold/templates/functional_test.rb
-generators/facebook_scaffold/templates/helper.rb
-generators/facebook_scaffold/templates/layout.fbml.erb
-generators/facebook_scaffold/templates/layout.html.erb
-generators/facebook_scaffold/templates/style.css
-generators/facebook_scaffold/templates/view_edit.fbml.erb
-generators/facebook_scaffold/templates/view_edit.html.erb
-generators/facebook_scaffold/templates/view_index.fbml.erb
-generators/facebook_scaffold/templates/view_index.html.erb
-generators/facebook_scaffold/templates/view_new.fbml.erb
-generators/facebook_scaffold/templates/view_new.html.erb
-generators/facebook_scaffold/templates/view_show.fbml.erb
-generators/facebook_scaffold/templates/view_show.html.erb
-generators/xd_receiver/xd_receiver_generator.rb
-generators/xd_receiver/templates/xd_receiver.html
-init.rb
-install.rb
-lib/facebooker/adapters/adapter_base.rb
-lib/facebooker/adapters/bebo_adapter.rb
-lib/facebooker/adapters/facebook_adapter.rb
-lib/facebooker/admin.rb
-lib/facebooker/batch_request.rb
-lib/facebooker/data.rb
-lib/facebooker/feed.rb
-lib/facebooker/logging.rb
-lib/facebooker/mobile.rb
-lib/facebooker/mock/service.rb
-lib/facebooker/mock/session.rb
-lib/facebooker/model.rb
-lib/facebooker/models/affiliation.rb
-lib/facebooker/models/album.rb
-lib/facebooker/models/applicationproperties.rb
-lib/facebooker/models/applicationrestrictions.rb
-lib/facebooker/models/cookie.rb
-lib/facebooker/models/education_info.rb
-lib/facebooker/models/event.rb
-lib/facebooker/models/friend_list.rb
-lib/facebooker/models/group.rb
-lib/facebooker/models/info_item.rb
-lib/facebooker/models/info_section.rb
-lib/facebooker/models/location.rb
-lib/facebooker/models/notifications.rb
-lib/facebooker/models/page.rb
-lib/facebooker/models/photo.rb
-lib/facebooker/models/tag.rb
-lib/facebooker/models/user.rb
-lib/facebooker/models/video.rb
-lib/facebooker/models/work_info.rb
-lib/facebooker/parser.rb
-lib/facebooker/rails/controller.rb
-lib/facebooker/rails/cucumber/world.rb
-lib/facebooker/rails/cucumber.rb
-lib/facebooker/rails/extensions/action_controller.rb
-lib/facebooker/rails/extensions/rack_setup.rb
-lib/facebooker/rails/extensions/routing.rb
-lib/facebooker/rails/facebook_form_builder.rb
-lib/facebooker/rails/facebook_pretty_errors.rb
-lib/facebooker/rails/facebook_request_fix.rb
-lib/facebooker/rails/facebook_session_handling.rb
-lib/facebooker/rails/facebook_url_helper.rb
-lib/facebooker/rails/facebook_url_rewriting.rb
-lib/facebooker/rails/helpers/fb_connect.rb
-lib/facebooker/rails/helpers.rb
-lib/facebooker/rails/integration_session.rb
-lib/facebooker/rails/profile_publisher_extensions.rb
-lib/facebooker/rails/publisher.rb
-lib/facebooker/rails/routing.rb
-lib/facebooker/rails/test_helpers.rb
-lib/facebooker/rails/utilities.rb
-lib/facebooker/server_cache.rb
-lib/facebooker/service.rb
-lib/facebooker/session.rb
-lib/facebooker/version.rb
-lib/facebooker.rb
-lib/net/http_multipart_post.rb
-lib/rack/facebook.rb
-lib/tasks/facebooker.rake
-lib/tasks/tunnel.rake
-rails/init.rb
-setup.rb
-templates/layout.erb
-test/facebooker/adapters_test.rb
-test/facebooker/admin_test.rb
-test/facebooker/batch_request_test.rb
-test/facebooker/data_test.rb
-test/facebooker/logging_test.rb
-test/facebooker/model_test.rb
-test/facebooker/models/event_test.rb
-test/facebooker/models/user_test.rb
-test/facebooker/rails/publisher_test.rb
-test/facebooker/rails_integration_test.rb
-test/facebooker/server_cache_test.rb
-test/facebooker/session_test.rb
-test/facebooker_test.rb
-test/fixtures/multipart_post_body_with_only_parameters.txt
-test/fixtures/multipart_post_body_with_single_file.txt
-test/fixtures/multipart_post_body_with_single_file_that_has_nil_key.txt
-test/net/http_multipart_post_test.rb
-test/rails_test_helper.rb
-test/test_helper.rb
-test/facebooker/mobile_test.rb