mlist 0.1.20 → 0.1.21

data/Gemfile

@@ -1,5 +1,6 @@
-source :gemcutter
+source 'http://rubygems.org'
 
+gem 'bundler', '>= 1.0.1'
 gem 'activerecord', '= 2.3.4'
 gem 'activesupport', '= 2.3.4'
 gem 'uuid', '>= 2.0.1'
@@ -8,10 +9,10 @@ gem 'tmail', '= 1.2.1'
 
 group :development do
   gem 'jeweler'
-  gem 'dataset'
+  gem 'dataset', '= 1.3.2'
   gem 'rake'
-  gem "sqlite3-ruby"
-  gem "rspec", :require => "spec"
-  gem "rr", "0.10.0"
-  gem "ruby-debug"
+  gem 'sqlite3-ruby'
+  gem 'rspec', '= 1.3.1'
+  gem 'rr', '0.10.0'
+  gem 'ruby-debug'
 end

data/Gemfile.lock

@@ -0,0 +1,48 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    activerecord (2.3.4)
+      activesupport (= 2.3.4)
+    activesupport (2.3.4)
+    columnize (0.3.2)
+    dataset (1.3.2)
+      activerecord (>= 2.3.0)
+      activesupport (>= 2.3.0)
+    git (1.2.5)
+    hpricot (0.8.3)
+    jeweler (1.5.1)
+      bundler (~> 1.0.0)
+      git (>= 1.2.5)
+      rake
+    linecache (0.43)
+    macaddr (1.0.0)
+    rake (0.8.7)
+    rr (0.10.0)
+    rspec (1.3.1)
+    ruby-debug (0.10.4)
+      columnize (>= 0.1)
+      ruby-debug-base (~> 0.10.4.0)
+    ruby-debug-base (0.10.4)
+      linecache (>= 0.3)
+    sqlite3-ruby (1.3.2)
+    tmail (1.2.1)
+    uuid (2.3.1)
+      macaddr (~> 1.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (= 2.3.4)
+  activesupport (= 2.3.4)
+  bundler (>= 1.0.1)
+  dataset (= 1.3.2)
+  hpricot (>= 0.8.2)
+  jeweler
+  rake
+  rr (= 0.10.0)
+  rspec (= 1.3.1)
+  ruby-debug
+  sqlite3-ruby
+  tmail (= 1.2.1)
+  uuid (>= 2.0.1)

data/Rakefile

@@ -1,6 +1,5 @@
-require 'rubygems'
-require "bundler"
-Bundler.setup
+require "rubygems"
+require "bundler/setup"
 
 require 'spec/rake/spectask'
 
@@ -26,4 +25,4 @@ begin
   Jeweler::GemcutterTasks.new
 rescue LoadError
   puts "Jeweler not available. Install it with: sudo gem install technicalpickles-jeweler -s http://gems.github.com"
-end
+end

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 20
+:minor: 1
 :build: 
+:patch: 21
 :major: 0
-:minor: 1

data/lib/mlist/mail_list.rb

@@ -24,8 +24,20 @@ module MList
 
     belongs_to :manager_list, :polymorphic => true
 
+    # Deletes any Email records that exist for this MailList. While this could
+    # be done by loading each Message, we do it here to make things go a bit
+    # faster.
+    #
     before_destroy :delete_unreferenced_email
+
+    # Answers the Messages that belong to this MailList. delete_all can be used
+    # for dependents because delete_unreferenced_email will clean up Email
+    # instances that are only referenced by Messages in this MailList.
+    #
     has_many :messages, :class_name => 'MList::Message', :dependent => :delete_all
+
+    # Answers the Threads that belong to this MailList.
+    #
     has_many :threads, :class_name => 'MList::Thread', :dependent => :delete_all
 
     delegate :address, :label, :post_url, :to => :list

data/lib/mlist/thread.rb

@@ -1,32 +1,32 @@
 module MList
   class Thread < ActiveRecord::Base
     set_table_name 'mlist_threads'
-    
+
     belongs_to :mail_list, :class_name => 'MList::MailList', :counter_cache => :threads_count
-    has_many :messages, :class_name => 'MList::Message', :dependent => :delete_all
-    
+    has_many :messages, :class_name => 'MList::Message', :dependent => :destroy
+
     def first?(message)
       tree_order.first == message
     end
-    
+
     def last?(message)
       tree_order.last == message
     end
-    
+
     def next(message)
       i = tree_order.index(message)
       tree_order[i + 1] unless messages.size < i
     end
-    
+
     def previous(message)
       i = tree_order.index(message)
       tree_order[i - 1] if i > 0
     end
-    
+
     def subject
       messages.first.subject
     end
-    
+
     # Answers a tree of messages.
     #
     # The nodes of the tree are decorated to act like a linked list, providing
@@ -37,26 +37,26 @@ module MList
       build_tree unless @tree
       @tree
     end
-    
+
     def tree_order
       build_tree unless @tree
       @tree_order
     end
-    
+
     private
       def build_tree
         nodes = messages.collect do |m|
           m.parent = messages.detect {|pm| pm.id == m.parent_id}
           Node.new(m)
         end
-        
+
         nodes.each do |node|
           if parent_node = nodes.detect {|n| n == node.parent}
             node.parent_node = parent_node
             parent_node.children << node
           end
         end
-        
+
         @tree_order = []
         previous_node = nil
         nodes.first.visit do |node|
@@ -67,32 +67,32 @@ module MList
           end
           previous_node = node
         end
-        
+
         @tree = @tree_order.first
       end
-      
+
       class Node < DelegateClass(Message)
         attr_accessor :parent_node, :previous, :next
         attr_reader :children
-        
+
         def initialize(message)
           super
           @children = []
         end
-        
+
         def leaf?
           children.empty?
         end
-        
+
         def root?
           parent_node.nil?
         end
-        
+
         def visit(&visitor)
           visitor.call self
           children.each {|c| c.visit(&visitor)}
         end
       end
-      
+
   end
-end
+end

data/spec/models/thread_spec.rb

@@ -6,15 +6,19 @@ describe MList::Thread do
     @thread = MList::Thread.new
     stub(@thread).messages {@messages}
   end
-  
+
   it 'should answer subject by way of the first message' do
     @thread.subject.should == '1'
   end
-  
+
   it 'should have messages counted' do
     MList::Message.reflect_on_association(:thread).counter_cache_column.should == :messages_count
     MList::Thread.column_names.should include('messages_count')
   end
+
+  it 'should destroy dependent messages, so that they may clean up email' do
+    MList::Thread.reflections[:messages].options[:dependent].should == :destroy
+  end
 end
 
 describe MList::Thread, 'tree' do
@@ -24,21 +28,21 @@ describe MList::Thread, 'tree' do
     @messages[2].parent_id = @messages[1].id
     @messages[3].parent_id = @messages[0].id
     @messages[4].parent_id = @messages[3].id
-    
+
     @thread = MList::Thread.new
     stub(@thread).messages {@messages}
-    
+
     @tree = @thread.tree
   end
-  
+
   it 'should answer the first message as the root of the tree' do
     @tree.should == @messages[0]
   end
-  
+
   it 'should connect the nodes into a tree' do
     @tree.children.should == [@messages[1], @messages[3]]
   end
-  
+
   it 'should connect next and previous to each node' do
     @tree.previous.should be_nil
     @tree.next.should == @messages[1]
@@ -46,38 +50,38 @@ describe MList::Thread, 'tree' do
     @tree.next.next.should == @messages[2]
     @tree.next.next.next.should == @messages[3]
   end
-  
+
   it 'should know if a message is the root' do
     @tree.root?.should be_true
     @tree.next.root?.should be_false
   end
-  
+
   it 'should know if a message is a leaf' do
     @tree.leaf?.should be_false
     @tree.next.leaf?.should be_false
     @tree.next.next.leaf?.should be_true
   end
-  
+
   it 'should answer when a message is last in the thread' do
     @thread.first?(@messages[0]).should be_true
     @thread.first?(@messages[1]).should be_false
     @thread.first?(@messages[2]).should be_false
   end
-  
+
   it 'should answer when a message is last in the thread' do
     @thread.last?(@messages[0]).should be_false
     @thread.last?(@messages[1]).should be_false
     @thread.last?(@messages[4]).should be_true
   end
-  
+
   it 'should answer the message next to given' do
     @thread.next(@messages[0]).should == @messages[1]
     @thread.next(@messages[2]).should == @messages[3]
     @thread.next(@messages[4]).should be_nil
   end
-  
+
   it 'should answer the message previous to given' do
     @thread.previous(@messages[0]).should be_nil
     @thread.previous(@messages[2]).should == @messages[1]
   end
-end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mlist
 version: !ruby/object:Gem::Version 
-  hash: 51
+  hash: 49
   prerelease: false
   segments: 
   - 0
   - 1
-  - 20
-  version: 0.1.20
+  - 21
+  version: 0.1.21
 platform: ruby
 authors: 
 - Adam Williams
@@ -15,10 +15,209 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-01 00:00:00 -04:00
+date: 2010-11-15 00:00:00 -05:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 21
+        segments: 
+        - 1
+        - 0
+        - 1
+        version: 1.0.1
+  name: bundler
+  requirement: *id001
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 11
+        segments: 
+        - 2
+        - 3
+        - 4
+        version: 2.3.4
+  name: activerecord
+  requirement: *id002
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 11
+        segments: 
+        - 2
+        - 3
+        - 4
+        version: 2.3.4
+  name: activesupport
+  requirement: *id003
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 13
+        segments: 
+        - 2
+        - 0
+        - 1
+        version: 2.0.1
+  name: uuid
+  requirement: *id004
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 59
+        segments: 
+        - 0
+        - 8
+        - 2
+        version: 0.8.2
+  name: hpricot
+  requirement: *id005
+- !ruby/object:Gem::Dependency 
+  type: :runtime
+  prerelease: false
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 29
+        segments: 
+        - 1
+        - 2
+        - 1
+        version: 1.2.1
+  name: tmail
+  requirement: *id006
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: jeweler
+  requirement: *id007
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id008 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 31
+        segments: 
+        - 1
+        - 3
+        - 2
+        version: 1.3.2
+  name: dataset
+  requirement: *id008
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id009 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rake
+  requirement: *id009
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id010 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3-ruby
+  requirement: *id010
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id011 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 25
+        segments: 
+        - 1
+        - 3
+        - 1
+        version: 1.3.1
+  name: rspec
+  requirement: *id011
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id012 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 55
+        segments: 
+        - 0
+        - 10
+        - 0
+        version: 0.10.0
+  name: rr
+  requirement: *id012
+- !ruby/object:Gem::Dependency 
+  type: :development
+  prerelease: false
+  version_requirements: &id013 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: ruby-debug
+  requirement: *id013
 description: A Ruby mailing list library designed to be integrated into other applications.
 email: adam@thewilliams.ws
 executables: []
@@ -31,6 +230,7 @@ extra_rdoc_files:
 files: 
 - CHANGELOG
 - Gemfile
+- Gemfile.lock
 - README
 - Rakefile
 - TODO
@@ -86,8 +286,8 @@ homepage: http://github.com/aiwilliams/mlist
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement