mlb_gameday 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b5e9fe24c12666b733a78d3d2095fbb9c27ef21
-  data.tar.gz: cc3b59210895a3b378e61a1e11a4a1b2fa1e3a76
+  metadata.gz: 6299f9b1205eaae985a66b13126e039e155a65c0
+  data.tar.gz: a6e7728f34e670cf8622430443126ee51049ed0d
 SHA512:
-  metadata.gz: ea269b35e30cd564fd0ccf6db6e44c2ae4a5d1ba990c7da1bc0c8efbac8a1b64366034c6f13a25d3bf56a08f2975da9033891c144c476851bbc89b7707f97738
-  data.tar.gz: b5c44b9f422d240c558cba09d205aa0c21688e1bcad3de246a2f8eb5863f952a8866f402dee3077b41b4a66172bf8f5d210b05787ab20d41e654f1d65365fc44
+  metadata.gz: 5d68b8ba4599172fd4a5778bf3b905a3ed9bfb7cb74159a112fe7b4810ade98c3e15dfe750662e028292d822b7c4d43df8a400e30c6f81f0e7f99e6d61c8485a
+  data.tar.gz: 696090f7753d5611090a935709c12d3263c6cb889fd1a23db33127057ac9734d6b1eb0c82801308a909c34252c83e061ffe20c607311c57c78f89deaa3c66ed0

data/README.md

@@ -18,7 +18,8 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+`require 'mlb_gameday' #=> true`
+`gd2 = MLBGameday::API.new`
 
 ## Contributing
 

data/lib/mlb_gameday.rb

@@ -34,13 +34,11 @@ module MLBGameday
     end
 
     def team(name)
-      return name if name.is_a? MLBGameday::Team
-
-      teams.each do |team|
-        return team if team.names.include? name.downcase
+      if name.is_a? MLBGameday::Team
+        name
+      else
+        teams.select { |team| team.is_called?(name) }.first
       end
-
-      nil
     end
 
     def teams
@@ -149,6 +147,8 @@ module MLBGameday
 
     def fetch_xml(path, interpolations = {})
       Nokogiri::XML open format(API_URL + path + '.xml', interpolations)
+    rescue OpenURI::HTTPError
+      {}
     end
   end
 end

data/lib/mlb_gameday/team.rb

@@ -1,6 +1,6 @@
 module MLBGameday
   class Team
-    attr_reader :id, :name, :city, :league, :division, :names, :code, :file_code
+    attr_reader :id, :name, :city, :league, :division, :code, :file_code
 
     def initialize(opts = {})
       @id        = opts[:id]
@@ -8,14 +8,50 @@ module MLBGameday
       @city      = opts[:city]
       @league    = opts[:league]
       @division  = opts[:division]
-      @names     = opts[:names]
+      @alt_names = opts[:alt_names]
       @code      = opts[:code]
       @file_code = opts[:file_code]
     end
+    
+    def full_name
+      "#{city} #{name}"
+    end
+    
+    def names
+      @names ||= (implicit_names + alt_names).uniq
+    end
+    
+    def is_called?(name)
+      names.include?(name.downcase)
+    end
 
     # So we don't get huge printouts
     def inspect
       %(#<MLBGameday::Team @name="#{@name}">)
     end
+    
+    private
+    def alt_names
+      @alt_names ||= []
+    end
+    
+    def implicit_names
+      result = strict_names + [code, singular_name, despaced_name].map(&:downcase)
+      result << city.downcase unless ["New York", "Chicago"].include?(city)
+      
+      result.uniq
+    end
+    
+    def strict_names
+      [name, full_name].map(&:downcase)
+    end
+    
+    def singular_name
+      name.chomp('s')
+    end
+    
+    def despaced_name
+      name.tr(' ', '')
+    end
   end
 end

data/lib/mlb_gameday/version.rb

@@ -1,3 +1,3 @@
 module MLBGameday
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

data/resources/data.yml

@@ -15,11 +15,6 @@
           code: BAL
           file_code: bal
           id: 110
-          names:
-          - bal
-          - orioles
-          - oriole
-          - baltimore
         :BOS: !ruby/object:MLBGameday::Team
           name: Red Sox
           city: Boston
@@ -28,11 +23,7 @@
           code: BOS
           file_code: bos
           id: 111
-          names:
-          - bos
-          - red sox
-          - redsox
-          - boston
+          alt_names:
           - bosox
         :NYY: !ruby/object:MLBGameday::Team
           name: Yankees
@@ -42,11 +33,7 @@
           code: NYY
           file_code: nyy
           id: 147
-          names:
-          - nyy
-          - yankees
-          - yankee
-          - new york yankees
+          alt_names:
           - new york yankee
         :TB: !ruby/object:MLBGameday::Team
           name: Rays
@@ -56,14 +43,10 @@
           code: TB
           file_code: tb
           id: 139
-          names:
-          - tb
-          - rays
-          - ray
+          alt_names:
           - devil rays
           - devil ray
           - tampa
-          - tampa bay
         :TOR: !ruby/object:MLBGameday::Team
           name: Blue Jays
           city: Toronto
@@ -72,15 +55,10 @@
           code: TOR
           file_code: tor
           id: 141
-          names:
-          - tor
-          - blue jays
-          - blue jay
-          - bluejays
+          alt_names:
           - bluejay
           - jays
           - jay
-          - toronto
     :Central: &alcentral !ruby/object:MLBGameday::Division
       name: Central
       league: *al
@@ -94,11 +72,6 @@
           code: CLE
           file_code: cle
           id: 114
-          names:
-          - cle
-          - indians
-          - indian
-          - cleveland
         :CWS: !ruby/object:MLBGameday::Team
           name: White Sox
           city: Chicago
@@ -107,10 +80,6 @@
           code: CWS
           file_code: cws
           id: 145
-          names:
-          - cws
-          - white sox
-          - chicago white sox
         :DET: !ruby/object:MLBGameday::Team
           name: Tigers
           city: Detroit
@@ -119,11 +88,6 @@
           code: DET
           file_code: det
           id: 116
-          names:
-          - det
-          - tigers
-          - tiger
-          - detroit
         :KC: !ruby/object:MLBGameday::Team
           name: Royals
           city: Kansas City
@@ -132,11 +96,7 @@
           code: KC
           file_code: kc
           id: 118
-          names:
-          - kc
-          - royals
-          - royal
-          - kansas city
+          alt_names:
           - kansas
         :MIN: !ruby/object:MLBGameday::Team
           name: Twins
@@ -146,11 +106,6 @@
           code: MIN
           file_code: min
           id: 142
-          names:
-          - min
-          - twins
-          - twin
-          - minnesota
     :West: &alwest !ruby/object:MLBGameday::Division
       name: West
       league: *al
@@ -164,17 +119,12 @@
           code: LAA
           file_code: ana
           id: 108
-          names:
-          - ana
-          - angels
-          - angel
-          - anaheim
+          alt_names:
           - ana
           - los angeles angel
           - los angeles angels
           - la angels
           - la angel
-          - laa
           - laaa
           - los angeles angels of anaheim
         :HOU: !ruby/object:MLBGameday::Team
@@ -185,11 +135,6 @@
           code: HOU
           file_code: hou
           id: 117
-          names:
-          - hou
-          - astros
-          - astro
-          - houston
         :OAK: !ruby/object:MLBGameday::Team
           name: Athletics
           city: Oakland
@@ -198,12 +143,8 @@
           code: OAK
           file_code: oak
           id: 133
-          names:
-          - oak
-          - athletics
-          - athletic
+          alt_names:
           - as
-          - oakland
         :SEA: !ruby/object:MLBGameday::Team
           name: Mariners
           city: Seattle
@@ -212,11 +153,6 @@
           code: SEA
           file_code: sea
           id: 136
-          names:
-          - sea
-          - mariners
-          - mariner
-          - seattle
         :TEX: !ruby/object:MLBGameday::Team
           name: Rangers
           city: Texas
@@ -225,11 +161,6 @@
           code: TEX
           file_code: tex
           id: 140
-          names:
-          - tex
-          - rangers
-          - ranger
-          - texas
 :NL: &nl !ruby/object:MLBGameday::League
   name: National
   divisions:
@@ -246,11 +177,6 @@
           code: ATL
           file_code: atl
           id: 144
-          names:
-          - atl
-          - braves
-          - brave
-          - atlanta
         :MIA: !ruby/object:MLBGameday::Team
           name: Marlins
           city: Miami
@@ -259,11 +185,7 @@
           code: MIA
           file_code: mia
           id: 146
-          names:
-          - mia
-          - marlins
-          - marlin
-          - miami
+          alt_names:
           - florida
         :NYM: !ruby/object:MLBGameday::Team
           name: Mets
@@ -273,11 +195,7 @@
           code: NYM
           file_code: nym
           id: 121
-          names:
-          - nym
-          - mets
-          - met
-          - new york mets
+          alt_names:
           - new york met
         :PHI: !ruby/object:MLBGameday::Team
           name: Phillies
@@ -287,12 +205,8 @@
           code: PHI
           file_code: phi
           id: 143
-          names:
-          - phi
-          - phillies
-          - phillie
+          alt_names:
           - philly
-          - philadelphia
         :WSH: !ruby/object:MLBGameday::Team
           name: Nationals
           city: Washington
@@ -301,12 +215,8 @@
           code: WSH
           file_code: was
           id: 120
-          names:
-          - wsh
-          - nationals
+          alt_names:
           - natinals
-          - national
-          - washington
     :Central: &nlcentral !ruby/object:MLBGameday::Division
       name: Central
       league: *nl
@@ -320,11 +230,7 @@
           code: CHC
           file_code: chc
           id: 112
-          names:
-          - chc
-          - cubs
-          - cub
-          - chicago cubs
+          alt_names:
           - chicago cub
         :CIN: !ruby/object:MLBGameday::Team
           name: Reds
@@ -334,11 +240,6 @@
           code: CIN
           file_code: cin
           id: 113
-          names:
-          - cin
-          - reds
-          - red
-          - cincinnati
         :MIL: !ruby/object:MLBGameday::Team
           name: Brewers
           city: Milwaukee
@@ -347,11 +248,6 @@
           code: MIL
           file_code: mil
           id: 158
-          names:
-          - mil
-          - brewers
-          - brewer
-          - milwaukee
         :PIT: !ruby/object:MLBGameday::Team
           name: Pirates
           city: Pittsburgh
@@ -360,13 +256,9 @@
           code: PIT
           file_code: pit
           id: 134
-          names:
-          - pit
-          - pirates
-          - pirate
+          alt_names:
           - buccos
           - bucco
-          - pittsburgh
         :STL: !ruby/object:MLBGameday::Team
           name: Cardinals
           city: St. Louis
@@ -375,12 +267,8 @@
           code: STL
           file_code: stl
           id: 138
-          names:
-          - stl
-          - cardinals
-          - cardinal
+          alt_names:
           - st louis
-          - st. louis
     :West: &nlwest !ruby/object:MLBGameday::Division
       name: West
       league: *nl
@@ -394,13 +282,9 @@
           code: ARI
           file_code: ari
           id: 109
-          names:
-          - ari
-          - diamondbacks
-          - diamondback
+          alt_names:
           - dbacks
           - dback
-          - arizona
           - az
         :COL: !ruby/object:MLBGameday::Team
           name: Rockies
@@ -410,11 +294,6 @@
           code: COL
           file_code: col
           id: 115
-          names:
-          - col
-          - rockies
-          - rockie
-          - colorado
         :LAD: !ruby/object:MLBGameday::Team
           name: Dodgers
           city: Los Angeles
@@ -423,11 +302,7 @@
           code: LAD
           file_code: la
           id: 119
-          names:
-          - lad
-          - dodgers
-          - dodger
-          - los angeles
+          alt_names:
           - la
           - los angeles dodgers
           - los angeles dodger
@@ -441,11 +316,6 @@
           code: SD
           file_code: sd
           id: 135
-          names:
-          - sd
-          - padres
-          - padre
-          - san diego
         :SF: !ruby/object:MLBGameday::Team
           name: Giants
           city: San Francisco
@@ -454,10 +324,6 @@
           code: SF
           file_code: sf
           id: 137
-          names:
-          - sf
-          - giants
-          - giant
+          alt_names:
           - san fran
-          - san francisco
           - gigantes

data/test/api_spec.rb

@@ -30,6 +30,10 @@ class TestApi < MiniTest::Test
     assert_equal @api.team('Dodgers').city, 'Los Angeles'
   end
 
+  def test_name_search_for_nonexistent_returns_nil
+    assert_nil @api.team('Senators')
+  end
+
   def test_division_team_count
     assert_equal @api.team('Dodgers').division.teams.count, 5
   end
@@ -38,4 +42,56 @@ class TestApi < MiniTest::Test
     assert_equal @api.team('Astros').league.name, 'American'
     assert_equal @api.team('Astros').division.name, 'West'
   end
+
+  def test_names_includes_code
+    @api.teams.each do |team|
+      assert_includes team.names, team.code.downcase
+    end
+  end
+
+  def test_names_includes_name
+    @api.teams.each do |team|
+      assert_includes team.names, team.name.downcase
+    end
+  end
+
+  def test_names_includes_alt_names
+    @api.teams.each do |team|
+      team.send(:alt_names).each do |alt_name|
+        assert_includes team.names, alt_name.downcase
+      end
+    end
+  end
+  
+  def test_names_include_singular_name_when_different_from_name
+    @api.teams.reject {|team| team.name == team.send(:singular_name)}.each do |team|
+      assert_includes team.names, team.send(:singular_name).downcase
+    end
+  end
+  
+  def test_names_includes_despaced_name_when_name_is_multi_word
+    @api.teams.select {|team| team.name.split.size > 1}.each do |team|
+        assert_includes team.names, team.send(:despaced_name).downcase
+    end
+  end
+
+  def test_names_includes_city_except_nyc_and_chicago
+    @api.teams.reject {|team| ["New York", "Chicago"].include?(team.city)}.each do |team|
+        assert_includes team.names, team.city.downcase
+    end
+  end
+
+  def test_names_does_not_include_city_for_nyc_and_chicago
+    @api.teams.select {|team| ["New York", "Chicago"].include?(team.city)}.each do |team|
+        refute_includes team.names, team.city.downcase
+    end
+  end
+  
+  def test_no_teams_share_any_names
+    @api.teams.each do |team|
+      @api.teams.select {|t| t != team}.each do |other_team|
+        assert_equal (team.names - other_team.names), team.names
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mlb_gameday
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Steven Hoffman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-08 00:00:00.000000000 Z
+date: 2016-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -241,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Fetches gameday data from the MLB Gameday API