mixpanel-ruby 1.1.0 → 1.2.0

data/Readme.rdoc

@@ -38,6 +38,10 @@ For more information please visit:
 
 == Changes
 
+== 1.2.0
+* All objects with a "strftime" method will be formatted as dates in
+  people updates.
+
 == 1.1.0
 * The default consumer now sends requests (and expects responses) in
   verbose, JSON mode, which may improve error reporting.

data/lib/mixpanel-ruby/people.rb

@@ -244,27 +244,9 @@ module Mixpanel
 
     def fix_property_dates(h)
       h.inject({}) do |ret,(k,v)|
-        ret[k] = PeopleDate.asPeopleDate(v)
+        ret[k] = v.respond_to?(:strftime) ? v.strftime('%Y-%m-%dT%H:%M:%S') : v
         ret
       end
     end
-
-    class PeopleDate
-      def initialize(date)
-        @date = date
-      end
-
-      def to_json(*a)
-        @date.strftime('%Y-%m-%dT%H:%M:%S').to_json(*a)
-      end
-
-      def self.asPeopleDate(thing)
-        if thing.is_a?(Date)
-          PeopleDate.new(thing)
-        else
-          thing
-        end
-      end
-    end
   end
 end

data/lib/mixpanel-ruby/version.rb

@@ -1,3 +1,3 @@
 module Mixpanel
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/spec/mixpanel-ruby/events_spec.rb

@@ -6,7 +6,7 @@ require 'time'
 describe Mixpanel::Events do
   before(:each) do
     @time_now = Time.parse('Jun 6 1972, 16:23:04')
-    Time.stub!(:now).and_return(@time_now)
+    Time.stub(:now).and_return(@time_now)
 
     @log = []
     @events = Mixpanel::Events.new('TEST TOKEN') do |type, message|

data/spec/mixpanel-ruby/people_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
-require 'date'
-require 'json'
-require 'mixpanel-ruby/people.rb'
+require 'mixpanel-ruby/people'
 
 describe Mixpanel::People do
   before(:each) do
     @time_now = Time.parse('Jun 6 1972, 16:23:04')
-    Time.stub!(:now).and_return(@time_now)
+    Time.stub(:now).and_return(@time_now)
 
     @log = []
     @people = Mixpanel::People.new('TEST TOKEN') do |type, message|
@@ -30,6 +28,20 @@ describe Mixpanel::People do
     }]])
   end
 
+  it 'should properly cast dates' do
+    @people.set("TEST ID", {
+        'created_at' => DateTime.new(2013, 1, 2, 3, 4, 5)
+    })
+    @log.should eq([[ :profile_update, 'data' => {
+        '$token' => 'TEST TOKEN',
+        '$distinct_id' => 'TEST ID',
+        '$time' => @time_now.to_i * 1000,
+        '$set' => {
+            'created_at' => '2013-01-02T03:04:05'
+        }
+    }]])
+  end
+
   it 'should send a well formed engage/set_once message' do
     @people.set_once("TEST ID", {
         '$firstname' => 'David',
@@ -63,7 +75,7 @@ describe Mixpanel::People do
     @log.should eq([[ :profile_update, 'data' => {
         '$token' => 'TEST TOKEN',
         '$distinct_id' => 'TEST ID',
-        '$time' => 76695784000,
+        '$time' => @time_now.to_i * 1000,
         '$add' => {
             'Albums Released' => 1
         }

data/spec/mixpanel-ruby/tracker_spec.rb

@@ -6,7 +6,7 @@ require 'uri'
 describe Mixpanel::Tracker do
   before(:each) do
     @time_now = Time.parse('Jun 6 1972, 16:23:04')
-    Time.stub!(:now).and_return(@time_now)
+    Time.stub(:now).and_return(@time_now)
   end
 
   it 'should send an alias message to mixpanel no matter what the consumer is' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mixpanel-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-14 00:00:00.000000000 Z
+date: 2013-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake