mixlib-config 1.1.0 → 1.1.2.rc01

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 0
-:build: 
+:patch: 2
+:build: rc01
 :major: 1 
 :minor: 1 

data/lib/mixlib/config.rb

@@ -18,12 +18,6 @@
 # limitations under the License.
 #
 
-class Object # http://whytheluckystiff.net/articles/seeingMetaclassesClearly.html
-  def meta_def name, &blk
-    (class << self; self; end).instance_eval { define_method name, &blk }
-  end
-end
-
 module Mixlib
   module Config
 
@@ -125,7 +119,7 @@ module Mixlib
     #      
     def internal_set(method_symbol,value)
       method_name = method_symbol.id2name
-      if (self.public_methods - ["[]="]).include?("#{method_name}=")
+      if self.respond_to?("#{method_name}=".to_sym)
         self.send("#{method_name}=", value)
       else
         self.configuration[method_symbol] = value
@@ -142,8 +136,9 @@ module Mixlib
     # value<Object>:: Value to be set in config hash
     #          
     def config_attr_writer(method_symbol, &blk)
-      method_name = "#{method_symbol.to_s}="
-      meta_def method_name do |value|
+      meta = class << self; self; end
+      method_name = "#{method_symbol.to_s}=".to_sym
+      meta.send :define_method, method_name do |value|
         self.configuration[method_symbol] = blk.call(value)
       end
     end

data/spec/mixlib/config_spec.rb

@@ -18,6 +18,11 @@
 
 require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
 
+class ConfigIt
+  extend ::Mixlib::Config
+end
+
+
 describe Mixlib::Config do
   before(:each) do
     ConfigIt.configure do |c|
@@ -96,47 +101,41 @@ describe Mixlib::Config do
   
   describe "when a class method override accessor exists" do
     before do
-      class ConfigIt
-        
+      @klass = Class.new
+      @klass.extend(::Mixlib::Config)
+      @klass.class_eval(<<-EVAL)
         config_attr_writer :test_method do |blah|
           blah.is_a?(Integer) ? blah * 1000 : blah
         end
-        
-      end
+        pp self.methods
+      EVAL
     end
 
     it "should multiply an integer by 1000" do
-      ConfigIt[:test_method] = 53
-      ConfigIt[:test_method].should == 53000
+      @klass[:test_method] = 53
+      @klass[:test_method].should == 53000
     end
 
     it "should multiply an integer by 1000 with the method_missing form" do
-      ConfigIt.test_method = 63
-      ConfigIt.test_method.should == 63000
+      @klass.test_method = 63
+      @klass.test_method.should == 63000
     end
 
     it "should multiply an integer by 1000 with the instance_eval DSL form" do
-      ConfigIt.instance_eval("test_method 73")
-      ConfigIt.test_method.should == 73000
+      @klass.instance_eval("test_method 73")
+      @klass.test_method.should == 73000
     end
 
     it "should multiply an integer by 1000 via from-file, too" do
       IO.stub!(:read).with('config.rb').and_return("test_method 99")
-      ConfigIt.from_file('config.rb')
-      ConfigIt.test_method.should == 99000
+      @klass.from_file('config.rb')
+      @klass.test_method.should == 99000
     end
     
     it "should receive internal_set with the method name and config value" do
-      ConfigIt.should_receive(:internal_set).with(:test_method, 53).and_return(true)
-      ConfigIt[:test_method] = 53
+      @klass.should_receive(:internal_set).with(:test_method, 53).and_return(true)
+      @klass[:test_method] = 53
     end
     
-    after do
-      class ConfigIt
-        class << self
-          undef test_method=
-        end
-      end
-    end
   end
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mixlib-config
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  prerelease: true
   segments: 
   - 1
   - 1
-  - 0
-  version: 1.1.0
+  - 2
+  - rc01
+  version: 1.1.2.rc01
 platform: ruby
 authors: 
 - Opscode, Inc.
@@ -14,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-28 00:00:00 -08:00
+date: 2010-06-15 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -54,6 +55,7 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
@@ -61,16 +63,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version 
       segments: 
-      - 0
-      version: "0"
+      - 1
+      - 3
+      - 1
+      version: 1.3.1
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: A class based config mixin, similar to the one found in Chef.