mittens 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a293e52f3e6ecf7669615bbf24aae34a9fcef78305b7324f7f739fc97e7eb0fc
-  data.tar.gz: e5f1ba1b94ac634316599a25d969c1d71d4a0ff591ef043011c2481fe641814d
+  metadata.gz: d7e35e680454076f43e5973db399645697e0e98732555293d6b5e3bae115308d
+  data.tar.gz: 6c619fe9518ba5ddd42001ee0e99b4883b0fa703d5bf7b45e9022a039c78fb7d
 SHA512:
-  metadata.gz: 4c392905c194b9eb723f44e7e97fd040395757751a43a034c34dfef51f399f24e2be4e390414e6e34e79bd26410987d696cd23fa197396ff9510f60a5503730e
-  data.tar.gz: 9dbff4611a7d1b43d42d19fa0e873a3c5055b2358b5b0d75e3080e9686ccd315be564dbd93af62e28a63c3e1b50706968a2b6dbcd01f9dc7cd41420bf782ac09
+  metadata.gz: 1148ef35cf15d3027b51934844763437f1a606b2eed92dec9ccb17c86a78e544d664a51e6470da7d117c3a30fb1e0638119f3f1091fb203b29630e11513d5672
+  data.tar.gz: c1cc877ce40bf0c2fc3dd9a7946b4cf0165f870392ff87024c3a717cfe742420b8de6b1bbe8ecf5645e0566f81ed906f1ce87a9072ba645c4ca3096702b253d8

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.4 (2026-08-06)
+
+- Fixed `dup` and `clone` methods
+
 ## 0.3.3 (2026-08-05)
 
 - Fixed issue with GC compaction

data/ext/mittens/ext.c

@@ -3,21 +3,35 @@
 #include "libstemmer.h"
 #include "ruby/ruby.h"
 
+#define GetAlgorithm(language) (NIL_P(language) ? "english" : StringValueCStr(language))
+#define GetStemmer(obj, ptr) TypedData_Get_Struct((obj), stemmer_t, &stemmer_data_type, (ptr))
+
 typedef struct stemmer {
     struct sb_stemmer* stemmer;
+    VALUE language;
 } stemmer_t;
 
+static void stemmer_mark(void* ptr)
+{
+    stemmer_t* stemmer = (stemmer_t*) ptr;
+    rb_gc_mark(stemmer->language);
+}
+
 static void stemmer_free(void* ptr)
 {
     stemmer_t* stemmer = (stemmer_t*) ptr;
-    // safe to pass null pointer according to docs
-    sb_stemmer_delete(stemmer->stemmer);
+
+    // safe to pass null pointer, but check anyways
+    if (stemmer->stemmer != NULL)
+        sb_stemmer_delete(stemmer->stemmer);
+
     xfree(ptr);
 }
 
 const rb_data_type_t stemmer_data_type = {
-    .wrap_struct_name = "stemmer",
+    .wrap_struct_name = "Mittens::Stemmer",
     .function = {
+        .dmark = stemmer_mark,
         .dfree = stemmer_free,
     },
     .flags = RUBY_TYPED_FREE_IMMEDIATELY
@@ -28,38 +42,37 @@ static VALUE stemmer_allocate(VALUE klass)
     stemmer_t* stemmer;
     VALUE obj = TypedData_Make_Struct(klass, stemmer_t, &stemmer_data_type, stemmer);
     stemmer->stemmer = NULL;
+    stemmer->language = Qnil;
     return obj;
 }
 
 static VALUE stemmer_initialize(int argc, VALUE* argv, VALUE self)
 {
+    stemmer_t* stemmer;
+    GetStemmer(self, stemmer);
+
+    if (stemmer->stemmer != NULL)
+        rb_raise(rb_eRuntimeError, "stemmer already initialized");
+
     VALUE opts;
     rb_scan_args(argc, argv, ":", &opts);
 
     VALUE language = Qnil;
-    const char* algorithm = "english";
-    if (!NIL_P(opts)) {
+    if (!NIL_P(opts))
         language = rb_hash_aref(opts, ID2SYM(rb_intern("language")));
-        if (!NIL_P(language)) {
-            Check_Type(language, T_STRING);
-            algorithm = RSTRING_PTR(language);
-        }
-    }
-
-    stemmer_t* stemmer;
-    TypedData_Get_Struct(self, stemmer_t, &stemmer_data_type, stemmer);
-
-    // in case called multiple times
-    sb_stemmer_delete(stemmer->stemmer);
 
     // if adding support for encoding, may want to change encoding returned from stem
-    stemmer->stemmer = sb_stemmer_new(algorithm, NULL);
-    if (stemmer->stemmer == NULL) {
-        rb_raise(rb_eArgError, "unknown language: %s", algorithm);
+    stemmer->stemmer = sb_stemmer_new(GetAlgorithm(language), NULL);
+    if (stemmer->stemmer == NULL)
+    {
+        if (!NIL_P(language))
+            rb_raise(rb_eArgError, "unknown language: %" PRIsVALUE, language);
+
+        rb_raise(rb_eNoMemError, "failed to allocate memory");
     }
 
-    // must be placed after last use of algorithm
-    RB_GC_GUARD(language);
+    // copy (after GetAlgorithm) in case string is modified in future
+    stemmer->language = rb_obj_dup(language);
 
     return self;
 }
@@ -67,17 +80,43 @@ static VALUE stemmer_initialize(int argc, VALUE* argv, VALUE self)
 static VALUE stemmer_stem(VALUE self, VALUE value)
 {
     stemmer_t* stemmer;
-    TypedData_Get_Struct(self, stemmer_t, &stemmer_data_type, stemmer);
+    GetStemmer(self, stemmer);
 
-    Check_Type(value, T_STRING);
+    if (stemmer->stemmer == NULL)
+        rb_raise(rb_eRuntimeError, "stemmer not initialized");
 
-    const sb_symbol* word = (const sb_symbol*) RSTRING_PTR(value);
+    const char* word = StringValuePtr(value);
     long size = RSTRING_LEN(value);
     if (size > INT_MAX)
         rb_raise(rb_eArgError, "string exceeds max length");
-    const sb_symbol* pointer_out = sb_stemmer_stem(stemmer->stemmer, word, (int) size);
 
-    return rb_utf8_str_new_cstr((char*) pointer_out);
+    const sb_symbol* pointer_out = sb_stemmer_stem(stemmer->stemmer, (const sb_symbol*) word, (int) size);
+    int length_out = sb_stemmer_length(stemmer->stemmer);
+
+    // place after last use of word
+    RB_GC_GUARD(value);
+
+    return rb_utf8_str_new((char*) pointer_out, (long) length_out);
+}
+
+static VALUE stemmer_initialize_copy(VALUE self, VALUE orig)
+{
+    stemmer_t* stemmer;
+    GetStemmer(self, stemmer);
+
+    stemmer_t* orig_stemmer;
+    GetStemmer(orig, orig_stemmer);
+
+    if (stemmer->stemmer != NULL)
+        rb_raise(rb_eRuntimeError, "stemmer already initialized");
+
+    stemmer->stemmer = sb_stemmer_new(GetAlgorithm(orig_stemmer->language), NULL);
+    if (stemmer->stemmer == NULL)
+        rb_raise(rb_eNoMemError, "failed to allocate memory");
+
+    stemmer->language = orig_stemmer->language;
+
+    return self;
 }
 
 static VALUE stemmer_languages(VALUE klass)
@@ -85,10 +124,8 @@ static VALUE stemmer_languages(VALUE klass)
     VALUE out = rb_ary_new();
 
     const char** language = sb_stemmer_list();
-    while (*language != NULL) {
-        rb_ary_push(out, rb_utf8_str_new_cstr(*language));
-        language++;
-    }
+    while (*language != NULL)
+        rb_ary_push(out, rb_utf8_str_new_cstr(*language++));
 
     return out;
 }
@@ -100,5 +137,6 @@ void Init_ext(void)
     rb_define_alloc_func(cStemmer, stemmer_allocate);
     rb_define_method(cStemmer, "initialize", stemmer_initialize, -1);
     rb_define_method(cStemmer, "stem", stemmer_stem, 1);
+    rb_define_method(cStemmer, "initialize_copy", stemmer_initialize_copy, 1);
     rb_define_singleton_method(cStemmer, "languages", stemmer_languages, 0);
 }

data/ext/mittens/extconf.rb

@@ -10,6 +10,8 @@ output, status = Open3.capture2(make_cmd, "CFLAGS=#{cflags}", chdir: vendor)
 puts output
 raise "Command failed" unless status.success?
 
+append_cflags("-Wall -Wextra -Wpedantic -Wconversion")
+
 $INCFLAGS += " -I$(srcdir)/../../vendor/snowball/include"
 $LDFLAGS += " $(srcdir)/../../vendor/snowball/libstemmer.a"
 

data/lib/mittens/version.rb

@@ -1,3 +1,3 @@
 module Mittens
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mittens
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Andrew Kane