mittens 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5d5216e3e6a0e86aa92ab80ec8876e66be4d766d500d82609f166452f28fb08
-  data.tar.gz: f5db98b8a25cc9fb2183a2f0010695239a66c82faf00e1ddb34355739087c48b
+  metadata.gz: a293e52f3e6ecf7669615bbf24aae34a9fcef78305b7324f7f739fc97e7eb0fc
+  data.tar.gz: e5f1ba1b94ac634316599a25d969c1d71d4a0ff591ef043011c2481fe641814d
 SHA512:
-  metadata.gz: 886dac65964a1b37c5156ff27b7703a71d6acde7f01c9525d1a564636b1fdfa99bf8871b98e8628ed511cdda536e4d28d7e5bebbefdb9b0a67454346e1f571c7
-  data.tar.gz: 62a9a20fca62714a28826626183dba6816d11863fb169da43c0fa7d35d2a7978704f4764be63bce5de1986b188566f15f7ec5be5a0d415d9a85fad7285b2f1ac
+  metadata.gz: 4c392905c194b9eb723f44e7e97fd040395757751a43a034c34dfef51f399f24e2be4e390414e6e34e79bd26410987d696cd23fa197396ff9510f60a5503730e
+  data.tar.gz: 9dbff4611a7d1b43d42d19fa0e873a3c5055b2358b5b0d75e3080e9686ccd315be564dbd93af62e28a63c3e1b50706968a2b6dbcd01f9dc7cd41420bf782ac09

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.3 (2026-08-05)
+
+- Fixed issue with GC compaction
+
 ## 0.3.2 (2026-07-10)
 
 - Updated Snowball to 3.1.1

data/ext/mittens/ext.c

@@ -1,13 +1,15 @@
+#include <limits.h>
+
 #include "libstemmer.h"
 #include "ruby/ruby.h"
 
 typedef struct stemmer {
-    struct sb_stemmer * stemmer;
+    struct sb_stemmer* stemmer;
 } stemmer_t;
 
-static void stemmer_free(void *ptr)
+static void stemmer_free(void* ptr)
 {
-    stemmer_t *stemmer = (stemmer_t *)ptr;
+    stemmer_t* stemmer = (stemmer_t*) ptr;
     // safe to pass null pointer according to docs
     sb_stemmer_delete(stemmer->stemmer);
     xfree(ptr);
@@ -23,7 +25,7 @@ const rb_data_type_t stemmer_data_type = {
 
 static VALUE stemmer_allocate(VALUE klass)
 {
-    stemmer_t *stemmer;
+    stemmer_t* stemmer;
     VALUE obj = TypedData_Make_Struct(klass, stemmer_t, &stemmer_data_type, stemmer);
     stemmer->stemmer = NULL;
     return obj;
@@ -34,16 +36,17 @@ static VALUE stemmer_initialize(int argc, VALUE* argv, VALUE self)
     VALUE opts;
     rb_scan_args(argc, argv, ":", &opts);
 
-    const char * algorithm = "english";
+    VALUE language = Qnil;
+    const char* algorithm = "english";
     if (!NIL_P(opts)) {
-        VALUE language = rb_hash_aref(opts, ID2SYM(rb_intern("language")));
+        language = rb_hash_aref(opts, ID2SYM(rb_intern("language")));
         if (!NIL_P(language)) {
             Check_Type(language, T_STRING);
             algorithm = RSTRING_PTR(language);
         }
     }
 
-    stemmer_t *stemmer;
+    stemmer_t* stemmer;
     TypedData_Get_Struct(self, stemmer_t, &stemmer_data_type, stemmer);
 
     // in case called multiple times
@@ -55,28 +58,33 @@ static VALUE stemmer_initialize(int argc, VALUE* argv, VALUE self)
         rb_raise(rb_eArgError, "unknown language: %s", algorithm);
     }
 
+    // must be placed after last use of algorithm
+    RB_GC_GUARD(language);
+
     return self;
 }
 
 static VALUE stemmer_stem(VALUE self, VALUE value)
 {
-    stemmer_t *stemmer;
+    stemmer_t* stemmer;
     TypedData_Get_Struct(self, stemmer_t, &stemmer_data_type, stemmer);
 
     Check_Type(value, T_STRING);
 
-    const sb_symbol * word = (const sb_symbol *) RSTRING_PTR(value);
-    int size = (int) RSTRING_LEN(value);
-    const sb_symbol * pointer_out = sb_stemmer_stem(stemmer->stemmer, word, size);
+    const sb_symbol* word = (const sb_symbol*) RSTRING_PTR(value);
+    long size = RSTRING_LEN(value);
+    if (size > INT_MAX)
+        rb_raise(rb_eArgError, "string exceeds max length");
+    const sb_symbol* pointer_out = sb_stemmer_stem(stemmer->stemmer, word, (int) size);
 
-    return rb_utf8_str_new_cstr((char *) pointer_out);
+    return rb_utf8_str_new_cstr((char*) pointer_out);
 }
 
 static VALUE stemmer_languages(VALUE klass)
 {
     VALUE out = rb_ary_new();
 
-    const char **language = sb_stemmer_list();
+    const char** language = sb_stemmer_list();
     while (*language != NULL) {
         rb_ary_push(out, rb_utf8_str_new_cstr(*language));
         language++;
@@ -87,10 +95,10 @@ static VALUE stemmer_languages(VALUE klass)
 
 void Init_ext(void)
 {
-    VALUE rb_mMittens = rb_define_module("Mittens");
-    VALUE rb_cStemmer = rb_define_class_under(rb_mMittens, "Stemmer", rb_cObject);
-    rb_define_alloc_func(rb_cStemmer, stemmer_allocate);
-    rb_define_method(rb_cStemmer, "initialize", stemmer_initialize, -1);
-    rb_define_method(rb_cStemmer, "stem", stemmer_stem, 1);
-    rb_define_singleton_method(rb_cStemmer, "languages", stemmer_languages, 0);
+    VALUE mMittens = rb_define_module("Mittens");
+    VALUE cStemmer = rb_define_class_under(mMittens, "Stemmer", rb_cObject);
+    rb_define_alloc_func(cStemmer, stemmer_allocate);
+    rb_define_method(cStemmer, "initialize", stemmer_initialize, -1);
+    rb_define_method(cStemmer, "stem", stemmer_stem, 1);
+    rb_define_singleton_method(cStemmer, "languages", stemmer_languages, 0);
 }

data/lib/mittens/version.rb

@@ -1,3 +1,3 @@
 module Mittens
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mittens
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Andrew Kane