mit_stalker 1.0.1 → 1.0.2

data/CHANGELOG

@@ -1,3 +1,5 @@
+v1.0.2. Workaround for people undergoing name changes.
+
 v1.0.1. Fixed copy-pasted manifest.
 
 v1.0. Initial release.

data/lib/mit_stalker.rb

@@ -75,7 +75,7 @@ module MitStalker
   #
   # Returns a single user information hash, or nil if no user has the given
   # full name. 
-  def self.refine_mitdir_response(users, full_name)
+  def self.refine_mitdir_response_by_name(users, full_name)
     vector = name_vector(full_name)
     user_base_info = users.find { |user| name_vector(user[:name]) == vector }
     return nil unless user_base_info
@@ -88,6 +88,28 @@ module MitStalker
     users and users.first
   end
   
+  # Narrows down a MIT directory response to a single user.
+  #
+  # Returns a single user information hash, or nil if no user has the given
+  # e-mail.
+  def self.refine_mitdir_response_by_email(users, user_name)
+    users.each do |user|
+      if user[:email]
+        next unless user[:email].split('@').first == user_name
+        users = parse_mitdir_response finger(user[:alias], 'web.mit.edu')
+        return users && users.first
+      else
+        users = parse_mitdir_response finger(user[:alias], 'web.mit.edu')
+        next unless users
+        user = users.first
+        if user[:email] and user[:email].split('@').first == user_name
+          return user  
+        end
+      end
+    end
+    nil
+  end
+  
   # Retrieves information about an MIT student from an Athena username.
   #
   # Returns a hash containing user information, or nil if the user was not
@@ -101,7 +123,8 @@ module MitStalker
       users = parse_mitdir_response finger(user_name, 'web.mit.edu')
     end
     
-    user = refine_mitdir_response(users, full_name)
+    user = refine_mitdir_response_by_name(users, full_name)
+    user = refine_mitdir_response_by_email(users, user_name) unless user
     user and user.merge(:full_name => full_name)
   end
 end

data/mit_stalker.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{mit_stalker}
-  s.version = "1.0.1"
+  s.version = "1.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Victor Costan"]
-  s.date = %q{2009-09-29}
+  s.date = %q{2010-02-07}
   s.description = %q{Fetches publicly available information about MIT students.}
   s.email = %q{victor@zergling.net}
   s.extra_rdoc_files = ["CHANGELOG", "LICENSE", "README.textile", "lib/mit_stalker.rb"]

data/test/mit_stalker_test.rb

@@ -61,16 +61,31 @@ class MitStalkerTest < Test::Unit::TestCase
     end
   end
   
-  def test_refine_mitdir_response
+  def test_refine_mitdir_response_by_name
     flexmock(MitStalker).should_receive(:finger).with('Y-li16', 'web.mit.edu').
-                         and_return(fixture('single_response.txt'))
+                         and_return(fixture('single_response.txt')).once
                          
     multi_response =
         MitStalker.parse_mitdir_response fixture('multi_response.txt')
-    user = MitStalker.refine_mitdir_response multi_response, 'Yan Ping Li'
+    user = MitStalker.refine_mitdir_response_by_name multi_response,
+                                                     'Yan Ping Li'
     assert_equal 'costan@MIT.EDU', user[:email], 'Wrong user information'
   end
   
+  def test_refine_mitdir_response_by_email
+    flexmock(MitStalker).should_receive(:finger).with('V-costan', 'web.mit.edu').
+                         and_return(fixture('single_response.txt')).once
+    flexmock(MitStalker).should_receive(:finger).with('A-li', 'web.mit.edu').
+                         and_return(fixture('single_response2.txt')).once
+
+    mixed_response =
+        MitStalker.parse_mitdir_response fixture('mixed_response.txt')
+    user = MitStalker.refine_mitdir_response_by_email mixed_response.reverse,
+                                                     'aliceli'
+    assert user, 'No user returned'
+    assert_equal 'Li, Alice', user[:name]
+  end
+  
   def test_from_user_name
     assert_equal nil, MitStalker.from_user_name('no_such_user')
     

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mit_stalker
 version: !ruby/object:Gem::Version 
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors: 
 - Victor Costan
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-29 00:00:00 -04:00
+date: 2010-02-07 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency