mission_control-jobs 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2bba1e3be2d257eea8a3956ca3f6b8c9e6708f2fc81fe23290953ac66ecd79b0
-  data.tar.gz: c470df35a98c7f0f90163540dca2d3c8bd9ca14128ae283731c0e920fdae140e
+  metadata.gz: 4f358c4160d8065ff1069ba50a20305eaab8c6beebdca8eddb8a3426f3ea4771
+  data.tar.gz: 11e94ea39f4700cfa9a4d35eeb032e5bb721d62f6eb3b033911832737239a61a
 SHA512:
-  metadata.gz: 8a6068c3fa2f86d32f07fb458b644efb9e8e0661f1feb65e26bf41d4051bca594ab29d15819b9ab94051451015b1d051bf33b7152797c87ec1952a074f968b2c
-  data.tar.gz: 972eb81ce61459dcdd2e881ce88a5bf69da431f1b2a17ed6e10a3bf8572222f27b111035747c46492fc459b485542b5dfd072cfb04c4ae1dca6a0cbc5b73bc0c
+  metadata.gz: 35ef96bedf4688eb227212f910687239b2d2418935a27a450102351507bb0cf0abb6377d2a27e1f91b9985d638bac4263e18fc5a75806d2e35f721357818c939
+  data.tar.gz: 430fef8fade1f488a6a73f69600dd743d361f07e50cf6df8bbba38de0b152058ae8023bea962d51966558ae72de01024b399cb12113380d3d46a9e007623f25c

data/README.md

@@ -24,7 +24,7 @@ Rails.application.routes.draw do
   mount MissionControl::Jobs::Engine, at: "/jobs"
 ```
 
-And that's it. With this alone, you should be able to access Mission Control Job's UI, where you can browse the existing queues, jobs pending in these queues, jobs in different statuses, and discard and retry failed jobs:
+Once you set up [Authentication](#authentication), you should be able to access Mission Control Job's UI, where you can browse the existing queues, jobs pending in these queues, jobs in different statuses, and discard and retry failed jobs:
 
 ![Queues tab in a simple app](docs/images/queues-simple.png)
 
@@ -113,7 +113,9 @@ Besides `base_controller_class`, you can also set the following for `MissionCont
 - `internal_query_count_limit`: in count queries, the maximum number of records that will be counted if the adapter needs to limit these queries. True counts above this number will be returned as `INFINITY`. This keeps count queries fast—defaults to `500,000`
 - `scheduled_job_delay_threshold`: the time duration before a scheduled job is considered delayed. Defaults to `1.minute` (a job is considered delayed if it hasn't transitioned from the `scheduled` status 1 minute after the scheduled time).
 - `show_console_help`: whether to show the console help. If you don't want the console help message, set this to `false`—defaults to `true`.
+- `back_to_main_app_path`: an optional string path for the "Back to main app" link. Example: `'/admin'`. Defaults to the host app's `root_path` when available.
 - `backtrace_cleaner`: a backtrace cleaner used for optionally filtering backtraces on the Failed Jobs detail page. Defaults to `Rails::BacktraceCleaner.new`. See the [Advanced configuration](#advanced-configuration) section for how to configure/override this setting on a per application/server basis.
+- `filter_arguments`: an array of strings representing the job argument keys you want to filter out in the UI. This is useful for hiding sensitive user data. Currently, only root-level hash keys are supported.
 
 This library extends Active Job with a querying interface and the following setting:
 - `config.active_job.default_page_size`: the internal batch size that Active Job will use when sending queries to the underlying adapter and the batch size for the bulk operations defined above—defaults to `1000`.

data/app/controllers/concerns/mission_control/jobs/job_filters.rb

@@ -10,8 +10,8 @@ module MissionControl::Jobs::JobFilters
   private
     def set_filters
       @job_filters = {
-        job_class_name: params.dig(:filter, :job_class_name).presence,
-        queue_name: params.dig(:filter, :queue_name).presence,
+        job_class_name: params.dig(:filter, :job_class_name).to_s.strip.presence,
+        queue_name: params.dig(:filter, :queue_name).to_s.strip.presence,
         finished_at: finished_at_range_params
       }.compact
     end
@@ -36,6 +36,6 @@ module MissionControl::Jobs::JobFilters
     end
 
     def parse_with_time_zone(date)
-      DateTime.parse(date).in_time_zone if date.present?
+      Time.zone.parse(date) if date.present?
     end
 end

data/app/controllers/concerns/mission_control/jobs/not_found_redirections.rb

@@ -24,8 +24,11 @@ module MissionControl::Jobs::NotFoundRedirections
     end
 
     def best_location_for_resource_not_found_error(error)
-      if error.message.match?(/recurring task/i)
+      case error.message
+      when /recurring task/i
         application_recurring_tasks_path(@application)
+      when /queue/i
+        application_queues_path(@application)
       else
         root_url
       end

data/app/controllers/mission_control/jobs/application_controller.rb

@@ -9,6 +9,7 @@ class MissionControl::Jobs::ApplicationController < MissionControl::Jobs.base_co
   helper MissionControl::Jobs::ApplicationHelper unless self < MissionControl::Jobs::ApplicationHelper
   helper Importmap::ImportmapTagsHelper unless self < Importmap::ImportmapTagsHelper
 
+  include MissionControl::Jobs::HostRouteHelpers
   include MissionControl::Jobs::BasicAuthentication
   include MissionControl::Jobs::ApplicationScoped, MissionControl::Jobs::NotFoundRedirections
   include MissionControl::Jobs::AdapterFeatures
@@ -18,7 +19,7 @@ class MissionControl::Jobs::ApplicationController < MissionControl::Jobs.base_co
 
   private
     def default_url_options
-      { server_id: MissionControl::Jobs::Current.server }
+      super.merge(server_id: MissionControl::Jobs::Current.server)
     end
 
     def set_current_locale(&block)

data/app/controllers/mission_control/jobs/queues_controller.rb

@@ -11,6 +11,6 @@ class MissionControl::Jobs::QueuesController < MissionControl::Jobs::Application
 
   private
     def set_queue
-      @queue = ActiveJob.queues[params[:id]]
+      @queue = ActiveJob.queues[params[:id]] or raise MissionControl::Jobs::Errors::ResourceNotFound, "Queue '#{params[:id]}' not found"
     end
 end

data/app/helpers/mission_control/jobs/jobs_helper.rb

@@ -38,6 +38,10 @@ module MissionControl::Jobs::JobsHelper
     job.scheduled_at.before?(MissionControl::Jobs.scheduled_job_delay_threshold.ago)
   end
 
+  def blocked_job_expiration(job)
+    "Expires #{bidirectional_time_distance_in_words_with_title(job.blocked_until)}".html_safe if job.blocked_until
+  end
+
   private
     def renderable_job_arguments_for(job)
       job.serialized_arguments.collect do |argument|
@@ -67,7 +71,8 @@ module MissionControl::Jobs::JobsHelper
       elsif argument["_aj_serialized"]
         ActiveJob::Arguments.deserialize([ argument ]).first
       else
-        argument.without("_aj_symbol_keys", "_aj_ruby2_keywords")
+        MissionControl::Jobs.job_arguments_filter.apply_to(argument)
+          .without("_aj_symbol_keys", "_aj_ruby2_keywords")
           .transform_values { |v| as_renderable_argument(v) }
           .map { |k, v| "#{k}: #{v}" }
           .join(", ")

data/app/helpers/mission_control/jobs/navigation_helper.rb

@@ -1,6 +1,10 @@
 module MissionControl::Jobs::NavigationHelper
   attr_reader :page_title, :current_section
 
+  def back_to_main_app_path
+    MissionControl::Jobs.back_to_main_app_path.presence || main_app.try(:root_path)
+  end
+
   def navigation_sections
     { queues: [ "Queues", application_queues_path(@application) ] }.tap do |sections|
       supported_job_statuses.without(:pending).each do |status|

data/app/views/layouts/mission_control/jobs/_application_selection.html.erb

@@ -1,8 +1,8 @@
 <nav class="navbar" role="navigation" aria-label="main navigation">
   <div class="navbar-menu is-active mb-4">
     <div class="navbar-start">
-      <% if defined?(main_app.root_path) %>
-        <%= link_to "Back to main app", main_app.root_path %>
+      <% if (path = back_to_main_app_path) %>
+        <%= link_to "Back to main app", path %>
       <% end %>
     </div>
 

data/app/views/layouts/mission_control/jobs/application.html.erb

@@ -7,6 +7,7 @@
 
   <meta name="viewport" content="width=device-width,initial-scale=1">
   <meta name="turbo-cache-control" content="no-cache">
+  <meta name="turbo-prefetch" content="false">
 
   <%= stylesheet_link_tag "mission_control/jobs/bulma.min" %>
   <%= stylesheet_link_tag "mission_control/jobs/application", "data-turbo-track": "reload" %>

data/app/views/mission_control/jobs/jobs/_error_information.html.erb

@@ -14,9 +14,11 @@
     </tbody>
   </table>
 
-  <% if @server.backtrace_cleaner %>
-    <%= render "mission_control/jobs/jobs/failed/backtrace_toggle", application: @application, job: job %>
-  <% end %>
+  <%= turbo_frame_tag "job-backtrace" do %>
+    <% if @server.backtrace_cleaner %>
+      <%= render "mission_control/jobs/jobs/failed/backtrace_toggle", application: @application, job: job %>
+    <% end %>
 
-  <pre class="is-family-monospace mb-4 backtrace-content"><%= failed_job_backtrace(job, @server) %></pre>
+    <pre class="is-family-monospace mb-4 backtrace-content"><%= failed_job_backtrace(job, @server) %></pre>
+  <% end %>
 <% end %>

data/app/views/mission_control/jobs/jobs/_general_information.html.erb

@@ -26,6 +26,12 @@
       <%= time_distance_in_words_with_title(job.enqueued_at.to_datetime) %> ago
     </td>
   </tr>
+  <% if job.executions > 0 %>
+    <tr>
+      <th>Retries</th>
+      <td><%= job.executions %></td>
+    </tr>
+  <% end %>
   <% if job.scheduled? %>
     <tr>
       <th>Scheduled</th>

data/app/views/mission_control/jobs/jobs/_raw_data.html.erb

@@ -1,4 +1,4 @@
 <h2 class="subtitle">Raw data</h2>
 <pre>
-  <%= JSON.pretty_generate(job.raw_data.without("backtrace")) %>
+  <%= JSON.pretty_generate(job.filtered_raw_data.without("backtrace")) %>
 </pre>

data/app/views/mission_control/jobs/jobs/blocked/_job.html.erb

@@ -1,7 +1,7 @@
 <td><%= link_to job.queue_name, application_queue_path(@application, job.queue) %></td>
 <td>
   <div class="is-family-monospace is-size-7"><%= job.blocked_by %></div>
-  <div class="has-text-grey is-size-7"><%= job.blocked_until ? "Expires #{bidirectional_time_distance_in_words_with_title(job.blocked_until)}" : "" %></div>
+  <div class="has-text-grey is-size-7"><%= blocked_job_expiration(job) %></div>
 </td>
 <td class="pr-0">
   <%= render "mission_control/jobs/jobs/blocked/actions", job: job %>

data/app/views/mission_control/jobs/jobs/scheduled/_job.html.erb

@@ -1,6 +1,9 @@
 <td><%= link_to job.queue_name, application_queue_path(@application, job.queue) %></td>
 <td>
   <%= bidirectional_time_distance_in_words_with_title(job.scheduled_at) %>
+  <% if job.executions > 0 %>
+    <div class="is-warning tag ml-4"><%= job.executions.ordinalize %> retry</div>
+  <% end %>
   <% if job_delayed?(job) %>
     <div class="is-danger tag ml-4">delayed</div>
   <% end %>

data/app/views/mission_control/jobs/queues/index.html.erb

@@ -1,7 +1,6 @@
 <% navigation(title: "Queues", section: :queues)  %>
 
 <table class="queues table is-hoverable is-fullwidth">
-  <tbody>
   <thead>
   <tr>
     <th>Queue</th>
@@ -10,6 +9,8 @@
   </tr>
   </thead>
 
+  <tbody>
+
   <%= render partial: "mission_control/jobs/queues/queue", collection: @queues %>
 
   </tbody>

data/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb

@@ -1,5 +1,7 @@
 <nav class="buttons is-right" role="navigation" aria-label="pagination">
   <span class="mr-3"><%= page.index %> / <%= page.pages_count || "..." %></span>
+  <%= link_to "↞", url_for(page: 1, **filter_param), class: "pagination-previous", disabled: page.first? %>
   <%= link_to "Previous page", url_for(page: page.previous_index, **filter_param), class: "pagination-previous", disabled: page.first? %>
   <%= link_to "Next page", url_for(page: page.next_index, **filter_param), class: "pagination-next", disabled: page.last? %>
+  <%= link_to "↠", url_for(page: page.pages_count, **filter_param), class: "pagination-next", disabled: page.last? %>
 </nav>

data/lib/active_job/job_proxy.rb

@@ -7,6 +7,8 @@ class ActiveJob::JobProxy < ActiveJob::Base
   class UnsupportedError < StandardError; end
 
   attr_reader :job_class_name
+  # Raw data with the sensitive user data filtered out.
+  attr_accessor :filtered_raw_data
 
   def initialize(job_data)
     super
@@ -25,7 +27,7 @@ class ActiveJob::JobProxy < ActiveJob::Base
   end
 
   def duration
-    finished_at - scheduled_at
+    finished_at - (scheduled_at || enqueued_at)
   end
 
   ActiveJob::JobsRelation::STATUSES.each do |status|

data/lib/active_job/jobs_relation.rb

@@ -26,7 +26,7 @@ class ActiveJob::JobsRelation
   FILTERS = %i[ queue_name job_class_name ]
 
   PROPERTIES = %i[ queue_name status offset_value limit_value job_class_name worker_id recurring_task_id finished_at ]
-  attr_reader *PROPERTIES, :default_page_size
+  attr_reader(*PROPERTIES, :default_page_size)
 
   delegate :last, :[], :reverse, to: :to_a
   delegate :logger, to: MissionControl::Jobs
@@ -61,7 +61,7 @@ class ActiveJob::JobsRelation
       finished_at: finished_at
     }.compact
 
-    clone_with **arguments
+    clone_with(**arguments)
   end
 
   def with_status(status)
@@ -219,7 +219,7 @@ class ActiveJob::JobsRelation
 
   private
     attr_reader :queue_adapter, :loaded_jobs
-    attr_writer *PROPERTIES
+    attr_writer(*PROPERTIES)
 
     def set_defaults
       self.offset_value = 0

data/lib/active_job/queue_adapters/resque_ext.rb

@@ -185,16 +185,29 @@ module ActiveJob::QueueAdapters::ResqueExt
         end
 
         def deserialize_resque_job(resque_job_hash, index)
-          args_hash = resque_job_hash.dig("payload", "args") || resque_job_hash.dig("args")
-          ActiveJob::JobProxy.new(args_hash&.first).tap do |job|
+          args_hash = extract_args_hash(resque_job_hash)
+          ActiveJob::JobProxy.new(args_hash).tap do |job|
             job.last_execution_error = execution_error_from_resque_job(resque_job_hash)
             job.raw_data = resque_job_hash
+            job.filtered_raw_data = filter_raw_data_arguments(resque_job_hash)
             job.position = jobs_relation.offset_value + index
             job.failed_at = resque_job_hash["failed_at"]&.to_datetime&.utc
             job.status = job.failed_at.present? ? :failed : :pending
           end
         end
 
+        def filter_raw_data_arguments(raw_data)
+          raw_data.deep_dup.tap do |filtered_data|
+            if args_hash = extract_args_hash(filtered_data)
+              args_hash["arguments"] = MissionControl::Jobs.job_arguments_filter.apply_to(args_hash["arguments"])
+            end
+          end
+        end
+
+        def extract_args_hash(raw_data)
+          (raw_data.dig("payload", "args") || raw_data.dig("args"))&.first
+        end
+
         def execution_error_from_resque_job(resque_job_hash)
           if resque_job_hash["exception"].present?
             ActiveJob::ExecutionError.new \

data/lib/active_job/queue_adapters/solid_queue_ext.rb

@@ -4,12 +4,14 @@ module ActiveJob::QueueAdapters::SolidQueueExt
 
   def queues
     queues = SolidQueue::Queue.all
-    pauses = SolidQueue::Pause.where(queue_name: queues.map(&:name)).index_by(&:queue_name)
+    queue_names = queues.map(&:name)
+    pauses = SolidQueue::Pause.where(queue_name: queue_names).index_by(&:queue_name)
+    sizes = SolidQueue::ReadyExecution.where(queue_name: queue_names).group(:queue_name).count
 
     queues.collect do |queue|
       {
         name: queue.name,
-        size: queue.size,
+        size: sizes[queue.name] || 0,
         active: pauses[queue.name].nil?
       }
     end
@@ -99,6 +101,7 @@ module ActiveJob::QueueAdapters::SolidQueueExt
         job.status = job_status
         job.last_execution_error = execution_error_from_solid_queue_job(solid_queue_job) if job_status == :failed
         job.raw_data = solid_queue_job.as_json
+        job.filtered_raw_data = filter_raw_data_arguments(job.raw_data)
         job.failed_at = solid_queue_job&.failed_execution&.created_at if job_status == :failed
         job.finished_at = solid_queue_job.finished_at
         job.blocked_by = solid_queue_job.concurrency_key
@@ -109,6 +112,12 @@ module ActiveJob::QueueAdapters::SolidQueueExt
       end
     end
 
+    def filter_raw_data_arguments(raw_data)
+      raw_data.deep_dup.tap do |filtered_raw_data|
+        filtered_raw_data["arguments"]["arguments"] = MissionControl::Jobs.job_arguments_filter.apply_to(filtered_raw_data.dig("arguments", "arguments"))
+      end
+    end
+
     def status_from_solid_queue_job(solid_queue_job)
       SolidQueueJobs::STATUS_MAP.invert[solid_queue_job.status]
     end
@@ -120,6 +129,11 @@ module ActiveJob::QueueAdapters::SolidQueueExt
           message: solid_queue_job.failed_execution.message,
           backtrace: solid_queue_job.failed_execution.backtrace || []
       end
+    rescue JSON::ParserError
+      ActiveJob::ExecutionError.new \
+        error_class: "",
+        message: solid_queue_job.failed_execution.error_before_type_cast,
+        backtrace: []
     end
 
     def dispatch_immediately(job)

data/lib/mission_control/jobs/arguments_filter.rb

@@ -0,0 +1,24 @@
+# Replaces argument values with [FILTERED] for any keys that match a filter.
+class MissionControl::Jobs::ArgumentsFilter
+  FILTERED = "[FILTERED]"
+
+  def initialize(filter)
+    @filter = filter
+  end
+
+  def apply_to(arguments)
+    case arguments
+    when Array
+      arguments.map { |a| apply_to(a) }
+    when Hash
+      arguments.map do |k, v|
+        [ k, filter.include?(k.to_s) ? FILTERED : v ]
+      end.to_h
+    else
+      arguments
+    end
+  end
+
+  private
+    attr_reader :filter
+end

data/lib/mission_control/jobs/engine.rb

@@ -34,12 +34,18 @@ module MissionControl
         end
       end
 
+      initializer "mission_control-jobs.host_route_helpers" do |app|
+        ActiveSupport.on_load(:after_routes_loaded) do
+          MissionControl::Jobs::HostRouteHelpers.define_from(app.routes, MissionControl::Jobs::Engine.routes)
+        end
+      end
+
       initializer "mission_control-jobs.http_basic_auth" do |app|
         MissionControl::Jobs.http_basic_auth_user ||= app.credentials.dig(:mission_control, :http_basic_auth_user)
         MissionControl::Jobs.http_basic_auth_password ||= app.credentials.dig(:mission_control, :http_basic_auth_password)
       end
 
-      initializer "mission_control-jobs.active_job.extensions" do
+      initializer "mission_control-jobs.active_job.extensions", before: "active_job.set_configs" do
         ActiveSupport.on_load :active_job do
           include ActiveJob::Querying
           include ActiveJob::Executing

data/lib/mission_control/jobs/host_route_helpers.rb

@@ -0,0 +1,33 @@
+# Route helpers of the host app that the engine doesn't define itself, routed through +main_app+.
+#
+# Mission Control's controllers inherit from the host app's +ApplicationController+ (see
+# +base_controller_class+), so host code such as a +before_action+ redirecting to
+# +new_session_path+ runs inside the engine, where route helpers resolve against the engine's
+# routes and raise +ActionController::UrlGenerationError+. This module defines, for every route
+# helper the host app has and the engine doesn't, a method delegating to the host app's routes,
+# so that code keeps working unchanged.
+#
+# Helpers defined by both, like +root_path+, keep resolving to the engine's, as in any isolated
+# engine; use +main_app.root_path+ for the host's.
+module MissionControl::Jobs::HostRouteHelpers
+  class << self
+    def define_from(host_routes, engine_routes)
+      undefine_all
+
+      (host_routes.named_routes.helper_names - engine_routes.named_routes.helper_names).each do |name|
+        define_method(name) { |*args| main_app.public_send(name, *args) }
+        defined_helpers << name
+      end
+    end
+
+    private
+      def undefine_all
+        defined_helpers.each { |name| remove_method(name) }
+        defined_helpers.clear
+      end
+
+      def defined_helpers
+        @defined_helpers ||= []
+      end
+  end
+end

data/lib/mission_control/jobs/version.rb

@@ -1,5 +1,5 @@
 module MissionControl
   module Jobs
-    VERSION = "1.1.0"
+    VERSION = "1.2.0"
   end
 end

data/lib/mission_control/jobs.rb

@@ -25,11 +25,18 @@ module MissionControl
 
     mattr_accessor :show_console_help, default: true
     mattr_accessor :backtrace_cleaner
+    mattr_accessor :back_to_main_app_path
 
     mattr_accessor :importmap, default: Importmap::Map.new
 
     mattr_accessor :http_basic_auth_user
     mattr_accessor :http_basic_auth_password
     mattr_accessor :http_basic_auth_enabled, default: true
+
+    mattr_accessor :filter_arguments, default: []
+
+    def self.job_arguments_filter
+      MissionControl::Jobs::ArgumentsFilter.new(filter_arguments)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mission_control-jobs
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Jorge Manrubia
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-11 00:00:00.000000000 Z
+date: 2026-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -465,6 +465,7 @@ files:
 - lib/mission_control/jobs/adapter.rb
 - lib/mission_control/jobs/application.rb
 - lib/mission_control/jobs/applications.rb
+- lib/mission_control/jobs/arguments_filter.rb
 - lib/mission_control/jobs/authentication.rb
 - lib/mission_control/jobs/console/connect_to.rb
 - lib/mission_control/jobs/console/context.rb
@@ -472,6 +473,7 @@ files:
 - lib/mission_control/jobs/engine.rb
 - lib/mission_control/jobs/errors/incompatible_adapter.rb
 - lib/mission_control/jobs/errors/resource_not_found.rb
+- lib/mission_control/jobs/host_route_helpers.rb
 - lib/mission_control/jobs/i18n_config.rb
 - lib/mission_control/jobs/identified_by_name.rb
 - lib/mission_control/jobs/identified_elements.rb