missing_validators 0.8.3 → 0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8965924e44993f7bfad6dcfd4a63917f544e417
-  data.tar.gz: 3a114c7b78f19d3384012dcefc5d7656514a5613
+  metadata.gz: 7fcaba1ca021815135f1424a4ba05e50bb43bcb8
+  data.tar.gz: e4c2defc413858dd7de4f324e5598f338c2289df
 SHA512:
-  metadata.gz: 3a6b1635cb5c6980b98cca25389c6f1b1a903197684d20ee4adb1de3e50674c50749d3dab2619cc50d3b31e05e353e44ee3f8fe3fa2dd262617a8e69b0edfaf3
-  data.tar.gz: 455faa6aa3d3a22b9ed992dc6d2a6bf4e9e67aff8391eca21e3ea86da435d9d0e14777cffe1841ddada8f1112557d5cf4edb999a002340148e270ec3145799d8
+  metadata.gz: 91854dee85dce2b8e089afe19dcb22a7c9a0e5a54d61ed09d6e457245a16e721f459d1f5e89943149672679878ba65795aa790de3f5e908e2e27bc05496b0e91
+  data.tar.gz: 81e974d943116e0561728a31cb9eff0b88f50961bf59219cf5b94b719f2c2420150782e4c94e2466f20f081ef68c6271a2cc0c8ae51a0172d1566d20ae335a98

data/config/locales/en.yml

@@ -1,11 +1,12 @@
 en:
   errors:
     messages:
-      inequality: "can't be equal to %{attr}"
-      email: "isn't a valid email address"
-      url: "isn't a valid URL"
-      mac_address: "isn't a valid MAC address"
-      longitude: "isn't a valid longitude"
+      imei: "is not a valid IMEI"
+      inequality: "cannot be equal to %{attr}"
+      email: "is not a valid email address"
+      url: "is not a valid URL"
+      mac_address: "is not a valid MAC address"
+      longitude: "is not a valid longitude"
   missing_validators:
     matchers:
       ensure_inequality_of:

data/lib/missing_validators.rb

@@ -11,3 +11,5 @@ require 'missing_validators/validators/mac_address_validator'
 require 'missing_validators/matchers/ensure_valid_mac_address_format_of' if defined?(RSpec)
 require 'missing_validators/validators/longitude_validator'
 require 'missing_validators/validators/latitude_validator'
+require 'missing_validators/validators/imei_validator'
+require 'missing_validators/matchers/ensure_valid_imei_format_of' if defined?(RSpec)

data/lib/missing_validators/matchers/ensure_valid_imei_format_of.rb

@@ -0,0 +1,20 @@
+RSpec::Matchers.define :ensure_valid_imei_format_of do |attribute|
+  match do |model|
+    model.send("#{attribute}=", "invalid.imei")
+    model.valid?
+
+    if model.errors.has_key?(attribute)
+      model.errors[attribute].include?(I18n.t('errors.messages.imei'))
+    end
+  end
+
+  failure_message_for_should do |model|
+    I18n.t 'missing_validators.matchers.ensure_valid_imei_format_of.failure_message_for_should',
+      model: model.class
+  end
+
+  failure_message_for_should_not do |model|
+    I18n.t 'missing_validators.matchers.ensure_valid_imei_format_of.failure_message_for_should_not',
+      model: model.class
+  end
+end

data/lib/missing_validators/validators/imei_validator.rb

@@ -0,0 +1,50 @@
+# Allows to check if the value of a specific attribute is a valid IMEI address.
+#
+# @example Validate that the device IMEI address is valid.
+#   class Device << ActiveRecord::Base
+#     attr_accessor :imei
+#     validates :imei, imei: true
+#   end
+class ImeiValidator < ActiveModel::EachValidator
+  # Checks if an attribute value is a valid IMEI address.
+  #
+  # @param [Object] record object to validate
+  # @param [String] attribute name of the object attribute to validate
+  # @param [Object] value attribute value
+  def validate_each(record, attribute, value)
+    allow_blank = options[:allow_blank] || false
+    return if allow_blank && value.blank?
+
+    unless valid?(value.to_s, options)
+      record.errors[attribute] << (options[:message] || I18n.t('errors.messages.imei'))
+    end
+  end
+
+  def self.validate_format(imei_number)
+    !!(imei_number =~ /\A[\d\.\:\-\s]+\z/i) # 356843052637512 or 35-6843052-637512 or 35.6843052.637512
+  end
+
+  def self.luhn_valid?(input)
+    numbers = input.gsub(/\D/, '').reverse
+
+    sum, i = 0, 0
+
+    numbers.each_char do |ch|
+      n = ch.to_i
+      n *= 2 if i.odd?
+      n = 1 + (n - 10) if n >= 10
+
+      sum += n
+      i   += 1
+    end
+
+    (sum % 10).zero?
+  end
+
+  private
+
+  def valid?(imei, options)
+    self.class.validate_format(imei) \
+      && self.class.luhn_valid?(imei)
+  end
+end

data/lib/missing_validators/version.rb

@@ -1,5 +1,5 @@
 # Provides a collection of custom validators that are often required in Rails applications.
 module MissingValidators
   # Gem version.
-  VERSION = "0.8.3"
+  VERSION = "0.9"
 end

data/missing_validators.gemspec

@@ -5,7 +5,7 @@ Gem::Specification.new do |gem|
   gem.authors       = ["Andrew Gridnev"]
   gem.email         = ["andrew.gridnev@gmail.com"]
   gem.summary       = %q{Adds some handy validators.}
-  gem.description   = %q{Validates email addresses, URLs, MAC addresses and inequality of attributes.}
+  gem.description   = %q{Validates email addresses, URLs, IMEI, MAC addresses and inequality of attributes.}
   gem.homepage      = "https://github.com/andrewgr/missing_validators/"
   gem.license = 'MIT'
 
@@ -16,9 +16,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = MissingValidators::VERSION
 
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'shoulda-matchers'
-
   gem.add_dependency 'activemodel', '> 3.0.0'
   gem.add_dependency 'activesupport', '> 3.0.0'
+
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'shoulda-matchers'
 end

data/spec/spec_helper.rb

@@ -1,8 +1,5 @@
 require 'missing_validators'
+require 'shoulda/matchers/active_record'
 require 'shoulda-matchers'
 
 I18n.load_path << File.expand_path("../../config/locales/en.yml", __FILE__)
-
-RSpec.configure do |config|
-  config.mock_with :rspec
-end

data/spec/validators/imei_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe ImeiValidator do
+  context "IMEI has valid format" do
+    let(:klass) do
+      Class.new do
+        include ActiveModel::Validations
+        attr_accessor :imei, :name
+        validates :imei, imei: true
+      end
+    end
+
+    subject { klass.new }
+
+    it { should ensure_valid_imei_format_of(:imei) }
+    it { should_not ensure_valid_imei_format_of(:name) }
+
+    it { should allow_value(356843052637512).for(:imei) }
+    it { should allow_value("356843052637512").for(:imei) }
+    it { should allow_value("35-684305-2637512").for(:imei) }
+    it { should allow_value("35-684305.263.7512").for(:imei) }
+
+    context "value too short" do
+      it { should_not allow_value("3568430537512").for(:imei) }
+      it { should_not allow_value("3").for(:imei) }
+    end
+
+    it "can't be too long" do
+      should_not allow_value("35684305263751233").for(:imei)
+    end
+
+    context "checksum doesn't match" do
+      it { should_not allow_value("356843052637513").for(:imei) }
+      it { should_not allow_value("156843052637512").for(:imei) }
+    end
+
+    it { should_not allow_value("invalid").for(:imei) }
+  end
+end

metadata

@@ -1,72 +1,73 @@
 --- !ruby/object:Gem::Specification
 name: missing_validators
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: '0.9'
 platform: ruby
 authors:
 - Andrew Gridnev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-22 00:00:00.000000000 Z
+date: 2014-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '>'
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 3.0.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '>'
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '>'
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 3.0.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '>'
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
-description: Validates email addresses, URLs, MAC addresses and inequality of attributes.
+        version: '0'
+description: Validates email addresses, URLs, IMEI, MAC addresses and inequality of
+  attributes.
 email:
 - andrew.gridnev@gmail.com
 executables: []
@@ -84,9 +85,11 @@ files:
 - lib/missing_validators.rb
 - lib/missing_validators/matchers/ensure_inequality_of_matcher.rb
 - lib/missing_validators/matchers/ensure_valid_email_format_of.rb
+- lib/missing_validators/matchers/ensure_valid_imei_format_of.rb
 - lib/missing_validators/matchers/ensure_valid_mac_address_format_of.rb
 - lib/missing_validators/matchers/ensure_valid_url_format_of.rb
 - lib/missing_validators/validators/email_validator.rb
+- lib/missing_validators/validators/imei_validator.rb
 - lib/missing_validators/validators/inequality_validator.rb
 - lib/missing_validators/validators/latitude_validator.rb
 - lib/missing_validators/validators/longitude_validator.rb
@@ -96,6 +99,7 @@ files:
 - missing_validators.gemspec
 - spec/spec_helper.rb
 - spec/validators/email_validator_spec.rb
+- spec/validators/imei_spec.rb
 - spec/validators/inequality_validator_spec.rb
 - spec/validators/latitude_validator_spec.rb
 - spec/validators/longitude_validator_spec.rb
@@ -128,6 +132,7 @@ summary: Adds some handy validators.
 test_files:
 - spec/spec_helper.rb
 - spec/validators/email_validator_spec.rb
+- spec/validators/imei_spec.rb
 - spec/validators/inequality_validator_spec.rb
 - spec/validators/latitude_validator_spec.rb
 - spec/validators/longitude_validator_spec.rb