missing_validators 0.4.0 → 0.4.1

data/README.md

@@ -67,6 +67,12 @@ Or any ruby class:
       validates :blog, url: true
     end
 
+You can specify domains to which the URL domain should belong in one of the folowing ways:
+
+    validates :url, url: { domains: 'com' }
+    validates :url, url: { domains: :com }
+    validates :url, url: { domains: [:com, 'edu'] }
+
 RSpec matcher is also available for your convenience:
 
     describe User do

data/lib/missing_validators/validators/email_validator.rb

@@ -16,7 +16,7 @@ class EmailValidator < ActiveModel::EachValidator
     return if allow_blank && value.blank?
 
     domains = Array.wrap(options[:domain])
-    email = value && value.downcase
+    email = value && value.downcase || ''
     in_valid_domain = domains.empty? ? true : domains.any? { |domain| email.end_with?(".#{domain.downcase}") }
 
     has_valid_format = !!(value =~ /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i)

data/lib/missing_validators/version.rb

@@ -1,5 +1,5 @@
 # Provides a collection of custom validators that are often required in Rails applications.
 module MissingValidators
   # Gem version.
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/spec/validators/email_validator_spec.rb

@@ -25,20 +25,23 @@ describe EmailValidator do
       let(:klass) do
         Class.new do
           include ActiveModel::Validations
-          attr_accessor :email
+          attr_accessor :email, :name
           validates :email, email: { domain: "edu" }
         end
       end
 
       it { should allow_value("user@example.edu").for(:email) }
       it { should_not allow_value("user@example.com").for(:email) }
+
+      it { should ensure_valid_email_format_of(:email) }
+      it { should_not ensure_valid_email_format_of(:name) }
     end
 
     context "email set as an array of strings and symbols" do
       let(:klass) do
         Class.new do
           include ActiveModel::Validations
-          attr_accessor :email
+          attr_accessor :email, :name
           validates :email, email: { domain: ['com', :edu, 'Com.Au'] }
         end
       end
@@ -48,6 +51,9 @@ describe EmailValidator do
       it { should allow_value("user@example.com.au").for(:email) }
       it { should allow_value("user@example.Com.Au").for(:email) }
       it { should_not allow_value("user@example.org").for(:email) }
+
+      it { should ensure_valid_email_format_of(:email) }
+      it { should_not ensure_valid_email_format_of(:name) }
     end
   end
 end

data/spec/validators/url_validator_spec.rb

@@ -35,38 +35,44 @@ describe UrlValidator do
     it { should_not allow_value("http://user_example.a").for(:url) }
   end
 
-  context "url is in the specified domain" do
-    let(:klass) do
-      Class.new do
-        include ActiveModel::Validations
-        attr_accessor :url, :name
-        validates :url, url: { domain: :org }
+  context "url is in the specific domain" do
+    context "url specified as symbol" do
+      let(:klass) do
+        Class.new do
+          include ActiveModel::Validations
+          attr_accessor :url, :name
+          validates :url, url: { domain: :org }
+        end
       end
-    end
 
-    subject { klass.new }
+      subject { klass.new }
 
-    it { should ensure_valid_url_format_of(:url) }
-    it { should allow_value("http://example.org").for(:url) }
-    it { should_not allow_value("http://example.com").for(:url) }
-  end
+      it { should ensure_valid_url_format_of(:url) }
+      it { should_not ensure_valid_url_format_of(:name) }
 
-  context "email set as an array of strings and symbols" do
-    let(:klass) do
-      Class.new do
-        include ActiveModel::Validations
-        attr_accessor :url, :name
-        validates :url, url: { domain: [:org, 'edu', 'Com.Au'] }
-      end
+      it { should allow_value("http://example.org").for(:url) }
+      it { should_not allow_value("http://example.com").for(:url) }
     end
 
-    subject { klass.new }
+    context "url specified as array of strings and symbols" do
+      let(:klass) do
+        Class.new do
+          include ActiveModel::Validations
+          attr_accessor :url, :name
+          validates :url, url: { domain: [:org, 'edu', 'Com.Au'] }
+        end
+      end
 
-    it { should ensure_valid_url_format_of(:url) }
-    it { should allow_value("http://example.org").for(:url) }
-    it { should allow_value("http://example.edu").for(:url) }
-    it { should allow_value("http://example.com.au").for(:url) }
-    it { should allow_value("http://example.Com.Au").for(:url) }
-    it { should_not allow_value("http://example.com").for(:url) }
+      subject { klass.new }
+
+      it { should ensure_valid_url_format_of(:url) }
+      it { should_not ensure_valid_url_format_of(:name) }
+
+      it { should allow_value("http://example.org").for(:url) }
+      it { should allow_value("http://example.edu").for(:url) }
+      it { should allow_value("http://example.com.au").for(:url) }
+      it { should allow_value("http://example.Com.Au").for(:url) }
+      it { should_not allow_value("http://example.com").for(:url) }
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: missing_validators
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2013-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70241132959780 !ruby/object:Gem::Requirement
+  requirement: &70201404629460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70241132959780
+  version_requirements: *70201404629460
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
-  requirement: &70241132957560 !ruby/object:Gem::Requirement
+  requirement: &70201404627380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70241132957560
+  version_requirements: *70201404627380
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70241132955500 !ruby/object:Gem::Requirement
+  requirement: &70201404625320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70241132955500
+  version_requirements: *70201404625320
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70241132954740 !ruby/object:Gem::Requirement
+  requirement: &70201404624480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70241132954740
+  version_requirements: *70201404624480
 description: Adds some handy validators.
 email:
 - andrew.gridnev@gmail.com