missing_translations 0.2.0 → 1.0.0

data/README.md

@@ -1,6 +1,14 @@
 # missing_translations
 
-Shows missing I18n keys for Rails 3 application. It parses all view files searchign for ```t``` helper invocation. Currently only haml views suported.
+Shows missing I18n keys for Rails 3 application. It parses all view files searching for ```t``` helper invocation. ```HAML``` and ```ERB``` views are supported.
+
+## Installation
+
+Add the following line to your ```Gemfile```:
+
+```ruby
+gem 'missing_translations'
+```
 
 ## How to run
 

data/VERSION

@@ -1 +1 @@
-0.2.0
+1.0.0

data/lib/tasks/missing_translations.rb

@@ -1,25 +1,11 @@
 require 'hash_keys_dumper'
+require 'templates_parser'
 
 namespace :missing_translations do
   desc 'Shows I18n translation keys which are missing (according to view parsing)'
   task :show => :environment do
-    keys = Dir.glob('app/**/*.haml').map do |view|
-      file    = File.basename(view).gsub /^_?(.+?)\..+$/, '\1'
-      dir     = view.split('/')[-2]
-      context = "#{dir}.#{file}"
-
-      File.readlines(view).map do |line|
-        line.scan(/\s+t\s*\(?['"]([^#+]+?)['"]/i).map do |m|
-          arg = m[0]
-          if arg != '.'
-            arg[0] == '.' ? "en.#{context}#{arg}" : "en.#{arg}"
-          end
-        end
-      end
-    end
-    used_keys = keys.compact.flatten.compact.uniq
-
-    # puts used_keys
+    parser = TemplatesParser.new Dir.glob('app/**/*.haml') + Dir.glob('app/**/*.erb')
+    used_keys = parser.keys
 
     keys = Dir.glob('config/locales/*.yml').map { |locale| HashKeysDumper.dump YAML.load(File.read(locale)) }
     available_keys = keys.flatten

data/lib/templates_parser.rb

@@ -0,0 +1,32 @@
+class TemplatesParser
+  def initialize(files)
+    @files = files
+  end
+
+  def keys
+    keys = @files.map do |template|
+      file    = File.basename(template).gsub /^_?(.+?)\..+$/, '\1'
+      dir     = template.split('/')[-2]
+      context = "#{dir}.#{file}"
+
+      File.readlines(template).map { |line| line_keys(line, context) }
+    end
+
+    keys.compact.flatten.compact.uniq
+  end
+
+  private
+
+  def locale
+    'en'.freeze
+  end
+
+  def line_keys(line, context)
+    line.scan(/\W+t(ranslate)?\s*\(?['"]([^#]+?)['"]/i).map do |m|
+      arg = m[1]
+      if arg != '.'
+        arg[0] == '.' ? "#{locale}.#{context}#{arg}" : "#{locale}.#{arg}"
+      end
+    end
+  end
+end

data/missing_translations.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "missing_translations"
-  s.version = "0.2.0"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Andrey Chernih"]
-  s.date = "2012-12-02"
+  s.date = "2012-12-04"
   s.email = "andrey.chernih@gmail.com"
   s.extra_rdoc_files = [
     "LICENSE.txt",
@@ -28,9 +28,13 @@ Gem::Specification.new do |s|
     "lib/missing_translations.rb",
     "lib/railtie.rb",
     "lib/tasks/missing_translations.rb",
+    "lib/templates_parser.rb",
     "missing_translations.gemspec",
+    "spec/fixtures/template.erb",
+    "spec/fixtures/template.haml",
     "spec/lib/hash_keys_dumper_spec.rb",
-    "spec/spec_helper.rb"
+    "spec/spec_helper.rb",
+    "spec/templates_parser_spec.rb"
   ]
   s.homepage = "http://github.com/AndreyChernyh/missing_translations"
   s.licenses = ["MIT"]

data/spec/fixtures/template.erb

@@ -0,0 +1,4 @@
+<h1>Testing</h1
+
+<%= t('.testing') %>
+<%= t('.erb_translation') %>

data/spec/fixtures/template.haml

@@ -0,0 +1,13 @@
+%h1 Testing
+
+= t('.testing')
+#whatever = t('.whatever')
+
+= t("with #{another} interpolation")
+
+= t(".with_double_quotes")
+= t('global_scoped')
+
+= translate('long_helper_name')
+
+= #{t('multiple_occurences')} #{t('on_the_same_string')}

data/spec/templates_parser_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+require 'templates_parser'
+
+describe TemplatesParser do
+  let(:templates) { ['spec/fixtures/template.erb', 'spec/fixtures/template.haml'] }
+
+  subject { described_class.new templates }
+
+  its(:keys) { should include 'en.fixtures.template.testing' }
+  its(:keys) { should include 'en.fixtures.template.erb_translation' }
+  its(:keys) { should include 'en.fixtures.template.whatever' }
+  its(:keys) { should include 'en.fixtures.template.with_double_quotes' }
+  its(:keys) { should include 'en.global_scoped' }
+  its(:keys) { should include 'en.long_helper_name' }
+  its(:keys) { should include 'en.multiple_occurences' }
+  its(:keys) { should include 'en.on_the_same_string' }
+
+  it 'does not includes keys with string interpolation' do
+    subject.keys.each { |key| key.should_not include 'interpolation' }
+  end
+end

metadata

@@ -2,14 +2,14 @@
 name: missing_translations
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Andrey Chernih
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-02 00:00:00.000000000 Z
+date: 2012-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   prerelease: false
@@ -95,9 +95,13 @@ files:
 - lib/missing_translations.rb
 - lib/railtie.rb
 - lib/tasks/missing_translations.rb
+- lib/templates_parser.rb
 - missing_translations.gemspec
+- spec/fixtures/template.erb
+- spec/fixtures/template.haml
 - spec/lib/hash_keys_dumper_spec.rb
 - spec/spec_helper.rb
+- spec/templates_parser_spec.rb
 homepage: http://github.com/AndreyChernyh/missing_translations
 licenses:
 - MIT
@@ -112,7 +116,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1209027482231938804
+      hash: -513714428489032317
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: