misfit 0.0.1 → 0.0.2

data/CHANGELOG

@@ -1,2 +1,6 @@
+= 0.0.2
+  * Support for the way rspec instantiates errors in stubs
+	* Support for instantiation without error messages
+
 = 0.0.1
-  * Initial Release
+  * Initial Release

data/MIT-LICENSE

@@ -1,7 +1,7 @@
 Copyright 2012 Ian White
 
 This plugin was developed by Ian White (http://github.com/ianwhite)
-while working at Distinctive Doors (http://distinctivedoors.co.uk)
+while working at Distinctive Doors (http://distinctivedoors.co.uk/oss)
 who have kindly agreed to release this under the MIT-LICENSE.
 
 Permission is hereby granted, free of charge, to any person obtaining

data/README.md

@@ -1,14 +1,21 @@
-misfit
+misfit [![Build Status](https://secure.travis-ci.org/i2w/misfit.png?branch=master)](http://travis-ci.org/i2w/misfit)
 ======
 
 Flexible approach to handling exceptions in ruby (for library writers, or consumers).  Inspired by [Avdi Grim](http://avdi.org/)'s excellent book [Exceptional Ruby](http://exceptionalruby.com/).
 
-This was developed by [Ian White](http://github.com/ianwhite) while working at [Distinctive Doors](http://distinctivedoors.co.uk) who have kindly agreed to release this under the MIT-LICENSE.
+This was developed by [Ian White](http://github.com/ianwhite) while working at [Distinctive Doors](http://distinctivedoors.co.uk/oss) who have kindly agreed to release this under the MIT-LICENSE.
 
 Misfit allows any module to act like a ruby exception class and gives the ability to decorate any standard ruby exception, optionally adding data.
 
 Misfit also provides a mechanism to change the error handling policy from raising to something else
 
+Installation
+------------
+
+In your Gemfile:
+
+    gem 'misfit'
+    
 Why?
 ----
 
@@ -94,6 +101,17 @@ You can also optionally wrap and add data to any Error:
 
 `YourLib::Error.wrap &block` causes all raised exceptions to be wrapped as `YourLib::Error`
 
+Development
+-----------
+
+To run the specs, you can start from the last known good set of gem dependencies in Gemfile.lock.development:
+
+    git clone http://github.com/i2w/misfit
+    cd misfit
+    cp Gemfile.lock.development Gemfile.lock
+    bundle
+    bundle exec rake spec
+
 Other Examples of use:
 ----------------------
 
@@ -127,4 +145,9 @@ Other Examples of use:
     end
 
     # the resulting error will be an IOError, extended with MyIOError, and MyError, and will be rescued as such
-    raise MyIOError
+    raise MyIOError
+    
+License
+-------
+
+This project uses the MIT-LICENSE.

data/Rakefile

@@ -20,8 +20,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-Bundler::GemHelper.install_tasks
-
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
@@ -31,3 +29,14 @@ task :simplecov => [:simplecov_env, :spec]
 task :simplecov_env do ENV['SIMPLECOV'] = '1' end
 
 task :default => :spec
+
+Bundler::GemHelper.install_tasks
+
+task :release => :check_gemfile
+
+task :check_gemfile do
+  if File.exists?("Gemfile.lock") && File.read("Gemfile.lock") != File.read("Gemfile.lock.development")
+    cp "Gemfile.lock", "Gemfile.lock.development"
+    raise "** Gemfile.lock.development has been updated, please commit these changes."
+  end
+end

data/lib/misfit.rb

@@ -3,15 +3,15 @@ require 'active_support/core_ext'
 
 module Misfit
   extend ActiveSupport::Concern
-  
+
   included do inherit_from_misfit end
-  
+
   def self.exception_class
     StandardError
   end
-  
+
   attr_accessor :data
-  
+
   module ClassMethods
     # when called with an exception, makes the exception a <self>
     # when called with a block, any exceptions raised in the block will be wrapped as <self>
@@ -22,20 +22,20 @@ module Misfit
         wrap_exception *args
       end
     end
-    
-    def new message, data = nil, *backtrace
+
+    def new message = nil, data = nil, *backtrace
       wrap_exception exception_class.exception(message, *backtrace), data
     end
-    
-    def exception message, *args
+
+    def exception message = nil, *args
       new message, nil, *args
     end
-    
+
     def exception_class klass = nil
       @exception_class = klass if klass
       @exception_class
     end
-    
+
   private
     def wrap_exception exception, data = nil
       exception.tap do |e|
@@ -43,13 +43,13 @@ module Misfit
         e.data = data if data
       end
     end
-    
+
     def wrap_block
       yield
     rescue Exception => exception
       raise wrap_exception(exception)
     end
-    
+
     # when an exception module is included, set up this module
     # as an exception module itself, and 'inherit' the exception_class
     def inherit_from_misfit
@@ -58,4 +58,9 @@ module Misfit
       included do inherit_from_misfit end
     end
   end
-end
+
+  # this is here solely because of the way rspec instantiates exception objects in stubs
+  def initialize *args
+    super
+  end
+end

data/lib/misfit/version.rb

@@ -1,3 +1,3 @@
 module Misfit
-  VERSION = '0.0.1'
-end
+  VERSION = '0.0.2'
+end

data/spec/misfit_spec.rb

@@ -9,21 +9,21 @@ module MisfitSpec
   module Error
     include Misfit
   end
-  
+
   module FooError
     include Error
     exception_class RuntimeError
   end
-  
+
   module FazError
     include FooError
     exception_class IOError
   end
-  
+
   module BarError
     include FazError
   end
-  
+
   describe Misfit do
     describe 'Error (includes Misfit)' do
       subject { exception_module }
@@ -33,27 +33,35 @@ module MisfitSpec
       let(:data)             { 'exception data' }
 
       describe 'standard idioms' do
+        it 'raise <exception_module> should raise error with no message' do
+          expect { raise exception_module }.to raise_error(exception_module)
+        end
+
+        it 'exception_module.exception should return error with no message' do
+          exception_module.exception.should be_a(exception_module)
+        end
+
         describe 'raise <exception_module>, <message>' do
           subject { raise exception_module, message }
 
           it { expect{ subject }.to raise_error(StandardError, message) }
           it { expect{ subject }.to raise_error(exception_module, message) }
         end
-      
+
         describe 'raise <exception_module>.new(<message>)' do
           subject { raise exception_module.new(message) }
 
           it { expect{ subject }.to raise_error(StandardError, message) }
           it { expect{ subject }.to raise_error(exception_module, message) }
         end
-      
+
         describe 'raise <exception_module>.exception(<message>)' do
           subject { raise exception_module.exception(message) }
 
           it { expect{ subject }.to raise_error(StandardError, message) }
           it { expect{ subject }.to raise_error(exception_module, message) }
         end
-        
+
         describe 'FooError (includes Error, exception_class RuntimeError)' do
           let(:exception_module) { FooError }
 
@@ -65,7 +73,7 @@ module MisfitSpec
             it { expect{ subject }.to raise_error(RuntimeError, message) }
           end
         end
-        
+
         describe 'FazError (includes FooError, exception_class IOError)' do
           let(:exception_module) { FazError }
 
@@ -79,7 +87,7 @@ module MisfitSpec
             it { expect{ subject }.to raise_error(IOError, message) }
           end
         end
-        
+
         describe 'BarError (includes FazError)' do
           let(:exception_module) { BarError }
 
@@ -93,12 +101,20 @@ module MisfitSpec
             it { expect{ subject }.to raise_error(IOError, message) }
           end
         end
+
+        describe "used in specs" do
+          it "should work with stubs" do
+            object = Object.new
+            object.stub(:foo).and_raise(Error)
+            expect { object.foo }.to raise_error(Error)
+          end
+        end
       end
-      
+
       describe 'adding data' do
         describe 'raise <exception_module>.new <message>, <data>' do
           subject { raise exception_module.new(message, data) }
-                  
+
           it "should have data added to the exception" do
             begin
               subject
@@ -108,28 +124,28 @@ module MisfitSpec
           end
         end
       end
-      
+
       describe '#wrap' do
         describe 'RuntimeError.new(<message>)' do
           subject { exception_module.wrap RuntimeError.new(message) }
-          
+
           it { should be_a RuntimeError }
           it { should be_a exception_module }
           its(:message) { should == message }
         end
-        
+
         describe 'RuntimeError.new(<message>), <exception data>' do
           subject { exception_module.wrap RuntimeError.new(message), data }
-          
+
           it { should be_a RuntimeError }
           it { should be_a exception_module }
           its(:message) { should == message }
           its(:data) { should == data }
         end
-        
+
         describe '{ some_error_ridden_code! }' do
           subject { exception_module.wrap do some_error_ridden_code! end }
-            
+
           it { expect{ subject }.to raise_error(NoMethodError, /some_error_ridden_code!/) }
           it { expect{ subject }.to raise_error(exception_module, /some_error_ridden_code!/) }
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: misfit
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-16 00:00:00.000000000 Z
+date: 2012-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70193682798820 !ruby/object:Gem::Requirement
+  requirement: &70208106687180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *70193682798820
+  version_requirements: *70208106687180
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70193682798160 !ruby/object:Gem::Requirement
+  requirement: &70208106655660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70193682798160
+  version_requirements: *70208106655660
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70193682797400 !ruby/object:Gem::Requirement
+  requirement: &70208106654580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *70193682797400
+  version_requirements: *70208106654580
 description: Flexible approach to handling exceptions in ruby (for library writers,
   or consumers).  Ispired by Avdi Grimm's excellent book 'Exceptional Ruby'.
 email:
@@ -74,7 +74,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1488499911703821850
+      hash: 2688544848088413638
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -83,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1488499911703821850
+      hash: 2688544848088413638
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15