miscellany 0.1.18 → 0.1.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dea6efd8728954e80a8a249f749dd8133ecfcf71fb6b4a3b3acf248b662fca8
-  data.tar.gz: bd567ce813d303ca03d8d87f8faa4a312d2417b934bb1ee8c3d2781b99126f88
+  metadata.gz: e919c60e03780d5fab1a21ae6d528482db21d5a4fcfbc176b4808cc1d9acdc77
+  data.tar.gz: c9ecbbbb69e28e8fbef7aa9efe93db1cab9576634ede5ad2dc698180c1743dda
 SHA512:
-  metadata.gz: 66f32e979d580c4297c1155f6bc87203ec808420856636724a257d07ca062ffe5d5ecd073aaa0fa0b09efb781f033affce87faa579b0007bd7f4ffe46c82fda3
-  data.tar.gz: 54210f971ad74cd8d14b4934cb36d155943626b5e66190c682c294fdcd30f3b315cf2b5dbae268ce70a1213726e294978c80b080fdf8422bd1256a4f47dd3f37
+  metadata.gz: 7468e0d150c79e5ebfb5760648e97699c7b88340c68b7eaa530c58e512ee982eb1d2b44c2599b374a7348a5b9cefe7d7037603a98aa5a8a895f18bac6d4efe84
+  data.tar.gz: 0a7dfb9250e3f686d88f7c2932cbd1a8b07f0a38ae4d3e491e98ee4c14a22126bcf3defd58227130fe3a43f8cd7d0b5dbaf002f6ded24fd187706b445fcce28e

data/lib/miscellany/controller/sliced_response.rb

@@ -219,7 +219,7 @@ module Miscellany
 
       def sort_sql
         sorts = [ *Array(self.sort) ]
-        sorts << options[:sort_parser]&.default
+        sorts.push(*options[:sort_parser]&.default_sorts)
         sorts.compact!
 
         return nil unless sorts.present?

data/lib/miscellany/sort_lang.rb

@@ -23,6 +23,21 @@ module Miscellany
     end
 
     def self.sqlize(sorts)
+      seen_sorts = Set.new
+
+      # Only include each sort key/"column" once
+      sorts = sorts.select do |sort|
+        sid = sort[:key] || sort[:column]
+        next true unless sid.present?
+
+        if seen_sorts.include?(sid)
+          false
+        else
+          seen_sorts << sid
+          true
+        end
+      end
+
       sorts.map do |sort|
         order = sort[:order] || 'ASC'
         if sort[:column].is_a?(Proc)
@@ -45,12 +60,20 @@ module Miscellany
     class Parser
       class SortParsingError < StandardError; end
 
+      attr_reader :default_sorts
+
       def initialize(valid_sorts, default: nil)
-        @sorts_map = normalize_sort_options(valid_sorts, default: default)
-      end
+        @sorts_map = normalize_sort_options(valid_sorts)
+
+        @default_sorts = []
 
-      def default
-        @sorts_map[:default]
+        parsed_defaults = normalize_sort_options(Array(default))
+        parsed_defaults.each do |k,v|
+          @sorts_map[k] ||= v
+        end
+        @default_sorts = parsed_defaults.keys.map do |k|
+          @sorts_map[k]
+        end
       end
 
       def valid?(sortstr)
@@ -80,14 +103,16 @@ module Miscellany
           sort
         end
 
-        sorts << self.default if default == :append || default && !sorts.compact.present?
+        if default == :append || default && !sorts.compact.present?
+          sorts.push(*self.default_sorts)
+        end
 
         sorts.compact.presence
       end
 
       protected
 
-      def normalize_sort_options(sorts, default: nil)
+      def normalize_sort_options(sorts)
         norm_sorts = { }
 
         sorts.each do |s|
@@ -100,20 +125,9 @@ module Miscellany
           else
             sort_hash = normalize_sort(s)
             norm_sorts[sort_hash[:column]] = sort_hash
-            # default ||= sort_hash
           end
         end
 
-        if default.present?
-          norm_default = normalize_sort(default)
-          reference = norm_sorts[norm_default[:key].to_s] || norm_default
-          norm_sorts[:default] = {
-            key: reference[:key],
-            column: reference[:column],
-            order: norm_default[:order] || reference[:order],
-          }
-        end
-
         norm_sorts
       end
 

data/lib/miscellany/version.rb

@@ -1,3 +1,3 @@
 module Miscellany
-  VERSION = "0.1.18".freeze
+  VERSION = "0.1.19".freeze
 end

data/spec/miscellany/sort_lang_spec.rb

@@ -0,0 +1,124 @@
+
+require 'spec_helper'
+
+describe Miscellany::SortLang do
+
+  describe ".normalize_sort" do
+    it "accepts Hash KV pairs" do
+      expect(Miscellany::SortLang.normalize_sort(["key", { column: "created_at", order: "ASC" }])).to eql({
+        column: "created_at", force_order: false, key: "created_at", order: "ASC"
+      })
+    end
+
+    it "accepts strings" do
+      expect(Miscellany::SortLang.normalize_sort("created_at")).to eql({
+        column: "created_at", force_order: false, key: "created_at"
+      })
+      expect(Miscellany::SortLang.normalize_sort("created_at ASC")).to eql({
+        column: "created_at", force_order: false, key: "created_at", order: "ASC"
+      })
+      expect(Miscellany::SortLang.normalize_sort("created_at ASC!")).to eql({
+        column: "created_at", force_order: true, key: "created_at", order: "ASC"
+      })
+    end
+
+    it "accepts Procs" do
+      logic = ->(x) { "created_at #{x}" }
+      expect(Miscellany::SortLang.normalize_sort(logic, key: "k")).to eql({
+        column: logic, key: "k"
+      })
+    end
+  end
+
+  describe ".sqlize" do
+    it "only includes each sort key once" do
+      expect(Miscellany::SortLang.sqlize([
+        { column: "created_at", order: "ASC" },
+        { column: "created_at", order: "DESC" },
+      ])).to eql "created_at ASC NULLS FIRST"
+    end
+
+    describe "nulls: option" do
+      it "accepts a nulls: option" do
+        expect(Miscellany::SortLang.sqlize([
+          { column: "created_at", order: "ASC", nulls: :last },
+        ])).to eql "created_at ASC NULLS LAST"
+      end
+
+      it "nulls: :high works" do
+        expect(Miscellany::SortLang.sqlize([
+          { column: "created_at", order: "ASC", nulls: :high },
+        ])).to eql "created_at ASC NULLS LAST"
+        expect(Miscellany::SortLang.sqlize([
+          { column: "created_at", order: "DESC", nulls: :high },
+        ])).to eql "created_at DESC NULLS FIRST"
+      end
+
+      it "nulls: :low works" do
+        expect(Miscellany::SortLang.sqlize([
+          { column: "created_at", order: "ASC", nulls: :low },
+        ])).to eql "created_at ASC NULLS FIRST"
+        expect(Miscellany::SortLang.sqlize([
+          { column: "created_at", order: "DESC", nulls: :low },
+        ])).to eql "created_at DESC NULLS LAST"
+      end
+    end
+  end
+
+  describe Miscellany::SortLang::Parser do
+    let(:valid_sorts) {[
+      "title", "created_at"
+    ]}
+    let(:default_sort) { "title" }
+
+    let(:subject) { Miscellany::SortLang::Parser.new(valid_sorts, default: default_sort) }
+
+    context "with multiple default sorts" do
+      let(:default_sort) { ["title", "created_at"] }
+
+      it "includes each" do
+        expect(subject.parse(nil)).to eql [
+          {:column=>"title", :force_order=>false, :key=>"title"},
+          {:column=>"created_at", :force_order=>false, :key=>"created_at"},
+        ]
+      end
+    end
+
+    describe "#parse" do
+      it "excludes uknown sorts" do
+        expect(subject.parse("updated_at")).to eql [
+          {:column=>"title", :force_order=>false, :key=>"title"},
+        ]
+      end
+
+      it "considers force_order" do
+        subject = Miscellany::SortLang::Parser.new([ "title ASC!" ])
+        expect(subject.parse("title DESC")).to eql [
+          {:column=>"title", :force_order=>true, :key=>"title", :order=>"ASC"},
+        ]
+      end
+
+      it "returns the default sort if no sort is given" do
+        expect(subject.parse("")).to eql [
+          {:column=>"title", :force_order=>false, :key=>"title"},
+        ]
+        expect(subject.parse("", default: true)).to eql [
+          {:column=>"title", :force_order=>false, :key=>"title"},
+        ]
+      end
+
+      it "appends the default sort" do
+        expect(subject.parse("created_at", default: :append)).to eql [
+          {:column=>"created_at", :force_order=>false, :key=>"created_at"},
+          {:column=>"title", :force_order=>false, :key=>"title"},
+        ]
+      end
+
+      it "excludes the default sort" do
+        expect(subject.parse("created_at", default: false)).to eql [
+          {:column=>"created_at", :force_order=>false, :key=>"created_at"},
+        ]
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: miscellany
 version: !ruby/object:Gem::Version
-  version: 0.1.18
+  version: 0.1.19
 platform: ruby
 authors:
 - Ethan Knapp
@@ -149,6 +149,7 @@ files:
 - spec/miscellany/goldiload_value_spec.rb
 - spec/miscellany/param_validator_spec.rb
 - spec/miscellany/sliced_response_spec.rb
+- spec/miscellany/sort_lang_spec.rb
 - spec/spec_helper.rb
 homepage: https://instructure.com
 licenses: []
@@ -174,6 +175,7 @@ specification_version: 4
 summary: Gem for a bunch of random, re-usable Rails Concerns & Helpers
 test_files:
 - spec/db/database.yml
+- spec/miscellany/sort_lang_spec.rb
 - spec/miscellany/arbitrary_prefetch_spec.rb
 - spec/miscellany/sliced_response_spec.rb
 - spec/miscellany/param_validator_spec.rb