minuteman 0.2.0 → 1.0.0.pre

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    minuteman (0.2.0)
+    minuteman (1.0.0.pre)
       redis (~> 3.0.2)
 
 GEM

data/README.md

@@ -1,5 +1,6 @@
 # Minuteman
 [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/elcuervo/minuteman)
+[![Build Status](https://secure.travis-ci.org/elcuervo/minuteman.png?branch=master)](https://travis-ci.org/elcuervo/minuteman)
 
 _Wikipedia_: Minutemen were members of teams from Massachusetts that were well-prepared
 militia companies of select men from the American colonial partisan militia
@@ -40,13 +41,13 @@ Freenode - #cuba.rb - 2012/10/30 15:20 UYT
 Depends on Redis 2.6 for the `bitop` operation. You can install it using:
 
 ```bash
-brew install --devel redis
+brew install redis
 ```
 
 or upgrading your current version:
 
 ```bash
-brew upgrade --devel redis
+brew upgrade redis
 ```
 
 And then install the gem

data/lib/minuteman/bit_operations.rb

@@ -73,13 +73,19 @@ class Minuteman
       redis.getbit(key, id) == 1
     end
 
-    # Private: executes an operation between the current timespan and another
+    # Private: Cxecutes an operation between the current timespan and another
     #
     #   type:     The operation type
     #   timespan: The given timespan
     #
     def operation(type, timespan)
-      Operation.new(redis, type, self, timespan).call
+      operate.call(type, timespan)
+    end
+
+    # Private: Memoizes the operation class
+    #
+    def operate
+      @_operate ||= Operation.new(redis, self)
     end
   end
 end

data/lib/minuteman/bit_operations/operation.rb

@@ -10,25 +10,92 @@ class Minuteman
     #   timespan:   One of the timespans to be permuted
     #   other:      The other timespan to be permuted
     #
-    class Operation < Struct.new(:redis, :type, :timespan, :other)
-      def call
-        if type == "MINUS" && operable?
-          return timespan ^ (timespan & other)
+    class Operation < Struct.new(:redis, :timespan)
+      # Public: Caches operations against Array
+      #
+      class Cache
+        attr_reader :cache
+
+        def initialize
+          @cache = {}
+        end
+
+        # Public: Access a cached object
+        #
+        #   array: The original data set
+        #
+        def [](array)
+          cache.fetch(array.sort.hash)
         end
 
-        klass.new(redis, type, other, timespan.key).call
+        # Public: Caches an object
+        #
+        #   array:  The original data set
+        #   object: The object to be cached
+        #
+        def []=(array, object)
+          cache[array.sort.hash] = object
+        end
+
+        # Public: Checks for the existance of an array in the cache
+        #
+        #   array:  The original data set
+        #
+        def include?(array)
+          cache.keys.include?(array.sort.hash) if array.is_a?(Array)
+        end
+      end
+
+      attr_reader   :other
+      attr_accessor :cache
+
+      # Public: Initializes the Operation and starts the cache
+      #
+      def initialize(*)
+        super
+
+        @cache = Cache.new
+      end
+
+      # Public: Executes an operation
+      #
+      #   type: The string type of the operation
+      #   other: The other set to be operated, can be Array or BitOperations
+      #
+      def call(type, other)
+        @other = other
+
+        return minus_operation  if type == "MINUS" && operable?
+        return cache[other]     if cache.include?(other)
+
+        caching { klass.new(redis, type, other, timespan.key).call }
       end
 
       private
 
+      # Private: Executes a minus operation between the sets
+      #
+      def minus_operation
+        timespan ^ (timespan & other)
+      end
+
+      # Private: Caches any caching capable operation
+      #
+      def caching
+        executed_class = yield
+        cache[other] = executed_class if other.is_a?(Array)
+        executed_class
+      end
+
       # Private: returns the class to use for the operation
       #
       #   timespan: The given timespan
       #
       def klass
         case true
-        when other.is_a?(Array) then WithData
         when other.is_a?(String), operable? then Plain
+        when other.is_a?(Array) then WithData
+        else raise(TypeError, "Unsupported type")
         end
       end
 

data/lib/minuteman/bit_operations/plain.rb

@@ -22,6 +22,7 @@ class Minuteman
 
         key = destination_key(type, events)
         redis.bitop(type, key, events)
+
         Result.new(redis, key)
       end
     end

data/lib/minuteman/bit_operations/with_data.rb

@@ -25,7 +25,10 @@ class Minuteman
           redis.getbit(source_key, id) == 1
         end
 
-        intersected_data.each { |id| redis.setbit(key, id, 1) }
+        if !redis.exists(key)
+          intersected_data.each { |id| redis.setbit(key, id, 1) }
+        end
+
         Data.new(redis, key, intersected_data)
       end
     end

data/minuteman.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name              = "minuteman"
-  s.version           = "0.2.0"
+  s.version           = "1.0.0.pre"
   s.summary           = "Bit Analytics"
   s.description       = "Fast and furious tracking system using Redis bitwise operations"
   s.authors           = ["elcuervo"]

data/test/unit/minuteman_test.rb

@@ -152,7 +152,7 @@ describe Minuteman do
     assert_equal [43], ids
   end
 
-  it "a resulting set with data should behave like an array" do
+  it "should return a set with data that behaves like an array" do
     ids = @week_events & [2, 12, 43]
 
     assert_kind_of Enumerator, ids.each

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: minuteman
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 1.0.0.pre
+  prerelease: 6
 platform: ruby
 authors:
 - elcuervo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-14 00:00:00.000000000 Z
+date: 2012-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -91,9 +91,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23