minter-raccdoc 0.0.8 → 0.0.9

data/lib/raccdoc.rb

@@ -1,6 +1,6 @@
 module Raccdoc
   
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
   require 'socket'
   require 'time'
   
@@ -9,4 +9,13 @@ module Raccdoc
   require 'raccdoc/forum'
   require 'raccdoc/post'
 
+end
+
+class InvalidLogin < StandardError
+end
+
+class ConnectionError < StandardError
+end
+
+class ResponseError < StandardError
 end

data/lib/raccdoc/connection.rb

@@ -2,6 +2,7 @@ module Raccdoc
   class Connection
 
     attr_reader :host
+    attr_reader :post
 
     # Creates a new Raccdoc connection.  By default, it connects to bbs.iscabbs.com, port 6145, which is the
     # ISCABBS server.
@@ -17,22 +18,28 @@ module Raccdoc
       begin
         @socket = TCPSocket.new(args[:host],args[:port])
       rescue Errno::ECONNREFUSED
-        raise RuntimeError, "Could not connect to #{args[:host]}, port #{args[:port]}\n"
+        raise ConnectionError, "Could not connect to #{args[:host]}, port #{args[:port]}\n"
       end
 
-      response = @socket.readline.chomp
+      begin
+        response = @socket.readline.chomp
+      rescue EOFError
+        raise ConnectionError, "Got an unexpected EOF from the remote end"
+      end
+      
       unless response.match(/^2/)
-        raise RuntimeError, response
+        raise ConnectionError, response
       end
 
       if (args[:user] && args[:password])
         @socket.puts("LOGIN #{args[:user]}\t#{args[:password]}")
         response = @socket.readline.chomp
         unless response.match(/^2/)
-          raise RuntimeError, response
+          raise InvalidLogin, response
         end
       end
       @host = args[:host]
+      @port = args[:port]
     end
 
     # Closes the Raccdoc connection, then closes the socket.
@@ -42,7 +49,7 @@ module Raccdoc
 
         response = @socket.readline.chomp
         unless response.match(/^2/)
-          raise RuntimeError, response
+          raise ConnectionError, response
         end
         @socket.close
       end
@@ -77,7 +84,7 @@ module Raccdoc
 
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       while line = @socket.readline.chomp

data/lib/raccdoc/forum.rb

@@ -21,7 +21,7 @@ module Raccdoc
       @socket.puts "TOPIC #{forum.to_s}"
       response = @socket.readline.chomp
       unless response.match(/^2/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       @headers = {}
@@ -57,7 +57,7 @@ module Raccdoc
       @socket.puts("XHDR noteno #{range.to_s}")
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       while line = @socket.readline.chomp
@@ -79,7 +79,7 @@ module Raccdoc
       @socket.puts("SHOW info")
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       # Get header information
@@ -107,7 +107,7 @@ module Raccdoc
       @socket.puts("SETRC #{postid.to_s}")
       response = @socket.readline.chomp
       unless response.match(/^2/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
     end
 
@@ -116,7 +116,7 @@ module Raccdoc
       @socket.puts("SHOW rcval")
       response = @socket.readline.chomp
       unless response.match(/^2/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
       response.match(/\d+.*?:\s+(\d+)/)
       return $1
@@ -135,7 +135,7 @@ module Raccdoc
       @socket.puts("XHDR ALL #{range.to_s}")
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       posts = Hash.new
@@ -171,7 +171,7 @@ module Raccdoc
       @socket.puts("POST")
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       @socket.puts(body)
@@ -182,7 +182,7 @@ module Raccdoc
         postid = response.split(/:\s+/)[1]
         return Post.new(@socket,postid)
       else
-        raise RuntimeError, response
+        raise ResponseError, response
       end
     end
 
@@ -197,7 +197,7 @@ module Raccdoc
       elsif response.match(/^4/)
         return false
       else
-        raise RuntimeError, response
+        raise ResponseError, response
       end
     end
   end

data/lib/raccdoc/post.rb

@@ -22,7 +22,7 @@ module Raccdoc
       @socket.puts "READ #{postid.to_s} #{dammit}"
       response = @socket.readline.chomp
       unless response.match(/^3/)
-        raise RuntimeError, response
+        raise ResponseError, response
       end
 
       # Get header information
@@ -61,7 +61,7 @@ module Raccdoc
       elsif response.match(/^4/)
         return false
       else
-        raise RuntimeError, response
+        raise ResponseError, response
       end
     end
 
@@ -76,7 +76,7 @@ module Raccdoc
       elsif response.match(/^4/)
         return false
       else 
-        raise RuntimeError, response
+        raise ResponseError, response
       end
     end
   end

data/raccdoc.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{raccdoc}
-  s.version = "0.0.8"
+  s.version = "0.0.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["H. Wade Minter"]
-  s.date = %q{2009-01-14}
+  s.date = %q{2009-09-03}
   s.description = %q{A Ruby interface into the Raccdoc protocol}
   s.email = %q{minter@lunenburg.org}
   s.extra_rdoc_files = ["CHANGELOG", "lib/raccdoc/connection.rb", "lib/raccdoc/forum.rb", "lib/raccdoc/post.rb", "lib/raccdoc.rb", "LICENSE", "README.rdoc"]

data/test/raccdoc_connection_test.rb

@@ -16,7 +16,7 @@ class RaccdocConnectionTest < Test::Unit::TestCase
   
   def test_connection_refused_anonymous
     TCPSocket.expects(:new).with('test.bbs.example', '6145').raises(Errno::ECONNREFUSED)
-    assert_raise(RuntimeError, 'Could not connect to test.bbs.example, port 6145') do
+    assert_raise(ConnectionError, 'Could not connect to test.bbs.example, port 6145') do
       bbs = Raccdoc::Connection.new(:host => 'test.bbs.example')
     end
   end
@@ -26,7 +26,7 @@ class RaccdocConnectionTest < Test::Unit::TestCase
     socket.stubs(:readline).returns("200 Server started 	seed:Ci0B2YeMio8ftYjElTa+EQ==").then.returns("405 Cannot process login 	Invalid password")
     socket.stubs(:puts)
     TCPSocket.expects(:new).returns(socket)
-    assert_raise(RuntimeError, '404 User does not exist') do
+    assert_raise(InvalidLogin, '404 User does not exist') do
       bbs = Raccdoc::Connection.new(:host => 'test.bbs.example', :user => 'Bugcrusher', :password => 'BadPassword')
     end
   end
@@ -35,7 +35,7 @@ class RaccdocConnectionTest < Test::Unit::TestCase
     socket = mock()
     TCPSocket.expects(:new).returns(socket)
     socket.expects(:readline).returns("999 Stuff is messed up")
-    assert_raise(RuntimeError) do
+    assert_raise(ConnectionError) do
       bbs = Raccdoc::Connection.new(:host => 'test.bbs.example')
     end
   end
@@ -52,7 +52,7 @@ class RaccdocConnectionTest < Test::Unit::TestCase
     @socket.stubs(:close)
     @socket.stubs(:closed?).returns(false)
     @socket.stubs(:readline).returns("999 Something Broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ConnectionError) do
       @bbs.logout
     end
   end
@@ -74,7 +74,7 @@ class RaccdocConnectionTest < Test::Unit::TestCase
   
   def test_forums_failure
     @socket.stubs(:readline).returns("999 Stuff Broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       forums = @bbs.forums
     end
   end

data/test/raccdoc_forum_test.rb

@@ -21,7 +21,7 @@ class RaccdocForumTest < Test::Unit::TestCase
     socket = mock()
     socket.stubs(:puts)
     socket.stubs(:readline).returns('999 Stuff broke')
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       forum = Raccdoc::Forum.new(socket,0)
     end
   end
@@ -51,7 +51,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_noteids_failure
     @socket.stubs(:readline).returns("999 Stuff Broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       notes = @forum.noteids
     end
   end
@@ -64,7 +64,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_forum_information_failure
     @socket.stubs(:readline).returns("999 Stuff broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       fi = @forum.forum_information
     end
   end
@@ -76,7 +76,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_set_first_unread_fails
     @socket.stubs(:readline).returns('999 Stuff Broke')
-    assert_raises(RuntimeError) do
+    assert_raises(ResponseError) do
       @forum.first_unread=99999
     end
   end
@@ -89,7 +89,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_first_unread_fails
     @socket.stubs(:readline).returns("999 Stuff Broke")
-    assert_raises(RuntimeError) do
+    assert_raises(ResponseError) do
       first = @forum.first_unread
     end
   end
@@ -108,7 +108,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_post_headers_fail
     @socket.stubs(:readline).returns("999 Stuff broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       headers = @forum.post_headers
     end
   end
@@ -134,14 +134,14 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_create_post_early_failure
     @socket.stubs(:readline).returns('999 Stuff broke')
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       post = @forum.post("This is a test")
     end
   end
   
   def test_create_post_late_failure
     @socket.stubs(:readline).returns('350 Send note body 	maxsize:50000').then.returns('999 Stuff broke')
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       post = @forum.post("This is a test")
     end
   end
@@ -158,7 +158,7 @@ class RaccdocForumTest < Test::Unit::TestCase
   
   def test_okay_post_fail
     @socket.stubs(:readline).returns("999 Stuff broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       @forum.post?
     end
   end

data/test/raccdoc_post_test.rb

@@ -14,7 +14,7 @@ class RaccdocPostTest < Test::Unit::TestCase
   
   def test_post_object_creation_failure
     @socket.stubs(:readline).returns("410 No Such Note")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       @post = Raccdoc::Post.new(@socket, 9999)
     end
   end
@@ -33,7 +33,7 @@ class RaccdocPostTest < Test::Unit::TestCase
   
   def test_delete_exception
     @socket.stubs(:readline).returns("999 Stuff Broke")
-    assert_raise(RuntimeError) do 
+    assert_raise(ResponseError) do 
       status = @post.delete
     end
   end
@@ -52,7 +52,7 @@ class RaccdocPostTest < Test::Unit::TestCase
   
   def test_delete_permissions_exception
     @socket.stubs(:readline).returns("999 Stuff broke")
-    assert_raise(RuntimeError) do
+    assert_raise(ResponseError) do
       status = @post.delete?
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: minter-raccdoc
 version: !ruby/object:Gem::Version 
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors: 
 - H. Wade Minter
@@ -9,11 +9,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-14 00:00:00 -08:00
+date: 2009-09-03 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: echoe
+  type: :development
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: