minitest_to_rspec 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a44d60bad5a0cb758c25862d1737497fa1c7efe9
-  data.tar.gz: 406146633e3d0abefe4f02e88b0c1d48233f2e53
+  metadata.gz: faa035369b21f564bdb2b69d3bfe572d04ed7de6
+  data.tar.gz: 5e63cd797b3ebe3b82d8dc66a857576eb8ce3d87
 SHA512:
-  metadata.gz: da5f6a050e22ae6a74e9f7366cd7576a9d0ab297814aa9fa3426d8d663d3c0775744deb722870cade29b7841634d33477895c8f48bac9a3926929780fd753dbb
-  data.tar.gz: 573d6aa172492ab68373a441480eb0a2b65396c4c994193b91a84f48047c2db33c4238b4610d5415c90a611ddaf86015828452eaa29fb932edf0fb21fe34d777
+  metadata.gz: 4922f99d97fa6de7a3be364417916479b463f5e31295dd4b87cd85927aedc776530126721d12f40b995a564955adf9dbad9ea37d7594ad1e3687b33c85cbaa46
+  data.tar.gz: ed33dca73e303c2de5b989313e894f1bc8dac0c4df4c082e717c9ffd2d48b39e6d7ec3349bf9213142fc2ea4f4522feed61f5688125319ca87186b00bba3e38f

data/.rubocop.yml

@@ -2,5 +2,5 @@ inherit_from: .rubocop_todo.yml
 
 AllCops:
   Exclude:
-    - spec/fixtures/**/in.rb # we should lint out.rb though
+    - spec/fixtures/**/*
   TargetRubyVersion: 2.0

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
 rvm:
-  - "2.0.0-p598"
-  - "2.1.6"
-  - "2.2.2"
+  - "2.1.10"
+  - "2.2.6"
+  - "2.3.3"
+  - "2.4.0"
 script: bundle exec rake
 notifications:
   email: false

data/CHANGELOG.md

@@ -4,6 +4,23 @@ Change Log
 This project follows [semver 2.0.0][1] and the recommendations
 of [keepachangelog.com][2].
 
+0.8.0
+-----
+
+### Changed
+
+- No longer care about code style of output. See discussion in readme.
+- Drop support for ruby 2.0
+
+### Added
+
+- Update ruby_parser to 3.8 (was 3.7)
+- Use the official ruby2ruby instead of my sketchy sexp2ruby fork
+
+### Fixed
+
+None
+
 0.7.1
 -----
 

data/README.md

@@ -28,15 +28,17 @@ end
 Output:
 
 ```ruby
-require "spec_helper"
-RSpec.describe Array do
-  it "changes length" do
+require("spec_helper")
+RSpec.describe(Array) do
+  it("changes length") do
     ary = []
-    expect { ary.push(:x) }.to change { ary.length }
+    expect { ary.push(:x) }.to(change { ary.length })
   end
 end
 ```
 
+You might not like the code style of the output. More on that below.
+
 ## Install
 
 ```bash
@@ -63,10 +65,12 @@ converter.convert("assert('banana')")
 
 ## Output
 
-The primary goal is correctness, but [code style][34] is also important. To
-allow us to configure our output, we use [sexp2ruby][33] instead of
-[ruby2ruby][6]. As [sexp2ruby][33] adds more configuration options, we'll make
-use of them.
+The only goal is correctness. [Code style][34] is not a consideration.
+Providing the level of configuration necessary to make everyone happy would
+be a huge distraction from the main purpose.
+
+After conversion, I recommend using [rubocop][35]'s awesome `--auto-correct`
+feature to apply your preferred code style.
 
 Comments are discarded by [ruby_parser][14], so we have no way of
 preserving them.
@@ -112,7 +116,7 @@ To do: [at_least, never, raises, etc.][30]
 This project would not be possible without [ruby_parser][14],
 [sexp_processor][15], and [ruby2ruby][16] by [Ryan Davis][17].
 
-[1]: https://travis-ci.org/jaredbeck/minitest_to_rspec.svg
+[1]: https://travis-ci.org/jaredbeck/minitest_to_rspec.svg?branch=master
 [2]: https://travis-ci.org/jaredbeck/minitest_to_rspec
 [3]: https://codeclimate.com/github/jaredbeck/minitest_to_rspec/badges/gpa.svg
 [4]: https://codeclimate.com/github/jaredbeck/minitest_to_rspec
@@ -144,5 +148,5 @@ This project would not be possible without [ruby_parser][14],
 [30]: http://www.rubydoc.info/github/floehopper/mocha/Mocha/Expectation
 [31]: http://www.rubydoc.info/github/floehopper/mocha/Mocha/Expectation#once-instance_method
 [32]: http://www.rubydoc.info/github/floehopper/mocha/Mocha/Expectation#twice-instance_method
-[33]: https://github.com/jaredbeck/sexp2ruby
 [34]: https://github.com/bbatsov/ruby-style-guide
+[35]: https://github.com/bbatsov/rubocop

data/lib/minitest_to_rspec/converter.rb

@@ -1,24 +1,10 @@
 require "ruby_parser"
-require "sexp2ruby"
+require "ruby2ruby"
 require_relative "processor"
 require_relative "errors"
 
 module MinitestToRspec
   class Converter
-    NO_PAREN_METHODS = %i[
-      context
-      delete
-      describe
-      get
-      include
-      it
-      post
-      put
-      require
-      to
-      to_not
-    ]
-
     def initialize(rails: false, mocha: false)
       @processor = Processor.new(rails, mocha)
     end
@@ -53,10 +39,7 @@ module MinitestToRspec
     end
 
     def renderer
-      Sexp2Ruby::Processor.new(
-        hash_syntax: :ruby19,
-        no_paren_methods: NO_PAREN_METHODS
-      )
+      Ruby2Ruby.new
     end
   end
 end

data/lib/minitest_to_rspec/version.rb

@@ -1,3 +1,3 @@
 module MinitestToRspec
-  VERSION = "0.7.1".freeze
+  VERSION = "0.8.0".freeze
 end

data/minitest_to_rspec.gemspec

@@ -21,10 +21,10 @@ A command-line tool for converting minitest files to rspec.
     f.match(%r{^(test|spec|features)/})
   }
   spec.require_paths = ["lib"]
-  spec.required_ruby_version = ">= 2.0.0"
+  spec.required_ruby_version = ">= 2.1.0"
 
-  spec.add_runtime_dependency "ruby_parser", "~> 3.7"
-  spec.add_runtime_dependency "sexp2ruby", "~> 0.0.4"
+  spec.add_runtime_dependency "ruby_parser", "~> 3.8"
+  spec.add_runtime_dependency "ruby2ruby", "~> 2.3"
   spec.add_runtime_dependency "trollop", "~> 2.1"
 
   spec.add_development_dependency "bundler", "~> 1.7"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest_to_rspec
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Jared Beck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-09 00:00:00.000000000 Z
+date: 2017-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_parser
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
-  name: sexp2ruby
+  name: ruby2ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.4
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.4
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: trollop
   requirement: !ruby/object:Gem::Requirement
@@ -164,9 +164,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.4
-description: 'A command-line tool for converting minitest files to rspec.
-
-'
+description: |
+  A command-line tool for converting minitest files to rspec.
 email:
 - jared@jaredbeck.com
 executables:
@@ -186,7 +185,6 @@ files:
 - Rakefile
 - bin/console
 - bin/mt2rspec
-- doc/code_style.md
 - doc/minitest.md
 - doc/rspec.md
 - doc/supported_assertions.md
@@ -222,7 +220,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -230,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: Converts minitest files to rspec

data/doc/code_style.md

@@ -1,24 +0,0 @@
-Code Style
-==========
-
-The code style is mostly determined by [sexp2ruby][1],
-and is not configurable yet.
-
-To clean up the style a bit afterwards, here are some tips.
-
-1. Convert `be_truthy` to [predicate matchers][2].
-
-```
-Find: expect\((.*).valid\?\)\.to\(be_truthy\)
-Replace: expect($1).to be_valid
-```
-
-And the negated variant:
-
-```
-Find: expect\(\(not (.*).valid\?\)\)\.to\(be_truthy\)
-Replace: expect($1).to be_invalid
-```
-
-[1]: https://github.com/jaredbeck/sexp2ruby
-[2]: https://relishapp.com/rspec/rspec-expectations/v/3-2/docs/built-in-matchers/predicate-matchers