minitest 5.4.0 → 5.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac2144c0ad443090c5e70bf1e677da480f41d172
-  data.tar.gz: 2f1c4c6746de6356e3050c197bf8a951f32ce9ea
+  metadata.gz: 7423e740dff22f01e1867e48e30e6393029dcde6
+  data.tar.gz: c407e0bf946d70ad125e54810d919bf3301826f6
 SHA512:
-  metadata.gz: 199fa9620e73107f167829d9076c7fd4347f0ccab63a42490be4231c22e67327b8baec370cc1c2553b422f63fef47f2b707c326e155635c11118d3100cca827d
-  data.tar.gz: 946d1ee85f934a6770dcfabdf069d76e576c34127fc4bf20cc3f20993f2bd4f6b5be3215ed227f6ab725d5e290502d218ad7c7e43a2042ddc66522ba5a2d3393
+  metadata.gz: 16942f3e38beaa47570abeecbeedca6b44c55af0b992b854a886adfc38e0373d9cf2bb30a8181c33a33307858c920de28e3e0e2fbf9b62878484b11d2c994f6a
+  data.tar.gz: c54dd7ef0bc0c64fc696ac3421c24dc376a95fbac0aa49ea3d33026d3dfe7622417da65b9f9a1c930ac7649935011aba5070a7180ccc7ececf4d15fd1ffe196a

data/History.txt

@@ -1,3 +1,9 @@
+=== 5.4.1 / 2014-08-28
+
+* 1 bug fix:
+
+  * Fixed specs hidden by nesting/ordering bug (blowmage/apotonick)
+
 === 5.4.0 / 2014-07-07
 
 * 2 minor enhancements:

data/README.txt

@@ -422,6 +422,8 @@ minispec-metadata           :: Metadata for describe/it blocks
 minitest-ansi               :: Colorize minitest output with ANSI colors.
 minitest-around             :: Around block for minitest. An alternative to
                                setup/teardown dance.
+minitest-bang               :: Adds support for RSpec-style let! to immediately
+                               invoke let statements before each test.
 minitest-capistrano         :: Assertions and expectations for testing
                                Capistrano recipes.
 minitest-capybara           :: Capybara matchers support for minitest unit and
@@ -487,6 +489,7 @@ minitest-spec-expect        :: Expect syntax for Minitest::Spec (e.g.
 minitest-spec-magic         :: Minitest::Spec extensions for Rails and beyond.
 minitest-spec-rails         :: Drop in Minitest::Spec superclass for
                                ActiveSupport::TestCase.
+minitest-stately            :: Find leaking state between tests
 minitest-stub_any_instance  :: Stub any instance of a method on the given class
                                for the duration of a block.
 minitest-stub-const         :: Stub constants for the duration of a block.

data/lib/minitest.rb

@@ -7,7 +7,7 @@ require "minitest/parallel"
 # :include: README.txt
 
 module Minitest
-  VERSION = "5.4.0" # :nodoc:
+  VERSION = "5.4.1" # :nodoc:
 
   @@installed_at_exit ||= false
   @@after_run = []

data/lib/minitest/spec.rb

@@ -206,10 +206,12 @@ class Minitest::Spec < Minitest::Test
 
       name = "test_%04d_%s" % [ @specs, desc ]
 
+      undef_klasses = self.children.reject { |c| c.public_method_defined? name }
+
       define_method name, &block
 
-      self.children.each do |mod|
-        mod.send :undef_method, name if mod.public_method_defined? name
+      undef_klasses.each do |undef_klass|
+        undef_klass.send :undef_method, name
       end
 
       name

data/test/minitest/metametameta.rb

@@ -59,6 +59,7 @@ class MetaMetaMetaTestCase < Minitest::Test
 
     output.gsub!(/ = \d+.\d\d s = /, ' = 0.00 s = ')
     output.gsub!(/0x[A-Fa-f0-9]+/, '0xXXX')
+    output.gsub!(/ +$/, '')
 
     if windows? then
       output.gsub!(/\[(?:[A-Za-z]:)?[^\]:]+:\d+\]/, '[FILE:LINE]')
@@ -71,6 +72,15 @@ class MetaMetaMetaTestCase < Minitest::Test
     output
   end
 
+  def restore_env
+    old_value = ENV["MT_NO_SKIP_MSG"]
+    ENV.delete "MT_NO_SKIP_MSG"
+
+    yield
+  ensure
+    ENV["MT_NO_SKIP_MSG"] = old_value
+  end
+
   def setup
     super
     srand 42

data/test/minitest/test_minitest_reporter.rb

@@ -1,7 +1,7 @@
 require "minitest/autorun"
 require "minitest/metametameta"
 
-class TestMinitestReporter < Minitest::Test
+class TestMinitestReporter < MetaMetaMetaTestCase
 
   attr_accessor :r, :io
 
@@ -165,25 +165,6 @@ class TestMinitestReporter < Minitest::Test
     assert_equal 0, r.assertions
   end
 
-  def normalize_output output
-    output.sub!(/Finished in .*/, "Finished in 0.00")
-    output.sub!(/Loaded suite .*/, 'Loaded suite blah')
-
-    output.gsub!(/ = \d+.\d\d s = /, ' = 0.00 s = ')
-    output.gsub!(/0x[A-Fa-f0-9]+/, '0xXXX')
-    output.gsub!(/ +$/, '')
-
-    if windows? then
-      output.gsub!(/\[(?:[A-Za-z]:)?[^\]:]+:\d+\]/, '[FILE:LINE]')
-      output.gsub!(/^(\s+)(?:[A-Za-z]:)?[^:]+:\d+:in/, '\1FILE:LINE:in')
-    else
-      output.gsub!(/\[[^\]:]+:\d+\]/, '[FILE:LINE]')
-      output.gsub!(/^(\s+)[^:]+:\d+:in/, '\1FILE:LINE:in')
-    end
-
-    output
-  end
-
   def test_report_empty
     r.start
     r.report
@@ -200,7 +181,6 @@ class TestMinitestReporter < Minitest::Test
       0 runs, 0 assertions, 0 failures, 0 errors, 0 skips
     EOM
 
-
     assert_equal exp, normalize_output(io.string)
   end
 
@@ -221,7 +201,6 @@ class TestMinitestReporter < Minitest::Test
       1 runs, 0 assertions, 0 failures, 0 errors, 0 skips
     EOM
 
-
     assert_equal exp, normalize_output(io.string)
   end
 
@@ -246,7 +225,6 @@ class TestMinitestReporter < Minitest::Test
       1 runs, 0 assertions, 1 failures, 0 errors, 0 skips
     EOM
 
-
     assert_equal exp, normalize_output(io.string)
   end
 
@@ -276,16 +254,6 @@ class TestMinitestReporter < Minitest::Test
     assert_equal exp, normalize_output(io.string)
   end
 
-  def restore_env
-    old_value = ENV["MT_NO_SKIP_MSG"]
-    ENV.delete "MT_NO_SKIP_MSG"
-    
-    yield
-  ensure
-    ENV["MT_NO_SKIP_MSG"] = old_value
-  end
-
-
   def test_report_skipped
     r.start
     r.record skip_test

data/test/minitest/test_minitest_spec.rb

@@ -613,6 +613,40 @@ class TestMetaStatic < Minitest::Test
     assert_equal [], y.children
     assert_equal [], z.children
   end
+
+  def test_it_wont_remove_existing_child_test_methods
+    Minitest::Spec.children.clear # prevents parallel run
+
+    outer = inner = nil
+    outer = describe "outer" do
+      inner = describe "inner" do
+        it do
+          assert true
+        end
+      end
+      it do
+        assert true
+      end
+    end
+
+    assert_equal 1, outer.public_instance_methods.grep(/^test_/).count
+    assert_equal 1, inner.public_instance_methods.grep(/^test_/).count
+  end
+
+  def test_it_wont_add_test_methods_to_children
+    Minitest::Spec.children.clear # prevents parallel run
+
+    outer = inner = nil
+    outer = describe "outer" do
+      inner = describe "inner" do end
+      it do
+        assert true
+      end
+    end
+
+    assert_equal 1, outer.public_instance_methods.grep(/^test_/).count
+    assert_equal 0, inner.public_instance_methods.grep(/^test_/).count
+  end
 end
 
 require "minitest/metametameta"
@@ -746,6 +780,24 @@ class TestMeta < MetaMetaMetaTestCase
     assert_equal inner_methods2, z.instance_methods(false).sort.map(&:to_s)
   end
 
+  def test_structure_postfix_it
+    z = nil
+    y = describe "outer" do
+      # NOT here, below the inner-describe!
+      # it "inner-it" do end
+
+      z = describe "inner" do
+        it "inner-it" do end
+      end
+
+      # defined AFTER inner describe means we'll try to wipe out the inner-it
+      it "inner-it" do end
+    end
+
+    assert_equal %w(test_0001_inner-it), y.instance_methods(false).map(&:to_s)
+    assert_equal %w(test_0001_inner-it), z.instance_methods(false).map(&:to_s)
+  end
+
   def test_setup_teardown_behavior
     _, _, z, before_list, after_list = util_structure
 
@@ -764,12 +816,14 @@ class TestMeta < MetaMetaMetaTestCase
       y = describe "first thingy" do end
 
       x1 = it "top level it" do end
-      x2 = it "не латинские буквы-и-спецсимволы&いった α, β, γ, δ, ε hello!!! world" do end
+      x2 = it "не латинские &いった α, β, γ, δ, ε hello!!! world" do end
 
       z = describe "second thingy" do end
     end
 
-    test_methods = ["test_0001_top level it", "test_0002_не латинские буквы-и-спецсимволы&いった α, β, γ, δ, ε hello!!! world"].sort
+    test_methods = ["test_0001_top level it",
+                    "test_0002_не латинские &いった α, β, γ, δ, ε hello!!! world"
+                   ].sort
 
     assert_equal test_methods, [x1, x2]
     assert_equal test_methods,

data/test/minitest/test_minitest_unit.rb

@@ -239,16 +239,7 @@ class TestMinitestRunner < MetaMetaMetaTestCase
   end
 
   def test_run_failing
-    @tu =
-    Class.new Minitest::Test do
-      def test_something
-        assert true
-      end
-
-      def test_failure
-        assert false
-      end
-    end
+    setup_basic_tu
 
     expected = clean <<-EOM
       F.
@@ -265,7 +256,7 @@ class TestMinitestRunner < MetaMetaMetaTestCase
     assert_report expected
   end
 
-  def test_run_failing_filtered
+  def setup_basic_tu
     @tu =
     Class.new Minitest::Test do
       def test_something
@@ -276,6 +267,10 @@ class TestMinitestRunner < MetaMetaMetaTestCase
         assert false
       end
     end
+  end
+
+  def test_run_failing_filtered
+    setup_basic_tu
 
     expected = clean <<-EOM
       .
@@ -368,15 +363,6 @@ class TestMinitestRunner < MetaMetaMetaTestCase
     assert_report expected
   end
 
-  def restore_env
-    old_value = ENV["MT_NO_SKIP_MSG"]
-    ENV.delete "MT_NO_SKIP_MSG"
-
-    yield
-  ensure
-    ENV["MT_NO_SKIP_MSG"] = old_value
-  end
-
   def test_run_skip
     @tu =
     Class.new Minitest::Test do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.1
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   Y4evBVezr3SjXz08vPqRO5YRdO3zfeMT8gBjRqZjWJGMZ2lD4XNfrs7eky74CyZw
   xx3n58i0lQkBE1EpKE0lFu/y
   -----END CERTIFICATE-----
-date: 2014-07-07 00:00:00.000000000 Z
+date: 2014-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc