minitest 5.10.1 → 5.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 351bcef5cdca59a8a7698e72b0416aef86219192
-  data.tar.gz: 7710a72ed204d63809ae8f9dae5f0f88c0747dbe
+  metadata.gz: a068763ee667d9319f37090fc6dca04537d7bd28
+  data.tar.gz: 7bc8c8f4d5b7107276ca308ef8a60a70078b4b18
 SHA512:
-  metadata.gz: 4b72cb4785010a33c2865225f9e07bb586ead20c47da1c83d735734766c3029a18e85ea46b691489e0a7310bd36ffc6c67f16eec57c94128311cbb156919fde8
-  data.tar.gz: ce094ff893bfacd8afdff1b390c32799d95da6159f7e4f71c3d9665a5c0dbf629c36d23157e8940b779a51c18d9a0e50a832097c635b5bacfd9ee9d0879ad4ad
+  metadata.gz: eb2c6d2f22a6d3a4bd32f600494173714705d6941de1a7c3abb449bbd7e404ddf7a9b4b2bde463f52e24cf9e253c9d68ea729468c9b049dfcc9b52c4344bea28
+  data.tar.gz: f1d4e1a88113f44c4008f608c69f457c405483fd19c16e8a5851db57734f9331500694a27b75193eb2812811bead231c3689df7242cd6b81ad6bd3c9630ab578

data.tar.gz.sig

@@ -1,2 +1,2 @@
-�(�HR��O���:��ȡ�
.
ݎ
-/�&gR>�Q���`C&G���b�I������(ۧ�M��L2�a�Qx�����;^ӯ���W���K��8�U��|��~���
+#<@c��·�\
+%�����ֳ��C�#���� .�Y�ܫA����g���q~���K�
@/�t�9��Ǥ�l[�̿zB�M����c@��t؜<���d�!�-u�p+(��4����Z���Z���D�wIs�T�#�s��S�M@� C���"��o�l��]o�~��Ğ�LN�V��u�ϓ�I.O�����c���j�BJ�a�Ev���S���K�g�,1&�E)���U1�7)/���Z���t��'��F��

data/History.rdoc

@@ -1,3 +1,19 @@
+=== 5.10.2 / 2017-05-09
+
+* 1 minor enhancement:
+
+  * Added suggestion in minitest/hell to install minitest/proveit.
+
+* 7 bug fixes:
+
+  * Expand MT6 to Minitest 6. (xaviershay)
+  * Fixed location of assert_send deprecation. (rab)
+  * Fixed location of nil assert_equal deprecation to work with expectations. (jeremyevans)
+  * Fixed minitest/hell to use parallelize_me! (azul)
+  * Made deprecation use warn so -W0 will silence it.
+  * Workaround for rdoc nodoc generation bug that totally f'd up minitest doco. (Paxa)
+  * Write aggregated_results directly to the IO object to avoid mixed encoding errors. (tenderlove)
+
 === 5.10.1 / 2016-12-01
 
 * 1 bug fix:
@@ -6,13 +22,20 @@
 
 === 5.10.0 / 2016-11-30
 
-* 2 minor enhancements:
+* 1 major enhancement:
+
+  * Deprecated ruby 1.8, 1.9, possibly 2.0, assert_send, & old MiniTest namespace.
+
+* 3 minor enhancements:
 
+  * Warn if assert_equal expects a nil. This will fail in minitest 6+. (tenderlove)
   * Added AbstractReporter#prerecord and extended ProgressReporter and CompositeReporter to use it.
   * Minor optimization: remove runnables with no runnable methods before run.
 
-* 1 bug fix:
+* 3 bug fixes:
 
+  * Fix assert_throw rescuing any NameError and ArgumentError. (waldyr)
+  * Clean up (most of the) last remaining vestiges of minitest/unit.
   * 2.4: removed deprecation warnings when referring to Fixnum.
 
 === 5.9.1 / 2016-09-25

data/README.rdoc

@@ -285,9 +285,9 @@ provided via plugins. To see them, simply run with +--help+:
     % ruby -Ilib:test test/minitest/test_minitest_test.rb --help
     minitest options:
         -h, --help                       Display this help.
-        -s, --seed SEED                  Sets random seed
+        -s, --seed SEED                  Sets random seed. Also via env. Eg: SEED=n rake
         -v, --verbose                    Verbose. Show progress processing files.
-        -n, --name PATTERN               Filter run on /pattern/ or string.
+        -n, --name PATTERN               Filter run on /regexp/ or string.
         -e, --exclude PATTERN            Exclude /regexp/ or string from run.
 
     Known extensions: pride, autotest

data/lib/minitest.rb

@@ -2,12 +2,13 @@ require "optparse"
 require "thread"
 require "mutex_m"
 require "minitest/parallel"
+require "stringio"
 
 ##
 # :include: README.rdoc
 
 module Minitest
-  VERSION = "5.10.1" # :nodoc:
+  VERSION = "5.10.2" # :nodoc:
   ENCS = "".respond_to? :encoding # :nodoc:
 
   @@installed_at_exit ||= false
@@ -593,7 +594,7 @@ module Minitest
       io.puts unless options[:verbose] # finish the dots
       io.puts
       io.puts statistics
-      io.puts aggregated_results
+      aggregated_results io
       io.puts summary
     end
 
@@ -602,21 +603,20 @@ module Minitest
         [total_time, count / total_time, assertions / total_time]
     end
 
-    def aggregated_results # :nodoc:
+    def aggregated_results io # :nodoc:
       filtered_results = results.dup
       filtered_results.reject!(&:skipped?) unless options[:verbose]
 
-      s = filtered_results.each_with_index.map { |result, i|
-        "\n%3d) %s" % [i+1, result]
-      }.join("\n") + "\n"
-
-      s.force_encoding(io.external_encoding) if
-        ENCS and io.external_encoding and s.encoding != io.external_encoding
-
-      s
+      filtered_results.each_with_index { |result, i|
+        io.puts "\n%3d) %s" % [i+1, result]
+      }
+      io.puts
+      io
     end
 
-    alias to_s aggregated_results
+    def to_s
+      aggregated_results(StringIO.new(binary_string)).string
+    end
 
     def summary # :nodoc:
       extra = ""
@@ -627,6 +627,14 @@ module Minitest
       "%d runs, %d assertions, %d failures, %d errors, %d skips%s" %
         [count, assertions, failures, errors, skips, extra]
     end
+
+    private
+
+    if '<3'.respond_to? :b
+      def binary_string; ''.b; end
+    else
+      def binary_string; ''.force_encoding(Encoding::ASCII_8BIT); end
+    end
   end
 
   ##

data/lib/minitest/assertions.rb

@@ -177,7 +177,10 @@ module Minitest
         if Minitest::VERSION =~ /^6/ then
           refute_nil exp, "Use assert_nil if expecting nil."
         else
-          $stderr.puts "Use assert_nil if expecting nil from #{caller.first}. This will fail in MT6."
+          where = Minitest.filter_backtrace(caller).first
+          where = where.split(/:in /, 2).first # clean up noise
+
+          warn "DEPRECATED: Use assert_nil if expecting nil from #{where}. This will fail in Minitest 6."
         end
       end
 
@@ -367,7 +370,9 @@ module Minitest
     # Fails unless the call returns a true value
 
     def assert_send send_ary, m = nil
-      warn "DEPRECATED: assert_send. From #{caller.first}"
+      where = Minitest.filter_backtrace(caller).first
+      where = where.split(/:in /, 2).first # clean up noise
+      warn "DEPRECATED: assert_send. From #{where}"
 
       recv, msg, *args = send_ary
       m = message(m) {

data/lib/minitest/hell.rb

@@ -1,17 +1,11 @@
 require "minitest/parallel"
 
 class Minitest::Test
-  class << self
-    alias :old_test_order :test_order # :nodoc:
-
-    def test_order # :nodoc:
-      :parallel
-    end
-  end
+  parallelize_me!
 end
 
 begin
   require "minitest/proveit"
 rescue LoadError
-  # do nothing
+  warn "NOTE: `gem install minitest-proveit` for even more hellish tests"
 end

data/lib/minitest/test.rb

@@ -13,8 +13,10 @@ module Minitest
 
     PASSTHROUGH_EXCEPTIONS = [NoMemoryError, SignalException, SystemExit] # :nodoc:
 
-    class << self; attr_accessor :io_lock; end # :nodoc:
+    # :stopdoc:
+    class << self; attr_accessor :io_lock; end
     self.io_lock = Mutex.new
+    # :startdoc:
 
     ##
     # Call this at the top of your tests when you absolutely

data/test/minitest/metametameta.rb

@@ -25,7 +25,7 @@ class MetaMetaMetaTestCase < Minitest::Test
   def run_tu_with_fresh_reporter flags = %w[--seed 42]
     options = Minitest.process_args flags
 
-    @output = StringIO.new("")
+    @output = StringIO.new("".encode('UTF-8'))
 
     self.reporter = Minitest::CompositeReporter.new
     reporter << Minitest::SummaryReporter.new(@output, options)

data/test/minitest/test_minitest_reporter.rb

@@ -74,6 +74,12 @@ class TestMinitestReporter < MetaMetaMetaTestCase
     @st
   end
 
+  def test_to_s
+    r.record passing_test
+    r.record fail_test
+    assert_match "woot", r.first.to_s
+  end
+
   def test_passed_eh_empty
     assert r.passed?
   end

data/test/minitest/test_minitest_spec.rb

@@ -216,6 +216,21 @@ describe Minitest::Spec do
     end
   end
 
+  it "needs to warn on equality with nil" do
+    @assertion_count += 1 # extra test
+
+    out, err = capture_io do
+      nil.must_equal(nil).must_equal true
+    end
+
+    exp = "DEPRECATED: Use assert_nil if expecting nil from #{__FILE__}:#{__LINE__-3}. " \
+      "This will fail in Minitest 6.\n"
+    exp = "" if $-w.nil?
+
+    assert_empty out
+    assert_equal exp, err
+  end
+
   it "needs to verify floats outside a delta" do
     @assertion_count += 1 # extra test
 

data/test/minitest/test_minitest_test.rb

@@ -3,6 +3,18 @@
 require "pathname"
 require "minitest/metametameta"
 
+if defined? Encoding then
+  e = Encoding.default_external
+  if e != Encoding::UTF_8 then
+    warn ""
+    warn ""
+    warn "NOTE: External encoding #{e} is not UTF-8. Tests WILL fail."
+    warn "      Run tests with `RUBYOPT=-Eutf-8 rake` to avoid errors."
+    warn ""
+    warn ""
+  end
+end
+
 module MyModule; end
 class AnError < StandardError; include MyModule; end
 class ImmutableString < String; def inspect; super.freeze; end; end
@@ -66,6 +78,38 @@ class TestMinitestUnit < MetaMetaMetaTestCase
   #   assert_instance_of Minitest::Unit, Minitest::Unit.runner
   # end
 
+  def test_infectious_binary_encoding
+    @tu = Class.new Minitest::Test do
+      def test_this_is_not_ascii_assertion
+        assert_equal "ЁЁЁ", "ёёё"
+      end
+
+      def test_this_is_non_ascii_failure_message
+        fail 'ЁЁЁ'.force_encoding('ASCII-8BIT')
+      end
+    end
+
+    expected = clean <<-EOM
+      EF
+
+      Finished in 0.00
+
+        1) Error:
+      #<Class:0xXXX>#test_this_is_non_ascii_failure_message:
+      RuntimeError: ЁЁЁ
+          FILE:LINE:in `test_this_is_non_ascii_failure_message'
+
+        2) Failure:
+      #<Class:0xXXX>#test_this_is_not_ascii_assertion [FILE:LINE]:
+      Expected: \"ЁЁЁ\"
+        Actual: \"ёёё\"
+
+      2 runs, 1 assertions, 1 failures, 1 errors, 0 skips
+    EOM
+
+    assert_report expected
+  end
+
   def test_passed_eh_teardown_good
     test_class = Class.new FakeNamedTest do
       def teardown; assert true; end
@@ -989,6 +1033,7 @@ class TestMinitestUnitTestCase < Minitest::Test
       end
     else
       err_re = /Use assert_nil if expecting nil from .*test_minitest_test.rb/
+      err_re = "" if $-w.nil?
 
       assert_output "", err_re do
         @tc.assert_equal nil, nil
@@ -1448,7 +1493,9 @@ class TestMinitestUnitTestCase < Minitest::Test
   end
 
   def assert_deprecated name
-    dep = /DEPRECATED: #{name}. From #{__FILE__}:\d+:.*?/
+    dep = /DEPRECATED: #{name}. From #{__FILE__}:\d+(?::.*)?/
+    dep = "" if $-w.nil?
+
     assert_output nil, dep do
       yield
     end
@@ -1957,19 +2004,24 @@ class TestMinitestUnitRecording < MetaMetaMetaTestCase
       end
     end
 
-    self.reporter = Minitest::CompositeReporter.new
-    reporter << Class.new do
-      def start; end
-      # def prerecord klass, name; end
-      def record result; end
+    bogus_reporter = Class.new do      # doesn't subclass AbstractReporter
+      def start; @success = false; end
+      # def prerecord klass, name; end # doesn't define full API
+      def record result; @success = true; end
       def report; end
       def passed?; end
       def results; end
+      def success?; @success; end
     end.new
 
+    self.reporter = Minitest::CompositeReporter.new
+    reporter << bogus_reporter
+
     Minitest::Runnable.runnables.delete @tu
 
     @tu.run reporter, {}
+
+    assert_predicate bogus_reporter, :success?
   end
 
   def test_record_passing

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest
 version: !ruby/object:Gem::Version
-  version: 5.10.1
+  version: 5.10.2
 platform: ruby
 authors:
 - Ryan Davis
@@ -30,36 +30,36 @@ cert_chain:
   E4oJcnPkJAr0rw504JGtlZtONZQblwmRJOIdXzolaE3NRGUzGVOUSptZppAKiavY
   fO6tdKQc/5RfA8oQEkg8hrxA5PQSz4TOFJGLpFvIapEk6tMruQ0bHgkhr9auXg==
   -----END CERTIFICATE-----
-date: 2016-12-02 00:00:00.000000000 Z
+date: 2017-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
   name: hoe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '3.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '3.16'
 description: |-
   minitest provides a complete suite of testing facilities supporting
   TDD, BDD, mocking, and benchmarking.
@@ -123,7 +123,7 @@ extra_rdoc_files:
 - Manifest.txt
 - README.rdoc
 files:
-- .autotest
+- ".autotest"
 - History.rdoc
 - Manifest.txt
 - README.rdoc
@@ -155,23 +155,23 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --main
+- "--main"
 - README.rdoc
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: minitest provides a complete suite of testing facilities supporting TDD,