minitest 4.7.2 → 4.7.3

data/History.txt

@@ -1,3 +1,9 @@
+=== 4.7.3 / 2013-04-20
+
+* 1 bug fix:
+
+  * Reverted stubbing of module methods change. Stub the user, not the impl. (ab9/tyabe)
+
 === 4.7.2 / 2013-04-18
 
 * 2 bug fixes:

data/lib/minitest/mock.rb

@@ -166,7 +166,7 @@ class Object # :nodoc:
   def stub name, val_or_callable, &block
     new_name = "__minitest_stub__#{name}"
 
-    metaclass = self.class == Module ? self : class << self; self; end
+    metaclass = class << self; self; end
 
     if respond_to? name and not methods.map(&:to_s).include? name.to_s then
       metaclass.send :define_method, name do |*args|

data/lib/minitest/unit.rb

@@ -731,7 +731,7 @@ module MiniTest
   end
 
   class Unit # :nodoc:
-    VERSION = "4.7.2" # :nodoc:
+    VERSION = "4.7.3" # :nodoc:
 
     attr_accessor :report, :failures, :errors, :skips # :nodoc:
     attr_accessor :assertion_count                    # :nodoc:

data/test/minitest/test_minitest_mock.rb

@@ -300,18 +300,40 @@ class TestMiniTestStub < MiniTest::Unit::TestCase
     end
   end
 
-  def test_stub_module
+  def test_stub_private_module_method
     @assertion_count += 1
 
     t0 = Time.now
 
-    Kernel.stub :sleep, nil do
+    self.stub :sleep, nil do
       @tc.assert_nil sleep(10)
     end
 
     @tc.assert_operator Time.now - t0, :<=, 1
   end
 
+  def test_stub_private_module_method_indirect
+    @assertion_count += 1
+
+    slow_clapper = Class.new do
+      def slow_clap
+        sleep 3
+        :clap
+      end
+    end.new
+
+    slow_clapper.stub :sleep, nil do |fast_clapper|
+      @tc.assert_equal :clap, fast_clapper.slow_clap # either form works
+      @tc.assert_equal :clap, slow_clapper.slow_clap # yay closures
+    end
+  end
+
+  def test_stub_public_module_method
+    Math.stub(:log10, 42.0) do
+      @tc.assert_in_delta 42.0, Math.log10(1000)
+    end
+  end
+
   def test_stub_value
     assert_stub 42
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: minitest
 version: !ruby/object:Gem::Version 
-  hash: 39
+  hash: 37
   prerelease: 
   segments: 
   - 4
   - 7
-  - 2
-  version: 4.7.2
+  - 3
+  version: 4.7.3
 platform: ruby
 authors: 
 - Ryan Davis
@@ -36,7 +36,7 @@ cert_chain:
   FBHgymkyj/AOSqKRIpXPhjC6
   -----END CERTIFICATE-----
 
-date: 2013-04-18 00:00:00 Z
+date: 2013-04-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rdoc