minitest-utils 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a99a19ba55c65932adf23dbac70bb1c4dd9c5d6ac2873ac68ee4a16587a33a7b
-  data.tar.gz: d8c351c71b8322a6aad1402495e74f5820a613f32982b9830f3d79fa398af51f
+  metadata.gz: cafac996d26a83dd52cab2251f1c2e2d7cae70ef30d382a72061945ab343f29f
+  data.tar.gz: ec09d038b0d0e95729038894f549fb81f440f86c21da502a05aca821f4924315
 SHA512:
-  metadata.gz: a3dc2f9ba2a9fab1d7c631210d02a43f521ba6634d9d4cdc53f6e4f24ff9754cef17379eb7b6e9ca77627d249bf2b02436a32319a9f7086c4690bf427d5f78fd
-  data.tar.gz: e6b70cdd8e30e1cf2019e3c439c0eaf258ec16578e27f1053bae3086ed3a0d7cba8d661aa7a453508cc406415703632cc463b7f72d832aedcc4ba2faa5e035a4
+  metadata.gz: eef226b50750e7ebc85861059679783dfbfce05a74909b8f15d0680ea59e930e4f580f976653d9759c3b6c3b66d0feb369f00e0688290754e61d0732be1fe080
+  data.tar.gz: 7ec28ba64bbf01f8bce06bbcb8c6010eb96070440f170c98de21454f61ffe45af620fec8a610a7a24b3e039ecfa7639e3068618f75aef81a93d8f6e9b392f091

data/.rubocop.yml

@@ -0,0 +1,17 @@
+---
+inherit_gem:
+  rubocop-fnando: .rubocop.yml
+
+AllCops:
+  TargetRubyVersion: 2.6
+
+Metrics/LineLength:
+  Exclude:
+    - test/**/*
+
+Metrics/AbcSize:
+  Enabled: false
+
+Style/GlobalVars:
+  Exclude:
+    - test/minitest/utils/let_test.rb

data/Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in minitest-utils.gemspec
 gemspec

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 
@@ -8,4 +10,4 @@ Rake::TestTask.new(:test) do |t|
   t.warning = false
 end
 
-task :default => :test
+task default: :test

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "minitest/utils"

data/bin/rake

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
@@ -6,11 +8,11 @@
 # this file is here to facilitate running it.
 #
 
-require 'pathname'
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+                                           Pathname.new(__FILE__).realpath)
 
-require 'rubygems'
-require 'bundler/setup'
+require "rubygems"
+require "bundler/setup"
 
-load Gem.bin_path('rake', 'rake')
+load Gem.bin_path("rake", "rake")

data/lib/minitest/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
     require "minitest"
@@ -7,18 +9,14 @@ module Minitest
     require "minitest/utils/test_notifier_reporter"
 
     load_lib = lambda do |path, &block|
-      begin
-        require path
-        block.call if block
-        true
-      rescue LoadError
-        false
-      end
+      require path
+      block&.call
+      true
+    rescue LoadError
+      false
     end
 
-    unless load_lib.call "mocha/minitest"
-      load_lib.call "mocha/mini_test"
-    end
+    load_lib.call "mocha/mini_test" unless load_lib.call "mocha/minitest"
 
     load_lib.call "capybara"
 

data/lib/minitest/utils/capybara/chrome_headless.rb

@@ -1,9 +1,14 @@
+# frozen_string_literal: true
+
 gem "selenium-webdriver"
 gem "chromedriver-helper"
 
 Capybara.register_driver :chrome do |app|
-  Capybara::Selenium::Driver.new app, browser: :chrome,
-    options: Selenium::WebDriver::Chrome::Options.new(args: %w[headless disable-gpu])
+  options = Selenium::WebDriver::Chrome::Options.new(
+    args: %w[headless disable-gpu]
+  )
+
+  Capybara::Selenium::Driver.new app, browser: :chrome, options: options
 end
 
 Capybara.javascript_driver = :chrome

data/lib/minitest/utils/capybara/screenshot_on_failures.rb

@@ -1,10 +1,15 @@
+# frozen_string_literal: true
+
 gem "launchy"
 
 module Minitest
   class Test
     teardown do
       next unless Capybara.current_driver == Capybara.javascript_driver
-      save_and_open_screenshot if failures.any?
+
+      return unless failures.any?
+
+      save_and_open_screenshot # rubocop:disable Lint/Debugger
     end
   end
 end

data/lib/minitest/utils/extension.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
     module Assertions
@@ -17,7 +19,7 @@ module Minitest
     include ::Minitest::Utils::Assertions
 
     def self.test(name, &block)
-      test_name = "test_#{name.gsub(/\s+/,'_')}".to_sym
+      test_name = "test_#{name.gsub(/\s+/, '_')}".to_sym
       defined = method_defined? test_name
 
       raise "#{test_name} is already defined in #{self}" if defined
@@ -55,12 +57,23 @@ module Minitest
       include mod
     end
 
-    def self.let(name, &block)
-      target = instance_method(name) rescue nil
+    def self.let(name, &block) # rubocop:disable Metrics/MethodLength
+      target = begin
+                 instance_method(name)
+               rescue StandardError
+                 nil
+               end
+
       message = "Cannot define let(:#{name});"
 
-      raise ArgumentError, "#{message} method cannot begin with 'test'." if name.to_s.start_with?("test")
-      raise ArgumentError, "#{message} method already defined by #{target.owner}." if target
+      if name.to_s.start_with?("test")
+        raise ArgumentError, "#{message} method cannot begin with 'test'."
+      end
+
+      if target
+        raise ArgumentError,
+              "#{message} method already defined by #{target.owner}."
+      end
 
       define_method(name) do
         @_memoized ||= {}

data/lib/minitest/utils/rails.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
     module UrlHelpers

data/lib/minitest/utils/rails/capybara.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "capybara/rails"
 
 module ActionDispatch
@@ -9,7 +11,7 @@ module ActionDispatch
       Capybara.use_default_driver
     end
 
-    def self.use_javascript!(raise_on_javascript_errors: true)
+    def self.use_javascript!(raise_on_javascript_errors: true) # rubocop:disable Metrics/MethodLength
       setup do
         Capybara.current_driver = Capybara.javascript_driver
       end
@@ -18,13 +20,17 @@ module ActionDispatch
         next if failures.any?
         next unless raise_on_javascript_errors
 
-        errors = page.driver.browser.manage.logs.get(:browser).select {|log| log.level == "SEVERE" }
+        errors = page.driver.browser.manage.logs.get(:browser).select do |log|
+          log.level == "SEVERE"
+        end
+
         next unless errors.any?
 
         messages = errors
-                    .map(&:message)
-                    .map {|message| message[/(\d+:\d+ .*?)$/, 1] }
-                    .join("\n")
+                   .map(&:message)
+                   .map {|message| message[/(\d+:\d+ .*?)$/, 1] }
+                   .join("\n")
+
         raise "JavaScript Errors\n#{messages}"
       end
     end

data/lib/minitest/utils/rails/locale.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
     module Locale

data/lib/minitest/utils/railtie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails/railtie"
 
 module Minitest

data/lib/minitest/utils/reporter.rb

@@ -1,19 +1,21 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
-    class Reporter < Minitest::StatisticsReporter
+    class Reporter < Minitest::StatisticsReporter # rubocop:disable Metrics/ClassLength
       COLOR_FOR_RESULT_CODE = {
         "." => :green,
         "E" => :red,
         "F" => :red,
         "S" => :yellow
-      }
+      }.freeze
 
       COLOR = {
         red: 31,
         green: 32,
         yellow: 33,
         blue: 34
-      }
+      }.freeze
 
       def initialize(*)
         super
@@ -33,7 +35,7 @@ module Minitest
         io.puts
       end
 
-      def report
+      def report # rubocop:disable Metrics/MethodLength
         super
         io.sync = true
 
@@ -45,29 +47,38 @@ module Minitest
         color = :red if failing_results.any?
 
         if failing_results.any? || skipped_results.any?
-          failing_results.each.with_index(1) {|result, index| display_failing(result, index) }
-          skipped_results.each.with_index(failing_results.size + 1) {|result, index| display_skipped(result, index) }
+          failing_results.each.with_index(1) do |result, index|
+            display_failing(result, index)
+          end
+
+          skipped_results
+            .each
+            .with_index(failing_results.size + 1) do |result, index|
+            display_skipped(result, index)
+          end
         end
 
         io.print "\n\n"
         io.puts statistics
         io.puts color(summary, color)
 
-        if failing_results.any?
-          io.puts "\nFailed Tests:\n"
-          failing_results.each {|result| display_replay_command(result) }
-          io.puts "\n\n"
-        end
-      end
+        return unless failing_results.any?
 
-      private
+        io.puts "\nFailed Tests:\n"
+        failing_results.each {|result| display_replay_command(result) }
+        io.puts "\n\n"
+      end
 
-      def statistics
-        "Finished in %.6fs, %.4f runs/s, %.4f assertions/s." %
-          [total_time, count / total_time, assertions / total_time]
+      private def statistics
+        format(
+          "Finished in %.6fs, %.4f runs/s, %.4f assertions/s.",
+          total_time,
+          count / total_time,
+          assertions / total_time
+        )
       end
 
-      def summary # :nodoc:
+      private def summary # :nodoc:
         [
           pluralize("run", count),
           pluralize("assertion", assertions),
@@ -77,40 +88,37 @@ module Minitest
         ].join(", ")
       end
 
-      def indent(text)
+      private def indent(text)
         text.gsub(/^/, "      ")
       end
 
-      def display_failing(result, index)
+      private def display_failing(result, index)
         backtrace = backtrace(result.failure.backtrace)
         message = result.failure.message
         message = message.lines.tap(&:pop).join.chomp if result.error?
 
-        str = "\n\n"
-        str << color("%4d) %s" % [index, result_name(result.name)])
-        str << "\n" << color(indent(message), :red)
-        str << "\n" << color(backtrace, :blue)
-        io.print str
+        output = ["\n\n"]
+        output << color(format("%4d) %s", index, result_name(result.name)))
+        output << "\n" << color(indent(message), :red)
+        output << "\n" << color(backtrace, :blue)
+        io.print output.join
       end
 
-      def display_skipped(result, index)
+      private def display_skipped(result, index)
         location = location(result.failure.location)
         str = "\n\n"
-        str << color("%4d) %s [SKIPPED]" % [index, result_name(result.name)], :yellow)
+        str << color(
+          format("%4d) %s [SKIPPED]", index, result_name(result.name)), :yellow
+        )
         str << "\n" << indent(color(location, :yellow))
         io.print str
       end
 
-      def display_replay_command(result)
+      private def display_replay_command(result)
         location, line = find_test_file(result)
         return if location.empty?
 
-        command = if defined?(Rails) && Rails.version >= "5.0.0"
-                    %[bin/rails test #{location}:#{line}]
-                  else
-                    bundle = "bundle exec " if defined?(Bundler)
-                    %[#{bundle}rake TEST=#{location} TESTOPTS="--name=#{result.name}"]
-                  end
+        command = build_test_command(location, line, result)
 
         str = "\n"
         str << color(command, :red)
@@ -118,49 +126,53 @@ module Minitest
         io.print str
       end
 
-      def find_test_file(result)
+      private def find_test_file(result)
         location, line = if result.respond_to?(:source_location)
                            result.source_location
                          else
                            result.method(result.name).source_location
                          end
 
-        location = location.gsub(%r[^.*?/((?:test|spec)/.*?)$], "\\1")
+        location = location.gsub(%r{^.*?/((?:test|spec)/.*?)$}, "\\1")
 
         [location, line]
       end
 
-      def backtrace(backtrace)
-        backtrace = filter_backtrace(backtrace).map {|line| location(line, true) }
+      private def backtrace(backtrace)
+        backtrace = filter_backtrace(backtrace).map do |line|
+          location(line, true)
+        end
+
         return if backtrace.empty?
+
         indent(backtrace.join("\n")).gsub(/^(\s+)/, "\\1# ")
       end
 
-      def location(location, include_line_number = false)
+      private def location(location, include_line_number = false)
         regex = include_line_number ? /^([^:]+:\d+)/ : /^([^:]+)/
         location = File.expand_path(location[regex, 1])
 
         return location unless location.start_with?(Dir.pwd)
 
-        location.gsub(%r[^#{Regexp.escape(Dir.pwd)}/], "")
+        location.gsub(%r{^#{Regexp.escape(Dir.pwd)}/}, "")
       end
 
-      def filter_backtrace(backtrace)
+      private def filter_backtrace(backtrace)
         Minitest.backtrace_filter.filter(backtrace)
       end
 
-      def result_name(name)
+      private def result_name(name)
         name
           .gsub(/^test(_\d+)?_/, "")
           .gsub(/_/, " ")
       end
 
-      def print_result_code(result_code)
+      private def print_result_code(result_code)
         result_code = color(result_code, COLOR_FOR_RESULT_CODE[result_code])
         io.print result_code
       end
 
-      def color(string, color = :default)
+      private def color(string, color = :default)
         if color_enabled?
           color = COLOR.fetch(color, 0)
           "\e[#{color}m#{string}\e[0m"
@@ -169,11 +181,11 @@ module Minitest
         end
       end
 
-      def color_enabled?
+      private def color_enabled?
         @color_enabled
       end
 
-      def pluralize(word, count)
+      private def pluralize(word, count)
         case count
         when 0
           "no #{word}s"
@@ -183,6 +195,21 @@ module Minitest
           "#{count} #{word}s"
         end
       end
+
+      private def running_rails?
+        defined?(Rails) &&
+        Rails.respond_to?(:version) &&
+        Rails.version >= "5.0.0"
+      end
+
+      private def build_test_command(location, line, result)
+        if running_rails?
+          %[bin/rails test #{location}:#{line}]
+        else
+          bundle = "bundle exec " if defined?(Bundler)
+          %[#{bundle}rake TEST=#{location} TESTOPTS="--name=#{result.name}"]
+        end
+      end
     end
   end
 end

data/lib/minitest/utils/setup/database_cleaner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 DatabaseCleaner[:active_record].strategy = :truncation
 
 module Minitest

data/lib/minitest/utils/setup/factory_bot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   class Test
     include FactoryBot::Syntax::Methods

data/lib/minitest/utils/setup/factory_girl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   class Test
     include FactoryGirl::Syntax::Methods

data/lib/minitest/utils/setup/webmock.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "webmock/minitest"
 
 WebMock.disable_net_connect!

data/lib/minitest/utils/test_notifier_reporter.rb

@@ -1,15 +1,16 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
     class TestNotifierReporter < Minitest::StatisticsReporter
       def report
         super
 
-        stats = TestNotifier::Stats.new(:minitest, {
-          count: count,
-          assertions: assertions,
-          failures: failures,
-          errors: errors
-        })
+        stats = TestNotifier::Stats.new(:minitest,
+                                        count: count,
+                                        assertions: assertions,
+                                        failures: failures,
+                                        errors: errors)
 
         TestNotifier.notify(status: stats.status, message: stats.message)
       end

data/lib/minitest/utils/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Minitest
   module Utils
-    VERSION = "0.4.4".freeze
+    VERSION = "0.4.5"
   end
 end

data/lib/minitest/utils_plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "minitest/utils/reporter"
 require "minitest/utils/test_notifier_reporter"
 
@@ -6,6 +8,9 @@ module Minitest
     reporters = Minitest.reporter.reporters
     reporters.clear
     reporters << Minitest::Utils::Reporter.new(options[:io], options)
-    reporters << Minitest::Utils::TestNotifierReporter.new(options[:io], options) if defined?(TestNotifier)
+
+    return unless defined?(TestNotifier)
+
+    reporters << TestNotifierReporter.new(options[:io], options)
   end
 end

data/minitest-utils.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "./lib/minitest/utils/version"
 
 Gem::Specification.new do |spec|
@@ -9,13 +11,17 @@ Gem::Specification.new do |spec|
   spec.description   = spec.summary
   spec.homepage      = "http://github.com/fnando/minitest-utils"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`
+                       .split("\x0")
+                       .reject {|f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^exe/}) {|f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "minitest"
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
   spec.add_development_dependency "pry-meta"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "rubocop-fnando"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-utils
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-03 00:00:00.000000000 Z
+date: 2019-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-meta
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +67,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-meta
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-fnando
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -74,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -120,8 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Some utilities for your Minitest day-to-day usage.