minitest-spec-rails 5.1.1 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6c837b598195683ee055f9ac77715ddfb20512f
-  data.tar.gz: e81d2580abb2f695a604b18d7e02fc76d4341a9e
+  metadata.gz: e9408e396ed2d699f0d7c87a2ff129b6c5f2054a
+  data.tar.gz: 495b7c539331c43354e2d652f74206bbaf8be340
 SHA512:
-  metadata.gz: ed1ad767526ebd9cf1317b48b30bb7c745d88b1fd2d8d8902d58d26448e2d193e982cd501318bea6c74b72f4db5fbfb4c462d0921ec105c1479dcf2f1ced0df5
-  data.tar.gz: 2d06e00852ec0c800b56862cb22c7a12ed5af7e017707c9830eabd86e7ae03a69bcc94eb3ffcacab53c9f4bcf1d56a724a56bc37e180e7bd04f21be237c04625
+  metadata.gz: a6113aadd99cccdd0f45345a9ed4877b88e5ffbd7d137b00c7c20f7c3cc63f5a262c627731a024cc20f424b9028cf5f61764c126c81b409a3c7d2b317bccd526
+  data.tar.gz: 5512028271386985bd24bccf781d65597252a5a84a66ad242b27fdaa666afba433d4d88ecb028cda8c0d56d9a1169ab3f26f669b19d68be6c565f7215c8c83c3

data/.travis.yml

@@ -1,3 +1,5 @@
+sudo: false
+cache: bundler
 rvm:
   - 1.9.3
   - 2.0.0

data/Appraisals

@@ -3,5 +3,5 @@ appraise 'rails41' do
 end
 
 appraise 'rails42' do
-  gem 'rails', '4.2.0.beta1'
+  gem 'rails', '4.2.0.rc3'
 end

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+
+## 5.2.0
+
+* Added ActiveJob support. Fixes #59. Thanks @xpepermint.
+
+## 5.1.1
+
+* Fix an issue where `describe` method was removed. Fixes #55 & #50
+  [41a0f851](https://github.com/metaskills/minitest-spec-rails/commit/41a0f851c8a290f59feb1cb8b20759f0e2a9697a)
+
+## 5.1.0
+
+No release notes yet. PRs welcome!
+
 ## 5.0.4
 
 * Fixed ActiveSupport's Declarative#test forwarded implementation. Fixed #46.

data/README.md

@@ -15,10 +15,15 @@ The minitest-spec-rails gem makes it easy to use the MiniTest::Spec DSL within y
 Existing or new Rails applications that use the default Rails testing structure can simply drop in the minitest-spec-gem and start writing their tests in the new spec DSL. Since MiniTest::Spec is built on top of MiniTest::Unit, a replacement for Test::Unit, all of your existing tests will continue to work.
 
 
-#### Rails 4.1
+#### Rails 4.1 or 4.2, 5.x
 
-Our master branch is tracking rails 4.1 and up.
+Our master branch is tracking rails 4.1, 4.2 and hopefully up to 5.x active development.
 
+```ruby
+group :test do
+  gem 'minitest-spec-rails'
+end
+```
 
 #### For Rails 3.x or 4.0
 
@@ -26,7 +31,7 @@ Our [3-x-stable](https://github.com/metaskills/minitest-spec-rails/tree/3-x-stab
 
 ```ruby
 group :test do
-  gem 'minitest-spec-rails'
+  gem 'minitest-spec-rails', '~> 4.7'
 end
 ```
 
@@ -95,12 +100,14 @@ end
 ```ruby
 require 'test_helper'
 describe User do
-  # This will work too.
+  # This will work too, but is not recommended
 end
 ```
 
 Just for reference, here is a full list of each of Rails test case classes and the matching describe alternative if one exists. Remember, names are important when using the describe syntax. So, you can not have a mailer named `FooBar` and expect it to work with the outer describe spec style since there is no way to map the spec type based on an existing naming convention.
 
+Using `describe` in this way [is not recommended](https://github.com/metaskills/minitest-spec-rails/issues/56).
+
 ```ruby
 # Model Test (or anything else not listed below)
 class UserTest < ActiveSupport::TestCase
@@ -288,3 +295,4 @@ We have a few branches for each major Rails version.
 Our current build status is:
 [![Build Status](https://secure.travis-ci.org/metaskills/minitest-spec-rails.png)](http://travis-ci.org/metaskills/minitest-spec-rails)
 
+

data/lib/minitest-spec-rails/init/active_job.rb

@@ -0,0 +1,27 @@
+module MiniTestSpecRails
+  module Init
+    module ActiveJobBehavior
+
+      extend ActiveSupport::Concern
+
+      included do
+        register_spec_type(self) { |desc| Class === desc && desc < ActiveJob::Base }
+        register_spec_type(/Job( ?Test)?\z/, self)
+        register_spec_type(self) { |desc| Class === desc && desc < self }
+        extend Descriptions
+      end
+
+      module Descriptions
+
+        def described_class
+          determine_default_mailer(name)
+        end
+
+      end
+
+    end
+  end
+end
+
+ActiveJob::TestCase.send :include, MiniTestSpecRails::Init::ActiveJobBehavior
+

data/lib/minitest-spec-rails/railtie.rb

@@ -14,6 +14,9 @@ module MiniTestSpecRails
       ActiveSupport.on_load(:action_mailer) do
         require 'minitest-spec-rails/init/action_mailer'
       end
+      ActiveSupport.on_load(:active_job) do
+        require 'minitest-spec-rails/init/active_job'
+      end
     end if Rails.env.test?
 
     initializer 'minitest-spec-rails.action_view', :after => 'action_view.setup_action_pack', :group => :all do |app|

data/lib/minitest-spec-rails/version.rb

@@ -1,3 +1,3 @@
 module MiniTestSpecRails
-  VERSION = "5.1.1"
+  VERSION = "5.2.0"
 end

data/test/cases/active_job_test.rb

@@ -0,0 +1,42 @@
+require 'test_helper'
+
+class MyJob < ActiveJob::Base ; def perform(record) ; true ; end end
+class TrashableCleanupJob < MyJob ; end
+
+class ActiveJobTest < MiniTestSpecRails::TestCase
+
+  it 'matches spec type for class constants' do
+    assert_job MiniTest::Spec.spec_type(MyJob)
+    assert_job MiniTest::Spec.spec_type(TrashableCleanupJob)
+  end
+
+  it 'matches spec type for strings' do
+    assert_job MiniTest::Spec.spec_type("WidgetJob")
+    assert_job MiniTest::Spec.spec_type("WidgetJobTest")
+    assert_job MiniTest::Spec.spec_type("Widget Job Test")
+    # And is case sensitive
+    refute_job MiniTest::Spec.spec_type("widgetmailer")
+    refute_job MiniTest::Spec.spec_type("widgetmailertest")
+    refute_job MiniTest::Spec.spec_type("widget mailer test")
+  end
+
+  it 'wont match spec type for non space characters' do
+    refute_job MiniTest::Spec.spec_type("Widget Job\tTest")
+    refute_job MiniTest::Spec.spec_type("Widget Job\rTest")
+    refute_job MiniTest::Spec.spec_type("Widget Job\nTest")
+    refute_job MiniTest::Spec.spec_type("Widget Job\fTest")
+    refute_job MiniTest::Spec.spec_type("Widget JobXTest")
+  end
+
+
+  private
+
+  def assert_job(actual)
+    assert_equal ActiveJob::TestCase, actual
+  end
+
+  def refute_job(actual)
+    refute_equal ActiveJob::TestCase, actual
+  end
+
+end

data/test/dummy_app/init.rb

@@ -10,8 +10,9 @@ module Dummy
     # Basic Engine
     config.root = File.join __FILE__, '..'
     config.cache_store = :memory_store
-    config.assets.enabled = false if Rails.version > '3.1'
+    config.assets.enabled = false
     config.secret_token = '012345678901234567890123456789'
+    config.active_support.test_order = :random
 
     # Mimic Test Environment Config.
     config.whiny_nils = true if Rails.version < '4.0'

data/test/dummy_tests/user_mailer_test.rb

@@ -6,7 +6,12 @@ module UserMailerTests
 
     let(:deliveries)        { ActionMailer::Base.deliveries }
     let(:user_mailer_class) { UserMailer }
-    let(:user_email)        { user_mailer_class.welcome(user_ken).deliver }
+    let(:user_email)        {
+      user_mailer_class.welcome(user_ken).tap do |mail|
+        laterable = Rails.version > '4.2' || Rails.version.starts_with?('4.2')
+        laterable ? mail.deliver_now : mail.deliver
+      end
+    }
 
     it 'works' do
       deliveries.must_be :empty?
@@ -40,7 +45,7 @@ module UserMailerTests
       end
 
     end
-    
+
   end
 end
 

data/test/dummy_tests/users_helper_test.rb

@@ -32,7 +32,7 @@ module UsersHelperTests
       end
 
     end
-    
+
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-spec-rails
 version: !ruby/object:Gem::Version
-  version: 5.1.1
+  version: 5.2.0
 platform: ruby
 authors:
 - Ken Collins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-19 00:00:00.000000000 Z
+date: 2015-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -102,6 +102,7 @@ files:
 - lib/minitest-spec-rails/init/action_dispatch.rb
 - lib/minitest-spec-rails/init/action_mailer.rb
 - lib/minitest-spec-rails/init/action_view.rb
+- lib/minitest-spec-rails/init/active_job.rb
 - lib/minitest-spec-rails/init/active_support.rb
 - lib/minitest-spec-rails/init/mini_shoulda.rb
 - lib/minitest-spec-rails/railtie.rb
@@ -111,6 +112,7 @@ files:
 - test/cases/action_dispatch_test.rb
 - test/cases/action_mailer_test.rb
 - test/cases/action_view_test.rb
+- test/cases/active_job_test.rb
 - test/cases/active_support_test.rb
 - test/cases/mini_shoulda_test.rb
 - test/dummy_app/app/controllers/application_controller.rb
@@ -167,6 +169,7 @@ test_files:
 - test/cases/action_dispatch_test.rb
 - test/cases/action_mailer_test.rb
 - test/cases/action_view_test.rb
+- test/cases/active_job_test.rb
 - test/cases/active_support_test.rb
 - test/cases/mini_shoulda_test.rb
 - test/dummy_app/app/controllers/application_controller.rb