minitest-spec-rails 4.3.0 → 4.3.1

data/CHANGELOG.md

@@ -1,4 +1,9 @@
 
+## v4.3.1
+
+* Eager load controller_class, mailer_class, and helper_class.
+
+
 ## v4.3.0
 
 * All new MiniTest::Spec for Rails!!! Tested to the hilt!!!

data/README.md

@@ -84,17 +84,38 @@ end
 describe UsersHelper do
 end
 ```
-  
 
 
 ## Gotchas
 
+### Assertion Methods
+
 If you are upgrading from Test::Unit, there are a few missing assertions that have been renamed or are no longer available within MiniTest.
 
 * The method `assert_raise` is renamed `assert_raises`.
 * There is no method `assert_nothing_raised`. There are good reasons for this on [Ryan's blog entry](http://blog.zenspider.com/blog/2012/01/assert_nothing_tested.html).
 
-If you are using minitest-spec-rails with Rails 3.0, then your controller or mailer tests will need to use the `tests` interface for the test to be setup correct within sub `describe` blocks. I think this is a bug with `class_attribute` within Rails 3.0. Rails 3.1 and higher does not exhibit this problem.
+### Mocha
+
+If you are using [Mocha](https://github.com/freerange/mocha) for mocking and stubbing, please update to the latest, 0.13.1 or higher so it is compatible with the latest MiniTest. If you do not like the deprecation warnings in older versions of Rails, just add this below the `require 'rails/all'` within your `application.rb` file :)
+
+```ruby
+require 'mocha/deprecation'
+Mocha::Deprecation.mode = :disabled
+```
+
+### Rails 3.0.x
+
+If you are using minitest-spec-rails with Rails 3.0, then your controller and mailer tests will need to use the `tests` interface for the assertions to be setup correctly within sub `describe` blocks. I think this is a bug with `class_attribute` within Rails 3.0 only. So use the following patterns.
+
+```ruby
+class UsersControllerTest < ActionController::TestCase
+  tests UsersController
+end
+class UserMailerTest < ActionMailer::TestCase
+  tests UserMailer
+end
+```
 
 
 ## Contributing

data/lib/minitest-spec-rails.rb

@@ -3,6 +3,7 @@ end
 
 require 'rails'
 require 'minitest/spec'
+require 'minitest-spec-rails/util'
 require 'minitest-spec-rails/version'
 require 'minitest-spec-rails/railtie'
 require 'test/unit/testcase'

data/lib/minitest-spec-rails/init/action_controller.rb

@@ -6,6 +6,8 @@ ActionController::TestCase.instance_eval do
 
   register_spec_type(/Controller( ?Test)?\z/i, self)
 
+  before { self.class.controller_class }
+
 end
 
 require 'action_dispatch/testing/integration' # For Rails 3.0 loading.

data/lib/minitest-spec-rails/init/action_mailer.rb

@@ -6,4 +6,6 @@ ActionMailer::TestCase.instance_eval do
 
   register_spec_type(/Mailer( ?Test)?\z/i, self)
 
+  before { self.class.mailer_class unless MiniTestSpecRails::Util.rails30? }
+
 end

data/lib/minitest-spec-rails/init/action_view.rb

@@ -16,5 +16,6 @@ ActionView::TestCase.instance_eval do
     end
   end
 
+  before { self.class.helper_class }
 
 end

data/lib/minitest-spec-rails/util.rb

@@ -0,0 +1,13 @@
+module MiniTestSpecRails
+  module Util
+    
+    def self.rails3?  ; rails30? || rails31? || rails32? ; end
+    def self.rails30? ; rails_version == '3.0' ; end
+    def self.rails31? ; rails_version == '3.1' ; end
+    def self.rails32? ; rails_version == '3.2' ; end
+    def self.rails40? ; rails_version == '4.0' ; end
+
+    def self.rails_version ; ::Rails.version.split('.')[0,2].join('.') ; end
+
+  end
+end

data/lib/minitest-spec-rails/version.rb

@@ -1,3 +1,3 @@
 module MiniTestSpecRails
-  VERSION = "4.3.0"
+  VERSION = "4.3.1"
 end

data/test/dummy_tests/application_controller_test.rb

@@ -4,6 +4,10 @@ module ApplicationControllerTests
   extend ActiveSupport::Concern
   included do
 
+    tests ApplicationController if MiniTestSpecRails::Util.rails30?
+
+    before { get :index }
+
     it 'works' do
       get :index
       response.body.must_equal 'Rendered MiniTest::Spec'
@@ -26,7 +30,7 @@ module ApplicationControllerTests
       it('works') { skip }
 
       it 'can find the controller_class' do
-        self.class.controller_class.must_equal ApplicationController unless rails30?
+        self.class.controller_class.must_equal ApplicationController
       end
 
       describe 'nested 2' do

data/test/dummy_tests/user_mailer_test.rb

@@ -4,6 +4,8 @@ module UserMailerTests
   extend ActiveSupport::Concern
   included do
 
+    tests UserMailer if MiniTestSpecRails::Util.rails30?
+
     let(:deliveries)        { ActionMailer::Base.deliveries }
     let(:user_mailer_class) { UserMailer }
     let(:user_email)        { user_mailer_class.welcome(user_ken).deliver }
@@ -30,7 +32,7 @@ module UserMailerTests
       it('works') { skip }
 
       it 'can find the mailer_class' do
-        self.class.mailer_class.must_equal user_mailer_class unless rails30?
+        self.class.mailer_class.must_equal user_mailer_class
       end
 
       describe 'nested 2' do

data/test/dummy_tests/user_test.rb

@@ -9,7 +9,7 @@ module UserTests
     end
 
     it 'allows custom assertions' do
-      assert_blank '' if rails3?
+      assert_blank '' if MiniTestSpecRails::Util.rails3?
     end
 
     describe 'nested 1' do

data/test/dummy_tests/users_controller_test.rb

@@ -4,8 +4,9 @@ module UsersControllerTests
   extend ActiveSupport::Concern
   included do
 
-    it 'works' do
-      get :index
+    before { get :index }
+
+    it 'works' do  
       assert_select 'h1', "All #{User.count} Users"
     end
     

data/test/support/shared_test_case_behavior.rb

@@ -20,16 +20,6 @@ module MiniTestSpecRails
         end
       end
     end
-
-    def rails_version
-      Rails.version.split('.')[0,2].join('.')
-    end
-
-    def rails3? ; rails30? || rails31? || rails32? ; end
-    def rails30? ; rails_version == '3.0' ; end
-    def rails31? ; rails_version == '3.1' ; end
-    def rails32? ; rails_version == '3.2' ; end
-    def rails40? ; rails_version == '4.0' ; end
     
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-spec-rails
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -137,6 +137,7 @@ files:
 - lib/minitest-spec-rails/init/action_view.rb
 - lib/minitest-spec-rails/init/active_support.rb
 - lib/minitest-spec-rails/railtie.rb
+- lib/minitest-spec-rails/util.rb
 - lib/minitest-spec-rails/version.rb
 - lib/test/unit.rb
 - lib/test/unit/assertions.rb
@@ -183,7 +184,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1108058497587389129
+      hash: -825537953231626350
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -192,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1108058497587389129
+      hash: -825537953231626350
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24