minitest-reporters 1.3.2.beta1 → 1.3.2.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3257dd726eea7dfcb07c3945e9066149fcbbd6c5cd8c7d4a05fa259c6f1fc849
-  data.tar.gz: 266cd94a13ebe4b9899feed855e9831edc03f87e8a137813df4067d15ab73499
+  metadata.gz: c72dc8853695e3534ded9072f34e163f80bdd335e971fd40279abf50b6056bb1
+  data.tar.gz: 682134ff3cf2d870f474346b6408f99ed592e7c932c69a9d677dd2aa2bbdaf6f
 SHA512:
-  metadata.gz: b2c695a962ded855e76c60c55a668f7b0d77d2b111c713367912a61e138f548861cf940877a1410a63d1b91550bc3c18986d28e864ec95b941b79894077aa15f
-  data.tar.gz: 13d3872725a4bb52c928e5238ebcc90f1e27c2660aaa0e2427860a5d0ec85532248d7e950f77516ff923a0a210f4048545f15c561e18a6c1278061a2579e831b
+  metadata.gz: 9d03a331a2474ec6f6882e459a913db53940c09e1f8500c24e0b262b3b793675d1f026fd95306d20f9a3500c2a170747ce18f8bdf609d251b3f3f0192d27dd7d
+  data.tar.gz: d8d56e13d1942f73e96737bc7d7bc21a8391c9207048339d345ade31c9bbc0a32be3d32c0937bcd42b8ec64af1c5698dc72cc65182430660550e21b0a9eda005

data/.rubocop.yml

@@ -1,8 +1,55 @@
+---
+#AllCops:
+#  DisabledByDefault: true
+
+Layout:
+  Enabled: true
+
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Lint:
+  Enabled: true
+
+Metrics:
+  Severity: refactor
+  Enabled: true
+
 Metrics/LineLength:
-  Max: 120
+  Severity: convention
+  Max: 130
+
+Naming:
+  Enabled: true
 
 Naming/UncommunicativeMethodParamName:
   MinNameLength: 1
 
+Performance:
+  Enabled: true
+
+Rails:
+  Enabled: false
+
+Security:
+  Enabled: true
+
+#todo: enable
+Style:
+  Enabled: false
+
 Style/FormatStringToken:
-  Enabled: false
+  Enabled: false
+
+#todo: enable
+Style/StringLiterals:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Bundler:
+  Enabled: true
+
+Gemspec:
+  Enabled: true

data/CHANGELOG.md

@@ -1,10 +1,14 @@
 ### [dev](https://github.com/kern/minitest-reporters/compare/v1.3.2.beta1...master)
 
+### [1.3.2.beta2](https://github.com/kern/minitest-reporters/compare/v1.3.2.beta1...v1.3.2.beta2)
+
+* fixed the way JUnitReporter calculates relative path [#258](https://github.com/kern/minitest-reporters/issues/258)
+
 ### [1.3.2.beta1](https://github.com/kern/minitest-reporters/compare/v1.3.1...v1.3.2.beta1)
 
-* SpecReporter do not print exception name any more (unless it is an test error) [#264](https://github.com/kern/minitest-reporters/pull/264)
+* SpecReporter do not print exception name any more (unless it is an test error) [#264](https://github.com/kern/minitest-reporters/issues/264)
 * Fixed loading error caused by fix for [#265](https://github.com/kern/minitest-reporters/pull/265)
-  see [#267](https://github.com/kern/minitest-reporters/pull/267) and 
+  see [#267](https://github.com/kern/minitest-reporters/issues/267) and 
   [#268](https://github.com/kern/minitest-reporters/pull/268) for more details.
 
 ### [1.3.1](https://github.com/kern/minitest-reporters/compare/v1.3.1.beta1...v1.3.1)

data/README.md

@@ -6,6 +6,7 @@
 [![Join the chat at https://gitter.im/kern/minitest-reporters](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/kern/minitest-reporters?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Gem Version](https://badge.fury.io/rb/minitest-reporters.svg)][gem]
 [![Build Status](https://secure.travis-ci.org/kern/minitest-reporters.png)][travis]
+[![Windows build status](https://ci.appveyor.com/api/projects/status/3pugsxatwcldgyjd/branch/master?svg=true)](https://ci.appveyor.com/project/os97673/minitest-reporters/branch/master)
 
 Death to haphazard monkey-patching! Extend Minitest through simple hooks.
 

data/appveyor.yml

@@ -0,0 +1,22 @@
+---
+version: '#{build}'
+cache:
+  - vendor/bundle
+environment:
+  matrix:
+    - RUBY_VERSION: 25-x64
+    - RUBY_VERSION: 24-x64
+
+install:
+  - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - bundle install
+
+build: off
+
+before_test:
+  - ruby -v
+  - gem -v
+  - bundle -v
+
+test_script:
+  - bundle exec rake test

data/lib/minitest/minitest_reporter_plugin.rb

@@ -31,6 +31,7 @@ module Minitest
       end
 
       private
+
       # stolen from minitest self.run
       def total_count(options)
         filter = options[:filter] || '/./'

data/lib/minitest/reporters.rb

@@ -79,7 +79,7 @@ module Minitest
     end
 
     def self.minitest_version
-      Minitest::VERSION.gsub('.', '').to_i
+      Minitest::VERSION.delete('.').to_i
     end
 
     def self.use_old_activesupport_fix!

data/lib/minitest/reporters/ansi.rb

@@ -2,7 +2,6 @@ module Minitest
   module Reporters
     module ANSI
       module Code
-
         def self.color?
           return false if ENV['MINITEST_REPORTERS_MONO']
           color_terminal = ENV['TERM'].to_s.downcase.include?("color")
@@ -19,7 +18,7 @@ module Minitest
             block_given? ? yield : s
           end
 
-          %w[ red green yellow blue magenta cyan white ].each do |color|
+          %w[red green yellow blue magenta cyan white].each do |color|
             alias_method color, :black
           end
 

data/lib/minitest/reporters/base_reporter.rb

@@ -13,7 +13,7 @@ module Minitest
     class BaseReporter < Minitest::StatisticsReporter
       attr_accessor :tests
 
-      def initialize(options={})
+      def initialize(options = {})
         super($stdout, options)
         self.tests = []
       end
@@ -40,7 +40,7 @@ module Minitest
       end
 
       # called by our own after hooks
-      def after_test(test)
+      def after_test(_test)
       end
 
       def report
@@ -81,11 +81,11 @@ module Minitest
 
       def print_colored_status(test)
         if test.passed?
-          print(green { pad_mark( result(test).to_s.upcase ) })
+          print(green { pad_mark(result(test).to_s.upcase) })
         elsif test.skipped?
-          print(yellow { pad_mark( result(test).to_s.upcase ) })
+          print(yellow { pad_mark(result(test).to_s.upcase) })
         else
-          print(red { pad_mark( result(test).to_s.upcase ) })
+          print(red { pad_mark(result(test).to_s.upcase) })
         end
       end
 
@@ -109,8 +109,8 @@ module Minitest
         io.print(*args)
       end
 
-      def print_info(e, name=true)
-        print "#{e.exception.class.to_s}: " if name
+      def print_info(e, name = true)
+        print "#{e.exception.class}: " if name
         e.message.each_line { |line| print_with_info_padding(line) }
 
         # When e is a Minitest::UnexpectedError, the filtered backtrace is already part of the message printed out

data/lib/minitest/reporters/html_reporter.rb

@@ -5,9 +5,11 @@ require 'erb'
 module Minitest
   module Reporters
     # A reporter for generating HTML test reports
-    # This is recommended to be used with a CI server, where the report is kept as an artifact and is accessible via a shared link
+    # This is recommended to be used with a CI server, where the report is kept as an artifact and is accessible via
+    # a shared link
     #
-    # The reporter sorts the results alphabetically and then by results so that failing and skipped tests are at the top.
+    # The reporter sorts the results alphabetically and then by results
+    # so that failing and skipped tests are at the top.
     #
     # When using Minitest Specs, the number prefix is dropped from the name of the test so that it reads well
     #
@@ -16,7 +18,6 @@ module Minitest
     # The report is generated using ERB. A custom ERB template can be provided but it is not required
     # The default ERB template uses JQuery and Bootstrap, both of these are included by referencing the CDN sites
     class HtmlReporter < BaseReporter
-
       # The title of the report
       attr_reader :title
 
@@ -32,12 +33,12 @@ module Minitest
 
       # The percentage of tests that were skipped
       def percent_skipps
-        (skips/count.to_f * 100).to_i
+        (skips / count.to_f * 100).to_i
       end
 
       # The percentage of tests that failed
       def percent_errors_failures
-        ((errors+failures)/count.to_f * 100).to_i
+        ((errors + failures) / count.to_f * 100).to_i
       end
 
       # Trims off the number prefix on test names when using Minitest Specs
@@ -57,11 +58,11 @@ module Minitest
         super({})
 
         defaults = {
-            :title           => 'Test Results',
-            :erb_template    => "#{File.dirname(__FILE__)}/../templates/index.html.erb",
-            :reports_dir     => 'test/html_reports',
-            :mode            => :safe,
-            :output_filename => 'index.html'
+          :title           => 'Test Results',
+          :erb_template    => "#{File.dirname(__FILE__)}/../templates/index.html.erb",
+          :reports_dir     => 'test/html_reports',
+          :mode            => :safe,
+          :output_filename => 'index.html'
         }
 
         settings = defaults.merge(args)
@@ -107,6 +108,7 @@ module Minitest
             f.write(result)
           end
 
+        # rubocop:disable Lint/RescueException
         rescue Exception => e
           puts 'There was an error writing the HTML report'
           puts 'This may have been caused by cancelling the test run'
@@ -114,10 +116,11 @@ module Minitest
           puts 'Use mode => :terse in the HTML reporters constructor to see less detail' if @mode != :terse
           raise e if @mode != :terse
         end
-
+        # rubocop:enable Lint/RescueException
       end
 
       private
+
       def html_file
         "#{@reports_path}/#{@output_filename}"
       end
@@ -211,10 +214,10 @@ module Minitest
         return ('%.2fs' % total_time) if total_time < 1
 
         hours = (total_time / (60 * 60)).round
-        minutes = ((total_time / 60) % 60).round.to_s.rjust(2,'0')
-        seconds = (total_time % 60).round.to_s.rjust(2,'0')
+        minutes = ((total_time / 60) % 60).round.to_s.rjust(2, '0')
+        seconds = (total_time % 60).round.to_s.rjust(2, '0')
 
-        "#{ hours }h#{ minutes }m#{ seconds }s"
+        "#{hours}h#{minutes}m#{seconds}s"
       end
     end
   end

data/lib/minitest/reporters/junit_reporter.rb

@@ -52,6 +52,13 @@ module Minitest
         end
       end
 
+      def get_relative_path(result)
+        file_path = Pathname.new(get_source_location(result).first)
+        base_path = Pathname.new(@base_path)
+        file_path.relative_path_from(base_path) if file_path.absolute?
+        file_path
+      end
+
       private
 
       def get_source_location(result)
@@ -64,11 +71,9 @@ module Minitest
 
       def parse_xml_for(xml, suite, tests)
         suite_result = analyze_suite(tests)
-        file_path = Pathname.new(get_source_location(tests.first).first)
-        base_path = Pathname.new(@base_path)
-        relative_path = file_path.relative_path_from(base_path)
+        file_path = get_relative_path(tests.first)
 
-        xml.testsuite(:name => suite, :filepath => relative_path,
+        xml.testsuite(:name => suite, :filepath => file_path,
                       :skipped => suite_result[:skip_count], :failures => suite_result[:fail_count],
                       :errors => suite_result[:error_count], :tests => suite_result[:test_count],
                       :assertions => suite_result[:assertion_count], :time => suite_result[:time]) do
@@ -144,7 +149,8 @@ module Minitest
 
       def filename_for(suite)
         file_counter = 0
-        suite_name = suite.to_s[0..240].gsub(/[^a-zA-Z0-9]+/, '-') # restrict max filename length, to be kind to filesystems
+        # restrict max filename length, to be kind to filesystems
+        suite_name = suite.to_s[0..240].gsub(/[^a-zA-Z0-9]+/, '-')
         filename = "TEST-#{suite_name}.xml"
         while File.exist?(File.join(@reports_path, filename)) # restrict number of tries, to avoid infinite loops
           file_counter += 1

data/lib/minitest/reporters/mean_time_reporter.rb

@@ -4,7 +4,6 @@ require 'yaml'
 
 module Minitest
   module Reporters
-
     # This reporter creates a report providing the average (mean), minimum and
     # maximum times for a test to run. Running this for all your tests will
     # allow you to:
@@ -23,7 +22,6 @@ module Minitest
     #     rake reset_statistics
     #
     class MeanTimeReporter < Minitest::Reporters::DefaultReporter
-
       class InvalidOrder < StandardError; end
       class InvalidSortColumn < StandardError; end
 
@@ -385,7 +383,6 @@ module Minitest
 
         end
       end
-
     end
   end
 end

data/lib/minitest/reporters/rubymine_reporter.rb

@@ -48,7 +48,6 @@ else
           elsif ::Rake::TeamCity.is_in_buildserver_mode
             log(@message_factory.create_progress_message("Starting.. (#{total_count} tests)"))
           end
-
         end
 
         def report

data/lib/minitest/reporters/spec_reporter.rb

@@ -38,7 +38,7 @@ module Minitest
         puts suite
       end
 
-      def after_suite(suite)
+      def after_suite(_suite)
         puts
       end
 

data/lib/minitest/reporters/version.rb

@@ -1,5 +1,5 @@
 module Minitest
   module Reporters
-    VERSION = '1.3.2.beta1'.freeze
+    VERSION = '1.3.2.beta2'.freeze
   end
 end

data/test/fixtures/junit_filename_bug_example_test.rb

@@ -19,3 +19,23 @@ describe 'something/other' do
     1.must_equal 2
   end
 end
+
+class Eval
+  class Issue258Tset < Minitest::Test
+    def test_true
+      assert true
+    end
+
+    [
+        ["bool1", "true", "true"],
+        ["bool2", "false", "false"]
+    ].each do |a|
+      (type, expectation1, expectation2) = a
+      eval(%{
+       def test_eval_#{type}_#{expectation1}
+         assert_equal(#{expectation1}, #{expectation2})
+       end
+      })
+    end
+  end
+end

data/test/unit/minitest/junit_reporter_test.rb

@@ -0,0 +1,23 @@
+require_relative "../../test_helper"
+
+module MinitestReportersTest
+  class JUnitReporterUnitTest < Minitest::Test
+    def setup
+      @reporter = Minitest::Reporters::JUnitReporter.new(
+          "report",
+          false,
+          :base_apath => Dir.pwd
+      )
+      @result = Minitest::Result.new("test_name")
+    end
+
+    def test_relative_path
+      path = Pathname.new(__FILE__).relative_path_from(Pathname.new(Dir.pwd)).to_s
+      @result.source_location = [path, 10]
+      relative_path = @reporter.get_relative_path(@result)
+      assert_equal path, relative_path.to_s
+    end
+  end
+end
+
+

data/test/unit/minitest/spec_reporter_test.rb

@@ -41,6 +41,7 @@ module MinitestReportersTest
     def test_report_for_describe_not_using_const
       klass = describe("whatever") { it("passes") { assert true } }
       runnable = klass.runnable_methods.first
+      @reporter.io = StringIO.new
 
       # Run the test
       result = klass.new(runnable).run

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-reporters
 version: !ruby/object:Gem::Version
-  version: 1.3.2.beta1
+  version: 1.3.2.beta2
 platform: ruby
 authors:
 - Alexander Kern
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2018-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -125,6 +125,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- appveyor.yml
 - assets/default-reporter.png
 - assets/mean_time_reporter.png
 - assets/progress-reporter.png
@@ -160,6 +161,7 @@ files:
 - test/integration/reporters/progress_reporter_test.rb
 - test/test_helper.rb
 - test/unit/minitest/extensible_backtrace_filter_test.rb
+- test/unit/minitest/junit_reporter_test.rb
 - test/unit/minitest/mean_time_reporter_unit_test.rb
 - test/unit/minitest/minitest_reporter_plugin_test.rb
 - test/unit/minitest/reporters_test.rb