minitest-perf 0.0.1 → 0.0.2

data/README.md

@@ -1,7 +1,7 @@
 # MiniTest::Perf
 
 `minitest-perf` stores information about your minitest runs so that you can later analyze and see where
-the pain points are. It's in pretty early beta status, so I'm more than glad to receive bug reportsand 
+the pain points are. It's in pretty early beta status, so I'm more than glad to receive bug reports and
 feature suggestions.
 
 For now it should work with later versions of MiniTest 4, since the biggest test suite I have available
@@ -10,18 +10,28 @@ is with this version. MiniTest 5 probably doesn't work yet.
 ## How it works
 
 Every test that is executed is stored in a sqlite database for later query. Just require `minitet/perf`
-somewhere in your test_helper, and you're good to go. Internally, `minitest/perf` includes itself as 
+somewhere in your test_helper, and you're good to go. Internally, `minitest/perf` includes itself as
 just another module and starts feeding the sqlite database.
 
-The sqlite database is stored by default as `.minitest-perf.db`.
+The sqlite database is stored by default as `.minitest-perf.db`. It can be set using either the
+environment variable `MINITEST_PERF_DATABASE_URL`, or the `DATABASE_URL`.
 
-An executable is provided that does prints a very basic analysis of the information it already has,
-but the sqlite database is perfectly normal, so you can do your own queries.
+Or setting it directly via ruby with:
+
+```ruby
+MiniTest::Perf.database_url = 'sqlite3://localhost/some_other_file.db'
+```
+
+So far only local `sqlite3` databases allowed, but I'm using the database url strategy to allow for
+flexibility in the future.
+
+An executable is provided that prints a very basic analysis of the information it already has, but
+the sqlite database is perfectly normal, so you can do your own queries.
 
 This is an example:
 
 ```
-$ be minitest-perf
+$ minitest-perf
 Slowest individual tests
 
       190.98ms | JobsCategoriesControllerLoggedOutTest#test_show_action_should_render_show_page_without_contact_distance_call_for_logged_out_users
@@ -54,6 +64,5 @@ Slowest test suites
 
 These are nice to haves I'd like to implement in the future:
 
-* Customizable db file
 * Store also in mysql
 * Web interface

data/lib/minitest/perf.rb

@@ -9,6 +9,21 @@ module MiniTest::Perf
   autoload :Plugin, 'minitest/perf/plugin'
   autoload :Persistence, 'minitest/perf/persistence'
   autoload :Statistics,  'minitest/perf/statistics'
+
+  class << self
+    attr_accessor :database_url
+    attr_writer :persistence
+
+    def database_url
+      @database_url ||= ENV["MINITEST_PERF_DATABASE_URL"] ||
+                        ENV["DATABASE_URL"] ||
+                        'sqlite3://localhost/.minitest-perf.db'
+    end
+    def persistence
+      @persistence ||= Persistence.new(database_url)
+    end
+
+  end
 end
 
 class MiniTest::Unit::TestCase

data/lib/minitest/perf/persistence.rb

@@ -2,42 +2,52 @@ require 'sqlite3'
 
 module MiniTest
   module Perf
-    module Persistence
-      class << self
-        def write(test)
-          db.execute <<-SQL, [test.run.to_s, test.suite, test.name, test.total]
-            INSERT INTO tests (run, suite, name, total)
-            VALUES (?, ?, ?, ?)
-          SQL
-        end
+    class Persistence
+      attr_reader :database_url
 
-        def read_tests
-          db.execute("SELECT * FROM TESTS").map do |run, suite, name, total|
-            Test.new(run, suite, name, total)
-          end
-        end
+      def initialize(database_url = Perf.database_url)
+        @database_url = database_url
+      end
 
-        def sql(query)
-          db.execute query
-        end
+      def write(test)
+        db.execute <<-SQL, [test.run.to_s, test.suite, test.name, test.total]
+          INSERT INTO tests (run, suite, name, total)
+          VALUES (?, ?, ?, ?)
+        SQL
+      end
 
-        private
-
-        def db
-          @@db ||= begin
-                     db = SQLite3::Database.new ".minitest-perf.db"
-                     db.execute <<-SQL
-                      create table if not exists tests (
-                        run varchar(255),
-                        suite varchar(255),
-                        name varchar(255),
-                        total float
-                      );
-                     SQL
-                     db
-                   end
+      def read_tests
+        db.execute("SELECT * FROM TESTS").map do |run, suite, name, total|
+          Test.new(run, suite, name, total)
         end
       end
+
+      def sql(query)
+        db.execute query
+      end
+
+      private
+
+      def db
+        @db ||= begin
+                  db = SQLite3::Database.new sqlite3_db_name
+                  db.execute <<-SQL
+                    create table if not exists tests (
+                      run varchar(255),
+                      suite varchar(255),
+                      name varchar(255),
+                      total float
+                    );
+                  SQL
+                  db
+                end
+      end
+
+      ##
+      # Use a simple regexp, because for now, only sqlite3 is supported.
+      def sqlite3_db_name
+        @database_url.scan(/sqlite3:\/\/localhost\/(.+)/)[0][0]
+      end
     end
   end
 end

data/lib/minitest/perf/test.rb

@@ -11,7 +11,7 @@ module MiniTest
       end
 
       def persist
-        Persistence.write(self)
+        Perf.persistence.write(self)
       end
     end
   end

data/lib/minitest/perf/version.rb

@@ -1,5 +1,5 @@
 module MiniTest
   module Perf
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/test/perf/persistence_test.rb

@@ -3,19 +3,26 @@ require 'sqlite3'
 
 module MiniTest::Perf
   class PersistenceTest < MiniTest::Unit::TestCase
+    TEST_DB_FILE = '.minitest-perf-tests.db'
     def setup
-      @test = Test.new('run', 'suite', 'name', 10)
-      Persistence.sql "delete from tests"
+      File.delete(TEST_DB_FILE) rescue Errno::ENOENT # First time won't be here
+      @persistence = Persistence.new("sqlite3://localhost/#{TEST_DB_FILE}")
+      @persistence.sql "delete from tests"
     end
 
     def test_exposes_a_sql_interface
-      assert_instance_of Array, Persistence.sql('select * from tests')
+      assert_instance_of Array, @persistence.sql('select * from tests')
+    end
+
+    def test_really_creates_a_sqlite_db_file
+      db = SQLite3::Database.new TEST_DB_FILE
+      assert_instance_of Array, db.execute('select * from tests')
     end
 
     def test_stores_the_test_as_a_new_row
-      Persistence.write(@test)
+      @persistence.write(Test.new('run', 'suite', 'name', 10))
 
-      result = Persistence.sql "SELECT * FROM tests"
+      result = @persistence.sql "SELECT * FROM tests"
 
       assert_equal 1, result.size
 
@@ -26,5 +33,9 @@ module MiniTest::Perf
       assert_equal 'name',  name
       assert_equal 10,      total
     end
+
+    def test_uses_the_database_from_the_database_url
+      assert_equal 'sqlite3://localhost/.minitest-perf-tests.db', @persistence.database_url
+    end
   end
 end

data/test/perf/test_test.rb

@@ -14,7 +14,7 @@ module MiniTest::Perf
     def test_persists_calls_persistence
       test = Test.new('run', 'suite', 'name', 10)
 
-      Persistence.expects(:write).with(test)
+      MiniTest::Perf.persistence.expects(:write).with(test)
 
       test.persist
     end

data/test/perf_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+module MiniTest
+  class PerfTest < MiniTest::Unit::TestCase
+    def test_default_database
+      MiniTest::Perf.database_url = nil
+
+      assert_equal 'sqlite3://localhost/.minitest-perf.db', MiniTest::Perf.database_url
+    end
+
+    def test_customizable_database
+      MiniTest::Perf.persistence  = nil
+      MiniTest::Perf.database_url = 'sqlite3://localhost/some_other_file.db'
+
+      assert_equal 'sqlite3://localhost/some_other_file.db', MiniTest::Perf.database_url
+      assert_equal 'sqlite3://localhost/some_other_file.db', MiniTest::Perf.persistence.database_url
+    end
+  end
+end

metadata

@@ -2,14 +2,14 @@
 name: minitest-perf
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Albert Llop
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-21 00:00:00.000000000 Z
+date: 2013-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -135,6 +135,7 @@ files:
 - test/perf/plugin_test.rb
 - test/perf/run_test.rb
 - test/perf/test_test.rb
+- test/perf_test.rb
 - test/test_helper.rb
 homepage: https://github.com/mrsimo/minitest-perf
 licenses:
@@ -168,4 +169,5 @@ test_files:
 - test/perf/plugin_test.rb
 - test/perf/run_test.rb
 - test/perf/test_test.rb
+- test/perf_test.rb
 - test/test_helper.rb