minitest-parallel_fork 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 07a0f8e198d9bfcd52a03b4fe0870e49b90ce1dc28d9ada77a158baf406f6eb6
-  data.tar.gz: 51f5ee3699e9251138235ea2f4c65a676a2a849e4249ec5528e4614a30837146
+  metadata.gz: 42db9e813710ee5326a0df5f24f4b5deb361cc21372e6a87124008039526cddc
+  data.tar.gz: e29d3ab12e2559a840a9bf92dd4653f0e98397c0381167c3f1dbb1fc6c7391f7
 SHA512:
-  metadata.gz: 03fba31357a97e37091d85f6e7fad43c26999b9cc85d95302f0e8ea3432604ab12dc599b6db6228dd08cc6d5a2e30867648bbeb1f1bb2a470aee0b57c7bb7779
-  data.tar.gz: 5e5617bbfe70c8100afdecbc5908292a6c259caba96871189407d1c5d53108645a59375c4f603ecec62fcd5048ac4bec477c8786d94b09ccf593cdaf6cfacefc
+  metadata.gz: 4e45f180446e10b90ab9aaa7051261eec1e5c472422a1b5c522f7d58cd44f4f0adef68f2d875f3061c4902662e2ed190208d8448af6d89b6faf78445e132c9dc
+  data.tar.gz: 5d8b6fecb607917c6bc3940ad758eae573a32c5f5b803f68bddc2e3bada9a50c0668e0ddfdb84d9cd14ee357a53ae6b15cd2ca33c24830cf1b57ded37b92b463

data/CHANGELOG

@@ -1,3 +1,9 @@
+=== 1.1.1 (2018-05-07)
+
+* Work around marshalling issue when there are failures in *_all hooks when using minitest-hooks (jeremyevans)
+
+* Don't deadlock when a child process sends a large amount of marshalled data (chanks) (#4, #5)
+
 === 1.1.0 (2018-04-19)
 
 * Remove DumpableUnexpectedError, require minitest 5.11.0+ (jeremyevans)

data/lib/minitest/parallel_fork.rb

@@ -51,23 +51,24 @@ module Minitest
         end
 
         data = %w'count assertions results'.map{|meth| stat_reporter.send(meth)}
+        if data[-1].any?{|result| !result.is_a?(Minitest::Result)}
+          data[-1] = data[-1].map do |result|
+            Minitest::Result.from(result)
+          end
+        end
+
         write.write(Marshal.dump(data))
         write.close
       end
       write.close
     end
-    Process.waitall
 
-    Thread.new do
-      reads.each do |r|
-        data = r.read
-        r.close
-        count, assertions, results = Marshal.load(data)
-        stat_reporter.count += count
-        stat_reporter.assertions += assertions
-        stat_reporter.results.concat(results)
-      end
-    end.join
+    reads.map{|read| Thread.new(read, &:read)}.map(&:value).each do |data|
+      count, assertions, results = Marshal.load(data)
+      stat_reporter.count += count
+      stat_reporter.assertions += assertions
+      stat_reporter.results.concat(results)
+    end
 
     nil
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-parallel_fork
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-19 00:00:00.000000000 Z
+date: 2018-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest