minitest-hooks 1.4.2 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cab2b3cd7d0bc63cc18436e87e08ff392e9facfc
-  data.tar.gz: 82eed894ed6beab837d83fd94a64ab3c36e1acb4
+SHA256:
+  metadata.gz: e1b87392a55ca81f157fd989534fc2b79040ec5e195fca3c8a1b7ddffaf15213
+  data.tar.gz: 82e5b7956582f51edd760939dee7b27e0dc06f472fd15cf9c21fff8a9855394c
 SHA512:
-  metadata.gz: fa12984df59acb3da5d4d038f2d5aa83b758724a5f7a2d258f6f82ddc5d23d7afc739eaaa9b09bdd72befa7f040f693a398ced29b3086e6ef9278118753975bb
-  data.tar.gz: b2e8f5f4bdf2e1283711cb2b947da5ea5526eaf7e00bd2ec0912011764203c16f7ba376011df4898a4bb8108599b6e416b447859838af44d7adf229f89d152ee
+  metadata.gz: 7ebed42f49cb8283e0b7312b05b7e2f67f98532487b78666f9bd1be0f9b53cad6667ff865e8802d7567b1b16cc1c77d75213a5d1ca67cfcafb9363b62e3278dc
+  data.tar.gz: 6770a8438db15b61715c2743870d1f25adc77c9214b3fd80395d71ac16541ab932c39f735756b9308cf9721ca4641c1d8e53a684f7c8a95a9617a2e73c24c4cd

data/CHANGELOG

@@ -1,3 +1,7 @@
+=== 1.5.0 (2018-05-21)
+
+* Fix use with minitest 5.11+ by using Minitest::Result in such cases (GUI) (#15)
+
 === 1.4.2 (2017-09-12)
 
 * Don't modify test instance name if before_all/after_all cause an error (jeremyevans) (#14)

data/lib/minitest/hooks/test.rb

@@ -64,40 +64,39 @@ module Minitest::Hooks::ClassMethods
   def with_info_handler(reporter, &block)
     @instance = new(NEW)
     @instance.time = 0
-    description = respond_to?(:desc) ? desc : name
-    @instance.name = "#{description}#around_all"
+    @instance.name = "around_all"
    
     begin
       @instance.around_all do
         begin
           @instance.capture_exceptions do
-            @instance.name = "#{description}#before_all"
+            @instance.name = "before_all"
             @instance.before_all
           end
 
           if @instance.failure
             failed = true
-            reporter.record @instance
+            _record_minitest_hooks_error(reporter, @instance)
           else
             super(reporter, &block)
           end
         ensure
           @instance.capture_exceptions do
-            @instance.name = "#{description}#after_all" unless failed
+            @instance.name = "after_all" unless failed
             @instance.after_all
           end
           if @instance.failure && !failed
             failed = true
-            reporter.record @instance
+            _record_minitest_hooks_error(reporter, @instance)
           end
-          @instance.name = "#{description}#around_all" unless failed
+          @instance.name = "around_all" unless failed
         end
       end
     rescue => e
       @instance.capture_exceptions do
         raise e
       end
-      reporter.record @instance
+      _record_minitest_hooks_error(reporter, @instance)
     end
   end
 
@@ -132,4 +131,17 @@ module Minitest::Hooks::ClassMethods
       super
     end
   end
+
+  private
+
+  def _record_minitest_hooks_error(reporter, instance)
+    # In MiniTest 5.11+, use Minitest::Result for wrapping the object to send
+    # to the reporter.
+    if(defined?(Minitest::Result))
+      result = Minitest::Result.from(instance)
+    else
+      result = instance
+    end
+    reporter.record result
+  end
 end

data/spec/errors/example.rb

@@ -3,6 +3,32 @@ require 'minitest/hooks/default'
 
 error = ENV['MINITEST_HOOKS_ERRORS']
 
+module Minitest
+  def self.plugin_result_inspector_reporter_init(options)
+    self.reporter << ResultInspectorReporter.new(options[:io], options)
+  end
+
+  class ResultInspectorReporter < SummaryReporter
+    def report
+      results.each do |result|
+        io.puts "result to_s: #{result.to_s.inspect}"
+        # For MiniTest 5.11+, we expect Minitest::Result objects.
+        if defined?(Minitest::Result)
+          io.puts "result source_location: #{result.source_location.inspect}"
+        else
+          # For older versions of Minitest, extract source_location in a
+          # similar fashion to how some third party reporters expected to be
+          # able to:
+          # https://github.com/circleci/minitest-ci/blob/8b72b0f32f154d91b53d63d1d0a8a8fb3b01d726/lib/minitest/ci_plugin.rb#L139
+          io.puts "result source_location: #{result.method(result.name).source_location.inspect}"
+        end
+      end
+    end
+  end
+end
+
+Minitest.extensions << "result_inspector_reporter"
+
 describe 'Minitest::Hooks error handling' do
   before(:all) do
     raise if error == 'before-all'
@@ -26,11 +52,11 @@ describe 'Minitest::Hooks error handling' do
     super(&block)
     case error
     when 'before-all'
-      name.must_equal 'Minitest::Hooks error handling#before_all'
+      name.must_equal 'before_all'
     when 'after-all'
-      name.must_equal 'Minitest::Hooks error handling#after_all'
+      name.must_equal 'after_all'
     else
-      name.must_equal 'Minitest::Hooks error handling#around_all'
+      name.must_equal 'around_all'
     end
     raise if error == 'around-all-after'
   end

data/spec/minitest_hooks_all_name_spec.rb

@@ -3,15 +3,15 @@ require 'minitest/hooks/default'
 
 describe 'Minitest::Hooks error handling' do
   before(:all) do
-    name.must_equal 'Minitest::Hooks error handling#before_all'
+    name.must_equal 'before_all'
   end
   after(:all) do
-    name.must_equal 'Minitest::Hooks error handling#after_all'
+    name.must_equal 'after_all'
   end
   around(:all) do |&block|
-    name.must_equal 'Minitest::Hooks error handling#around_all'
+    name.must_equal 'around_all'
     super(&block)
-    name.must_equal 'Minitest::Hooks error handling#around_all'
+    name.must_equal 'around_all'
   end
 
   3.times do |i|
@@ -24,15 +24,15 @@ class MinitestHooksNameTest < Minitest::Test
   include Minitest::Hooks
 
   def before_all
-    assert_equal 'MinitestHooksNameTest#before_all', name
+    assert_equal 'before_all', name
   end
   def after_all
-    assert_equal 'MinitestHooksNameTest#after_all', name
+    assert_equal 'after_all', name
   end
   def around_all
-    assert_equal 'MinitestHooksNameTest#around_all', name
+    assert_equal 'around_all', name
     super
-    assert_equal 'MinitestHooksNameTest#around_all', name
+    assert_equal 'around_all', name
   end
 
   3.times do |i|

data/spec/minitest_hooks_errors_spec.rb

@@ -9,8 +9,13 @@ describe 'Minitest::Hooks error handling' do
     it "should handle errors in #{desc}" do
       ENV['MINITEST_HOOKS_ERRORS'] = desc
       Open3.popen3(RUBY, "spec/errors/example.rb", "-v") do  |_, o, e, w|
-        o.read.must_match /#{runs} runs, 0 assertions, 0 failures, #{errors} errors, 0 skips/
-        e.read.must_equal ''
+        output = o.read
+        output.must_match /#{runs} runs, 0 assertions, 0 failures, #{errors} errors, 0 skips/
+        output.must_match /result to_s: ".*?Minitest::Hooks error handling#\w+.*?spec\/errors\/example\.rb:\d+/
+        output.must_match /result source_location: \["(unknown|.+?\.rb)", -?\d+\]/
+        output = e.read
+        output.gsub!(/Picked up _JAVA_OPTIONS: [^\n]+\n/, '')
+        output.must_equal ''
         w.value.exitstatus.wont_equal 0 if w
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-hooks
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.5.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-12 00:00:00.000000000 Z
+date: 2018-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '5'
-  type: :development
+        version: '5.3'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: sequel
   requirement: !ruby/object:Gem::Requirement
@@ -121,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Around and before_all/after_all/around_all hooks for Minitest