minitest-hooks 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 678da317b529ac1cf071fd42f4abd5d325ccfb55
-  data.tar.gz: 2462e95a886cc806fe5fd14caa1157ab19ce9efe
+  metadata.gz: 46c586c45d801e02455f2d74a92f50e01a17d879
+  data.tar.gz: e9d4dbde7545d3d5fbe792c83ddf2760a88944c9
 SHA512:
-  metadata.gz: 34e5d358da0294ec5819af4afaa9594bfa313008d8f038986d494b33e9600161ab0a076c3bc42a60f49e57eba62fb56cecf2f02dcfaf76388d896062d4370429
-  data.tar.gz: efe83c55538e493b71104e53a8a20a24fc1be05c8b5f1250f3bed6f5a35c23f76a427df209e46da6f06dfc329ad1250a7aeb62447a9f954800bc73be2dda83d7
+  metadata.gz: b9d8417604cb8cb9b55bfea18bd4b6d5ce4668f7efa50fcfbe9f63211ba7217ff072b3769c8789bd6f7284604fd39a5452d0eace4718ced3206718e64925a4cf
+  data.tar.gz: 89eb265c8ec02d84cafa99440e80c6b681ef9e40d2f30207067b6ac773d2fe6a201827f0f484b406480e5a06d6c10e5166d64eb112fcd57ef79e14e52b071a6f

data/CHANGELOG

@@ -1,3 +1,7 @@
+=== 1.4.0 (2015-11-17)
+
+* Handle errors in before(:all)/after(:all)/around(:all) hooks (jeremyevans)
+
 === 1.3.0 (2015-08-17)
 
 * Don't run before_all/after_all/around_all hooks for classes with no tests/specs when using minitest >= 5.8.0 (jeremyevans) (#7)

data/Rakefile

@@ -12,6 +12,8 @@ end
 
 desc "Run specs"
 task :spec do
+  ENV['RUBY'] = FileUtils::RUBY
+  ENV['RUBYLIB'] = "lib:#{ENV['RUBYLIB']}"
   sh %{#{FileUtils::RUBY} -I lib -e 'ARGV.each{|f| require f}' ./spec/*.rb}
 end
 

data/lib/minitest/hooks/test.rb

@@ -63,14 +63,38 @@ module Minitest::Hooks::ClassMethods
   # dup of the singleton instance.
   def with_info_handler(reporter, &block)
     @instance = new(NEW)
+    inside = false
+   
+    begin
+      @instance.around_all do
+        inside = true
+        begin
+          @instance.capture_exceptions do
+            @instance.before_all
+          end
 
-    @instance.around_all do
-      begin
-        @instance.before_all
-        super(reporter, &block)
-      ensure
-        @instance.after_all
+          if @instance.failure
+            failed = true
+            reporter.record @instance
+          else
+            super(reporter, &block)
+          end
+        ensure
+          @instance.capture_exceptions do
+            @instance.after_all
+          end
+          if @instance.failure && !failed
+            failed = true
+            reporter.record @instance
+          end
+          inside = false
+        end
       end
+    rescue => e
+      @instance.capture_exceptions do
+        raise e
+      end
+      reporter.record @instance
     end
   end
 

data/spec/errors/example.rb

@@ -0,0 +1,34 @@
+require './spec/helper'
+require 'minitest/hooks/default'
+
+error = ENV['MINITEST_HOOKS_ERRORS']
+
+describe 'Minitest::Hooks error handling' do
+  before(:all) do
+    raise if error == 'before-all'
+  end
+  before do
+    raise if error == 'before'
+  end
+  after do
+    raise if error == 'after'
+  end
+  after(:all) do
+    raise if error == 'after-all'
+  end
+  around do |&block|
+    raise if error == 'around-before'
+    super(&block)
+    raise if error == 'around-after'
+  end
+  around(:all) do |&block|
+    raise if error == 'around-all-before'
+    super(&block)
+    raise if error == 'around-all-after'
+  end
+
+  3.times do |i|
+    it "should work try #{i}" do
+    end
+  end
+end

data/spec/minitest_hooks_errors_spec.rb

@@ -0,0 +1,27 @@
+require './spec/helper'
+require 'minitest/hooks/default'
+require 'open3'
+
+RUBY = ENV['RUBY'] || 'ruby'
+
+describe 'Minitest::Hooks error handling' do
+  def self.run_test(desc, runs, errors)
+    it "should handle errors in #{desc}" do
+      ENV['MINITEST_HOOKS_ERRORS'] = desc
+      Open3.popen3(RUBY, "spec/errors/example.rb") do  |_, o, e, w|
+        o.read.must_match /#{runs} runs, 0 assertions, 0 failures, #{errors} errors, 0 skips/
+        e.read.must_equal ''
+        w.value.exitstatus.wont_equal 0 if w
+      end
+    end
+  end
+
+  run_test "before-all", 1, 1
+  run_test "before", 3, 3
+  run_test "after", 3, 3
+  run_test "after-all", 4, 1
+  run_test "around-before", 1, 1
+  run_test "around-after", 1, 1
+  run_test "around-all-before", 1, 1
+  run_test "around-all-after", 4, 1
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-hooks
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-17 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -86,8 +86,10 @@ files:
 - lib/minitest/hooks.rb
 - lib/minitest/hooks/default.rb
 - lib/minitest/hooks/test.rb
+- spec/errors/example.rb
 - spec/helper.rb
 - spec/minitest_hooks_direct_spec.rb
+- spec/minitest_hooks_errors_spec.rb
 - spec/minitest_hooks_spec.rb
 - spec/minitest_hooks_test.rb
 homepage: http://github.com/jeremyevans/minitest-hooks
@@ -117,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Around and before_all/after_all/around_all hooks for Minitest