minitest-heat 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e33245f206aa23bcbad541459db13fb8f6f088df51777850bb1276369dc0b3b
-  data.tar.gz: f66fd4f6ba49d1f80be0f97e0d54fd5fa5a2f4fa2063a57f20d9f46520d17ed2
+  metadata.gz: 3c787ecc1dc1259c0dd25a3f245476c353d7b2dcab4050876965470c1f117a17
+  data.tar.gz: 1eab9c751b578a6eedfeffe8b7029df9699e25e7d9e644b2e472a47b3fba1f0d
 SHA512:
-  metadata.gz: 24897c2218d77cae17eba80b0e28f24df8f051d13f3f2cddeb47ffabb4730a19b45601f34119749f7fa3d7828fbe617313821d6939cf41653e6559e91bf74526
-  data.tar.gz: 38b9e2b060ba864243e384ef260bfb9f771b607bc2786668d462abee84142d5505f3de63182e8238e94bc8ba01932f991125a4db1fcceb4252d764afcc7a62f8
+  metadata.gz: 56ad59e3df9468d7157f43e7d033e9187a66da1c11e388286ad25d140094ace8219e5c86e86891afe587f86d2c11df3e16ef900cef7db815ca50df3e35320fe8
+  data.tar.gz: 35fc16047ced8c8718b42cfcaa0cf0ee6796c8953f21f67db6edab23fc802a1659858bdffb77d853c4530359afea83417f6efa32485d7053d48b7baf568c7dff

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    minitest-heat (0.0.7)
+    minitest-heat (0.0.8)
       minitest
 
 GEM

data/lib/minitest/heat/hit.rb

@@ -15,11 +15,11 @@ module Minitest
       #   test is broken (i.e. raising an exception), that's a special sort of failure that would be
       #   misleading. It doesn't represent a proper failure, but rather a test that doesn't work.
       WEIGHTS = {
-        error: 3,    # exceptions from source code have the highest likelihood of a ripple effect
-        broken: 2,   # broken tests won't have ripple effects but can't help if they can't run
-        failure: 1,  # failures are kind of the whole point, and they could have ripple effects
-        skipped: 0,  # skips aren't failures, but they shouldn't go ignored
-        painful: 0,  # slow tests aren't failures, but they shouldn't be ignored
+        error: 5,    # exceptions from source code have the highest likelihood of a ripple effect
+        broken: 4,   # broken tests won't have ripple effects but can't help if they can't run
+        failure: 3,  # failures are kind of the whole point, and they could have ripple effects
+        skipped: 2,  # skips aren't failures, but they shouldn't go ignored
+        painful: 1,  # slow tests aren't failures, but they shouldn't be ignored
         slow: 0
       }.freeze
 
@@ -43,10 +43,6 @@ module Minitest
         (Time.now - mtime).to_i
       end
 
-      def critical_issues?
-        issues[:error].any? || issues[:broken].any? || issues[:failure].any?
-      end
-
       def issue_count
         count = 0
         Issue::TYPES.each do |issue_type|

data/lib/minitest/heat/map.rb

@@ -7,22 +7,6 @@ module Minitest
 
       attr_reader :hits
 
-      # So we can sort hot spots by liklihood of being the most important spot to check out before
-      #   trying to fix something. These are ranked based on the possibility they represent ripple
-      #   effects where fixing one problem could potentially fix multiple other failures.
-      #
-      #   For example, if there's an exception in the file, start there. Broken code can't run. If a
-      #   test is broken (i.e. raising an exception), that's a special sort of failure that would be
-      #   misleading. It doesn't represent a proper failure, but rather a test that doesn't work.
-      WEIGHTS = {
-        error: 3,    # exceptions from source code have the highest liklihood of a ripple effect
-        broken: 2,   # broken tests won't have ripple effects but can't help if they can't run
-        failure: 1,  # failures are kind of the whole point, and they could have ripple effects
-        skipped: 0,  # skips aren't failures, but they shouldn't go ignored
-        painful: 0,  # slow tests aren't failures, but they shouldn't be ignored
-        slow: 0
-      }.freeze
-
       def initialize
         @hits = {}
       end

data/lib/minitest/heat/output/map.rb

@@ -4,22 +4,23 @@ module Minitest
   module Heat
     class Output
       class Map
-        # extend Forwardable
+        attr_accessor :results
 
-        attr_accessor :map
-
-        # def_delegators :@results, :errors, :brokens, :failures, :slows, :skips, :problems?, :slows?
-
-        def initialize(map)
-          @map = map
+        def initialize(results)
+          @results = results
           @tokens = []
         end
 
         def tokens
-          map.file_hits.each do |file|
+          map.file_hits.each do |hit|
+            file_tokens = pathname(hit)
+            line_number_tokens = line_numbers(hit)
+
+            next if line_number_tokens.empty?
+
             @tokens << [
-              *pathname(file),
-              *line_numbers(file)
+              *file_tokens,
+              *line_number_tokens
             ]
           end
 
@@ -28,6 +29,20 @@ module Minitest
 
         private
 
+        def map
+          results.heat_map
+        end
+
+        def relevant_issue_types
+          issue_types = %i[error broken failure]
+
+          issue_types << :skipped unless results.problems?
+          issue_types << :painful unless results.problems? || results.skips.any?
+          issue_types << :slow    unless results.problems? || results.skips.any?
+
+          issue_types
+        end
+
         def pathname(file)
           directory = "#{file.pathname.dirname.to_s.delete_prefix(Dir.pwd)}/"
           filename = file.pathname.basename.to_s
@@ -40,11 +55,8 @@ module Minitest
         end
 
         def hit_line_numbers(file, issue_type)
-          line_numbers_for_issue_type = file.issues.fetch(issue_type) { [] }
-
-          return nil if line_numbers_for_issue_type.empty?
-
           numbers = []
+          line_numbers_for_issue_type = file.issues.fetch(issue_type) { [] }
           line_numbers_for_issue_type.sort.map do |line_number|
             numbers << [issue_type, "#{line_number} "]
           end
@@ -52,14 +64,11 @@ module Minitest
         end
 
         def line_numbers(file)
-          [
-            *hit_line_numbers(file, :error),
-            *hit_line_numbers(file, :broken),
-            *hit_line_numbers(file, :failure),
-            *hit_line_numbers(file, :skipped),
-            *hit_line_numbers(file, :painful),
-            *hit_line_numbers(file, :slow)
-          ].compact.sort_by { |number_token| number_token[1] }
+          line_number_tokens = []
+          relevant_issue_types.each do |issue_type|
+            line_number_tokens += hit_line_numbers(file, issue_type)
+          end
+          line_number_tokens.compact.sort_by { |number_token| number_token[1] }
         end
       end
     end

data/lib/minitest/heat/results.rb

@@ -4,14 +4,16 @@ module Minitest
   module Heat
     # A collection of test failures
     class Results
-      attr_reader :issues
+      attr_reader :issues, :heat_map
 
       def initialize
         @issues = []
+        @heat_map = Heat::Map.new
       end
 
       def record(issue)
-        @issues << issue
+        @issues.push(issue)
+        @heat_map.add(*issue.to_hit) if issue.hit?
       end
 
       def problems?

data/lib/minitest/heat/version.rb

@@ -2,6 +2,6 @@
 
 module Minitest
   module Heat
-    VERSION = '0.0.7'
+    VERSION = '0.0.8'
   end
 end

data/lib/minitest/heat_reporter.rb

@@ -32,15 +32,13 @@ module Minitest
     attr_reader :output,
                 :options,
                 :timer,
-                :results,
-                :map
+                :results
 
     def initialize(io = $stdout, options = {})
       @options = options
 
       @timer =    Heat::Timer.new
       @results =  Heat::Results.new
-      @map =      Heat::Map.new
       @output =   Heat::Output.new(io)
     end
 
@@ -68,7 +66,6 @@ module Minitest
 
       timer.increment_counts(issue.result.assertions)
       results.record(issue)
-      map.add(*issue.to_hit) if issue.hit?
 
       output.marker(issue.type)
     end
@@ -97,7 +94,7 @@ module Minitest
 
       # If there were issues, shows a short heat map summary of which files and lines were the most
       # common sources of issues
-      output.heat_map(map)
+      output.heat_map(results)
 
       # A blank line to create some breathing room
       output.newline

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-heat
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Garrett Dimon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-14 00:00:00.000000000 Z
+date: 2021-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest