minitest-ci 1.0.3 → 1.0.4

data/lib/minitest/ci.rb

@@ -31,7 +31,7 @@ module MiniTest
     ###
     CI_MINI_DIR = File.dirname(File.dirname(file))
 
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
 
     @test_dir = nil #'test/reports'
     @error = nil
@@ -120,7 +120,7 @@ module MiniTest
           f.puts "  <testcase time='#{"%6f" % time}' name='#{method}' assertions='#{asserts}'>"
           if error
             bt = filter_backtrace(error.backtrace).join "\n"
-            f.write "    <#{type error} type='#{escape error.class}' message='#{escape error.message}'>"
+            f.write "    <#{type error} type='#{escape error.class}' message=#{escape( error.message ).inspect}>"
             f.puts escape bt
             f.puts "    </#{type error}>"
           end

data/test/test_minitest_ci.rb

@@ -27,6 +27,10 @@ class MockTestSuite < MiniTest::Unit::TestCase
   def test_invalid_error_name
     raise Class.new(Exception)
   end
+
+  def test_escaping_failure_message
+    flunk "failed: doesn't like single or \"double\" quotes or symbols such as <"
+  end
 end
 
 class TestMinitest
@@ -61,15 +65,15 @@ class TestMinitest::TestCi < MiniTest::Unit::TestCase
 
   def test_testsuite
     assert_equal "1", @doc['skipped']
-    assert_equal "1", @doc['failures']
+    assert_equal "2", @doc['failures']
     assert_equal "4", @doc['errors']
-    assert_equal "2", @doc['assertions']
-    assert_equal "6", @doc['tests']
+    assert_equal "3", @doc['assertions']
+    assert_equal "7", @doc['tests']
     assert_equal "MockTestSuite", @doc['name']
   end
 
   def test_testcase
-    assert_equal 6, @doc.children.count {|c| Nokogiri::XML::Element === c}
+    assert_equal 7, @doc.children.count {|c| Nokogiri::XML::Element === c}
     @doc.children.each do |c|
       next unless Nokogiri::XML::Element === c
       assert_equal 'testcase', c.name
@@ -98,6 +102,11 @@ class TestMinitest::TestCi < MiniTest::Unit::TestCase
     error = @doc.at_xpath('/testsuite/testcase[@name="test_invalid_error_name"]')
     assert_match( /^#<Class/, error.at_xpath('failure')['message'] )
     assert_equal '0', error['assertions']
+
+    error = @doc.at_xpath('/testsuite/testcase[@name="test_escaping_failure_message"]')
+    msg = "failed: doesn't like single or \"double\" quotes or symbols such as <"
+    assert_equal msg, error.at_xpath('failure')['message']
+    assert_equal '1', error['assertions']
   end
 
   def test_output

metadata

@@ -2,7 +2,7 @@
 name: minitest-ci
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors: 
 - Brian Henderson
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-04 00:00:00 Z
+date: 2011-10-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: minitest
@@ -103,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: minitest-ci
-rubygems_version: 1.8.10
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: CI reporter plugin for MiniTest This gem was made possible by ATT Interactive.