minitest-around 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 713334daf3b3e114e8d5bf5aa6a4767fe8cfddef
-  data.tar.gz: 4c485989c943ccddc3b3aa515ddc2923a590770a
+  metadata.gz: 58fd3c77c52798c76e4b1ee4ea7c52e48cc38d2b
+  data.tar.gz: e640ebafb486d4c355e850679ad68d9472b3b6f8
 SHA512:
-  metadata.gz: 601fbba788d9d5983ea09cecd1d7658d7ce913636f87014d3691e0a5484e5c07427901f475ff45015bfd50ea0c02edfc7621ec2a49341e31c812c78a0dfab111
-  data.tar.gz: 5d67a70bf24e57b8d3a9e8af8be0e70bbba37b3afec9d14b507d882d43fc4c0bdfb763e547dbdfda43157271ca8f22b45fd34cd5384abe85c719b63c1c6f864c
+  metadata.gz: bceba5d95427bffd1fc6488fc36d8f1e259d1084b5648ec2c080b9adf6da079a14d35c983c3a670d6cc1db8b0044ef59c483e7fb2ef28ff9c68873a36d632407
+  data.tar.gz: 8915f7bc547c3b2db4481f1038d943bbc0c98d6740123805e5647df7f6bef11b3279b7ed15ddaad7ebbc8b7b8872f0377eab3dbab025dca4ac4ac093ba64972e

data/Rakefile

@@ -3,7 +3,7 @@ require 'bundler/gem_tasks'
 require 'cucumber/rake/task'
 
 desc 'Default: run unit tests.'
-task :default => [:test, :features]
+task :default => [:test, :"test:isolated", :features]
 
 # Test
 TEST_FILES = FileList.new('test/*_{test,spec}.rb')

data/features/around_spec.feature

@@ -86,6 +86,29 @@ Feature: `around` hooks
     When I run `rspec example_spec.rb`
     Then the output should contain "this should show up in the output"
 
+  Scenario: An around hook continues to run even if the example throws an exception
+    Given a file named "example_spec.rb" with:
+      """ruby
+        RSpec.describe "something" do
+          around(:example) do |example|
+            puts "around example setup"
+            example.run
+            puts "around example cleanup"
+          end
+
+          it "still executes the entire around hook" do
+            fail "the example blows up"
+          end
+        end
+      """
+    When I run `rspec example_spec.rb`
+    Then the output should contain "1 example, 1 error"
+    And the output should contain:
+      """
+      around example setup
+      around example cleanup
+      """
+
   @rspec
   Scenario: Define a global `around` hook
     Given a file named "example_spec.rb" with:
@@ -220,9 +243,11 @@ Feature: `around` hooks
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the output should contain:
       """
-      Pending:
-        implicit pending example should be detected as Not yet implemented
-          # Not yet implemented
+      Pending: (Failures listed here are expected and do not affect your suite's status)
+
+        1) implicit pending example should be detected as Not yet implemented
+           # Not yet implemented
+           # ./example_spec.rb:6
       """
 
 
@@ -245,8 +270,10 @@ Feature: `around` hooks
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the output should contain:
       """
-        explicit pending example should be detected as pending
-          # No reason given
+      Pending: (Failures listed here are expected and do not affect your suite's status)
+
+        1) explicit pending example should be detected as pending
+           # No reason given
       """
 
   Scenario: Multiple `around` hooks in the same scope

data/features/step_definitions/around_steps.rb

@@ -10,14 +10,15 @@ When(/^I run `rspec.*?(\S+)`$/) do |filename|
 end
 
 Then(/^the output should contain:$/) do |content|
-  assert_includes @output, content
+  assert_includes @output, content, @output
 end
 
 Then(/^the output should contain "(.*?)"$/) do |content|
   # 1 runs, 0 assertions, 0 failures, 0 errors, 0 skips
   runs = $1 if content =~ /(\d+) examples?/
+  errors = $1 if content =~ /(\d+) errors?/
   failures = $1 if content =~ /(\d+) failures?/
   skips = $1 if content =~ /(\d+) pending/
-  content = /#{runs} runs, \d+ assertions, #{failures} failures, 0 errors, #{skips || 0} skips/
-  assert_match content, @output
+  content = /#{runs} runs, \d+ assertions, #{failures || 0} failures, #{errors || 0} errors, #{skips || 0} skips/
+  assert_match content, @output, @output
 end

data/features/support/env.rb

@@ -15,12 +15,12 @@ class MyWorld
     content.gsub!("RSpec.describe", "describe")
     # example.run -> example.call
     content.gsub!("example.run", "example.call")
+    # expect(..).to .. -> expect(..).must_equal ..
+    content.gsub!("to eq", "must_equal")
 
     content = <<-RUBY + content
       require 'minitest/autorun'
-      require "#{File.expand_path("../../../lib/minitest/around/spec", __FILE__)}"
-
-      require 'rspec/expectations/minitest_integration'
+      require '#{File.expand_path("../../../lib/minitest/around/spec", __FILE__)}'
     RUBY
     write_file(filename, content)
   end

data/lib/minitest/around/version.rb

@@ -1,3 +1,3 @@
 module MinitestAround
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

data/minitest-around.gemspec

@@ -14,5 +14,4 @@ Gem::Specification.new "minitest-around", MinitestAround::VERSION do |s|
   s.add_development_dependency 'rdoc'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'cucumber'
-  s.add_development_dependency 'rspec-expectations'
 end

data/test/nested_spec.rb

@@ -1,36 +1,36 @@
 require_relative 'helper'
 require 'minitest/around'
 
-$var = []
-
 describe 'Outer' do
+  let(:var) { [] }
+
   before do
-    $var << :before
+    var << :before
   end
   after do
-    $var << :after
-    $var.must_equal [:before, :begin, :ibefore, :ibegin, :during, :iend, :iafter, :end, :after]
+    var << :after
+    var.must_equal [:before, :begin, :ibefore, :ibegin, :during, :iend, :iafter, :end, :after]
   end
   around do |test|
-    $var << :begin
+    var << :begin
     test.call
-    $var << :end
+    var << :end
   end
 
   describe 'Inner' do
     before do
-      $var << :ibefore
+      var << :ibefore
     end
     after do
-      $var << :iafter
+      var << :iafter
     end
     around do |test|
-      $var << :ibegin
+      var << :ibegin
       test.call
-      $var << :iend
+      var << :iend
     end
     it 'testing' do
-      $var << :during
+      var << :during
     end
   end
 end

data/test/nested_test.rb

@@ -1,36 +1,35 @@
 require_relative 'helper'
 require 'minitest/around/unit'
 
-$var = []
-
 class OuterNestedTest < Minitest::Test
+  @@var = []
   def setup
-    $var << :before
+    @@var << :before
   end
   def teardown
-    $var << :after
-    $var.must_equal [:before, :ibefore, :begin, :ibegin, :during, :iend, :end, :iafter, :after]
+    @@var << :after
+    @@var.must_equal [:before, :ibefore, :begin, :ibegin, :during, :iend, :end, :iafter, :after]
   end
   def around
-    $var << :begin
+    @@var << :begin
     yield
-    $var << :end
+    @@var << :end
   end
 end
 
 class InnerNestedTest < OuterNestedTest
   def setup
-    $var << :ibefore
+    @@var << :ibefore
   end
   def teardown
-    $var << :iafter
+    @@var << :iafter
   end
   def around
-    $var << :ibegin
+    @@var << :ibegin
     yield
-    $var << :iend
+    @@var << :iend
   end
   def test_nesting
-    $var << :during
+    @@var << :during
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: minitest-around
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Peter Suschlik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-15 00:00:00.000000000 Z
+date: 2015-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -66,20 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-expectations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Alternative for setup/teardown dance.
 email:
 - peter-minitest-around@suschlik.de
@@ -128,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Around block for minitest.