minitest-allow 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d4b452b249bcbf28fd6a1fe02554605287695f5132a49355c1ff86d9670050c
-  data.tar.gz: 43f8db6fc12c23fef4ea9ae778f67d49ddfea0a394f599c65258519913682d80
+  metadata.gz: f24ec8511a2369224f41c4a036d52efa431c102690aa1f933097a863e13df8e0
+  data.tar.gz: b5e459178923fd55debdc76f1bd8e0647ababe7fccb457839c2f2599c0bb8f7c
 SHA512:
-  metadata.gz: c440e3f3205155ff80a83bc5abbeb2e70b2a225c50097ae8a25a3346fe11a60d1d845aa71717e80f45649bbb61180926b6dfe8562ef6ae70ea5451e024685255
-  data.tar.gz: cb00914e91781619a1ac7eb85cba9f2734b3163e0abdb96c4f474cf1e916274d6c35dcc82a50d07bf4e34f9bcc670c2f69dca1d063410666f9029cfc232930cd
+  metadata.gz: a4e5a3e8bfda70b669f185b92280ea1146a18a61533d5508d256ea72f04672e1f3691505dad3b0c643d46ec98577bf681170cc7605c0db1edc82f1d60861eaa3
+  data.tar.gz: e9d36c2adcb5fa8005b4e2a7eeeecfe35b20bc0822f02ecccd71b419f6e63ffa46a7d544363ffffcf917d4105cc3e3bb23a9b8e36f3248a47ff088702cd46b21

data/History.rdoc

@@ -1,3 +1,10 @@
+=== 1.1.0 / 2021-04-19
+
+* 2 minor enhancements:
+
+  * This works even when running subsets of tests (eg parallel in a CI)
+  * Tracks tests that are allowed yet pass and can thus be removed from allowed list.
+
 === 1.0.0 / 2021-04-02
 
 * 1 major enhancement

data/lib/minitest/allow_plugin.rb

@@ -1,5 +1,7 @@
 module Minitest
   def self.plugin_allow_options opts, _options # :nodoc:
+    @allow = @allow_save = false
+
     opts.on "-a", "--allow=path", String, "Allow listed tests to fail." do |f|
       require "yaml"
       @allow = YAML.load File.read f
@@ -14,10 +16,10 @@ module Minitest
   def self.plugin_allow_init options # :nodoc:
     if @allow || @allow_save then
       self.reporter.extend Allow
+      self.reporter.allow      = @allow
+      self.reporter.allow_save = @allow_save
+      self.reporter.allow_seen = []
     end
-
-    self.reporter.allow      = @allow      if @allow
-    self.reporter.allow_save = @allow_save if @allow_save
   end
 
   class Result # TODO: push up
@@ -26,10 +28,21 @@ module Minitest
     end
   end
 
+  class Minitest::Test # sigh... rails
+    def full_name
+      "%s#%s" % [self.class, name]
+    end
+  end
+
   module Allow
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
 
-    attr_accessor :allow, :allow_save
+    attr_accessor :allow, :allow_save, :allow_seen
+
+    def record result
+      allow_seen << result.full_name
+      super
+    end
 
     def allow_results
       self.reporters
@@ -39,7 +52,8 @@ module Minitest
 
     def write_allow
       data = allow_results
-        .flat_map { |rs| rs.map(&:full_name) }
+        .flatten
+        .map(&:full_name)
         .uniq
         .sort
 
@@ -47,18 +61,33 @@ module Minitest
     end
 
     def filter_allow
+      maybe_bad = allow_results.flatten.map(&:full_name).uniq
+      to_remove = maybe_bad & allow
+      extra_bad = maybe_bad - to_remove
+
+      self.allow -= to_remove
+
       allow_results.each do |results|
-        results.delete_if { |r| allow.delete r.full_name }
+        results.delete_if { |r| to_remove.include? r.full_name }
+      end
+
+      unless extra_bad.empty? then
+        io.puts
+        io.puts "Bad tests that are NOT allowed:"
+        io.puts
+        io.puts extra_bad.to_yaml
       end
     end
 
     def report_extra_allow
-      unless allow.empty? then
+      good = allow & allow_seen
+
+      unless good.empty? then
         io.puts
         io.puts "Excluded tests that now pass:"
         io.puts
-        allow.each do |name|
-          io.puts "  #{name}"
+        good.each do |name|
+          io.puts "  :allow_good: %p" % [name]
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minitest-allow
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   d/AHw/kcnU6iuMUoJEcGiJd4gVCTn1l3cDcIvxakGslCA88Jubw0Sqatan0TnC9g
   KToW560QIey7SPfHWduzFJnV
   -----END CERTIFICATE-----
-date: 2021-04-03 00:00:00.000000000 Z
+date: 2021-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.16
 signing_key:
 specification_version: 4
 summary: Allows you to provide an exclusion list of allowed failures/errors