ministry_of_state 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fee29b6c22b9b8a1e96cd23c447879ecffa61e66
-  data.tar.gz: 265f34f8d6f14f2a8044fc7018737b28ad29cf39
+  metadata.gz: 9987f8af486f7e33c06b18925622f9b6a696e34f
+  data.tar.gz: d3c34e4a6898e962e772baec3a4fb9e5a4c53bfd
 SHA512:
-  metadata.gz: 95b251d93d73210d8c70497701df729e64abc286b61b5c6f96b83c800e5488f67744152c8318e70b883815391675391f3966600d4696e604fffcf5d010d3ed3e
-  data.tar.gz: 3bd244877747f72622cea22d3bf73cceaa5ab6fbd241a7f8e3e248c49e46ffdacec86f2aca7dc8c161fe0dcd236d9ec7a12ca826e5bb71a7dfa787263875b271
+  metadata.gz: 165f45dcbbab28525c54d9d7f2a0e533e3dbd7a574a77ab4dde02c9370d1c5a1d88008a76f47dac1fef62a8995c70b4127656a816e36e74532dc75041672050f
+  data.tar.gz: 658b915271b7242f849767205eadf63ef108c46478061165b4be87a2f18608a70baa802254830f9f937f961b6e21272efaddf3b14715b3e439a2addc71250193

data/.travis.yml

@@ -2,10 +2,13 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.5
 
 gemfile:
   - Gemfile
-  - gemfiles/Gemfile.rails-3.2.13
+  - gemfiles/Gemfile.rails-3.2.x
+  - gemfiles/Gemfile.rails-4.0.x
+  - gemfiles/Gemfile.rails-4.1.x
 
 script:
   - bundle exec rake test

data/README.rdoc

@@ -8,8 +8,8 @@ Because State machines are simple, they do not have to be greater than 2000 line
 = Features
 * Supports rails4 now. No changes required.
 * Events are wrapped in a transaction and record is locked before going for a state change.
-* Ignores dirty attributes (still on the fence with this one)
-* Events and states can be inhereted across classes.
+* Ignores dirty attributes while going for state change. This means unlike AASM you can't use an event transition as shorthand of `save`.
+* Events and states can be inherited across classes.
 * Simple 136 lines of code, covered with close to > 98% test coverage.
 
 = Using it

data/gemfiles/Gemfile.rails-3.2.x

@@ -0,0 +1,10 @@
+# -*- ruby -*-
+
+source 'http://rubygems.org'
+
+gemspec path: '..'
+gem 'rails', '~> 3.2.13'
+
+# rails 3.2.x depends on minitest 4.x, so i had to hardcode it.
+# rails 4.x depends on minitest 5.x which is default now
+gem 'minitest', '~> 4.7.5'

data/gemfiles/Gemfile.rails-4.0.x

@@ -0,0 +1,6 @@
+# -*- ruby -*-
+
+source 'http://rubygems.org'
+
+gemspec path: '..'
+gem 'rails', '~> 4.0.0'

data/gemfiles/Gemfile.rails-4.1.x

@@ -0,0 +1,6 @@
+# -*- ruby -*-
+
+source 'http://rubygems.org'
+
+gemspec path: '..'
+gem 'rails', '~> 4.1.0'

data/lib/ministry_of_state/ministry_of_state.rb

@@ -37,7 +37,7 @@ module MinistryOfState
         self.states = HashWithIndifferentAccess.new
         self.events = HashWithIndifferentAccess.new
 
-        before_create :set_initial_states
+        after_initialize :set_initial_states_for_new_record
         after_create  :run_initial_state_actions
       end
     end
@@ -83,6 +83,10 @@ module MinistryOfState
     end
 
     def transitions(opts = {})
+      if opts[:from] == :any
+        opts[:from] = self.states.keys
+      end
+
       if opts[:from].blank? || opts[:to].blank?
         raise TransitionNotAllowed.new("You need to specify from and to states")
       end
@@ -108,6 +112,11 @@ module MinistryOfState
     end
   end
 
+
+  def set_initial_states_for_new_record
+    set_initial_states if new_record?
+  end
+
   def run_initial_state_actions
     states.each do |name, state|
       next unless state.initial?
@@ -129,7 +138,8 @@ module MinistryOfState
 
   def check_state(state)
     column = states[state].column
-    send("#{column}_was") == state.to_s
+    method = new_record? ? column : "#{column}_was"
+    send(method) == state.to_s
   end
 
   def fire(event)

data/lib/ministry_of_state/version.rb

@@ -1,3 +1,3 @@
 module MinistryOfState
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/test/blog.rb

@@ -8,10 +8,15 @@ class Blog < ActiveRecord::Base
     add_initial_state 'pending'
 
     add_state :approved, :enter => :test_method
+    add_state :cancelled
 
     add_event :approve do
       transitions :from => 'pending', :to => 'approved'
     end
+
+    add_event(:cancel) do
+      transitions from: :any, to: 'cancelled'
+    end
   end
 
   def test_method

data/test/helper.rb

@@ -7,7 +7,9 @@ rescue Bundler::BundlerError => e
   $stderr.puts "Run `bundle install` to install missing gems"
   exit e.status_code
 end
-require 'test/unit'
+
+require 'minitest/autorun'
+require 'minitest/unit'
 require 'shoulda'
 
 # TODO: Fix this one when shoulda-context patches MiniTest::Unit::TestCase

data/test/test_ministry_of_state.rb

@@ -147,6 +147,26 @@ class TestMinistryOfState < ActiveSupport::TestCase
     end
   end
 
+  context "can specify from transition as any" do
+    should "cancel a pending blog" do
+      @pending_blog = Blog.create(status: 'pending', text: "some text")
+      assert @pending_blog.cancel!
+      assert @pending_blog.errors.blank?
+    end
+
+    should "cancel a approved blog" do
+      @approved_blog = Blog.create(status: 'approved', text: "some text")
+      assert @approved_blog.cancel!
+      assert @approved_blog.errors.blank?
+    end
+
+    should "cancel an already cancelled blog" do
+      @cancelled_blog = Blog.create(status: 'cancelled', text: "some text")
+      assert @cancelled_blog.cancel!
+      assert @cancelled_blog.errors.blank?
+    end
+  end
+
   context "calling enter and exit callbacks for normal events" do
     setup do
       @post = Post.create(:title => "Hello", :content => "Good world")
@@ -227,4 +247,35 @@ class TestMinistryOfState < ActiveSupport::TestCase
       assert @cargo.paid?
     end
   end
+
+  context 'status helpers without persisting objects' do
+    should 'be able to read value from mos column' do
+      @cargo = Cargo.new
+      assert @cargo.unpaid?
+    end
+
+    should 'be able to read updated value from mos column' do
+      @cargo = Cargo.new
+      @cargo.payment = 'paid'
+      assert @cargo.paid?
+    end
+
+    should 'be able to persist with a different state' do
+      @cargo = Cargo.create(payment: 'paid')
+      assert @cargo.reload.paid?
+    end
+  end
+
+  context 'fetching records from database' do
+    setup do
+      @cargo = Cargo.create(payment: 'paid')
+    end
+
+    should 'not fire set initial state callback' do
+      Cargo.any_instance.expects(:set_initial_state).times(0)
+
+      fetch_cargo_from_db = Cargo.find(@cargo.id)
+      assert fetch_cargo_from_db.paid?
+    end
+  end
 end

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: ministry_of_state
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Hemant Kumar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-02 00:00:00.000000000 Z
+date: 2014-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.13
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.13
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.7
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.14.0
 description: A ActiveRecord plugin for working with state machines
@@ -103,15 +103,16 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.rdoc
 files:
-- .document
-- .gitignore
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.rdoc
 - Rakefile
-- VERSION
-- gemfiles/Gemfile.rails-3.2.13
+- gemfiles/Gemfile.rails-3.2.x
+- gemfiles/Gemfile.rails-4.0.x
+- gemfiles/Gemfile.rails-4.1.x
 - lib/ministry_of_state.rb
 - lib/ministry_of_state/ministry_of_state.rb
 - lib/ministry_of_state/railtie.rb
@@ -135,17 +136,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Handling state machines
@@ -158,3 +159,4 @@ test_files:
 - test/student.rb
 - test/test_ministry_of_state.rb
 - test/user.rb
+has_rdoc: true

data/VERSION

@@ -1 +0,0 @@
-0.0.1

data/gemfiles/Gemfile.rails-3.2.13

@@ -1,6 +0,0 @@
-# -*- ruby -*-
-
-source "http://rubygems.org"
-
-gemspec path: '..'
-gem 'rails', "~> 3.2.13"