minimapper 0.6.1 → 0.6.2

data/README.md

@@ -265,6 +265,16 @@ class User
 end
 ```
 
+### Protected attributes
+
+We recommend using [strong_parameters](https://github.com/rails/strong_parameters) for attribute security, without including `ActiveModel::ForbiddenAttributesProtection`.
+
+Use of `attr_accessible` or `attr_protected` may obstruct the mapper.
+
+If you use Minimapper as intended, you only assign attributes on the entity. Once they're on the entity, the mapper will assume they're permitted to be persisted; and once they're in the record, the mapper will assume they are permitted for populating an entity.
+
+(FIXME?: There's a ongoing discussion about whether Minimapper should actively bypass attribute protection, or encourage you not to use it, or what.)
+
 ### Associations
 
 There is no core support for associations, but we're implementing them in [minimapper-extras](https://github.com/barsoom/minimapper-extras) as we need them.

data/lib/minimapper/entity/attributes.rb

@@ -8,14 +8,15 @@ module Minimapper
 
         # By adding instance methods via an included module,
         # they become overridable with "super".
-        instance_method_container = Module.new
+        unless @minimapper_instance_method_container
+          @minimapper_instance_method_container = Module.new
+          include @minimapper_instance_method_container
+        end
 
         columns.each do |column|
-          define_reader(column, instance_method_container)
-          define_writer(column, instance_method_container)
+          define_reader(column)
+          define_writer(column)
         end
-
-        include instance_method_container
       end
 
       def attribute(*opts)
@@ -34,16 +35,16 @@ module Minimapper
         @entity_columns |= list.map { |data| Column.new(data) }
       end
 
-      def define_reader(column, instance_method_container)
-        instance_method_container.module_eval do
+      def define_reader(column)
+        @minimapper_instance_method_container.module_eval do
           define_method(column.name) do
             attributes[column.name]
           end
         end
       end
 
-      def define_writer(column, instance_method_container)
-        instance_method_container.module_eval do
+      def define_writer(column)
+        @minimapper_instance_method_container.module_eval do
           define_method("#{column.name}=") do |value|
             attributes[column.name] = Convert.new(value).to(column.type)
           end

data/lib/minimapper/version.rb

@@ -1,3 +1,3 @@
 module Minimapper
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

data/unit/entity/convert_spec.rb

@@ -33,4 +33,8 @@ describe Minimapper::Entity::Convert do
   it "does not make false nil" do
     described_class.new(false).to(:unknown).should eq(false)
   end
+
+  it "does not make false nil" do
+    described_class.new(false).to(:unknown).should eq(false)
+  end
 end

data/unit/entity_spec.rb

@@ -9,6 +9,10 @@ class TestUser
   attributes :name
 end
 
+class TestAgedUser < TestUser
+  attributes :age
+end
+
 class TestProject
   include Minimapper::Entity
   attributes :title
@@ -87,6 +91,14 @@ describe Minimapper::Entity do
     entity.attributes[:id].should == 15
   end
 
+  it "inherits attributes" do
+    user = TestAgedUser.new
+    user.name = "Name"
+    user.age = 123
+    user.name.should == "Name"
+    user.age.should == 123
+  end
+
   it "is possible to override attribute readers with inheritance" do
     user = OverridingTestUser.new
     user.name = "pelle"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimapper
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-22 00:00:00.000000000 Z
+date: 2013-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70347747664260 !ruby/object:Gem::Requirement
+  requirement: &70133111671800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70347747664260
+  version_requirements: *70133111671800
 description: A minimalistic way of separating your models from ORMs like ActiveRecord.
 email:
 - joakim.kolsjo@gmail.com
@@ -75,12 +75,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2264146464665909809
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2264146464665909809
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5