minimapper 0.5.3 → 0.6.0

data/README.md

@@ -174,9 +174,7 @@ end
 module AR
   class ProjectMapper < Minimapper::AR
     def waiting_for_review
-      record_class.where(waiting_for_review: true).order("id DESC").map do |record|
-        entity_for(record)
-      end
+      entities_for record_class.where(waiting_for_review: true).order("id DESC")
     end
   end
 end
@@ -250,7 +248,9 @@ Minimapper only calls #convert on non-empty strings. When the value is blank or
 
 ### Associations
 
-There is no built in support for associations yet, but you can handle them manually (see https://github.com/joakimk/minimapper/issues/3).
+There is no core support for associations, but we're implementing them in [minimapper-extras](https://github.com/barsoom/minimapper-extras) as we need them.
+
+For some discussion, [see this issue](https://github.com/joakimk/minimapper/issues/3).
 
 ### Lifecycle hooks
 
@@ -272,11 +272,11 @@ end
 
 ### Custom entity class
 
-[Minimapper::Entity](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity.rb) adds some convenience methods for when a model is used within a rails application. If you don't need that you can just include the core API from the [Minimapper::Entity::Core](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity/core.rb) module (or implement your own version that behaves like [Minimapper::Entity::Core](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity/core.rb)).
+[Minimapper::Entity](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity.rb) adds some convenience methods for when a model is used within a Rails application. If you don't need that you can just include the core API from the [Minimapper::Entity::Core](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity/core.rb) module (or implement your own version that behaves like [Minimapper::Entity::Core](https://github.com/joakimk/minimapper/blob/master/lib/minimapper/entity/core.rb)).
 
 ### Adding a new mapper
 
-If you where to add a [Mongoid](http://mongoid.org/en/mongoid/index.html) mapper:
+If you were to add a [Mongoid](http://mongoid.org/en/mongoid/index.html) mapper:
 
 1. Start by copying *spec/ar_spec.rb* to *spec/mongoid_spec.rb* and adapt it for Mongoid.
 2. Add any setup code needed in *spec/support/database_setup.rb*.

data/lib/minimapper/entity/convert.rb

@@ -26,6 +26,10 @@ module Minimapper
       private
 
       def converter_for(type)
+        if type && !@@converters[type]
+          raise "Unknown attribute type: #{type}. Perhaps you've spelled it wrong or not registered the converter for it."
+        end
+
         @@converters.fetch(type, NoOpConverter.new)
       end
 

data/lib/minimapper/mapper/ar.rb

@@ -9,6 +9,8 @@ module Minimapper
 
       def create(entity)
         record = record_class.new
+
+        copy_attributes_to_record(record, entity)
         validate_record_and_copy_errors_to_entity(record, entity)
 
         if entity.valid?
@@ -50,6 +52,8 @@ module Minimapper
 
       def update(entity)
         record = record_for(entity)
+
+        copy_attributes_to_record(record, entity)
         validate_record_and_copy_errors_to_entity(record, entity)
 
         if entity.valid?
@@ -80,13 +84,13 @@ module Minimapper
       # NOTE: Don't memoize the classes or code reloading will break in rails apps.
 
       # Will attempt to use AR:Project as the record class
-      # when the mapper class name is AR::ProjectMapper
+      # when the mapper class name is AR::ProjectMapper.
       def record_class
         self.class.name.sub(/Mapper$/, '').constantize
       end
 
-      # Will attempt to use Project as the enity class when
-      # the mapper class name is AR::ProjectMapper
+      # Will attempt to use Project as the entity class when
+      # the mapper class name is AR::ProjectMapper.
       def entity_class
         ("::" + self.class.name.split('::').last.sub(/Mapper$/, '')).constantize
       end
@@ -99,8 +103,11 @@ module Minimapper
         record_class.protected_attributes
       end
 
-      def validate_record_and_copy_errors_to_entity(record, entity)
+      def copy_attributes_to_record(record, entity)
         record.attributes = accessible_attributes(entity)
+      end
+
+      def validate_record_and_copy_errors_to_entity(record, entity)
         record.valid?
         entity.mapper_errors = record.errors.map { |k, v| [k, v] }
       end

data/lib/minimapper/version.rb

@@ -1,3 +1,3 @@
 module Minimapper
-  VERSION = "0.5.3"
+  VERSION = "0.6.0"
 end

data/unit/entity/convert_spec.rb

@@ -18,11 +18,15 @@ describe Minimapper::Entity::Convert do
     described_class.new('garbage').to(:date_time).should be_nil
   end
 
-  it "returns the value as-is when it does not know how to convert it" do
-    described_class.new('foobar').to(:unknown).should == 'foobar'
+  it "returns the value as-is when the type isn't specified" do
+    described_class.new('foobar').to(nil).should == 'foobar'
   end
 
   it "does not make false nil" do
-    described_class.new(false).to(:unknown).should eq(false)
+    described_class.new(false).to(nil).should eq(false)
+  end
+
+  it "raises when the type isn't known" do
+    lambda { described_class.new('foobar').to(:unknown) }.should raise_error(/Unknown attribute type/)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimapper
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-16 00:00:00.000000000 Z
+date: 2013-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70136082132800 !ruby/object:Gem::Requirement
+  requirement: &70151297215480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70136082132800
+  version_requirements: *70151297215480
 description: A minimalistic way of separating your models from ORMs like ActiveRecord.
 email:
 - joakim.kolsjo@gmail.com
@@ -75,12 +75,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4467739529293173565
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4467739529293173565
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5