minimapper 0.2.4 → 0.2.5

data/README.md

@@ -274,6 +274,10 @@ You need mysql and postgres installed (but they do not have to be running) to be
 
 ### Next
 
+* Make it possible to override minimapper attributes with super (like it's done in https://github.com/barsoom/traco)
+* Support default values for attributes (probably only using lambdas to avoid bugs).
+* Built in way to set induvidual attributes in a way that bypasses protected attributes like you can do with an AR model.
+  - user.is_admin = true; user_mapper.update(user) should probably set is_admin to true, mass-assignment should not.
 * Extract entity and model class lookup code from the ar-mapper and reuse it in the memory mapper.
 * Change the memory mapper to store entity attributes, not entity instances.
   - Unless this makes it difficult to handle associated data.

data/lib/minimapper/ar.rb

@@ -7,7 +7,7 @@ module Minimapper
     # Create
     def create(entity)
       if entity.valid?
-        entity.id = record_klass.create!(entity.attributes).id
+        entity.id = record_klass.create!(accessible_attributes(entity)).id
       else
         false
       end
@@ -41,7 +41,7 @@ module Minimapper
     # Update
     def update(entity)
       if entity.valid?
-        record_for(entity).update_attributes!(entity.attributes)
+        record_for(entity).update_attributes!(accessible_attributes(entity))
         true
       else
         false
@@ -81,6 +81,14 @@ module Minimapper
       @entity_class
     end
 
+    def accessible_attributes(entity)
+      entity.attributes.reject { |k, v| protected_attributes.include?(k.to_s) }
+    end
+
+    def protected_attributes
+      record_klass.protected_attributes
+    end
+
     def find_record_safely(id)
       find_record(id) ||
         raise(Common::CanNotFindEntity, :id => id)

data/lib/minimapper/version.rb

@@ -1,3 +1,3 @@
 module Minimapper
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

data/spec/ar_spec.rb

@@ -18,8 +18,10 @@ class TestMapper < Minimapper::AR
   end
 
   class Record < ActiveRecord::Base
-    attr_accessible :name
+    attr_protected :visible
+
     self.table_name = :projects
+    self.mass_assignment_sanitizer = :strict
   end
 end
 
@@ -28,4 +30,38 @@ describe Minimapper::AR do
   let(:entity_class) { TestEntity }
 
   include_examples :mapper
+
+  describe "#create" do
+    it "does not include protected attributes" do
+      # because it leads to exceptions when mass_assignment_sanitizer is set to strict
+      entity = TestEntity.new
+      entity.attributes = { :visible => true, :name => "Joe" }
+      mapper.create(entity)
+
+      stored_entity = mapper.find(entity.id)
+      stored_entity.attributes[:visible].should be_nil
+      stored_entity.attributes[:name].should == "Joe"
+
+      entity = TestEntity.new
+      entity.attributes = { :visible => true, :name => "Joe" }
+      TestMapper::Record.stub(:protected_attributes => [])
+      lambda { mapper.create(entity) }.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
+    end
+  end
+
+  describe "#update" do
+    it "does not include protected attributes" do
+      entity = TestEntity.new
+      mapper.create(entity)
+
+      entity.attributes = { :visible => true, :name => "Joe" }
+      mapper.update(entity)
+      stored_entity = mapper.find(entity.id)
+      stored_entity.attributes[:visible].should be_nil
+      stored_entity.attributes[:name].should == "Joe"
+
+      TestMapper::Record.stub(:protected_attributes => [])
+      lambda { mapper.update(entity) }.should raise_error(ActiveModel::MassAssignmentSecurity::Error)
+    end
+  end
 end

data/spec/support/database_setup.rb

@@ -46,6 +46,7 @@ silence_stream(STDOUT) do
   ActiveRecord::Schema.define(:version => 0) do
     create_table :projects, :force => true do |t|
       t.string :name
+      t.boolean :visible
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: minimapper
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-18 00:00:00.000000000 Z
+date: 2012-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70303088200960 !ruby/object:Gem::Requirement
+  requirement: &70274703776420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70303088200960
+  version_requirements: *70274703776420
 description: A minimalistic way of separating your models from ORMs like ActiveRecord.
 email:
 - joakim.kolsjo@gmail.com
@@ -77,7 +77,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3678706732154060402
+      hash: -1932883242687325558
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3678706732154060402
+      hash: -1932883242687325558
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.5