mini_racer 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2859c8be892f264c6734f90135b2dbb423be6cf60f208ae5496dd8e61d54070
-  data.tar.gz: 9f88ce7ca37b3803f1dae6f4270a117b326ce3afb5f0974b00f724f3d14e0563
+  metadata.gz: 99d9eecfd656415e7b78e2dc350e74fa48efff6ba59c0753435acbcb354a6f1f
+  data.tar.gz: 5569cf7c40958530af9326e0a73240bbe564eeca8242b4e254fbb72088134de1
 SHA512:
-  metadata.gz: 78d14edf7ea4b93f3a432273b530694b7bb43fe26186f6c32d0e38e687fcf125c862e40a2ccbbc3363879c4bd2363169a910a9ab90946035a848afe0f9918d97
-  data.tar.gz: acdb7f28a9800a7b4e401b40c847a072a8eb5ddd38326490830da376d7bbf58f07f984968943938f3b0b5da4cf2dbd2094cd59d8b84e541ebd98c0b55c655c53
+  metadata.gz: 2460052cf2bff6b6b6e7ad0971830d409daf71e7e2f6e7c6c15270378ac83758f38d31b24a48ff7eeb4108be6eff012bd8f762f85a2aa2b8f31e96e8f7207719
+  data.tar.gz: e94abed7909184fa5c2d982cdffbc751731fe9f1618a543842631660380c8fcba77cc5fba3b6b6337d94531f1738f19c6b66c00753e62aa0314179317f8a798a

data/CHANGELOG

@@ -1,3 +1,10 @@
+- 02-11-2018
+
+- 0.2.4
+
+  - FIX: deadlock releasing context when shared isolates are used
+  - FEATURE: include js backtrace when snapshots do not compile
+
 - 28-09-2018
 
 - 0.2.3

data/ext/mini_racer_extension/mini_racer_extension.cc

@@ -70,6 +70,10 @@ public:
         }
     }
 
+    int refs() {
+	return refs_count;
+    }
+
     static void* operator new(size_t size) {
         return ruby_xmalloc(size);
     }
@@ -1071,21 +1075,50 @@ void free_isolate(IsolateInfo* isolate_info) {
     delete isolate_info->allocator;
 }
 
+static void *free_context_raw(void* arg) {
+    ContextInfo* context_info = (ContextInfo*)arg;
+    IsolateInfo* isolate_info = context_info->isolate_info;
+    Persistent<Context>* context = context_info->context;
+
+    if (context && isolate_info && isolate_info->isolate) {
+        Locker lock(isolate_info->isolate);
+        v8::Isolate::Scope isolate_scope(isolate_info->isolate);
+        context->Reset();
+        delete context;
+    }
+
+    if (isolate_info) {
+        isolate_info->release();
+    }
+
+    xfree(context_info);
+    return NULL;
+}
+
 // destroys everything except freeing the ContextInfo struct (see deallocate())
 static void free_context(ContextInfo* context_info) {
 
     IsolateInfo* isolate_info = context_info->isolate_info;
 
+    ContextInfo* context_info_copy = ALLOC(ContextInfo);
+    context_info_copy->isolate_info = context_info->isolate_info;
+    context_info_copy->context = context_info->context;
+
+    if (isolate_info && isolate_info->refs() > 1) {
+	pthread_t free_context_thread;
+	if (pthread_create(&free_context_thread, NULL, free_context_raw, (void*)context_info_copy)) {
+            fprintf(stderr, "WARNING failed to release memory in MiniRacer, thread to release could not be created, process will leak memory\n");
+	}
+
+    } else {
+	free_context_raw(context_info_copy);
+    }
+
     if (context_info->context && isolate_info && isolate_info->isolate) {
-        Locker lock(isolate_info->isolate);
-        v8::Isolate::Scope isolate_scope(isolate_info->isolate);
-        context_info->context->Reset();
-        delete context_info->context;
 	context_info->context = NULL;
     }
 
     if (isolate_info) {
-        isolate_info->release();
         context_info->isolate_info = NULL;
     }
 }

data/lib/mini_racer.rb

@@ -320,7 +320,7 @@ module MiniRacer
         ctx = MiniRacer::Context.new
         ctx.eval(str)
       rescue MiniRacer::RuntimeError => e
-        raise MiniRacer::SnapshotError.new,  e.message
+        raise MiniRacer::SnapshotError.new, e.message, e.backtrace
       end
 
       @source = str
@@ -338,7 +338,7 @@ module MiniRacer
         ctx.eval(@source)
         ctx.eval(src)
       rescue MiniRacer::RuntimeError => e
-        raise MiniRacer::SnapshotError.new,  e.message
+        raise MiniRacer::SnapshotError.new, e.message, e.backtrace
       end
 
       warmup_unsafe!(src)

data/lib/mini_racer/version.rb

@@ -1,3 +1,3 @@
 module MiniRacer
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_racer
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-28 00:00:00.000000000 Z
+date: 2018-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler