mini_phone 1.1.5 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c3a42ec155de4fb7b2a8ea675ac0380274f23b38795c0eb0e73c0efb3ed4d8a5
-  data.tar.gz: aaec470245e26e61d277a329340833eef93fa22939395273eabba719f977408e
+  metadata.gz: 48fbcbb306ad72fdcbd33b68c46e1c3bc586d24a7ba931f8c4a059e22f65b3a7
+  data.tar.gz: cbdc2cadfa4c1438312de09177b2c54d476f68e5fc585248eeb046212d71025a
 SHA512:
-  metadata.gz: 99128e918a87c4e875191b47177507da77be675aafb7a7bec430457ab420c4b5081872407b31d07de04fc24233e57d14e711a019f49939d3db89e757eeeab1a1
-  data.tar.gz: a9676a2d17fd3a5e0d178159ed9b413ea73469790e5219040cfa80e5679fce578ac0e80e95b60366cdd23f4961744eba65740464e6bd05bb1549805547862b1f
+  metadata.gz: 0cb7432992d4c61aaa8ccb0774e48aad98a61a575555dc6e4d509560938fd4fb4267bd62d90cdd2f589d93ed1eb5ded12503fe213023f10972ed399ded5f863c
+  data.tar.gz: 4dd9e4ae33cde41d27e308fc1d5249cc7676274162ecc20d79e1088f029b6aab330bfe1dc424fb74515fbb42ab744c375fd60ef6078ad6c9ba6e315ca07a71f8

data/Gemfile

@@ -17,4 +17,5 @@ gem 'rubocop', require: false
 group :bench do
   gem 'benchmark-ips'
   gem 'phonelib'
+  gem 'telephone_number'
 end

data/README.md

@@ -77,16 +77,18 @@ an issue and we will try to support it.
 On average, most methods are 40x to 50x faster than other libraries. To run
 the benchmarks locally, execute: `bundle exec rake bench`
 
-```
-# Results from my Linux (5.10.6-arch1-10)
+### Results from my Linux (5.10.6-arch1-10)
 
+```
 Comparison:
-    Phonelib: valid?:      426.0 i/s
-   MiniPhone: valid?:    34707.9 i/s - 81.47x faster
+   MiniPhone:    valid?:    33382.0 i/s
+    Phonelib:    valid?:      422.8 i/s - 78.95x  (± 0.00) slower
+TelephoneNumber: valid?:      164.3 i/s - 203.13x  (± 0.00) slower
 
 Comparison:
-      Phonelib: e164:      580.3 i/s
-     MiniPhone: e164:    43385.9 i/s - 74.76x faster
+     MiniPhone:  e164:    41187.5 i/s
+      Phonelib:  e164:      579.0 i/s - 71.14x  (± 0.00) slower
+TelephoneNumber: e164:      228.8 i/s - 179.99x  (± 0.00) slower
 ```
 
 ## Installation

data/ext/mini_phone/mini_phone.cc

@@ -433,13 +433,14 @@ extern "C" VALUE rb_phone_number_to_s(VALUE self) {
   PhoneNumberInfo *phone_number_info;
   TypedData_Get_Struct(self, PhoneNumberInfo, &phone_number_info_type, phone_number_info);
   PhoneNumber *phone_number = phone_number_info->phone_number;
-  std::string raw_input = phone_number->raw_input();
 
-  if (raw_input == "") {
+  if (phone_number == NULL) {
     return Qnil;
-  } else {
-    return rb_str_new(raw_input.c_str(), raw_input.size());
   }
+
+  std::string raw_input = phone_number->raw_input();
+
+  return rb_str_new(raw_input.c_str(), raw_input.size());
 }
 
 static inline void setup_formats() {
@@ -517,10 +518,10 @@ extern "C" VALUE rb_phone_number_initialize(int argc, VALUE *argv, VALUE self) {
 
   if (result != PhoneNumberUtil::NO_PARSING_ERROR) {
     rb_phone_number_nullify_ivars(self);
-  } else {
-    phone_number_info->phone_number->Swap(&parsed_number);
   }
 
+  phone_number_info->phone_number->Swap(&parsed_number);
+
   return self;
 }
 
@@ -577,6 +578,5 @@ extern "C" void Init_mini_phone(void) {
   rb_define_method(rb_cPhoneNumber, "type", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_type), 0);
   rb_define_method(rb_cPhoneNumber, "area_code", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_area_code), 0);
   rb_define_method(rb_cPhoneNumber, "to_s", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_to_s), 0);
-  rb_define_method(rb_cPhoneNumber, "raw_input", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_to_s), 0);
   rb_define_method(rb_cPhoneNumber, "==", reinterpret_cast<VALUE (*)(...)>(rb_phone_number_match_eh), 1);
 }

data/lib/mini_phone/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MiniPhone
-  VERSION = '1.1.5'
+  VERSION = '1.1.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mini_phone
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.6
 platform: ruby
 authors:
 - Ian Ker-Seymer
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-11 00:00:00.000000000 Z
+date: 2021-02-18 00:00:00.000000000 Z
 dependencies: []
 description: Plugs directly in the the Google's native C++ [libphonenumber](https://github.com/google/libphonenumber)
   for extemely _fast_ and _robust_ phone number parsing, validation, and formatting.
@@ -43,7 +43,7 @@ metadata:
   homepage_uri: https://github.com/ianks/mini_phone
   source_code_uri: https://github.com/ianks/mini_phone
   changelog_uri: https://github.com/ianks/mini_phone/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -59,7 +59,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Uses the Google libphonenumber C lib to parse, validate, and format phone
   numbers